DPDK patches and discussions
 help / color / mirror / Atom feed
From: Srikanth Yalavarthi <syalavarthi@marvell.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Nicolas Chautru <nicolas.chautru@intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: RE: [EXT] Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr
Date: Thu, 3 Nov 2022 07:24:19 +0000	[thread overview]
Message-ID: <CO6PR18MB393961204AFAA3879132F888AE389@CO6PR18MB3939.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1NCydfLsg4PgnknqC+Lyd1ChECJTvagYZqT0wdX8FOY5w@mail.gmail.com>

> On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
> <syalavarthi@marvell.com> wrote:
> >
> > Use helper function rte_mbuf_iova_set to set IOVA address to fix
> > compilation failures.
> >
> > Below error was observed:
> >
> > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> > dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> > ‘struct rte_mbuf’ has no member named ‘buf_iova’
> >  1145 |     m_head->buf_iova = rte_malloc_virt2iova(data);
> >       |           ^~
> >
> > Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
> 
> Is this change came after rte_mbuf_iova_set() API introduction?
Yes,  the change is need after rte_mbuf_iova_set API is added. Build failure is observed on x86 and ARM64.
> 
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> 
> 
> > ---
> >  app/test-bbdev/test_bbdev_perf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-bbdev/test_bbdev_perf.c
> > b/app/test-bbdev/test_bbdev_perf.c
> > index 8cf4359a2c..b285d3f3a7 100644
> > --- a/app/test-bbdev/test_bbdev_perf.c
> > +++ b/app/test-bbdev/test_bbdev_perf.c
> > @@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data
> *bufs,
> >                                         "rte malloc failed with %u bytes",
> >                                         seg->length + 1024);
> >                                 m_head->buf_addr = data;
> > -                               m_head->buf_iova = rte_malloc_virt2iova(data);
> > +                               rte_mbuf_iova_set(m_head,
> > + rte_malloc_virt2iova(data));
> >                                 m_head->data_off = 0;
> >                                 m_head->data_len = seg->length;
> >                         } else {
> > --
> > 2.17.1
> >

  reply	other threads:[~2022-11-03  7:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  9:53 Srikanth Yalavarthi
2022-11-03  6:31 ` Jerin Jacob
2022-11-03  7:24   ` Srikanth Yalavarthi [this message]
2022-11-03  7:36     ` [EXT] " Jerin Jacob
2022-11-03  8:01       ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB393961204AFAA3879132F888AE389@CO6PR18MB3939.namprd18.prod.outlook.com \
    --to=syalavarthi@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinjacobk@gmail.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=nicolas.chautru@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).