From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E06F941E9F; Wed, 15 Mar 2023 14:39:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA32140EE4; Wed, 15 Mar 2023 14:39:08 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id EAF7340FDF for ; Wed, 15 Mar 2023 14:39:06 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32FCtJF5027555; Wed, 15 Mar 2023 06:39:03 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3pb2a8j8k6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Mar 2023 06:39:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LaFY9LSZnBt2oTcxShQWwUXMTO3MReVmG4my0WkvKwWe2C+08UGLUAmwVYXNOjweLTgpINS6m/tLEwFYloJ2iVSSiLT86R8imetoqAUMrqiwgNvAsu5Gm+M0GOYADYKxqMNBoJnmylLjQc2qLiAZkWu1Gpd15f/OtU0vWdiLduPp2pByGdp3QaaVa+7FGGSHwZbsjnrPf2nZHcvVQOJCY9jqtRJsrzSD7HXx4KmO1nrPUq+80MaYx6/yyOaxF/iWYC3fQRUSCLc+X+j6ZilzcoHwWeD6SHxoXOuthqGAcU/AvQz8B4A/fNMyymwZ+DR33rASc4vtCOYdHteGj6/MwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HxlIaeVlPCSgaiTdD07JwBIvefw0LKyRn3crnaaGx4U=; b=fbYGFIUBJeYg5BYhz+bHylAVMv1sAxd6FeFyES7HJ0OlLgKMLsTu4zzWP/e0gdvXT3Wg59qIx+MbGCGcVY56ikO4jtr24KfeDQAnAEjtuJD/Sh4p0h0tbHrlq+f/58nWwkQGwPqESx6p6I4mN6HpAobbmghYoGVzN1MfWKRJMkJeOA9hK+WZljbFXr2Jhs2DDhYkzG0ddZy3ZyjVAzkQCPpG3n2JHXemX6SojPZBvQXZpfXNcs8m/HIM+7lELDBy3gg/z1UwyoFtoxMXAS1bQSX9fDgNHqFAWMx3BRy79RtmUNumBwUlHmFuJdfPJrYKwXj7Esfdr7Yqoyi1BTc9Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HxlIaeVlPCSgaiTdD07JwBIvefw0LKyRn3crnaaGx4U=; b=n2HFvRlF5HJE5DRi/4b6ucU796z2akqS7XguZbexLvx8CrRutQuYLOZ92ZruPISNt0Ez+uI1Wb1lnEPzLkA8RgrY9P4goakxxJ4jafwokiRuDCMkas2mPRx94mbupSrF4NqDmHKlWVrwhI2FC/Jk1Q4QEGccdMVnIbFa3/9mh1g= Received: from CO6PR18MB3939.namprd18.prod.outlook.com (2603:10b6:5:34d::18) by DM8PR18MB4437.namprd18.prod.outlook.com (2603:10b6:8:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 13:39:01 +0000 Received: from CO6PR18MB3939.namprd18.prod.outlook.com ([fe80::66ce:a9db:b43b:5ba0]) by CO6PR18MB3939.namprd18.prod.outlook.com ([fe80::66ce:a9db:b43b:5ba0%7]) with mapi id 15.20.6178.029; Wed, 15 Mar 2023 13:39:00 +0000 From: Srikanth Yalavarthi To: Ruifeng Wang CC: "dev@dpdk.org" , Shivah Shankar Shankar Narayan Rao , "david.marchand@redhat.com" , nd , Srikanth Yalavarthi Subject: RE: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files Thread-Topic: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files Thread-Index: AQHZVaPMikiwcyKnD0i1M7Ln+L76ra77nyaAgAAKkHCAAB5F4A== Date: Wed, 15 Mar 2023 13:39:00 +0000 Message-ID: References: <20230313114342.10812-1-syalavarthi@marvell.com> <20230313120306.28911-1-syalavarthi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc3lhbGF2YXJ0?= =?us-ascii?Q?aGlcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZi?= =?us-ascii?Q?ODRiYTI5ZTM1Ylxtc2dzXG1zZy1iYmM4OTQ0OC1jMzM2LTExZWQtOWVmMS05?= =?us-ascii?Q?OGZhOWI4YTVlZTJcYW1lLXRlc3RcYmJjODk0NDktYzMzNi0xMWVkLTllZjEt?= =?us-ascii?Q?OThmYTliOGE1ZWUyYm9keS50eHQiIHN6PSI1MTk2IiB0PSIxMzMyMzM2MTEz?= =?us-ascii?Q?NzcxMzY0ODEiIGg9IlpRdWNJeVFVYzNLazNaODU1ODBLMlZqTDFoYz0iIGlk?= =?us-ascii?Q?PSIiIGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQUhZ?= =?us-ascii?Q?SUFBQmgwMForUTFmWkFUbkE3L01yaytvRk9jRHY4eXVUNmdVTkFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFIQUFBQUFHQ0FBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFRQUJBQUFBMUZIM2FBQUFBQUFBQUFBQUFBQUFBSjRBQUFCaEFH?= =?us-ascii?Q?UUFaQUJ5QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4?= =?us-ascii?Q?QWNBQmxBSElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFB?= =?us-ascii?Q?Q0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VB?= =?us-ascii?Q?YmdCMUFHMEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJq?= =?us-ascii?Q?QUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1QUY4QVpBQmhBSE1BYUFCZkFIWUFN?= =?us-ascii?Q?QUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdB?= =?us-ascii?Q?QUFHTUFkUUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0JyQUdVQWVRQjNBRzhB?= =?us-ascii?Q?Y2dCa0FITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWXdCMUFITUFkQUJ2?= =?us-ascii?Q?QUcwQVh3QnpBSE1BYmdCZkFHNEFid0JrQUdVQWJBQnBBRzBBYVFCMEFHVUFj?= =?us-ascii?Q?Z0JmQUhZQU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFB?= =?us-ascii?Q?QUFBQUFBSUFBQUFBQUo0QUFBQmpBSFVBY3dCMEFHOEFiUUJmQUhNQWN3QnVB?= =?us-ascii?Q?RjhBY3dCd0FHRUFZd0JsQUY4QWRnQXdBRElBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFu?= =?us-ascii?Q?Z0FBQUdRQWJBQndBRjhBY3dCckFIa0FjQUJsQUY4QVl3Qm9BR0VBZEFCZkFH?= =?us-ascii?Q?MEFaUUJ6QUhNQVlRQm5BR1VBWHdCMkFEQUFNZ0FBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFaQUJzQUhBQVh3?= =?us-ascii?Q?QnpBR3dBWVFCakFHc0FYd0JqQUdnQVlRQjBBRjhBYlFCbEFITUFjd0JoQUdj?= =?us-ascii?Q?QVpRQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCa0FHd0Fj?= =?us-ascii?Q?QUJmQUhRQVpRQmhBRzBBY3dCZkFHOEFiZ0JsQUdRQWNnQnBBSFlBWlFCZkFH?= =?us-ascii?Q?WUFhUUJzQUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1VBYlFCaEFHa0FiQUJmQUdFQVpB?= =?us-ascii?Q?QmtBSElBWlFCekFITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBRWdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FB?= =?us-ascii?Q?QUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFC?= =?us-ascii?Q?akFIUUFYd0JqQUc4QVpBQmxBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdF?= =?us-ascii?Q?QWNnQjJBR1VBYkFCc0FGOEFkQUJsQUhJQWJRQnBBRzRBZFFCekFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBRUFBQUFBQUFBQUFnQUFBQUFBIi8+PC9tZXRhPg=3D=3D?= x-dg-rorf: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB3939:EE_|DM8PR18MB4437:EE_ x-ms-office365-filtering-correlation-id: 882833aa-bc69-4d4d-3d4f-08db255aa280 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RP+EPrmHaJ/ufBLbKJaK2KabMDjQTuJL/dhlp/fd2pp4qcV1Cg5pXJ6s1aetWY6pQ+4v0mYuM2hc57uEsfLFEniqw6lw7jONQurL0nCBwDf87qt1ZKe3SNEWI6drGsuz9NdWOySyWYJ5vWdgo7XwdTBgDAt4uRYXAu+NfVinzt4IcS/UpTi6Hr4qOLKtKSCU8zRoISMKcZaC0S5GxleYQA9ySx2m9+tgEMEU216Mq+mAbdIJZSZQ2ip3POYw9k/MjTAqqurqrb6T3V1LhjnxgMNKati2hzkHYwBa0PcJEVoT+xobstLJt7OqVqv9Qdv1BF2wv02910R4YKSdvYN4uoG+i1UcoXukNc8sB141XLEBCPaEBafjCUqxwC5+97zlQt81zVPzHDnHPuQfcM6M2ARYFgjsDTyU5aMEDmRdTvPWcBfIyewdIvD5DZguBUaH86KZlHTP2aA9sqZbhN+6P24binN6gWp2RjDgDMAAP43z68DHTVUIYoSqEttTo3JCJMRE8k4tStaf36+WNB4Xtf2/8OQ4e1d+7dRVf+BBbbgBmKn+QhHHlRHa1twv0CZTgpUXau4VecKMqijtGCmr0ifyYZ3Vgeo0LlR/Csh4Qr/NFmdf/Dp43LLkPcbWmjd1vjimzbV3bebWKdzJemSKa/esxrt630p0Y6qwV5WDJXnHxp2RRikzDTmm+UFzJuIL x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3939.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199018)(8936002)(5660300002)(41300700001)(4326008)(6916009)(52536014)(55016003)(33656002)(86362001)(38070700005)(38100700002)(122000001)(2906002)(53546011)(8676002)(6506007)(9686003)(2940100002)(478600001)(83380400001)(186003)(966005)(107886003)(71200400001)(26005)(66556008)(66476007)(64756008)(66446008)(7696005)(66899018)(66946007)(76116006)(54906003)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z5k/MXjc7PVo/gVUMyMvpbwyPNPqPe1vroHMfPxX0pXrHi2NZs/mmUlWt6mo?= =?us-ascii?Q?ZO1ifhQvSA3YDqlZ6w0YeU6cET/ilrfe0ETeXK+2K97uh6F0MTqCbIqjtyA1?= =?us-ascii?Q?D/CQtVwupj+v+q9HgncTyajCW/rMBnhDxiIkWHnkoK8GjqJ90cHe7gkZqKc8?= =?us-ascii?Q?/jFGKTI8rax1JaQ0GdjlMYHb8efRlEunczS0T2QCQOq7IrjbO8oblJmtnuUq?= =?us-ascii?Q?2soRK3pxtJzGKcmbTc0WlyIekqB0Q2awN1Rlf4RdJs+Y33Eq51B168sNGqK0?= =?us-ascii?Q?dpSdICvOOxMadkL804YU+/KFHSNMlzjY+E1DVcKZIi7nFYMeNSYSuzFVVorD?= =?us-ascii?Q?1cXTNLYJN7QlylXe3a3747JTIjxXHuITbVc1SduVm7MN4i6M5qcDEK5gxmIt?= =?us-ascii?Q?W0NEzUZ9a1X/rM5Hhal8Er7EuCZtCD3CCAq2dEmJ/w9a/iVp/uo4lMHS59F8?= =?us-ascii?Q?1LizbVOrJeq5A0ualcIx5X7YEK4N6deond7+jTrIItNG9beQqk0dokQ/e+Lt?= =?us-ascii?Q?C4xgYMeodVRrlKruJYVJJTKqJ7si6jEH7Qihz3Sz0FHsrNVtTE49Egwfhky5?= =?us-ascii?Q?pXiaz/215JGR4SF3/fHLS4VY162613orIGMO59frLQ8jU6Xlk1Dgs6KLDqd5?= =?us-ascii?Q?+ZiAG5Mx6M58LYL+EJvggoxM45PYPPv3adOOe/lrjqNHDjQGEvBrLbG2fmzn?= =?us-ascii?Q?P+BQ2N45cKDB83AixX4WtAx6PPVSJlruc5XWfoKPQjvV7YqSZabSILKG6gJU?= =?us-ascii?Q?ib3//rK74w0xweoLkxyN7chBmIcGNjieoiFIdNr+UNdAKdPmzTWuCPeat3Pa?= =?us-ascii?Q?eXLpr+iboc4PNJjd6hUXRIy9PP3E2BUCxz8rnEdUg68j36xcDkNfc9TMazm1?= =?us-ascii?Q?yB2g82LU2ZRuOeWEDmYEQ26oj8XOqqeBU+02drSclbPGL3sQTlmnmf1DKHb9?= =?us-ascii?Q?qQ8/m7mvy2dY76DYwj7moCFsoLaxCtYiG+8nm81pT1U3x0xg6MwKkOhzp18K?= =?us-ascii?Q?+Ft/YJkQS+ZykpuZu2ArHmHM2+NLV0YRAdVS9TFb/tQap6TL+8K/dHOAOcUA?= =?us-ascii?Q?md16qytvkzoZVzFNP7gvPVDbwYL208YU0uDcdnYr5A4vnGrjTh3ge3ieluEC?= =?us-ascii?Q?dxBAjcg/k5mIzrSt9gh+U/w+YIwlbCgUT9YupE1Aw+F+SzlKOX+0h/ShWR6X?= =?us-ascii?Q?jafM9r2ujb5CBZo2cWQet7cvPq6UAbvPqHb3Ryr9zn97OeGphFqhgDHC6d2z?= =?us-ascii?Q?qwGO73EWC8VXjbJtvSGuRxHLDNVc1YnzFt/gi0QClX87KzJOPKHa+qWKSGy3?= =?us-ascii?Q?u6vsz9dR+adbimmt7vJseWDu+hT1Pt/B8AKyfBsQ25e9Zv56iMrWyZxwOvUP?= =?us-ascii?Q?L/8MgGqlqHi0MbEYSakLi51yr9IIYPRgJOwlTo2Iej4nI24BQtTOr7/WkNAV?= =?us-ascii?Q?A8tqV9hpGfHNTqFSb2IOkvazq6bfVb9em8DhP2p5QhZOVHn+lIFEe+sqxlPr?= =?us-ascii?Q?EnxxuB8IxBsKXEPETO+RQTkTfqLXSrYccjisgQGNHDfP3/AADxnh3ODX3MvA?= =?us-ascii?Q?w+DDMltfthlDi10FCXm18zOvHkXt2N4335v3IKdz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3939.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 882833aa-bc69-4d4d-3d4f-08db255aa280 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 13:39:00.6186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mUy/U4XQnNltcjYuNoF7Loy5zlh6mJAupVNpTfxRpfvvt1wxprTE9OJo5zCmrs8E/su2BEjeScjqxl6ct6l2dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR18MB4437 X-Proofpoint-ORIG-GUID: fx0YcOMBoy9fGV4p_LOb77mH_ZWepvQi X-Proofpoint-GUID: fx0YcOMBoy9fGV4p_LOb77mH_ZWepvQi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-15_06,2023-03-15_01,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Srikanth Yalavarthi > Sent: 15 March 2023 16:12 > To: Ruifeng Wang > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; david.marchand@redhat.com; nd > ; Srikanth Yalavarthi ; Srikanth > Yalavarthi > Subject: RE: [PATCH v2 1/1] mldev: split bfloat16 routines to separate fi= les >=20 > > -----Original Message----- > > From: Ruifeng Wang > > Sent: 15 March 2023 15:32 > > To: Srikanth Yalavarthi > > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > > ; david.marchand@redhat.com; nd > > > Subject: [EXT] RE: [PATCH v2 1/1] mldev: split bfloat16 routines to > > separate files > > > > External Email > > > > ---------------------------------------------------------------------- > > > -----Original Message----- > > > From: Srikanth Yalavarthi > > > Sent: Monday, March 13, 2023 8:03 PM > > > To: Srikanth Yalavarthi ; Ruifeng Wang > > > > > > Cc: dev@dpdk.org; sshankarnara@marvell.com; > > david.marchand@redhat.com > > > Subject: [PATCH v2 1/1] mldev: split bfloat16 routines to separate > > > files > > > > > > Since bfloat16 intrinsics are not supported on all ARM platforms > > > that support NEON, > > > bfloat16 routines are moved to separate files. > > > This would enable using scalar implementation for bfloat16 on > > > unsupported > > ARM platforms. > > > > > > Bugzilla ID: 1179 > > > Fixes: fc54766b1612 ("mldev: add Arm NEON type conversion") > > > > > > Signed-off-by: Srikanth Yalavarthi > > > --- > > > Depends-on: patch-120653 ("mldev: remove weak symbols use in type > > > conversions") > > > Depends-on: patch-125035 ("mldev: fix identical code in conditional > > > branches") > > > > > > lib/mldev/meson.build | 11 +- > > > lib/mldev/mldev_utils_neon.c | 142 +------------ > > > lib/mldev/mldev_utils_neon_bfloat16.c | 154 ++++++++++++++ > > > lib/mldev/mldev_utils_scalar.c | 262 +---------------------= -- > > > lib/mldev/mldev_utils_scalar.h | 80 ++++++++ > > > lib/mldev/mldev_utils_scalar_bfloat16.c | 197 ++++++++++++++++++ > > > 6 files changed, 445 insertions(+), 401 deletions(-) create mode > > > 100644 lib/mldev/mldev_utils_neon_bfloat16.c > > > create mode 100644 lib/mldev/mldev_utils_scalar.h create mode > > > 100644 lib/mldev/mldev_utils_scalar_bfloat16.c > > > > > > diff --git a/lib/mldev/meson.build b/lib/mldev/meson.build index > > > c9db42257b..5769b0640a > > > 100644 > > > --- a/lib/mldev/meson.build > > > +++ b/lib/mldev/meson.build > > > @@ -7,12 +7,21 @@ sources =3D files( > > > 'mldev_utils.c', > > > ) > > > > > > -if dpdk_conf.has('RTE_ARCH_ARM64') > > > +if (dpdk_conf.has('RTE_ARCH_ARM64') and > > > + cc.get_define('__ARM_NEON', args: machine_args) !=3D '') > > > > I found in ACLE document that "__ARM_NEON" is always set to 1 for > > AArch64". > > So this line of check is redundant? >=20 > Checking for __ARM_NEON should be enough. > We can drop the dpdk_conf.has('RTE_ARCH_ARM64') check. > I will test the builds and submit a revised patch. >=20 Correction. Ideally checking for RTE_ARCH_ARM64 is enough. But, __ARM_NEON check is required when building with gcc-4.8.x I have teste= d this on CentOS-7 with GCC-4.8.5 Refer https://bugs.dpdk.org/show_bug.cgi?id=3D1179 Below errors, are reported with GCC-4.8, when __ARM_NEON check is not used ../lib/mldev/mldev_utils_neon.c:220:2: warning: nested extern declaration o= f 'vcvtas_u32_f32' [-Wnested-externs] ../lib/mldev/mldev_utils_neon.c: In function '__uint8_to_float32_neon_f32x1= ': ../lib/mldev/mldev_utils_neon.c:297:2: warning: implicit declaration of fun= ction 'vcvts_f32_u32' [-Wimplicit-function-declaration] *output =3D scale * vcvts_f32_u32((uint32_t)*input); ^ ../lib/mldev/mldev_utils_neon.c:297:2: warning: nested extern declaration o= f 'vcvts_f32_u32' [-Wnested-externs] ../lib/mldev/mldev_utils_neon.c: At top level: ../lib/mldev/mldev_utils_neon.c:604:51: error: unknown type name 'float16_t= ' __float32_to_float16_neon_f16x4(float32_t *input, float16_t *output) ^ So, we will need both checks. > > > > > sources +=3D files('mldev_utils_neon.c') else > > > sources +=3D files('mldev_utils_scalar.c') endif > > > > > > +if (dpdk_conf.has('RTE_ARCH_ARM64') and > > > + cc.get_define('__ARM_NEON', args: machine_args) !=3D '' and > > > > Same here. > > > > > + cc.get_define('__ARM_FEATURE_BF16', args: machine_args) !=3D '') > > > + sources +=3D files('mldev_utils_neon_bfloat16.c') > > > +else > > > + sources +=3D files('mldev_utils_scalar_bfloat16.c') > > > +endif > > > + > > > headers =3D files( > > > 'rte_mldev.h', > > > ) > >