From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E96F42FBD; Thu, 3 Aug 2023 05:14:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED31C406BA; Thu, 3 Aug 2023 05:14:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 71060406B8 for ; Thu, 3 Aug 2023 05:14:01 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 372KAjX4027965; Wed, 2 Aug 2023 20:13:57 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3s529keven-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Aug 2023 20:13:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MC7tnqM1AAq2TJXogH5aF02692x/nBFiX8fihXO/iEnvSTIdCIy0TIo2DTVdySq7fO8Rtc69Y/UU87JWUEECqq3q+/drbaKGxGefMzPj/zl5Ve9yI1usHmQtbbILhFbIDsBfbKdIeAakQisFY652eEpwvuHrJwcng0tgBiLcsFu5u3GzBK2u5uFn6BABoWVRKLtDDWo1pYkhsvMiF89HGlXtxUL52S8sFCC4h54z7jjKHa8SkNvhdY4gmtyFmP70oWFLsjkVQv7a4jCeYSWaS6+NqfqnP8y3lJpM9KhKIChm+WartHsJLw6AujsDsxZV2AW3B69/IFXAsPaPaaSpBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=69Wvw03H2jvx6N0ZVNWrXqn1FpGvR248n4uDCQeM6sg=; b=RzOxPbb8XOTT1qZpWYfjVNZ0vkbhpwMV4AFcKTRj5LG051wpooSF+cIQRbgneCiVbfgxLmffKnGZRKVqLoWTatvOSkm7t4gNcZiZ28441Bwrxe2WRg8q/3DYqekW48HzJJ9Sf/qoceXHzD2WQgitiC0k3otJKc926fLXf/bz3lIO8fdl4+we/KK2uCYSzJrj5F1Wam1AdN3nhTuOT4mOkRPckGXgj02V29UMOgy3Ud0GdbBtVcFgfx/9Hx8rPJlL2PnQHIyhaMyCQmLbcrYHdCYluW2rAW4qOagIqf4ht3vcPINjzAsNt5eLJ7b5e3yhLbGg7e11hGM53YqfQ/mJVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=69Wvw03H2jvx6N0ZVNWrXqn1FpGvR248n4uDCQeM6sg=; b=WuDM/6ldjMbzMDXnveE/OZKVIvXqVIr827ei4ni2k3a3JoWfUx2cviZ+YtEtiw46zoEVjQ+tPittfpEBOx0SqWTBIX1E61w43KvbyoBz+H0IPHlbCFeP6N/PN/TWCEDeGWrT76XBcQnH/ANfywORBz4Kv9cJXlpfReZ0NXrV44s= Received: from CO6PR18MB4452.namprd18.prod.outlook.com (2603:10b6:303:13e::6) by CO6PR18MB3874.namprd18.prod.outlook.com (2603:10b6:5:341::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 03:13:53 +0000 Received: from CO6PR18MB4452.namprd18.prod.outlook.com ([fe80::89af:1bd2:dc8e:c534]) by CO6PR18MB4452.namprd18.prod.outlook.com ([fe80::89af:1bd2:dc8e:c534%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 03:13:53 +0000 From: Devendra Singh Rawat To: Stephen Hemminger , "dev@dpdk.org" CC: Hemant Agrawal , Sachin Saxena , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Andrew Rybchenko , Bruce Richardson , Kevin Laatz , Chas Williams , "Min Hu (Connor)" , Liron Himi , Chaoyong He , =?iso-8859-1?Q?Niklas_S=F6derlund?= , Alok Prasad Subject: RE: [EXT] [PATCH v4 19/19] drivers: remove use of term sanity check Thread-Topic: [EXT] [PATCH v4 19/19] drivers: remove use of term sanity check Thread-Index: AQHZxZjAMAqtM0Z4ZEuqWDiCPxufsq/X5Sdw Date: Thu, 3 Aug 2023 03:13:53 +0000 Message-ID: References: <20230517161603.117728-1-stephen@networkplumber.org> <20230802232550.125487-1-stephen@networkplumber.org> <20230802232550.125487-20-stephen@networkplumber.org> In-Reply-To: <20230802232550.125487-20-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcZHNpbmdocm?= =?iso-8859-1?Q?F3YXRcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVl?= =?iso-8859-1?Q?LTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy1jMWQ3ZTA4Yy0zMWFiLTExZWUtOW?= =?iso-8859-1?Q?UwNC04MDhhYmQwMzRhNTFcYW1lLXRlc3RcYzFkN2UwOGUtMzFhYi0xMWVl?= =?iso-8859-1?Q?LTllMDQtODA4YWJkMDM0YTUxYm9keS50eHQiIHN6PSI4MjY1IiB0PSIxMz?= =?iso-8859-1?Q?MzNTUwNjAyODM4ODczNTUiIGg9ImQ2Yjk2WGNOdUx6eGtUTFdyZzNBOGR4?= =?iso-8859-1?Q?WnV5UT0iIGlkPSIiIGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1?= =?iso-8859-1?Q?JVRk5DZ1VBQU40UEFBRDd6amlGdU1YWkFmWUFUSnBoSXZLczlnQk1tbUVp?= =?iso-8859-1?Q?OHF3WkFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFIQUFBQUJ1RHdBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFFQUFRRUJBQUFBeloxamFRQ0FBUUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBSjRBQUFCaEFHUUFaQUJ5QUdVQWN3QnpBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW?= =?iso-8859-1?Q?5nQUFBR01BZFFCekFIUUFid0J0QUY4QWNBQmxBSElBY3dCdkFHNEFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQmdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3?= =?iso-8859-1?Q?QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VBYmdCMUFHMEFZZ0JsQU?= =?iso-8859-1?Q?hJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3Qj?= =?iso-8859-1?Q?BBRzhBYlFCZkFITUFjd0J1QUY4QVpBQmhBSE1BYUFCZkFIWUFNQUF5QUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQU?= =?iso-8859-1?Q?FBbmdBQUFHTUFkUUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0JyQUdVQWVR?= =?iso-8859-1?Q?QjNBRzhBY2dCa0FITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFB?= =?iso-8859-1?Q?WXdCMUFITUFkQUJ2QUcwQVh3QnpBSE1BYmdCZkFHNEFid0JrQUdVQWJBQn?= =?iso-8859-1?Q?BBRzBBYVFCMEFHVUFjZ0JmQUhZQU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmpBSFVBY3?= =?iso-8859-1?Q?dCMEFHOEFiUUJmQUhNQWN3QnVBRjhBY3dCd0FHRUFZd0JsQUY4QWRnQXdB?= =?iso-8859-1?Q?RElBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdRQWJBQndBRjhBY3dC?= =?iso-8859-1?Q?ckFIa0FjQUJsQUY4QVl3Qm9BR0VBZEFCZkFHMEFaUUJ6QUhNQVlRQm5BR1?= =?iso-8859-1?Q?VBWHdCMkFEQUFNZ0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?UUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFaQUJzQUhBQVh3QnpBR3dBWVFCak?= =?iso-8859-1?Q?FHc0FYd0JqQUdnQVlRQjBBRjhBYlFCbEFITUFjd0JoQUdjQVpRQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCa0FHd0?= =?iso-8859-1?Q?FjQUJmQUhRQVpRQmhBRzBBY3dCZkFHOEFiZ0JsQUdRQWNnQnBBSFlBWlFC?= =?iso-8859-1?Q?ZkFHWUFhUUJzQUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1VBYlFCaEFHa0Fi?= =?iso-8859-1?Q?QUJmQUdFQVpBQmtBSElBWlFCekFITUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRmdBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FYd0?= =?iso-8859-1?Q?J3QUhJQWJ3QnFBR1VBWXdCMEFGOEFiZ0JoQUcwQVpRQnpBRjhBWXdCdkFH?= =?iso-8859-1?Q?NEFaZ0JwQUdRQVpRQnVBSFFBYVFCaEFHd0FYd0JoQUd3QWJ3QnVBR1VBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQU?= =?iso-8859-1?Q?FBQUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCZkFIQUFjZ0J2?= =?iso-8859-1?Q?QUdvQVpRQmpBSFFBWHdCdUFHRUFiUUJsQUhNQVh3QnlBR1VBY3dCMEFISU?= =?iso-8859-1?Q?FhUUJqQUhRQVpRQmtBRjhBWVFCc0FHOEFiZ0JsQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFn?= =?iso-8859-1?Q?QUFBQUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBRjhBY0FCeUFHOEFhZ0JsQU?= =?iso-8859-1?Q?dNQWRBQmZBRzRBWVFCdEFHVUFjd0JmQUhJQVpRQnpBSFFBY2dCcEFHTUFk?= =?iso-8859-1?Q?QUJsQUdRQVh3Qm9BR1VBZUFCakFHOEFaQUJsQUhNQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2?= =?iso-8859-1?Q?VBQUFBYlFCaEFISUFkZ0JsQUd3QWJBQmZBR0VBY2dCdEFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-rorf: true x-dg-refthree: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQU?= =?iso-8859-1?Q?FBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QVp3?= =?iso-8859-1?Q?QnZBRzhBWndCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFB?= =?iso-8859-1?Q?QWdBQUFBQUFuZ0FBQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3Qn?= =?iso-8859-1?Q?FBR1VBWXdCMEFGOEFZd0J2QUdRQVpRQnpBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQU?= =?iso-8859-1?Q?FDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpRQmpB?= =?iso-8859-1?Q?SFFBWHdCakFHOEFaQUJsQUhNQVh3QmtBR2tBWXdCMEFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?iso-8859-1?Q?dEFHRUFjZ0IyQUdVQWJBQnNBRjhBY0FCeUFHOEFhZ0JsQUdNQWRBQmZBRz?= =?iso-8859-1?Q?RBWVFCdEFHVUFjd0JmQUdNQWJ3QnVBR1lBYVFCa0FHVUFiZ0IwQUdrQVlR?= =?iso-8859-1?Q?QnNBRjhBYlFCaEFISUFkZ0JsQUd3QWJBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeU?= =?iso-8859-1?Q?FIWUFaUUJzQUd3QVh3QndBSElBYndCcUFHVUFZd0IwQUY4QWJnQmhBRzBB?= =?iso-8859-1?Q?WlFCekFGOEFZd0J2QUc0QVpnQnBBR1FBWlFCdUFIUUFhUUJoQUd3QVh3Qn?= =?iso-8859-1?Q?RBR0VBY2dCMkFHVUFiQUJzQUY4QWJ3QnlBRjhBWVFCeUFHMEFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQU?= =?iso-8859-1?Q?FBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFC?= =?iso-8859-1?Q?akFIUUFYd0J1QUdFQWJRQmxBSE1BWHdCakFHOEFiZ0JtQUdrQVpBQmxBRz?= =?iso-8859-1?Q?RBZEFCcEFHRUFiQUJmQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J2QUhJQVh3?= =?iso-8859-1?Q?Qm5BRzhBYndCbkFHd0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFB?= =?iso-8859-1?Q?QUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFjQUJ5QUc4QWFnQmxBR01BZEFCZk?= =?iso-8859-1?Q?FHNEFZUUJ0QUdVQWN3QmZBSElBWlFCekFIUUFjZ0JwQUdNQWRBQmxBR1FB?= =?iso-8859-1?Q?WHdCdEFHRUFjZ0IyQUdVQWJBQnNBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHMEFZUU?= =?iso-8859-1?Q?J5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhBYmdCaEFH?= =?iso-8859-1?Q?MEFaUUJ6QUY4QWNnQmxBSE1BZEFCeUFHa0FZd0IwQUdVQVpBQmZBRzBBWV?= =?iso-8859-1?Q?FCeUFIWUFaUUJzQUd3QVh3QnZBSElBWHdCaEFISUFiUUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBYlFCaEFISUFkZ0Js?= =?iso-8859-1?Q?QUd3QWJBQmZBSFFBWlFCeUFHMEFhUUJ1QUhVQWN3QUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQU?= =?iso-8859-1?Q?Y4QWR3QnZBSElBWkFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQU?= =?iso-8859-1?Q?FBQUFBQWdBQUFBQUEiLz48L21ldGE+?= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4452:EE_|CO6PR18MB3874:EE_ x-ms-office365-filtering-correlation-id: c431c0c1-9e86-4e98-f122-08db93cfaa8d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v+nRgJoIDv4vvoZFlNunn+zdbJUVEFWgoW10FO/dASJVvIMtwvQfWGcDOIPsk4fME6DHSkb9bCSB9n0Ph558ZBtzPLAxlNEysYf5dncv5rx/vlFyNIK82GCKHiDqdPPBlUgNHrtcUAqLNSoeFMYVK+tw7fYMq0mNB91oemJ1cgLgAV1W0mV0H1lmWFaKhhDIr4+7tMu7xJmvJ6TefGD369xfqh3/DGwiaunXqkOJE3pj85Ivm95wd4woCLq4GUJ5j+VYZGZ59dg/n6BSox1zfKJrzrGw3S7Q8syenn0+9/CSXG4EBrar9diCYDrp8tC7KEv0jU5cen+t7naomoFjBocVFPVNvtpxEVhbe7qCpubV+JXDmd+5XVHz8A6PlzxeDF/iEuDSMdXmFesrDu65fucVztp3J9xuwMgmhhDn6qg4quCczGyYb8mLHfSPnf+7y3tflE1NURbooa1Yg8A5On8G3xo6O66gG1Yt4VP0/PpZiVph4AIxqNqjxJ1clPQwldK5bzgDnPN4ZCUsfZ6Ao00uJ5eIw0WADFF+m86nNa77GR8JxoXCFLGoc2E6Mli+YdP9/BHRai6ECQUyzuquEA6QVhDXlmMt9/GcCZv774zdECkTFW8tCDcWMaOcUAdx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4452.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(366004)(376002)(451199021)(66574015)(107886003)(53546011)(6506007)(83380400001)(26005)(186003)(316002)(76116006)(2906002)(66946007)(4326008)(64756008)(66446008)(66476007)(66556008)(5660300002)(52536014)(7416002)(41300700001)(8676002)(8936002)(7696005)(71200400001)(9686003)(478600001)(110136005)(54906003)(55016003)(38100700002)(122000001)(33656002)(86362001)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?jqIG6MDRzIMVd9ucgKeKaK6FaFHnZfvDSNckSGQ/TjHxmCNhCzuMS5dJBu?= =?iso-8859-1?Q?ZJXn4ZNRasSGreO3Ms1mW845cF+Rx7MwetzMuT38AKtD1q63fjVoxq78CQ?= =?iso-8859-1?Q?zIHl8+3sPSkeUb8O+S1hdcjVXnDAhfmmNmhma7Syw3HYTd74tc+I6Yksmg?= =?iso-8859-1?Q?dqQG4Ca+0G+QFMj1VRSoWtSUBQB+/WS7WoCZasbI5HxzH/YCxjUSjL+FSk?= =?iso-8859-1?Q?Xi4WR9wiOkOpckJhi1G8rtZCoRFi30Nl2+GTWrPpj7XLnV+5Rv6Z2dsCnh?= =?iso-8859-1?Q?FnVtV1/PuHe9cG1VWX0dmunHqXkIxWplWqKWQMpg2QE4eVmMbbclmNe81D?= =?iso-8859-1?Q?dlqLJpKZuIfc9zmHajVLAx+6/dq5wBP/BRo3U12OmRnMXsWzusvvmzCoZ+?= =?iso-8859-1?Q?K/aG9KKGhOxyUd4c+pqOHjifHWUVe7czVu1KHN0DlhZPc/HFOXHPrlADq7?= =?iso-8859-1?Q?gFT0mhcQABgCNsFy0hgLGWHS7ES9tzaGaV4XwFLrUR3FNaGNylWMup62pl?= =?iso-8859-1?Q?4LBym/bjauTweW0/W9T4HwqHwYe4Mu+6cdqFe9wLMPcmUcaDXvCpTfTmBx?= =?iso-8859-1?Q?GemWYUyhvfoi3OuqazBlcxnGqPHLUBRSVN03J1L1NybNLaMI61lq6YCweE?= =?iso-8859-1?Q?OfFSq1B9tcnfd6Cf0zKB3dcxclLd8o3GuIFDCvfvD1/fk70uzxqBdTjvvb?= =?iso-8859-1?Q?4TUwOTtGdl9D5D1ZOQeeekmnzpzq6sgvlzmcCoMkyxW3Co07VZm7WSFnwM?= =?iso-8859-1?Q?mm7GU7oLk8eGpHXDzIOest9QaZ6ThpcOY03b/9AadEw9XFUIlUJ/ZLsP9x?= =?iso-8859-1?Q?VcYtZy12byX/Jg99OhbKur8CXh4bvUGUrk5YOOXQ5G0Ryofaoth3raWsZq?= =?iso-8859-1?Q?kVrXNycDRtzXbybh+bn2UqBSXkevxuINoi+zwKGtTlY8EmndLqaBOs4XTc?= =?iso-8859-1?Q?hRf0Z5Lg3L6vG1CALobyT+gRl12uLUFADfwKgpxBYPbyGgFappmDuEUsm8?= =?iso-8859-1?Q?4h89yoB3SVj/h7FiH1eSsf1z64M+AsrPalhFWyjWEE70sWWn7Qesm1REyw?= =?iso-8859-1?Q?E7SwERzNumdO1MwJIsWr4FZ02tdTwNEKSbdwMRempzT3ZdtwwyStx4vDEP?= =?iso-8859-1?Q?Hh+D0NUu55B8foHPQShvXQa0YOBStSNM8/v/NpyJkBNE1UfbIEj5OF2wlf?= =?iso-8859-1?Q?PQ1cxLxPxkZ1c9PxSTqbCscibsUKTUCYs1qFIMplwnnq+EphdZAnHw2bl8?= =?iso-8859-1?Q?L3oo1v8eLS9CVI5/JfE6WrEo1HfavPvUJqsBAz6Yk4FdLucdijKyfb5bCc?= =?iso-8859-1?Q?FEs5MwRIuJu1PvpKlr05sSVS5LOwgQoalTo8VUaBtFm7wDPjd3k4NtdzNp?= =?iso-8859-1?Q?mnd7qOKNVDBYo0iwuPwe8aH+ZOti0ShumvWv4MUMKhMzgPDnR+I8SrvRKf?= =?iso-8859-1?Q?p+bXZJE0/upPTkuA5kFipB9QPnF9YNcWhl80/f/nREQoHfWggFeOF1aLTU?= =?iso-8859-1?Q?1m4MShVQnDaP3Q57NWWKg0UwXQurwfU5fUsixZkCNRLzoTbyIlPYDJ0eGW?= =?iso-8859-1?Q?junzd2Kfyze28oL2rffAutV4WeMHhlfqciAnq4Ml1/dDu4oBUWwQisQK0y?= =?iso-8859-1?Q?LxPQPmZ4bGYE0jc2Rjn9FNtMWjGTTIcW3i?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4452.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c431c0c1-9e86-4e98-f122-08db93cfaa8d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 03:13:53.1563 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OFS4cE97XQmU78Bb4cf0vFZVIALjTajUscJiShDwcimJntqR8RmOBoooTmCmxael7lTuNUV64QF+fhRqdrgn2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3874 X-Proofpoint-GUID: Tz8zj-2Sic1Qb9Q-gfiMZGEAeGuBNlV2 X-Proofpoint-ORIG-GUID: Tz8zj-2Sic1Qb9Q-gfiMZGEAeGuBNlV2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-02_21,2023-08-01_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org -----Original Message----- From: Stephen Hemminger =20 Sent: Thursday, August 3, 2023 4:56 AM To: dev@dpdk.org Cc: Stephen Hemminger ; Hemant Agrawal ; Sachin Saxena ; Nithin Kumar Dabil= puram ; Kiran Kumar Kokkilagadda ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi= ; Andrew Rybchenko = ; Bruce Richardson ; Kevin Laatz ; Chas Williams ; Min Hu (Connor) ; Liron Himi ; Chaoyong He ; Niklas S=F6derlund ; Devendra Singh Rawat= ; Alok Prasad Subject: [EXT] [PATCH v4 19/19] drivers: remove use of term sanity check External Email ---------------------------------------------------------------------- Replace non-inclusive language with better comments. Covers multiple drivers Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/cnxk/roc_npa.c | 2 +- drivers/common/dpaax/caamflib/desc.h | 2 +- drivers/common/sfc_efx/base/ef10_nvram.c | 4 ++-- drivers/common/sfc_efx/base/efx_rx.c | 2 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- drivers/net/mvpp2/mrvl_qos.c | 2 +- drivers/net/nfp/nfp_flow.c | 2 +- drivers/net/qede/qede_rxtx.c | 6 +++--- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/q= bman/qbman_sys_decl.h index caaae417773c..2b6162d0ceaf 100644 --- a/drivers/bus/fslmc/qbman/qbman_sys_decl.h +++ b/drivers/bus/fslmc/qbman/qbman_sys_decl.h @@ -9,7 +9,7 @@ #include #include =20 -/* Sanity check */ +/* Byte order check */ #if (__BYTE_ORDER__ !=3D __ORDER_BIG_ENDIAN__) && \ (__BYTE_ORDER__ !=3D __ORDER_LITTLE_ENDIAN__) #error "Unknown endianness= !" diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c = index e796878ba634..1db78631a185 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -614,7 +614,7 @@ npa_aura_alloc(struct npa_lf *lf, const uint32_t block_= count, int pool_id, { int rc, aura_id; =20 - /* Sanity check */ + /* parameter check */ if (!lf || !aura || !aura_handle) return NPA_ERR_PARAM; =20 diff --git a/drivers/common/dpaax/caamflib/desc.h b/drivers/common/dpaax/ca= amflib/desc.h index 635d6bad071f..feb6a5d7bb2d 100644 --- a/drivers/common/dpaax/caamflib/desc.h +++ b/drivers/common/dpaax/caamflib/desc.h @@ -107,7 +107,7 @@ extern enum rta_sec_era rta_sec_era; =20 /* * ONE - should always be set. Combination of ONE (always - * set) and ZRO (always clear) forms an endianness sanity check + * set) and ZRO (always clear) forms an endianness check */ #define HDR_ONE BIT(23) #define HDR_ZRO BIT(15) diff --git a/drivers/common/sfc_efx/base/ef10_nvram.c b/drivers/common/sfc_= efx/base/ef10_nvram.c index ce8357fa94ce..fad9f0f507f3 100644 --- a/drivers/common/sfc_efx/base/ef10_nvram.c +++ b/drivers/common/sfc_efx/base/ef10_nvram.c @@ -595,13 +595,13 @@ tlv_update_partition_len_and_cks( =20 /* * We just modified the partition, so the total length may not be - * valid. Don't use tlv_find(), which performs some sanity checks + * valid. Don't use tlv_find(), which performs some checks * that may fail here. */ partition.data =3D cursor->block; memcpy(&partition.tlv_cursor, cursor, sizeof (*cursor)); header =3D (struct tlv_partition_header *)partition.data; - /* Sanity check. */ + /* Header check */ if (__LE_TO_CPU_32(header->tag) !=3D TLV_TAG_PARTITION_HEADER) { rc =3D EFAULT; goto fail1; diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/= base/efx_rx.c index dce9ada55d28..28676c5a5b99 100644 --- a/drivers/common/sfc_efx/base/efx_rx.c +++ b/drivers/common/sfc_efx/base/efx_rx.c @@ -930,7 +930,7 @@ efx_rx_qcreate_internal( ndescs, id, flags, eep, erp)) !=3D 0) goto fail4; =20 - /* Sanity check queue creation result */ + /* Check queue creation result */ if (flags & EFX_RXQ_FLAG_RSS_HASH) { const efx_rx_prefix_layout_t *erplp =3D &erp->er_prefix_layout; const efx_rx_prefix_field_info_t *rss_hash_field; diff --git a/drivers/d= ma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index 3696c7f452fc..633065= aa4577 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -196,7 +196,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd= _dmadev *idxd, pci->portals =3D dev->mem_resource[2].addr; pci->wq_cfg_sz =3D (pci->regs->wqcap >> 24) & 0x0F; =20 - /* sanity check device status */ + /* check device status */ if (pci->regs->gensts & GENSTS_DEV_STATE_MASK) { /* need function-level-reset (FLR) or is enabled */ IDXD_PMD_ERR("Device status is not disabled, cannot init"); diff --git a= /drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bo= nd_8023ad.c index 4a266bb2caf1..56972f06c045 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -1477,7 +1477,7 @@ bond_8023ad_setup_validate(uint16_t port_id, return -EINVAL; =20 if (conf !=3D NULL) { - /* Basic sanity check */ + /* Basic input check */ if (conf->slow_periodic_ms =3D=3D 0 || conf->fast_periodic_ms >=3D conf->slow_periodic_ms || conf->long_timeout_ms =3D=3D 0 || diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c in= dex f43217bc589c..db5052a9ab6f 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -260,7 +260,7 @@ get_entry_values(const char *entry, uint8_t *tab, if (nb_rng_tokens !=3D 2) return -3; =20 - /* Range and sanity checks. */ + /* Range and input checks. */ if (get_val_securely(rng_tokens[0], &token_val) < 0) return -4; beg =3D (char)token_val; diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index = 3ed78eab5706..6342d6cbfbd0 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -1956,7 +1956,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_represen= tor *repr, break; } =20 - /* Perform basic sanity checks */ + /* Perform basic checks */ ret =3D nfp_flow_item_check(item, proc); if (ret !=3D 0) { PMD_DRV_LOG(ERR, "nfp flow item %d check failed", item->type); diff --g= it a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index c355= 85f5fdd6..8b89841e03b1 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -1383,7 +1383,7 @@ qede_rx_process_tpa_end_cqe(struct qede_dev *qdev, cqe->len_list[0]); /* Update total length and frags based on end TPA */ rx_mb =3D rxq->tpa_info[cqe->tpa_agg_index].tpa_head; - /* TODO: Add Sanity Checks */ + /* TODO: Add more checks */ rx_mb->nb_segs =3D cqe->num_of_bds; rx_mb->pkt_len =3D cqe->total_packet_len; =20 @@ -2211,7 +2211,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct = rte_mbuf **tx_pkts, =20 #ifdef RTE_LIBRTE_QEDE_DEBUG_TX static inline void -qede_mpls_tunn_tx_sanity_check(struct rte_mbuf *mbuf, +qede_mpls_tunn_tx_basic_check(struct rte_mbuf *mbuf, struct qede_tx_queue *txq) { if (((mbuf->outer_l2_len + mbuf->outer_l3_len) / 2) > 0xff) @@ -2473,7 +2= 473,7 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb= _pkts) RTE_MBUF_F_TX_TUNNEL_MPLSINUDP) { mplsoudp_flg =3D true; #ifdef RTE_LIBRTE_QEDE_DEBUG_TX - qede_mpls_tunn_tx_sanity_check(mbuf, txq); + qede_mpls_tunn_tx_basic_check(mbuf, txq); #endif /* Outer L4 offset in two byte words */ tunn_l4_hdr_start_offset =3D -- 2.39.2 Acked for qede Acked-by: Devendra Singh Rawat