From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D76EA0547; Wed, 8 Sep 2021 14:55:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7689D41140; Wed, 8 Sep 2021 14:55:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2809440E25 for ; Wed, 8 Sep 2021 14:55:03 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1889TYvR030875; Wed, 8 Sep 2021 05:55:03 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2046.outbound.protection.outlook.com [104.47.73.46]) by mx0a-0016f401.pphosted.com with ESMTP id 3axtka8mr1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Sep 2021 05:55:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5/KAKUJWnza4J3rk8HdHxypqvVGeHNUBO6N96RriaeCgTtnSWJdJeTOtesDmXF3hvRBF28Qi3WGGsGUzrG+9OFTf2BpfRO3uwk/dV4I/B030hZ0Z+rWBKzwwJKc2z1LjyQpcWdiCtkMZUY1tR4pao5M+kq/blEfKqWyYh12iG0S8A83klVnHt2ULpM/Jz0bvXdM67B2cXIiIUl60SDBWY1Hh3E+TaQSofaWNLjdxqZTxPY1dPrCoHDGz7oTQ9EE4Qmp0s7ZJoZICrDzmRjPwhgwfbGKy3YQT50a/8bEAcl7vl8ERlbX5HJuA8axfVCNZV9IIuoyfkmwF/i+GKjoAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jEnviJmz+aBzlfRNwEr/6EuWHjAlGC2CYUIUZY3sMRg=; b=Eg/HiixpeQsKLd80Ai8x1zlUy69TUPEalZqqL06m8OSf35hY0tcgiEDy+94ef5xm7UvcCqHuDePZ9+240qMdJp+tOjhUDIspxtezUDIjoYwr+vfEsqxWWBT//FAU5Y9u/Bg4VPM3/djLl5cAVT2V3yXPDaiom46pgtobqL1Feaw1+NUkS+PwlHpsAwVMQDZKvqWIxmuLrr0PP1YXFPM9amwif4F4jbxFMGG7igCJjgx8kG+xnSurSZWj6kgQiPbHCBrlhWiNPQTthia09iZA6bs1V6qqfrdhlNkyTGRmnsT62lwVgk+dBaiPg7IyNmb6H4Fkwh6Dh7vH3e9nrDWXGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jEnviJmz+aBzlfRNwEr/6EuWHjAlGC2CYUIUZY3sMRg=; b=uYAyxwzBMdicIZKfsqZckmDKSqQC4uhx5tf8ahTQqXcvd0JgMsCLyhtcOshVZ+N3pFna1LDdgGIHXkLxgJzQqxDHHtuEHPj1sHvvLnB+BwGQIvXhpQWYBAkwq+b5UK90MzHGENuXtLMOW5722oLMVvyQ1CCGQWbCjX2FZhqwUyg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4730.namprd18.prod.outlook.com (2603:10b6:303:e9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 12:54:59 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::411f:5b87:321e:de29%3]) with mapi id 15.20.4478.026; Wed, 8 Sep 2021 12:54:59 +0000 From: Akhil Goyal To: Radu Nicolau CC: "dev@dpdk.org" , "declan.doherty@intel.com" Thread-Topic: [EXT] [PATCH 3/7] examples/ipsec-secgw: add support for TSO Thread-Index: AQHXoLblK1T1NSRqjkC7QnlNmqVse6uaHqJg Date: Wed, 8 Sep 2021 12:54:59 +0000 Message-ID: References: <20210903112257.303961-1-radu.nicolau@intel.com> <20210903112257.303961-4-radu.nicolau@intel.com> In-Reply-To: <20210903112257.303961-4-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6acf9fc1-b94b-4e49-9e7c-08d972c7dd9f x-ms-traffictypediagnostic: CO1PR18MB4730: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: owTJWd/h3fyIiHt1wM8DlnLvjym9ansRLkVFl8CLKBkBruzmCqZW/sHj5vXCv/xCHyoe9pFYz05CRT4zu3LWjVewzTrMa0lL9HAIKStwsLvC0Mfn7qA238ZEVkMsqDdq/X4mYu4TL4vNKAdWR8PcSC4+Dxb8XZAUDF/F86C96w8hvl67Vy8Z61qbgGDlZwlJEXjRKPq4JqUheoRzr7IgPIPrNwyHdvv4O/ryco4+jeIUVQ93pt0mB2e8I5tUTz37l7uqoXPjPRzMRkptPwWefoXzgYc1GuqRoeeJM4pcjzcL/x2IXxhYz6nPahh1jpwiJw3VCxxffbf5v2Aq00subcEd2SvjAMSSUfCbBFqXbdn6TrJGer++eE81hClSdhg21HbnxkLaxbo32UUfkz+zL+0SvQmHwG2+qEPifSI+cylTrucvXqVlS5jDUC/xXtgovzsXdTEBFIo1rhaZDMHZBIOwnpeiQChHd4DyCtANhwsOdY8+noLwcqWPq5rNB4U4BNUwUNflXD/mABfsy9psnX9N3lz9sE8uJRrKFRIdNLKNAz7nr2fvQIW/6V9Z2zEzEOVvCuP5TepthHkOfOiZ1wvBAURVkT7OgTyut+2qGUBxFNgtDhhEnOedFUiqzE4chgw9sxoPj92QVuc8ikzuxWjonTpkgsgjmIFS6m07e/v4pd+x5TB8DHhJN+0sE0aXg2zDLnRuwSKsJknght2X2w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(6506007)(71200400001)(122000001)(66946007)(6916009)(64756008)(5660300002)(26005)(66556008)(83380400001)(66446008)(66476007)(8676002)(76116006)(8936002)(38100700002)(52536014)(186003)(38070700005)(55236004)(4326008)(54906003)(2906002)(33656002)(86362001)(478600001)(55016002)(9686003)(7696005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1l1Kt+NlvDoW2L45gicoYmXQTUaYcbCfmtQr3Wv8PINzihW/lfBuHSAQIzmq?= =?us-ascii?Q?UGQFKw9hyLb79mtlnG0Erbdqrjrvw5+yTt64Kd6Z7QsAnBtZUFrCHT9/BKfh?= =?us-ascii?Q?EA4vDpCf84FokV+f6rGRYWGMUjHvsEZs/JsU11SxIUK9lzudeNruMZVGVPRm?= =?us-ascii?Q?AKEF863dswJztpS2uDk1AKvHIodtoM3VghQD8twohwT6CZIX6z0KZEw2oGH/?= =?us-ascii?Q?v7Fv8uBzfi6+8ZlReU+oGntf7mZygCTlKv550Cj4fix9q3P5IZDJEPMOTXUK?= =?us-ascii?Q?kg/dQ12f3/y31LtphIsaTOcz4pzKCNC1bZnVgsKgVA0xaw6IHPt/YYDtOQ89?= =?us-ascii?Q?WWw5Ad8KEpMz8jZPANxZNETWLOMXYzq0TmicW7SSFyQRkJ7Da1XECVpUs+xG?= =?us-ascii?Q?D2OoEhCVSFnWND7X9nsSG0lxeC9IlvD7etA9kuUMAuhAacnaOwbjonAsiwcw?= =?us-ascii?Q?h78vc5+7HbmQu7Vwdp+oX/qyCODUZi/K4YrCaKH8sO/7Tskdw/FoOGbF9h7q?= =?us-ascii?Q?6/r/4jpx2ZwOIaNa/OKWwUV+izaDM66UGIeZ7jb87Fm4t1T//1nBKwnI4Ayz?= =?us-ascii?Q?fgceOQJONAIVD/rhCG66xvcfCsqHxmspPMRutR/sDL5Xg+CY/rTAVBIfvoMM?= =?us-ascii?Q?uBLh0l4WuhBFNXQCAu30LUnU7gOXSZYepztHAq55UUtSRfgnSrOXvd1ZmUfY?= =?us-ascii?Q?cTeGqMIIBbn7fj9j7y17cVZqhikg45y/catm1SwvAmyf5in+2x+hmK7nKS7k?= =?us-ascii?Q?RB2PNLDHlqOyIq0r+11Olelh89EWdQamGVaNVL7UIc+76Yo1as0YEhR9Ie1b?= =?us-ascii?Q?JzVcyboE0cf+RlIRbVam5QijdYcn4bBvq/BFxHivwgUfV6wjQPZKxQzAypJg?= =?us-ascii?Q?PraZKuHHChOLNv0zD54S2YFtyjkm/t2Dgin7U2bRTOQZ+YQkJZ5z1SKOIb61?= =?us-ascii?Q?8+1dZo7Rlh0YvU7rXMUmxjt8q2IAt486LNpN+8BibPvr6Ql4Hl3fwPphOtF9?= =?us-ascii?Q?WZ7XY4Wi266GLbmSnIr+dNIpBQQZoT6BGhjQUIfMjSY05nnckmtS1c4nbCA9?= =?us-ascii?Q?X4GypDIdiz5tSYYIlZHoqm3jk4WpIxzsjatFih47bQqF8aP5B83wlNyH/oJ4?= =?us-ascii?Q?1IQpaN3iZRvomGwyGZrzQglHVVr0UfEj1/srGi7Y5g40xrseLjvJABu+VH8/?= =?us-ascii?Q?E5jEdDmHIpbYrIIZvnWdIV1bYG83FlQALRoqFZCVuy24H4hIh88scVspRIaU?= =?us-ascii?Q?vzFWC2zC15mHyB9so/TPAR0n7jHl2Ks0YJDDD7p5nFs0xRY9jd9rbwOnAQmo?= =?us-ascii?Q?ura7ROqUX8wleVI+7dGhIR7+?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6acf9fc1-b94b-4e49-9e7c-08d972c7dd9f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 12:54:59.0814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wkE5DVSabyKbqro4o2AW4n8mCZ5qpPcnIQPO59RY0iMRzumo/t2ktdrdq1ozjnS4v2Hxe8hfrWXhVM/6BNxSsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4730 X-Proofpoint-GUID: bwZhXCB5vuh1XIINnCr9_aiyU_GlMQwh X-Proofpoint-ORIG-GUID: bwZhXCB5vuh1XIINnCr9_aiyU_GlMQwh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-08_06,2021-09-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH 3/7] examples/ipsec-secgw: add support for TSO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Add support to allow user to specific MSS for TSO offload on a per SA Spell check 'specify' > basis. MSS configuration in the context of IPsec is only supported for > outbound SA's in the context of an inline IPsec Crypto offload. >=20 > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec.h | 1 + > examples/ipsec-secgw/sa.c | 15 +++++++++++++++ No update for the new mss option in the documentation of the app Please also update description to explain the new option. > 2 files changed, 16 insertions(+) >=20 > diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h > index b496b4a936..7ba29406bf 100644 > --- a/examples/ipsec-secgw/ipsec.h > +++ b/examples/ipsec-secgw/ipsec.h > @@ -143,6 +143,7 @@ struct ipsec_sa { > enum rte_security_ipsec_sa_direction direction; > uint8_t udp_encap; > uint16_t portid; > + uint16_t mss; > uint8_t fdir_qid; > uint8_t fdir_flag; >=20 > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > index d5943f8cdc..bc83e4bccc 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -695,6 +695,16 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > continue; > } >=20 > + if (strcmp(tokens[ti], "mss") =3D=3D 0) { > + INCREMENT_TOKEN_INDEX(ti, n_tokens, status); > + if (status->status < 0) > + return; > + rule->mss =3D atoi(tokens[ti]); > + if (status->status < 0) > + return; > + continue; > + } > + > if (strcmp(tokens[ti], "fallback") =3D=3D 0) { > struct rte_ipsec_session *fb; >=20 > @@ -1366,6 +1376,11 @@ fill_ipsec_sa_prm(struct rte_ipsec_sa_prm *prm, > const struct ipsec_sa *ss, > prm->ipsec_xform.options.ecn =3D 1; > prm->ipsec_xform.options.copy_dscp =3D 1; >=20 > + if (ss->mss > 0) { > + prm->ipsec_xform.options.tso =3D 1; > + prm->ipsec_xform.mss =3D ss->mss; > + } > + > if (IS_TRANSPORT(ss->flags)) { > /* transport mode */ > prm->trs.proto =3D rc; > -- > 2.25.1