From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46657A00C2; Fri, 7 Oct 2022 06:48:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA69D40687; Fri, 7 Oct 2022 06:48:15 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A046940042 for ; Fri, 7 Oct 2022 06:48:14 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2972QU6T025564; Thu, 6 Oct 2022 21:46:06 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3k2bb48bpr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 06 Oct 2022 21:46:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjqfKNXAZsrZ4ExLyqHgmo6keFIXDmBxiaJbC1qSpKqbg4uRWTlMn5+jafvqRJZnm8BMLHiQMDox+p30NkoVU9j/5z80/GU7IoA41MSeUHget5FitfAsqib+X4biZfTXSvKCJDvaCfRFwkIimAkdeLOtdCK20OduguaMNiUE91EJZwVwzaPuDTzJaRfSb8AVN81CFdurHbkWMzyRNwP5Hp95HwN/MftGYTREBZD1PWedguLyhX9KBlm+3IHI6/7CbPLoATfieVqjfrBP8AH3Zq2kdGLJtFN9obP41n8R67aGpMO8xWa4GYM4hvRtzTYpqyjZb0rrG8LeAeV4hmGc3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aP7CVu2uv3WIBdZatrKKxacBD67oT16An177alNeL0o=; b=j8Vv+Oxz3F5rHyraIQauulDp9lqgIOxMUOLdCutaKr7Aenumfm8wMsKGTeL+zSidNtvjTz20h9b5AGPDFW9xDVUMuhtvdb0AnJi3XvGKDPBpEtDAGjaWOLRvqTzDNFha6vo6JE/kW13kRk4qa0gH426C8M1BFLN4isgw46sIbfpn4qW+YaOdvEX8OA5XcdmOswMWtEcJze6bV1keiNGkQEPX6dxgAbXqXApxGDRxdMC56ZXkJlqhu2l4gXt3S2juC3umHH/I8y5XZWeJDfAQsUTJLhgHXnjtxFi7HnlGFlB9R3vTZJIrZp2Q7dWve521JvsPd8p/ikUqtb5nDgiAHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aP7CVu2uv3WIBdZatrKKxacBD67oT16An177alNeL0o=; b=mW1sWjIpkOY9U58JYZbpzv9m+G6zcYvybXPCs4rzxqw+CKdQSmndGHtTrcWiUmy5Bcyx52nOIB7uRkIr7aUlKvJmrZdhFuzj8X0tPjsYcEdIHhB2isjltp0DIfSZq7qBzAarsfESeifFeOpAPBjFcMSLAmN/OJcAgG+dR5T1mr0= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BN9PR18MB4282.namprd18.prod.outlook.com (2603:10b6:408:11b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.36; Fri, 7 Oct 2022 04:46:03 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5676.033; Fri, 7 Oct 2022 04:46:03 +0000 From: Akhil Goyal To: "Chautru, Nicolas" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "maxime.coquelin@redhat.com" , "trix@redhat.com" , "mdr@ashroe.eu" , "Richardson, Bruce" , "david.marchand@redhat.com" , "stephen@networkplumber.org" , "Zhang, Mingshan" , "hemant.agrawal@nxp.com" Subject: RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11 Thread-Topic: [EXT] [PATCH v12 0/7] bbdev changes for 22.11 Thread-Index: AQHY2BUmus88kB47d0iJm+ofLlDVa64BoeJggABT8YCAAGg9wA== Date: Fri, 7 Oct 2022 04:46:03 +0000 Message-ID: References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com> <20221004171656.17967-1-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|BN9PR18MB4282:EE_ x-ms-office365-filtering-correlation-id: a6dbe696-62fb-4d1f-65eb-08daa81ed6ce x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: slQ+nsSAnwVkMC8F8rcrG/8BR4SgBp0XXKWyrDtIr4lTL1DwsJWoqNq8QIAYErOyo6RtHj9wQpLGKz7q3HUqEW2VeXDvxY+AL1oRtPhKS9g1KUS5D3nLbXoiSwpz6Iyu77elleP816X2ZSl9J8ZGq5WTCvlZ/6X75XOAi+aw9smg7vEIvuM39KJUz19hXNRnjXFUnhmOgg/CF/MUs7a3d2fIlM2uQYQZkVIxdVTAJ+KE4DhiW5P/+zw8pYIP8i0WIKOBFWbyZN71NTR3HGqLNU9/2xRFdoPYVkW8Io+EJp3YncmN3lsmAQVj1ennr/kmitXwLA7SnJm2PiWGW5pMn9xhrVa7MsQiLP77BlWRH5BrEXxKwh9Wkn9BgqFhJHqPHdiJbQP4RNPhXLAq0ewgdWZTX3nsXSiD1Uny2SAZYmDoERAqceHMMFJUNgGMO4nu3oqJfN7pR8N+5eKuIO6tV/PHpZypjdWxiZwme111Hs3EyFN7nS11gjZnS1V0AaPvEtaCSsEoe1+Pdh5A4+PM3bKXsElTuf3qEtatCBOQjFqqxlaBrLBN/3qhW+uU/pPiAwngjxxfCyurPwX2bg+cilYqidh+kbX66oGZ3ug3HeTvchTAkgEfZEIBc2npwnD/Gy0/hV15mICedz2g33LaSVN/06h3qfSwxeR8PqQFOX+sOMTWplVuMIf3MA4bzXXkOWS/rdMfl0BFY97cZrtCVaYsbT6TPLTVPOxVPlGMlr4ywE5wpStYXvfGoG7uE8V8932BCsS6gBbDqduShpPI9Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(136003)(366004)(396003)(376002)(451199015)(76116006)(64756008)(66946007)(7696005)(478600001)(66476007)(66446008)(66556008)(55236004)(53546011)(8676002)(4326008)(6506007)(33656002)(316002)(110136005)(54906003)(71200400001)(38070700005)(122000001)(55016003)(38100700002)(186003)(26005)(9686003)(86362001)(83380400001)(52536014)(5660300002)(7416002)(8936002)(41300700001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VhCUe6J6oclZ2ruYFLgGFfmaeUy5OWW2xZDMUmObwfhuoe9KeFwpeX9LMCrb?= =?us-ascii?Q?h5liFy2C+XAgmUodYXlFX6QitNc7pEYqIj7PfjBvgScIosc37BcFebiVr8W1?= =?us-ascii?Q?4uRSW1nnW3LSRGCOvUYR4wRxHZemTHKVdd4/EYTlcXe4xLx22Br4eaht+erS?= =?us-ascii?Q?qjvkPdZfse5No4UHjXtcicIwZinz7lPdJ3RHWn5MNYSYwhEvv9JQdwo6yU8k?= =?us-ascii?Q?/oCPDc2gVVvMAyFGE3jp0ii/i93tPmSz41hApawCqFkNP8FSKkG7ziWEqJHv?= =?us-ascii?Q?qEjVW6Iv98mxHC2xFVgyXidYP+UzEgSkKS8skeZLn/fMjlobnPfFzKtRzlCw?= =?us-ascii?Q?SBY+Xra1XYdM+U5cThJ+5MtnQVV0kNFXh35gqZijkeHAOVRDM0uhKaWcNct2?= =?us-ascii?Q?lO+y/G0Afq+bvbvpGdZm5wU2x557ZIiz6WXWWlp9eaZ5DH8P0v74aNBBO0L+?= =?us-ascii?Q?B1S1/NfIJ2vWjkHn6FmAeFcu5hPci4qEOHEaOYVsI3XjxLC+ijUi75sdaTgO?= =?us-ascii?Q?IKuryuqOk004odib8u4DF1nR2YM7imf4/Bk0z9KDxFGWFbHwGMP5OQ4fOyTd?= =?us-ascii?Q?siP2KOjZMA0W4y3J/RzYQq9RfiRB5b9Bod6RoeQfbKG5MD7HUQz3L2EVvIAf?= =?us-ascii?Q?po37JJMDWxw9fsp7+cFatrclYORbZRR6l9/BddDsoOgfdbapHZNFBGxrABmt?= =?us-ascii?Q?jPQKU7IlSCSkEFEX7OHezJA2Pta53lAOQQpe79HsuGSlITv12oTaRIcLtZlD?= =?us-ascii?Q?uKbd4b3SF8Q9CmEYKLam4Dq2FzET/+FyZbs5CEMW6E/WZVloRx80pXTuVB/q?= =?us-ascii?Q?XeY0eew5aNa+kyUaem0SCrlh98Uq7ZhKmvgYiBV7+Oe7UvG2HiYqtPzednYb?= =?us-ascii?Q?RczWvN5nD9mD4gBUFoY2CHdSS37SSKZb9R+SCNc+dOiYc3tMyGbuX2U+IrA9?= =?us-ascii?Q?N8hiBSIJ5EMyp2kKr6K+uYfUKr/X4FHLCQ40nG4vOeGsp1zxKkioAti/6Zom?= =?us-ascii?Q?beuMNNgInfl1rvDAV99zA8OWvaEoZ5m2iohbQTkGLNrAwK2T3YUYKn3QWXNx?= =?us-ascii?Q?0EWUneBmuXvBe/XwU0tM7es++gDARXdxiyc0m1nRm+6yDNhf0t/0ylsxzc9Y?= =?us-ascii?Q?13RzBQXywww13t5S92sgehEQBBOjB//yZ0NiFxlf9viNkKk4dIFvds5HlNQy?= =?us-ascii?Q?SSgGajH35utLU+CweVC7KpO+IERv0K7IGR1YwowyPKJZDjtReYqoE28bAejo?= =?us-ascii?Q?X7vQYPZmCl1wsM+nVgG0ENDr/LqaXhYFhG+x/nJEVABDQQ+j1OJdBipHiPLb?= =?us-ascii?Q?g4mA05VnjsKHoeKhqiiLbFYCY9sAglgrjU8mHLZh8u/tpK10tvyye1GONuzA?= =?us-ascii?Q?CcWi+6crOUo5pFpw4E8KPQ8jO1mPocQ4kC7GTXJ/HFbPi6SUpzVzN5UF4tUJ?= =?us-ascii?Q?3fN/K0sBlJFePLkMF6IsAkIuObprchlf1slzl5K+LU7c7HrxvEQiNRDUJhB+?= =?us-ascii?Q?G6in+1jlL5gaNWMLfD0/soxepCmwxsd247ZjJ+AalcQIfFO3a2rznPW93ew2?= =?us-ascii?Q?Z4/De7xK4hohr55P3yk39KsSFD/ZgpHOQtxguuFK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6dbe696-62fb-4d1f-65eb-08daa81ed6ce X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 04:46:03.2370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b38CM1NJxEnIh/HERVeiRkKI5znG08pocmDvGJKQFsQGcERmH+yLlh8SIkVko1Jx9xIcAWhHo3bfYb59qVAXpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4282 X-Proofpoint-ORIG-GUID: K3mWBMtSmP-c9-QYA0HZf415QSBWbdxN X-Proofpoint-GUID: K3mWBMtSmP-c9-QYA0HZf415QSBWbdxN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-06_05,2022-10-06_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Thanks Akhil, >=20 > A couple of things I miss in term of guidelines for my benefit and that I= don't see > in documentation: > - May I ask what rule we should use for documentation line breaking? I am > unclear of the reason for some of the changes you made whose origin versi= on > looked legit to me. Were you trying to fit into 80 chars (not always the = case) or > was this to split the sentence by phrase as opposed to breaking simply ju= st > before 100 chars? Can you clarify the recommendation? I see in the doc it > suggests 80 chars but unsure whether this is because this was not updated= when > moving to 100 chars. The guideline for is for 80 characters, but if the sentence is going to be = split across two Lines, we should break at logical points. This improves readability. > - Do we really need a dot at the end of every text in a comment even when= not > an actual sentence? I don't personally see the point nor do I believe thi= s is > followed in much of DPDK existing code (it depends at best), nor was this= case in > the file where new structure was added (keeping consistency). Is that re= ally a > recommendation for DPDK guideline for all new code to add a dot at the en= d of > all text? Dots should be added for each of the comment wherever we have a sentence. They may be skipped for a couple of words. >=20 > Thanks for kindly clarifying, I can then update the other serie based on = such > guidelines. >=20 > Thanks for the other formatting issues and commit message changes. >=20 > Nic >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Thursday, October 6, 2022 10:32 AM > > To: Chautru, Nicolas ; dev@dpdk.org; > > thomas@monjalon.net > > Cc: maxime.coquelin@redhat.com; trix@redhat.com; mdr@ashroe.eu; > > Richardson, Bruce ; > > david.marchand@redhat.com; stephen@networkplumber.org; Zhang, > > Mingshan ; hemant.agrawal@nxp.com > > Subject: RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11 > > > > > Hi Akhil, Thomas, > > > > > > v12: minor change to fix misaligned comment on patch 6 raised by Thom= as. > > > Thanks. > > > v11: updated based on Thomas review notably on comments through the > > > serie and ordering. Thanks. I have also updated rel_notes and > > > deprecation through the serie this time. > > > v10: replacing the _PADDED_MAX enum to _SIZE_MAX macro based on > > > suggestion from Ferruh/Maxime/Akhil. Thanks > > > v9: removing code snippet from documentation in 5/7 requested by Akhi= l. > > > Thanks. > > > v8: edit based on review by Akhil : typos, coding guidelines. No > > > functional change. Thanks > > > v7: couple of typos in documentation spotted by Maxime. Thanks. > > > v6: added one comment in commit 2/7 suggested by Maxime. > > > v5: update base on review from Tom Rix. Number of typos reported and > > > resolved, removed the commit related to rw_lock for now, added a > > > commit for code clean up from review, resolved one rebase issue > > > between 2 commits, used size of array for some bound check > > > implementation. Thanks. > > > v4: update to the last 2 commits to include function to print the > > > queue status and a fix to the rte_lock within the wrong structure > > > v3: update to device status info to also use padded size for the rela= ted > > array. > > > Adding also 2 additionals commits to allow the API struc to expose > > > more information related to queues corner cases/warning as well as an > > > optional rw lock. > > > Hemant, Maxime, this is planned for DPDK 21.11 but would like > > > review/ack early is possible to get this applied earlier and due to t= ime off > > this summer. > > > Thanks > > > Nic > > > > > > Nicolas Chautru (7): > > > bbdev: allow operation type enum for growth > > > bbdev: add device status info > > > bbdev: add device info on queue topology > > > drivers/baseband: update PMDs to expose queue per operation > > > bbdev: add new operation for FFT processing > > > bbdev: add queue related warning and status information > > > bbdev: remove unnecessary if-check > > > > > > app/test-bbdev/test_bbdev.c | 2 +- > > > app/test-bbdev/test_bbdev_perf.c | 6 +- > > > doc/guides/prog_guide/bbdev.rst | 103 +++++++++++ > > > doc/guides/rel_notes/deprecation.rst | 13 -- > > > doc/guides/rel_notes/release_22_11.rst | 14 ++ > > > drivers/baseband/acc100/rte_acc100_pmd.c | 30 ++-- > > > .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 9 + > > > drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 9 + > > > drivers/baseband/la12xx/bbdev_la12xx.c | 10 +- > > > drivers/baseband/null/bbdev_null.c | 1 + > > > .../baseband/turbo_sw/bbdev_turbo_software.c | 13 ++ > > > examples/bbdev_app/main.c | 2 +- > > > lib/bbdev/rte_bbdev.c | 57 +++++- > > > lib/bbdev/rte_bbdev.h | 158 +++++++++++++++- > > > lib/bbdev/rte_bbdev_op.h | 169 ++++++++++++++++= -- > > > lib/bbdev/version.map | 12 ++ > > > 16 files changed, 560 insertions(+), 48 deletions(-) > > > > > Hi Nicolas, > > > > There were many formatting issues in this patch. This has been a practi= ce in > > whole of bbdev. > > Please take a diff of what is applied on the tree and what was submitte= d to > > take care of the formatting in future patches and please plan to fix th= e rest > > of bbdev documentation (API + prog_guide). > > > > Series applied to dpdk-next-crypto > > > > Thanks.