From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EECD42B7D; Tue, 23 May 2023 10:12:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 344EB40EF0; Tue, 23 May 2023 10:12:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D66D240A80 for ; Tue, 23 May 2023 10:12:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34N1k9xV029337; Tue, 23 May 2023 01:12:33 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qrm46h8vv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 May 2023 01:12:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ckY50BcahgLJlajgsPikLSZl5pUsyvEeE/rKCqtKUFwSYOev5420Joephs+I1JLdLR20Wa+ML4KqAqgB6JQc9vXQBIe51Em67mEr1IHDvA57cqg1xqTad6btj8hKpqEaIMab/v2wvTNyFtHeMWGmoCZI9Co6w5D3vN265Dj6A7uRC3MhERP4aH46rRY/UfW+u+WKXBhbXlTZWw6KnzHOT58o0s5Mwu9FbX9tRPtm+sM1Tpm0C8rVaLoznJyGWHn5yRV/PfMnJ+m8Fo/TGx/1YaAYS3uBmc+oLUtmWV5Q4pAJXQoKnUtXfLHXFpLAx+NbtTwl7DBeTWDPyE+pzRkGxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jaJxBuEdXlXUrCjQq0Q4+Jprtrp2cQuBFjk5kO6MdBk=; b=ArJQAQWA32+zfnQD7fhEXAWVH3/vyLfxYyCpb72sRJP+bmxTd3Y57prgVyHrCyu1LrCVhi88lFglKz6X1fbaPm4D9YKlFBHd0xCC94FKQFsa4aY7Z4WeG2zdv+dmecAvnVHxoJ4dWJysWTQm9bMIZarTAT9fliA8HrymDrX38c/dq3U4F+WoNgdES1kVgg5X1UOWB4lzaBfFKhlSxe8YMiR41q85YFXq5OdtfENY6Hlvm9Gj/59MrG9ufptrE94U7fyRVySdwlQd/3K675TCKqgm576rdoOAp4JjJgEeUbkGkt2AHn3FHBrjbwYZ+KZrqZdEYs0lqeJhI0KzSpDaLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jaJxBuEdXlXUrCjQq0Q4+Jprtrp2cQuBFjk5kO6MdBk=; b=UzflkuHLUs+xoOviRxgpuL8pCs+MOd0hxB7LYhi4MtgtJ1jk8ZMto/60yVmkspfhM9apQk/Pmu7kKL8ZK2ePhNW+MQ4DIs1VeARSU1PBWXIVVw1RHyBHHZsD9tb/FlgbId4jiRYe/269oD/DXPLbCLy2g3Sx2ZcHkWpiDaNxeqc= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DS0PR18MB5503.namprd18.prod.outlook.com (2603:10b6:8:160::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 08:12:28 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::831b:85d2:9a45:8489%6]) with mapi id 15.20.6411.028; Tue, 23 May 2023 08:12:28 +0000 From: Akhil Goyal To: Stephen Hemminger , Kamil Godzwon CC: "dev@dpdk.org" , Fan Zhang Subject: RE: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning Thread-Topic: [EXT] Re: [PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation warning Thread-Index: AQHZjPPnXz6FYqq4eUK5FCVob4XvMK9ngCSg Date: Tue, 23 May 2023 08:12:28 +0000 Message-ID: References: <20230522184951.452626-1-kamilx.godzwon@intel.com> <20230522190453.453281-1-kamilx.godzwon@intel.com> <20230522142510.3952adc5@hermes.local> In-Reply-To: <20230522142510.3952adc5@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcZ2FraGlsXGFw?= =?us-ascii?Q?cGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0YmEy?= =?us-ascii?Q?OWUzNWJcbXNnc1xtc2ctOGMyOTcxZDUtZjk0MS0xMWVkLWEwOTMtOTRlNmY3?= =?us-ascii?Q?NjYxOTA3XGFtZS10ZXN0XDhjMjk3MWQ3LWY5NDEtMTFlZC1hMDkzLTk0ZTZm?= =?us-ascii?Q?NzY2MTkwN2JvZHkudHh0IiBzej0iMjMzNiIgdD0iMTMzMjkzMDMxNDQ4MzQ5?= =?us-ascii?Q?MDI5IiBoPSIvTU1WVk43U1dRUXJibkdRVzJTdXRxZ3pVa2c9IiBpZD0iIiBi?= =?us-ascii?Q?bD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFId1FBQUJs?= =?us-ascii?Q?aVlOT1RvM1pBVDc4TGE4ZXRDaXhQdnd0cng2MEtMRWFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBSEFBQUFBTUVBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?RUFBUUVCQUFBQThBTU44d0NBQVFBQUFBQUFBQUFBQUo0QUFBQmhBR1FBWkFC?= =?us-ascii?Q?eUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFF?= =?us-ascii?Q?QUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFGOEFjQUJs?= =?us-ascii?Q?QUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFB?= =?us-ascii?Q?QUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFB?= =?us-ascii?Q?RzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFj?= =?us-ascii?Q?d0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01B?= =?us-ascii?Q?ZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4QWNnQmtB?= =?us-ascii?Q?SE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFY?= =?us-ascii?Q?d0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VBY2dCZkFI?= =?us-ascii?Q?WUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFB?= =?us-ascii?Q?QUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1QUY4QWN3?= =?us-ascii?Q?QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFH?= =?us-ascii?Q?UUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFC?= =?us-ascii?Q?ekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3?= =?us-ascii?Q?QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFI?= =?us-ascii?Q?UUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFC?= =?us-ascii?Q?c0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFB?= =?us-ascii?Q?QUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJ?= =?us-ascii?Q?QVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFnQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFD?= =?us-ascii?Q?ZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhB?= =?us-ascii?Q?YmdCaEFHMEFaUUJ6QUY4QVl3QnZBRzRBWmdCcEFHUUFaUUJ1QUhRQWFRQmhB?= =?us-ascii?Q?R3dBWHdCaEFHd0Fid0J1QUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFHRUFjZ0Iy?= =?us-ascii?Q?QUdVQWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QnVBR0VBYlFCbEFITUFY?= =?us-ascii?Q?d0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQUY4QVlRQnNBRzhBYmdCbEFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVB?= =?us-ascii?Q?QUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUY4QWNBQnlB?= =?us-ascii?Q?RzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFISUFaUUJ6QUhRQWNn?= =?us-ascii?Q?QnBBR01BZEFCbEFHUUFYd0JvQUdVQWVBQmpBRzhBWkFCbEFITUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFB?= =?us-ascii?Q?QUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUdFQWNnQnRBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refthree: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlB?= =?us-ascii?Q?QUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFad0J2QUc4QVp3QnNB?= =?us-ascii?Q?R1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHMEFZ?= =?us-ascii?Q?UUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhBWXdCdkFH?= =?us-ascii?Q?UUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBYlFCaEFISUFkZ0JsQUd3QWJB?= =?us-ascii?Q?QmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QmpBRzhBWkFCbEFITUFYd0JrQUdr?= =?us-ascii?Q?QVl3QjBBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFB?= =?us-ascii?Q?SUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QWNBQnlBRzhBYWdC?= =?us-ascii?Q?bEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFHTUFid0J1QUdZQWFRQmtBR1VB?= =?us-ascii?Q?YmdCMEFHa0FZUUJzQUY4QWJRQmhBSElBZGdCbEFHd0FiQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcw?= =?us-ascii?Q?QVlRQnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFGOEFiZ0Jo?= =?us-ascii?Q?QUcwQVpRQnpBRjhBWXdCdkFHNEFaZ0JwQUdRQVpRQnVBSFFBYVFCaEFHd0FY?= =?us-ascii?Q?d0J0QUdFQWNnQjJBR1VBYkFCc0FGOEFZUUJ1QUdRQVh3QnRBR2tBY0FBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFB?= =?us-ascii?Q?QUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpRQmpBSFFBWHdC?= =?us-ascii?Q?dUFHRUFiUUJsQUhNQVh3QmpBRzhBYmdCbUFHa0FaQUJsQUc0QWRBQnBBR0VB?= =?us-ascii?Q?YkFCZkFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCdkFISUFYd0JoQUhJQWJRQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdV?= =?us-ascii?Q?QWJBQnNBRjhBY0FCeUFHOEFhZ0JsQUdNQWRBQmZBRzRBWVFCdEFHVUFjd0Jm?= =?us-ascii?Q?QUdNQWJ3QnVBR1lBYVFCa0FHVUFiZ0IwQUdrQVlRQnNBRjhBYlFCaEFISUFk?= =?us-ascii?Q?Z0JsQUd3QWJBQmZBRzhBY2dCZkFHY0Fid0J2QUdjQWJBQmxBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFB?= =?us-ascii?Q?QUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QndBSElB?= =?us-ascii?Q?YndCcUFHVUFZd0IwQUY4QWJnQmhBRzBBWlFCekFGOEFjZ0JsQUhNQWRBQnlB?= =?us-ascii?Q?R2tBWXdCMEFHVUFaQUJmQUcwQVlRQnlBSFlBWlFCc0FHd0FBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNl?= =?us-ascii?Q?QUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFCakFIUUFY?= =?us-ascii?Q?d0J1QUdFQWJRQmxBSE1BWHdCeUFHVUFjd0IwQUhJQWFRQmpBSFFBWlFCa0FG?= =?us-ascii?Q?OEFiUUJoQUhJQWRnQmxBR3dBYkFCZkFHOEFjZ0JmQUdFQWNnQnRBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJB?= =?us-ascii?Q?R1VBYkFCc0FGOEFkQUJsQUhJQWJRQnBBRzRBZFFCekFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFB?= =?us-ascii?Q?QUFBQUFBQUFnQUFBQUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCM0FH?= =?us-ascii?Q?OEFjZ0JrQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffive: QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQT0iLz48L21ldGE+ x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|DS0PR18MB5503:EE_ x-ms-office365-filtering-correlation-id: 9afd7f68-f359-4b83-7276-08db5b6572ff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +x3uKr6PtSOQvCotEedOS5117JJz0Hyt/ckftYXvEsE4ZY9DSS3ke2pQ2OMjBw40Wtf1QR1dy5Vvm43gAqiVhhFeIDOTc0UTfA8rqY6Ym3BOIcz9Hs0WpP1HHFwALwBS+xGpHkHQuBAhfXdrMnjfOKOgbrS5+wxUYJtEQbhAeaJu6IXM1W0hloKyKniEb73rxJ3W6WEeYXIO417RGn6T5FCWkmZsrBtcMd73Ma+jbxZ7v96NwhUHOYC594HTUQ6cQDkIghyYyvb6Ew1kd8ZbpSus4ndhx3wBgujWYTWQn/N9tpM58HCjgoPt5Kkxiv1+HieHBOZVTIomHM7eJHC7e3M6vOskDNgkl//lzhOuUNysLjwHxzTzReSl4yzZgX0uduA6BIwMhk7WxVDkn8OFHlcGlRd+Q0k+LbP1V0kKJtOcNY/OOfcB+19m2B+NQC6QoimQFodydmV895SvHwJWWHqisqV839HieGuXbsGBedOpHWCUI+OcZFwYHpmnECzjvm2J0HzRlAuujFemhU19j/lvKWgw/yEQopil9Rao4byUv4niWsdRms+nG8hBGN1PMkC79nsydSczECBg+yike6VZteacrxgoM7uHsAo3eWvk8POsZGyNb/PvH/455rlF x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(346002)(396003)(136003)(39860400002)(451199021)(26005)(9686003)(6506007)(52536014)(55016003)(83380400001)(186003)(2906002)(55236004)(66446008)(64756008)(4326008)(316002)(66476007)(66556008)(76116006)(66946007)(122000001)(71200400001)(7696005)(38100700002)(41300700001)(110136005)(54906003)(478600001)(86362001)(38070700005)(8936002)(8676002)(5660300002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jft36aT+Px1kcE6fCK+0yuQqFegbesFiAusYpcgu4tSBKXPiAN3u18XYm+D0?= =?us-ascii?Q?6PiOFejEiQemrHIwcFDesShsysu83/LkKbaN/3F5b5JSpfVEaswft7E1hKeV?= =?us-ascii?Q?1VJ7SgaFa6V4Bo9lcsETOG5F/qQqZm1sJlNdU3hbJUvp5vYyulvuLgTLRhpp?= =?us-ascii?Q?EaZaG4u74/0Th+JKsmaJS7SYwBomk0zPzvDNFSBPuOwzbdMj3+lN4b4Izd+d?= =?us-ascii?Q?O95svjtZ9iOo7Xv2Bim5iitWuwz5+Kuw83wcFWsbpUuAkO5ptVR+cCW7irAs?= =?us-ascii?Q?+ksxpS5Su2ftflEYXRvt8C24FF3Iu8nnbud3XnGvHYH6vrTKsfdnE5op93V3?= =?us-ascii?Q?J0QLt1ZRxy9gFe/U823GHMQfIvZzbOB6o03m+Wtmtxe90icgI987HtR/cVbm?= =?us-ascii?Q?vJdbksEaIWPWTU1vhR7ktA4/plVyRNS3sF8jyXD35F3QFw+3UbXBgiMP3Zgm?= =?us-ascii?Q?BLRyFqWFqemuMmJXZGa7aE9yutPau37DP6ZkWlIDY9W57qP2D+wlkky/4bfy?= =?us-ascii?Q?E+VLe8xoHBEI5Nt+mixGENPiif39Hx02pxip9gfawJ7nWlkjgxs8ppeItizj?= =?us-ascii?Q?pf5YmcVl8x5X7EG9dh5NfEORpNRKwlz4A7iXlCDreDlGvQjGOxPheSJH1uV/?= =?us-ascii?Q?U7dc6H+4+ZGHuTGiR3SQyNX3ATCnP5MoOY6EwhIW292YSRp9uxt+s6djLr6o?= =?us-ascii?Q?M9TSRUpS1cHUx5RxnbI6RF3+P59Ao5PZZfB+ITBl70YHFot/zzr2CjQ7kgbM?= =?us-ascii?Q?4x9ok9tGXn3v36bylBNkL5udLYdiKAvpuj4dYH5X5OoN+I07TzIGGY+yzuPA?= =?us-ascii?Q?ozN1mVR8pqhMulAUdfj5kX1sZcYiNnJ5sDVoA5Ow4d4MAmECXFYDl1+tjinP?= =?us-ascii?Q?1mjYAF0yD6SU2vEdNDoSDYZb/e6nJ8o1ySfH9uFX9qvFbDEKHQfryNpP47o2?= =?us-ascii?Q?aeRC7xWpdxiVCSWV0Tf4h/rAhPmBprdAIzF4cUUry2mETbQmFw+8Qhoidy9L?= =?us-ascii?Q?2frSODyxhoC+ElPLQtVJP/SS0gn2Xx5t6GreHAVYK+miz1rLxRpTySB6KAzZ?= =?us-ascii?Q?RCUBBEX5C4rgGpRh6Cs9aNhkxU4Jiw+LbvYNvG1+nycDW9SxN+cNLI8bH9TO?= =?us-ascii?Q?z+/nEjsEJJ6s6mXPrZM+deTRvHs4OJvaAfZ05thPimYPp1ICOPNUZzuT2zAS?= =?us-ascii?Q?2YVOsNdwxrAWCn35H6+A95LB4OOuhMkr8MU3Gh4ofkws0N1OPO/z3coyRnMZ?= =?us-ascii?Q?1Tr3ECdONQN1+/iMccDH7kcb2fC+Vf4qgRDhuFxyFHslHeCBCJ9hoskhe/yU?= =?us-ascii?Q?ZUURwsauHvVd9w6ANskA09vgk7AqSOEzLNl5pov2A4xhevlqIzOgykceJ9mI?= =?us-ascii?Q?oGrBaunOyoKvsENx+O5ZC5NyF9IqSp1XO09X6YofLPQKF7fGG46jppM6aJXy?= =?us-ascii?Q?N1L+h1ECjhwX2ejK6HMHtRZJHhtLk/QIr565KbIXcQkV+pMajYSZFdTlowXs?= =?us-ascii?Q?CsuTudcRM1mVmMBoFpra2drj8/2LYy5EX26J8PV2R9e58GrQspvSrFlTRQzb?= =?us-ascii?Q?DfZpLgx5vkAjc2JvCfA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9afd7f68-f359-4b83-7276-08db5b6572ff X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2023 08:12:28.1946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i+7iFb0JtkSAbjwsjB4ZHd9mrmCisKlZ5XHuRP6ZX5xsDvts5at5P3ArdIxDGCCPaHYpa57t8ExN3XdQuAi09w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR18MB5503 X-Proofpoint-ORIG-GUID: lf3XhsUN3ion1wM1Pjkm_M0P91JvoSUq X-Proofpoint-GUID: lf3XhsUN3ion1wM1Pjkm_M0P91JvoSUq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-23_04,2023-05-22_03,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Mon, 22 May 2023 15:04:52 -0400 > Kamil Godzwon wrote: >=20 > > /home/vagrant/dpdk/build/include/rte_crypto_sym.h:1009:4: \ > > warning: Value stored to 'left' is never read [deadcode.DeadStores] > > left =3D 0; > > ^ ~ > > 1 warning generated. > > > > Compilator sees that the variable 'left' is never read after > > assignment a '0' value. To get rid of this warning message, use 'if' > > condition to verify the 'left' value before RTE_ASSERT. > > > > Signed-off-by: Kamil Godzwon > > --- > > v2: > > Changed commit message as the line was too long > > Removed braces > > --- > > lib/cryptodev/rte_crypto_sym.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_= sym.h > > index b43174dbec..dcef1a5049 100644 > > --- a/lib/cryptodev/rte_crypto_sym.h > > +++ b/lib/cryptodev/rte_crypto_sym.h > > @@ -1016,7 +1016,9 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf > *mb, uint32_t ofs, uint32_t len, > > left -=3D seglen; > > } > > > > - RTE_ASSERT(left =3D=3D 0); > > + if (left !=3D 0) > > + RTE_ASSERT(false); > > + > > return i; > > } > > >=20 > This could happen if the passed in length to this routine was larger than > the amount of data in the mbuf. Should the function check and return an e= rror? >=20 > Panic should only be reserved for seriously corrupted input (like invalid= mbuf). >=20 > Also, this is a big enough function that it really should not be inlined. This is a datapath API. RTE_ASSERT is normally not enabled in release build= . So, this assert is not doing any check for normal scenario. We normally avoid these type of error checks in the datapath. And while building in debug mode, we need these asserts to give a backtrace= also To debug the rootcause of the issue. I would suggest fixing the assert itself instead of adding a check. Current patch will affect performance. Agreed, that the function is big for being an inline function, but that is what all the datapath APIs are and we keep them inline to improve the performance.