From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF0EDA054A; Tue, 25 Oct 2022 17:01:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C3CB42C37; Tue, 25 Oct 2022 17:01:56 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id E41F742C0C for ; Tue, 25 Oct 2022 17:01:54 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29P95a3i030836; Tue, 25 Oct 2022 07:59:49 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kcg1mujpx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Oct 2022 07:59:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OXV9CCNhI4rPc/zNxKNqyBo4nHV4a4qI3v0uVEaaf/Ncf/nMq+K8/EHQ2cFEyMtUjckuSH0yC0WH9T6emv1c2LJMVjwhXtvTWPWwdXAflulQa4D0XjSsj73fJp9eC5EuJKjXtyEfH7iHueaA2HEUWBm608zWUMZtdaXTbkRWNMStOZNopTVdQ+shuhcLGMpGeBxBJkUyko6daQZeQHGy0Lh1QWAH1yaRfFsqKPoK5/5aVBoEiNiVVw/6uykmITRkqbjQba2lDKpW3IO7iMGZBd7q5SQSEQCyIqUaanWazMJQgHEabdx7jeKlVVDjxJb5tkFCr6+HKalUuen3UjJcgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MbDBQLrNPDi0orBTwI/b9bjAkizzgN1sty16EpiASmg=; b=leMUjvEmpT6qJhEtc51sR5FZ/4DGqlSntep2zT2DVWUMinLWkPfFFbn2RT02E1l9YSODK2uc+EQwFwL0qFiKMqKUDw1NaXeCn0IPjnVDMIrLhq+nAqOqnguj9tehtCCNQ8zNdhKhC51OLvCuIrYQXAzA/fpiXz48LRUKl8dWWTJ1cUotO0IL/joRPDGgqcoTqDKTB+Sp8/vRoQ8voSzFLEmUpCpwkxDfUM7NXZQFqXKuSDBp4jBKD8p+yDiCdIBxpRcG6GWG+QYm+wWKFRWjit/RQ7Pj6pZnxcz0Ifs0UFsBQ8nLK8weypVKrHNJ+iWyakmIDIedis6B5Scx5P5/Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MbDBQLrNPDi0orBTwI/b9bjAkizzgN1sty16EpiASmg=; b=RPQ65Q/91e+BBWScdWRxGgPCufrN0tMdeanajD6Hni8m82/qxKjQOR5Y+ZIwwkIMUYMpwNIH+QSeu/+IF3HL/zxdnSI8rx/WgafUF9JG0jxycP+h/pyU9hfZa9x76TyE8IJxs6a3R6IF/i3pu9XI7TCAsbEf7Xzc7BHWJZfOpK0= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SA1PR18MB4598.namprd18.prod.outlook.com (2603:10b6:806:1d1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 14:59:45 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::8c4f:e24e:332d:dc6d%3]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 14:59:45 +0000 From: Akhil Goyal To: Zhangfei Gao , Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella , "thomas@monjalon.net" CC: "dev@dpdk.org" , "acc@openeuler.org" Subject: RE: [EXT] [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver Thread-Topic: [EXT] [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver Thread-Index: AQHY56/cCke26anRp0WiihP2QrQt/a4fNA+w Date: Tue, 25 Oct 2022 14:59:45 +0000 Message-ID: References: <20221024134409.1896776-1-zhangfei.gao@linaro.org> In-Reply-To: <20221024134409.1896776-1-zhangfei.gao@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SA1PR18MB4598:EE_ x-ms-office365-filtering-correlation-id: 6fe0e936-99a9-44d6-a268-08dab6998e20 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oc9B1yiYVpceg8NAJoKL7iREr5jQZrccbXgK8OrmWcH0sdmWDt7tWyFEWLk/gokdytgrpjfwYdCYF9Xq3RXDQiGxI/ipfjmeS1okCRHcNUGIR7YMumitHjGHxtpdKZUNwmvzZfVx2LHcPVdg3YxOvC16QcAAi2mcREOy3kQ+9eUySpKivw/8weJEEHH+Y9B/EasFXJ/9YGahMAUkduDLzp+AROJJi4eerAcXWnv2JoCv/XB84s/46g79BeRoCjhAaV5XVxt7yQ/k/yxpaODCgCisGSTBcDMFSeWeGbbvm8A1Nd3z1FrHs6DfLp4fg2NQOZV0k5szRbVbLIxnXyibwOl27GKO/JsrZGdA2TW102gILo1wIvZCY7SAIWOyvLsM0vGNnqsSvogX3rLEm5ArxFEkzPwOhtyRoCbHtCv9KcT76a8fKwTg4jXOTArXLO2pxqKpUXveah7iBx3e97u2HgTcRzo6wV9GP3pQWtVT89j7zv8OeoSOkq6dcT46XKgnq0PpykecH5TMD+IaWg2f13Dt7XVg3obhG2dITVAPU5zyqn8SNJlWSFeqBmG+t579R4o3MHuUuf9pJl852Lbns3gB3e/5N0rdMIPXm1vgMGgT7WB5FYdtvMahX3emnZjiC/U9n/HFwqacCw7dvgu/jDT6F4j/u0XcasKyTyvGoIRILeRyFbpkNhSjOxgTRDV5SeXk2PJsQeiCjTLb0z8aaMl3Jl1gi89rsWxg0b3nRxeKty0u0P6NGAjpIu1MWxjT7khdPdV1yaHcbrwrinWFCD6LqtsyKSA4H2C6duSVY6g= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(451199015)(83380400001)(186003)(122000001)(26005)(2906002)(38100700002)(5660300002)(52536014)(41300700001)(55236004)(9686003)(6506007)(7696005)(110136005)(38070700005)(33656002)(86362001)(66946007)(55016003)(54906003)(8936002)(66446008)(76116006)(316002)(4326008)(71200400001)(66556008)(64756008)(8676002)(478600001)(66476007)(966005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aA2WBK7ChvRmrViAO/WQgQuwehtOSr8MtNftPUz5aRcArmmpF+vrH5OivgkJ?= =?us-ascii?Q?uF+0pWublT9igKbDFHZ+9S3rCD+OfKofAfq0vBreuLCVf2/1oayWpjePfs02?= =?us-ascii?Q?mR92cKTjC0jHEOywV+paUr+epKQKw6UFVsALeQCNDesiR/15cSN7mlYGCUkQ?= =?us-ascii?Q?Y7rqaMM6dbRffobDyFZTN0kEm0U/liSs8i8gcw98Vp6QqLqWXIJYQMObbgBy?= =?us-ascii?Q?0iB6M8VekOLrQhIkqLiAf/DiauE6iFHnkG82v0rwxJ/3SbMwO/yIhcQ2zmPb?= =?us-ascii?Q?3dY+1i4YJnuJqtRMBWs3bVSB1e9HxNXUxSz07QD8ySPZurj9utgbH6ykIHEd?= =?us-ascii?Q?dZzv+qahmj8yln+/h3KrpJHM5WmalWw5T1MiIVslJJJ+uYAI3DBzVf93jeLJ?= =?us-ascii?Q?rwS3u0nIHoPYSPvkuq40fkoa6aQUYR4ovNhYrsmkeSgfsrYgu2WwkJkq/PhS?= =?us-ascii?Q?OICX2HDVwv7pkq6TI1fwFfR05fSXq0iF2Zjt1RyAulObwCqhkbpprYNDH6nu?= =?us-ascii?Q?Og4tQPhXvYNECDKtxgUsDHEgHdVp5CiM1I+tYa9TWkLoR+mY6dFyHZewcj4I?= =?us-ascii?Q?lFYj44S5BRbcSV043hpOETCuwZqQsW25HXPMHrWtgL7Gj1Lj0Wtu5GjRogZc?= =?us-ascii?Q?eWka7JLM6PK3qKBXMvOUy5+WysZ6IURbJSQ4p/lCTSlgo90Tzv+XZuKcHAIZ?= =?us-ascii?Q?g1d/W3d2c/E9ekdSdYaPjU4PULGL+X7dAWul4D25xwAEQa/ExcZDkU6a1Zcm?= =?us-ascii?Q?tpbBHLmAcE1OLJjCEyCVt5bJW7aMTKxTFrZKFJRxBGAMTVK5VoEPDsx9dyJr?= =?us-ascii?Q?KcerTNLLn++kF1VpFTI6G+VOM9LB8TRfDASm+D5TIPNgyFO6ikjQ7PAv2pSs?= =?us-ascii?Q?3GGCMb0+SX9y58LsBJAoOoI2DxsarQoiCvSIJwArTo6U2grBN2dz4gd6yAP8?= =?us-ascii?Q?XMbc1E8B2tzeGEUlHXEjj8QccbsDnOX9JvFIt47+YcyxBj1qy7It9iQ91j53?= =?us-ascii?Q?PFpcjlMVrmObSZ5+wImyWstCmaw1BueyMd0L5senipseIHgWX4xDJyF9x/YB?= =?us-ascii?Q?6rMRp4atyJAwAOJsWA/RH77aRvH5YA4TA//RckRSCvbjdbWqdwsC13cFK9Y2?= =?us-ascii?Q?9tyc00gl6p2BFYQytsCBqfheeK0hqB6BgpfrBVMW0oKv8eBVtW96W5DZyury?= =?us-ascii?Q?GqcnVFkMKhmu9GUuFWf7IOsgkCHC1oEpFynSfBgRIe4jRMDlWTjRblJbQJbp?= =?us-ascii?Q?vPAcYiVC7URx8mncU59d8ZzVOxRhXLp/7qMx4kUwJtrOkUPi9kGTNQ9Pbwi7?= =?us-ascii?Q?p6g++phPJrhIkyhm2C+9Ekr6st/IvJkYU8iMj07r5DZpcOcD7TOM5rKKYgvu?= =?us-ascii?Q?aK6Ve0KDYqew7dq34419ce5+Chy3vrRLmnNl9XuH8KwcugwWkgeRoKup+KWL?= =?us-ascii?Q?Rnv0g0XmBF5sopzOly6d3EoGLcKkERSZf7Yi4KoO2/0eSBiVJXCuvLsjr4cs?= =?us-ascii?Q?7EAgZIkSpNu4Hwl6kKGLlnpBt472wsF4UxUZozO9XDH53qcAfX+8Z6O/xNSt?= =?us-ascii?Q?lJSy2Cz/Cx8yntdlQ52hKZRKNWaFxNE2arRCCNAV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fe0e936-99a9-44d6-a268-08dab6998e20 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 14:59:45.6788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: urXODBdh40i+cmwgKcJ8Ked54Qb16bhhAUXi0SJjJOthYNrWcKR1TC+Brz0CMAPIWxFRrBxsd+N8K/Me3FxiTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4598 X-Proofpoint-ORIG-GUID: ujfA6KuH3sh_wMntIeDLd77q3lkRa26M X-Proofpoint-GUID: ujfA6KuH3sh_wMntIeDLd77q3lkRa26M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-25_08,2022-10-25_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. >=20 > UADK is a framework for user applications to access hardware accelerators= . > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > the same page table between IOMMU and MMU. > Thereby user application can directly use virtual address for device dma, > which enhances the performance as well as easy usability. >=20 > [1] https://github.com/Linaro/uadk=20 >=20 > Test: > sudo dpdk-test --vdev=3Dcrypto_uadk (--log-level=3D6) > RTE>>cryptodev_uadk_autotest > RTE>>quit >=20 > resend: > fix uadk lib, still use There is nothing called as resend in DPDK ML. Please simply increment version number each time you send the set. Also add release notes update in the patch where the driver implementation is complete. Compilation issues are all done now. Have sent some other comments on the patches. Please send the v6 ASAP. We need to close RC2 in a couple of days. >=20 > Update in v5 > Patch 1 fix the build issue when uadk is installed to specific folder > And update doc accordingly >=20 > Update in v4: > Akril suggest dpdk use pkg-config, So > Enable uadk support x86 local build, and support pkg-config. > Use pkg-config feature for the uadk crypto pmd. > Add build uadk library steps in doc > Test on both x86 and arm. > x86 can build and install, but can not test since no device. >=20 > Resend v3: > Rebase on next/for-main, which just merged the series > "cryptodev: rework session framework". >=20 > Update in v3: > Split patches according to Akhil's suggestions > Please split the patches as below. > 1. introduce driver - create files with meson.build and with probe/remove > and device ops defined but not implemented. > You do not need to write empty functions. > Add basic documentation also which defines what the driver is. > You can explain the build dependency here. > 2. define queue structs and setup/remove APIs > 3. Add data path > 4. implement cipher op. Add capabilities and documentation of what is > supported in each of the patches. Add feature flags etc. > 5. implement auth, add capabilities and documentation > 6. test app changes. >=20 > Update in v2: > Change uadk_supported_platform to uadk_crypto_version, which matches > better > than platform. > enum uadk_crypto_version { > UADK_CRYPTO_V2, > UADK_CRYPTO_V3, > }; >=20 > Update in v1, compared with rfc >=20 > Suggested from Akhil Goyal > Only consider crypto PMD first > Split patch into small (individually compiled) patches. > Update MAINTAINERS and doc/guides/cryptodevs/features/uadk.ini >=20 > Zhangfei Gao (6): > crypto/uadk: introduce uadk crypto driver > crypto/uadk: support basic operations > crypto/uadk: support enqueue/dequeue operations > crypto/uadk: support cipher algorithms > crypto/uadk: support auth algorithms > test/crypto: add cryptodev_uadk_autotest >=20 > MAINTAINERS | 6 + > app/test/test_cryptodev.c | 7 + > app/test/test_cryptodev.h | 1 + > doc/guides/cryptodevs/features/uadk.ini | 55 ++ > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/cryptodevs/uadk.rst | 94 ++ > drivers/crypto/meson.build | 1 + > drivers/crypto/uadk/meson.build | 30 + > drivers/crypto/uadk/uadk_crypto_pmd.c | 1141 +++++++++++++++++++++++ > drivers/crypto/uadk/version.map | 3 + > 10 files changed, 1339 insertions(+) > create mode 100644 doc/guides/cryptodevs/features/uadk.ini > create mode 100644 doc/guides/cryptodevs/uadk.rst > create mode 100644 drivers/crypto/uadk/meson.build > create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c > create mode 100644 drivers/crypto/uadk/version.map >=20 > -- > 2.38.1