DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Fan Zhang <fanzhang.oss@gmail.com>,
	Ashish Gupta <ashishg@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
	David Marchand <david.marchand@redhat.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Subject: RE: [EXTERNAL] [PATCH v3 0/2] uadk: realize async mode
Date: Mon, 30 Jun 2025 10:15:27 +0000	[thread overview]
Message-ID: <CO6PR18MB448406CE61F820DE93117452D846A@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CABQgh9HRhMK02y8eCNMhmWYq0MqUbZxNgp=bCHzUmwYU8jUjZQ@mail.gmail.com>

> Hi, Akhil
> 
> On Mon, 30 Jun 2025 at 17:04, Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > > > > make[2]: Entering directory '/home/gakhil/up/uadk'
> > > > > depbase=`echo wd_alg.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > > > > /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
> -
> > > Wall -Werror -fno-strict-aliasing -I./include -fPIC -fPIE -pie -fstack-protector-
> > > strong -D_FORTIFY_SOURCE=2 -O2 -ftrapv -Wl,-z,relro,-z,now -Wl,-s  -
> > > DUADK_VERSION_NUMBER="\"UADK version: 2.9.0\"" -
> > > DUADK_RELEASED_TIME="\"Released June 6, 2025\""  -g -O2 -MT wd_alg.lo
> -
> > > MD -MP -MF $depbase.Tpo -c -o wd_alg.lo wd_alg.c &&\
> > > > > mv -f $depbase.Tpo $depbase.Plo
> > > > > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> aliasing
> > > -I./include -fPIC -fstack-protector-strong -D_FORTIFY_SOURCE=2 -O2 -ftrapv
> -
> > > Wl,-z,relro,-z,now -Wl,-s "-DUADK_VERSION_NUMBER=\"UADK version:
> 2.9.0\""
> > > "-DUADK_RELEASED_TIME=\"Released June 6, 2025\"" -g -O2 -MT wd_alg.lo
> -
> > > MD -MP -MF .deps/wd_alg.Tpo -c wd_alg.c  -fPIC -DPIC -o .libs/wd_alg.o
> > > > > wd_alg.c: In function ‘wd_check_ce_support’:
> > > > > wd_alg.c:106:44: error: ‘HWCAP_CE_SM3’ undeclared (first use in this
> > > function)
> > > > >   106 |  if (!strcmp("sm3", alg_name) && (hwcaps & HWCAP_CE_SM3))
> > > > >       |                                            ^~~~~~~~~~~~
> > > > > wd_alg.c:106:44: note: each undeclared identifier is reported only once
> for
> > > each function it appears in
> > > > > wd_alg.c:115:46: error: ‘HWCAP_CE_SM4’ undeclared (first use in this
> > > function)
> > > > >   115 |  if (!strcmp("(sm4)", alg_tail) && (hwcaps & HWCAP_CE_SM4))
> > > > >       |                                              ^~~~~~~~~~~~
> > > > > wd_alg.c: In function ‘wd_check_sve_support’:
> > > > > wd_alg.c:128:15: error: ‘HWCAP_SVE’ undeclared (first use in this
> function)
> > > > >   128 |  if (hwcaps & HWCAP_SVE)
> > > > >       |               ^~~~~~~~~
> > > > > make[2]: *** [Makefile:1055: wd_alg.lo] Error 1
> > >
> > > This is solved by https://github.com/Linaro/uadk/pull/679
> > > Will be merged next week.
> >
> > So are you going to update this patchset with newer version of uadk?
> 
> How bout just adding bug fix patches on master branch.
> or have to ensure the dependent uadk release version build no problem
> on both x86 and Arm?

How is the DPDK user supposed to build your driver without proper tag of uadk?
May be apply a hot fix tag(2.9.1 or something) on UADK and mention that in your driver doc.
You need to ensure when someone picks a particular DPDK release,
your driver can be built with the version mentioned in your PMD doc. 


> 
> It's our mistake that we ignored x86 platform.


      reply	other threads:[~2025-06-30 10:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20  3:35 Zhangfei Gao
2025-06-20  3:35 ` [PATCH v3 1/2] compress/uadk: use async mode to replace sync mode Zhangfei Gao
2025-06-20  3:35 ` [PATCH v3 2/2] crypto/uadk: " Zhangfei Gao
2025-06-24 13:57   ` [EXTERNAL] " Akhil Goyal
2025-06-25 12:14 ` [EXTERNAL] [PATCH v3 0/2] uadk: realize async mode Akhil Goyal
2025-06-27 15:41   ` Zhangfei Gao
2025-06-28 12:49     ` Zhangfei Gao
2025-06-30  9:04       ` Akhil Goyal
2025-06-30 10:07         ` Zhangfei Gao
2025-06-30 10:15           ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB448406CE61F820DE93117452D846A@CO6PR18MB4484.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=ashishg@marvell.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fanzhang.oss@gmail.com \
    --cc=thomas@monjalon.net \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).