DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] compress/octeontx: fix null pointer dereference
@ 2022-01-25 14:33 Weiguo Li
  2022-02-08 21:38 ` [EXT] " Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Weiguo Li @ 2022-01-25 14:33 UTC (permalink / raw)
  To: ashish.gupta; +Cc: dev

Check for memory allocation failure is added to avoid null
pointer dereference.

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/compress/octeontx/otx_zip_pmd.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c
index dd62285b86..1b6178f661 100644
--- a/drivers/compress/octeontx/otx_zip_pmd.c
+++ b/drivers/compress/octeontx/otx_zip_pmd.c
@@ -392,6 +392,8 @@ zip_pmd_qp_setup(struct rte_compressdev *dev, uint16_t qp_id,
 	}
 
 	name =  rte_malloc(NULL, RTE_COMPRESSDEV_NAME_MAX_LEN, 0);
+	if (name == NULL)
+		return (-ENOMEM);
 	snprintf(name, RTE_COMPRESSDEV_NAME_MAX_LEN,
 		 "zip_pmd_%u_qp_%u",
 		 dev->data->dev_id, qp_id);
@@ -399,8 +401,10 @@ zip_pmd_qp_setup(struct rte_compressdev *dev, uint16_t qp_id,
 	/* Allocate the queue pair data structure. */
 	qp = rte_zmalloc_socket(name, sizeof(*qp),
 				RTE_CACHE_LINE_SIZE, socket_id);
-	if (qp == NULL)
+	if (qp == NULL) {
+		rte_free(name);
 		return (-ENOMEM);
+	}
 
 	qp->name = name;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [EXT] [PATCH] compress/octeontx: fix null pointer dereference
  2022-01-25 14:33 [PATCH] compress/octeontx: fix null pointer dereference Weiguo Li
@ 2022-02-08 21:38 ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2022-02-08 21:38 UTC (permalink / raw)
  To: Weiguo Li, Ashish Gupta; +Cc: dev, stable

> Check for memory allocation failure is added to avoid null
> pointer dereference.
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied to dpdk-next-crypto
Added Fixes tag

Cc: stable@dpdk.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-08 21:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 14:33 [PATCH] compress/octeontx: fix null pointer dereference Weiguo Li
2022-02-08 21:38 ` [EXT] " Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).