From: Akhil Goyal <gakhil@marvell.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>,
Declan Doherty <declan.doherty@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Ashish Gupta <ashishg@marvell.com>, Ray Kinsella <mdr@ashroe.eu>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH 0/3] Add uadk compression and crypto PMD
Date: Sun, 28 Aug 2022 13:02:56 +0000 [thread overview]
Message-ID: <CO6PR18MB44840CCFC078533281CE1D86D8779@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20220620123544.3168-1-zhangfei.gao@linaro.org>
> UADK compression PMD provides poll mode compression & decompression
> driver
> UADK crypto PMD provides poll mode driver
> All cryptography operations are using UADK crypto API.
> All compression operations are using UADK compress API.
>
> Hardware accelerators using UADK are supposed to be supported.
> Currently supported hardware platforms:
> HiSilicon Kunpeng920 and Kunpeng930
>
> Test:
> sudo dpdk-test --vdev=compress_uadk
> sudo dpdk-test --vdev=crypto_uadk
>
> v1:
> Target to DPDK 22.11
> Rebased on http://git.dpdk.org/next/dpdk-next-crypto/
>
> Suggested from Akhil Goyal <gakhil@marvell.com>
> > Current release cycle is DPDK-22.07 for which this patchset is late.
> > As we had the V1 deadline last month.
> > This patchset can go for next release cycle which is 22.11.
>
> Zhangfei Gao (3):
> compress/uadk: add uadk compression PMD
> test/crypto: add cryptodev_uadk_autotest
> crypto/uadk: add uadk crypto PMD
>
> app/test/test_cryptodev.c | 7 +
> app/test/test_cryptodev.h | 1 +
> doc/guides/compressdevs/index.rst | 1 +
> doc/guides/compressdevs/uadk.rst | 60 ++
> doc/guides/cryptodevs/index.rst | 1 +
> doc/guides/cryptodevs/uadk.rst | 70 ++
> drivers/compress/meson.build | 1 +
> drivers/compress/uadk/meson.build | 28 +
> drivers/compress/uadk/uadk_compress_pmd.c | 489 +++++++++
> drivers/compress/uadk/version.map | 3 +
> drivers/crypto/meson.build | 1 +
> drivers/crypto/uadk/meson.build | 28 +
> drivers/crypto/uadk/uadk_crypto_pmd.c | 1137 +++++++++++++++++++++
> drivers/crypto/uadk/version.map | 3 +
> 14 files changed, 1830 insertions(+)
> create mode 100644 doc/guides/compressdevs/uadk.rst
> create mode 100644 doc/guides/cryptodevs/uadk.rst
> create mode 100644 drivers/compress/uadk/meson.build
> create mode 100644 drivers/compress/uadk/uadk_compress_pmd.c
> create mode 100644 drivers/compress/uadk/version.map
> create mode 100644 drivers/crypto/uadk/meson.build
> create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c
> create mode 100644 drivers/crypto/uadk/version.map
>
Please split the series into two - crypto pmd and compression pmd.
And split each of the PMD into logical small (individually compiled) patches.
Update MAINTAINERS file
Update documentation in doc/guides/cryptodevs/features/uadk.ini
and doc/guides/compressdevs/features/uadk.ini
Also UADK does not look to be a PMD name. It is some development kit
Outside of DPDK. Can you rename it to something else?
Is there some dependency to build it using external libraries etc?
Can you explain what exactly is UADK?
Regards,
Akhil
next prev parent reply other threads:[~2022-08-28 13:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 12:35 Zhangfei Gao
2022-06-20 12:35 ` [PATCH 1/3] compress/uadk: add uadk compression PMD Zhangfei Gao
2022-06-20 12:35 ` [PATCH 2/3] test/crypto: add cryptodev_uadk_autotest Zhangfei Gao
2022-06-20 12:35 ` [PATCH 3/3] crypto/uadk: add uadk crypto PMD Zhangfei Gao
2022-08-28 13:02 ` Akhil Goyal [this message]
2022-08-29 6:52 ` [EXT] [PATCH 0/3] Add uadk compression and " Zhangfei Gao
2022-08-29 7:11 ` Akhil Goyal
2022-08-29 8:21 ` Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44840CCFC078533281CE1D86D8779@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=ashishg@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=roy.fan.zhang@intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).