From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 429A2A0545; Sun, 28 Aug 2022 15:05:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE70640DF7; Sun, 28 Aug 2022 15:05:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B5A9140696 for ; Sun, 28 Aug 2022 15:05:09 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27SBeu6v024748; Sun, 28 Aug 2022 06:03:01 -0700 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2170.outbound.protection.outlook.com [104.47.73.170]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3j7gmququ5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 28 Aug 2022 06:03:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HR4IpBNuK2IooYdDDGovZGUTIyi/PXKVq60/XeoxRfCGPGXhXg2zNU3lHRcSCC8M96BWOxZ3tLBCI9tSxrmhfdVjvJe3VqjLqo9P6ZXpAvWAqBU+m4Ll88FSeuJxcJq+nxgVvuiUiN+f6QNfkt4LkSWyvFsUaSDYatGqXcYCfRWxWHP+XII7PBHW3skiSVuUIePl8GP+b/wG1rLcGdpiHCm4Xf4FFe8qTbplquGq7vjy5Amn4pKugmVZ4VTh08RVl+Cn1v5CGbI1L6F1/u/GZBkfcDSh02K3XEz58fr9aU2dDAUV+vC+SQdt45nKHT4QgjNy8BbbA0tXbPt09Qcicg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EsXVRhFO2pAJF/HM7am/Z5uxFw8M2Gr3FxY4KsoSGxQ=; b=SeWSDM3Hqsft/TbbznAAH0vYYQMWXY5M05+W8mhGySIy2/BrrHIZBWku8YSE4R3JhZ9aocXWQB0aDIyBJIzegWCmNsOL8UZTWVFgzwJDJU996C0I+3d5FrxHRbUR0JKHmWzMRgwOet4HkEX4li1enmRHA5IQ2HQRONd/bGd7bkh4yLZZLSUVcY+qmQCcBCGSq+Z99t73lKx5+598TtlExaxxXHmAcXgul6Xr5UtrOmtnqoJqB7WsWihiEPTO000ze81rWm/SdcnCMthT102NLyZPV7WLcBAofmq5SMms5mrkjoSMyFn0Po4CVJqavC7qDQqGoK6wFCZJ+u3u15mc7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EsXVRhFO2pAJF/HM7am/Z5uxFw8M2Gr3FxY4KsoSGxQ=; b=YecQnZycm+TPNTNyRTuL0UMrotez7m3CjDh9xuTUiAf+D3p8ABmZ7fKixtcP7mBI1Z8SgxYn6d1uNTLIxgwACy+oKILPetYkZ1/Xehuauro3C8QzR1WyZMgO2CE4iwp7LiaL6fifBT9ndZVEHYuqd7Pks8fcsHIn3lTFfCVjcvA= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MW3PR18MB3691.namprd18.prod.outlook.com (2603:10b6:303:5a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Sun, 28 Aug 2022 13:02:56 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::b0e9:25a1:1aea:4382]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::b0e9:25a1:1aea:4382%8]) with mapi id 15.20.5566.021; Sun, 28 Aug 2022 13:02:56 +0000 From: Akhil Goyal To: Zhangfei Gao , Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH 0/3] Add uadk compression and crypto PMD Thread-Topic: [EXT] [PATCH 0/3] Add uadk compression and crypto PMD Thread-Index: AQHYhKJJ35TJUFVL2UKhFbex9BF4563EsOkQ Date: Sun, 28 Aug 2022 13:02:56 +0000 Message-ID: References: <20220620123544.3168-1-zhangfei.gao@linaro.org> In-Reply-To: <20220620123544.3168-1-zhangfei.gao@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed3d018e-0771-4ff1-f847-08da88f5a075 x-ms-traffictypediagnostic: MW3PR18MB3691:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QZ2uzDXssSrJP0YSkpJ398uNkwWugSYL2kOHupo5dSurfh9/NL2BnYTA6y+IxFG+c2zp20vyZaklAu0kL8nmspWGNKe4KJvPrhvNPKMQ+vElHMWauoa8UrpFUgkOHG8SffG1N91EFaxVZezPc1ifFJ8i4YDizfMhQqEUI/fyQLcNhfPsaM6NTKTraDybfxiQofJWLQRrheyedSFcuvZe/GD5l4tN3kdZvCqFQuQZ8Cctia23AzhMVUvrFznjJ6EozCqk/wB6AMdKdRotSpX92kDHnDZoD9kAqnjc4QK2IHfKmk0BU0BNhe/sEUZCVBQ1rl2+koec0DmQglydzbxtLSrobVd+8op/ASx3Xl2klZJh3d5JaiHE/M2W69qekIJdSdDT9Ux8O1CnYvi29h+SqAeYdC0yhZq6xhz4DwyF/P7mTbc90R2jPJlcCS6GhIL9zdVFwL/djfye/wdzCPkThX0y+xNdLSS6kTMmktcapaQ64BT7wjZ+YjLcVF6qLTmQcP7bola6RXQZcL4I7IYeTQM2W6/UdLXmwt8V0GVlKLHz6NEutZe6/b1KP9EFeO3MJHt4f5wt5RqcfewI89hHP/njCYE1ZxWSHgZLNNhuvgvwXi0WlCHkmuzGGy3rNS3JhxXVmCoHhnuuKApTHNyPIKIVkr2ebtRYa8Orj/0a6DMTYlkz2pbrZ8lYz4vJ3Lgxg1YtdeHZFLjhSXFymArM00Yfu8wefLowlgZ65057oFJHFGJahI84x3kPx11A7zMVr3nJ0NQZf516vLFYk6Vn7F0V/LWUW+DIvds1jWUPNa0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(366004)(39850400004)(7696005)(122000001)(6506007)(38100700002)(55236004)(2906002)(55016003)(83380400001)(186003)(33656002)(26005)(9686003)(8676002)(86362001)(4326008)(64756008)(66476007)(66556008)(66946007)(76116006)(66446008)(316002)(966005)(71200400001)(110136005)(38070700005)(52536014)(41300700001)(5660300002)(8936002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?omt8HDGVNYMsOLHKEGh39HSOJa7APae9PiIN0HHgqrRo9f21/dirK3B3EQe5?= =?us-ascii?Q?EETTGsgZmca3z+pT6GWgH19+lFiuIw6+s9k5wY/Pb842V/Ja645NiY0Ojflx?= =?us-ascii?Q?2hcsEzMFXD314YmxODtOocjJgxKaukWOB6g10DdQELVZB+91gwh6Lu+Pfyhh?= =?us-ascii?Q?XXcvXN555KrmUKYoQ9Cd1ihhL+IrXpteqaEOq5TX7oRowZdAZgfstjB61HX4?= =?us-ascii?Q?sPCKtk7bSBMaQsJFhgRxEKfAyBxgnEzEeypN1EwLOhgeN68BXN3RpHejSKr7?= =?us-ascii?Q?uH+I4NozdJScysh70xmw9vCIFf1cL+1yHXN4HSlrQN5jhQRtGlqQ/tu0lLoC?= =?us-ascii?Q?3yNfIxh0n8A8sM3516jhS6W3LgkA+XC3hRZTif4MhZRDcCTwaPM/0/tVOrZr?= =?us-ascii?Q?V2aGr9F5ACFJ4UPUEVPkakWRHrzg3z4CWf/YmpnDxExPFYOksOCdiqKLNYyO?= =?us-ascii?Q?cPm5cqdIW1Z4mD3+niDXXQ+aosz5WbMJnGEmDCNTH1wrtip127+4/JLVKVkc?= =?us-ascii?Q?VdP5u41V/SAxAKJQAJGsNm9JKU2T1wM4kunHotN48ARA00gXsT6ezCYNXwG9?= =?us-ascii?Q?u2deq1Ra/5I6KXXY79clATcecNODcKpc1EB+n47LGlY6iUF+7wA1WL3KWGls?= =?us-ascii?Q?WnBHMO8xoeAVtFH/dCYtenSWO/s4KlXXlMlVawbksTczwbRT0OnvxhXOY2dJ?= =?us-ascii?Q?+LiQQo/b/+T0D2IQeWmHjMD2RFWaoia/HOA4EKz/8y5pRW5jcPsKYiV/qAic?= =?us-ascii?Q?hlcn/9BMMISmzM6MWQftp1fJkrMogRsqcxIyEQ5dZfVGAfbdgrmURc+cJqJx?= =?us-ascii?Q?52lxXuwq88+lYUUrMHR/fWrZwjM8M+oHd2Mn9dxPUSZkBntscGLSUw6y4oc/?= =?us-ascii?Q?1fh2miH3IokKiXj0T6zX12HR3pw2vVeKTLry2i1utZLAEf/gxgoeAgFVr9rF?= =?us-ascii?Q?/hrvwOQIZgV51SWbILi7vmNeaHAffQxMXR655NSbtyDLKpX1buRrxSbE7V32?= =?us-ascii?Q?0v26VLA7DLfod3Zg3rV5KTfxKtY0d5WDY3dVTonzNiZ9PJzmp1wnitOUm5xu?= =?us-ascii?Q?NZePppHiW7jSgqP3ykeTuJB2ADiOK2XZ3S0SV2EY++ovspR5xrSb2FQcTzEK?= =?us-ascii?Q?9nCj1NNoVlvSwgPpeZFCdYt+E5dlM7R2m6KGlEM804cP28kScKWAIqu0zPTM?= =?us-ascii?Q?LHbZ8/ZdYZT10B+Y7BSR793fmwlrFcfCSGo3xpZpZb09wv4L6nnigMqmbL6I?= =?us-ascii?Q?ahWPBR7ZgQnjTxbs2YPbeezyvIk2tXEFKdD1FvDw4rF1JiLOVoKN32FlS2aa?= =?us-ascii?Q?BZUdJDsbij51cX8/hLh1Mj8GvHNiqfN7pj2pVyoeV/AbaCa+stV7yR+W49UD?= =?us-ascii?Q?Nin7kEMqo34t6Vg7fcHDYcc2VgKeMMutfGjJbBXl5wWecm4OJ3T+qmHxkc9S?= =?us-ascii?Q?7y77m+sZdEH0uVCkAcni8yuSPF1GBfIWTtXuhLSWLdDYJpwQ8YgeI/Y/KRvI?= =?us-ascii?Q?F64Ni1ndwcyXxbrWcPSQPWYc5QH9M3ZGnhSAHGnN5EF9uvd6XEg6WhwB501j?= =?us-ascii?Q?itxKnEEgAlXUaPQxz/P3YeFKR/0QDw0x0fQzpmUD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed3d018e-0771-4ff1-f847-08da88f5a075 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2022 13:02:56.6328 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T3nA5AYZZPUJPsSePtx4z0N+valPxE4oUDeZqG5EQxAHKyHhJ8sqyUvpuDQ/P5FT9lJcl3gtdVinrVEqY99EkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3691 X-Proofpoint-GUID: 9DL-NTiLfhpqxw-NhjHgY5amHiNq2Fcf X-Proofpoint-ORIG-GUID: 9DL-NTiLfhpqxw-NhjHgY5amHiNq2Fcf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-28_08,2022-08-25_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > UADK compression PMD provides poll mode compression & decompression > driver > UADK crypto PMD provides poll mode driver > All cryptography operations are using UADK crypto API. > All compression operations are using UADK compress API. >=20 > Hardware accelerators using UADK are supposed to be supported. > Currently supported hardware platforms: > HiSilicon Kunpeng920 and Kunpeng930 >=20 > Test: > sudo dpdk-test --vdev=3Dcompress_uadk > sudo dpdk-test --vdev=3Dcrypto_uadk >=20 > v1: > Target to DPDK 22.11 > Rebased on http://git.dpdk.org/next/dpdk-next-crypto/ >=20 > Suggested from Akhil Goyal > > Current release cycle is DPDK-22.07 for which this patchset is late. > > As we had the V1 deadline last month. > > This patchset can go for next release cycle which is 22.11. >=20 > Zhangfei Gao (3): > compress/uadk: add uadk compression PMD > test/crypto: add cryptodev_uadk_autotest > crypto/uadk: add uadk crypto PMD >=20 > app/test/test_cryptodev.c | 7 + > app/test/test_cryptodev.h | 1 + > doc/guides/compressdevs/index.rst | 1 + > doc/guides/compressdevs/uadk.rst | 60 ++ > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/cryptodevs/uadk.rst | 70 ++ > drivers/compress/meson.build | 1 + > drivers/compress/uadk/meson.build | 28 + > drivers/compress/uadk/uadk_compress_pmd.c | 489 +++++++++ > drivers/compress/uadk/version.map | 3 + > drivers/crypto/meson.build | 1 + > drivers/crypto/uadk/meson.build | 28 + > drivers/crypto/uadk/uadk_crypto_pmd.c | 1137 +++++++++++++++++++++ > drivers/crypto/uadk/version.map | 3 + > 14 files changed, 1830 insertions(+) > create mode 100644 doc/guides/compressdevs/uadk.rst > create mode 100644 doc/guides/cryptodevs/uadk.rst > create mode 100644 drivers/compress/uadk/meson.build > create mode 100644 drivers/compress/uadk/uadk_compress_pmd.c > create mode 100644 drivers/compress/uadk/version.map > create mode 100644 drivers/crypto/uadk/meson.build > create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c > create mode 100644 drivers/crypto/uadk/version.map >=20 Please split the series into two - crypto pmd and compression pmd. And split each of the PMD into logical small (individually compiled) patche= s. Update MAINTAINERS file Update documentation in doc/guides/cryptodevs/features/uadk.ini and doc/guides/compressdevs/features/uadk.ini Also UADK does not look to be a PMD name. It is some development kit Outside of DPDK. Can you rename it to something else? Is there some dependency to build it using external libraries etc?=20 Can you explain what exactly is UADK? Regards, Akhil