* [PATCH 1/1] test/bbdev: use helper function to set IOVA addr
@ 2022-11-01 9:53 Srikanth Yalavarthi
2022-11-03 6:31 ` Jerin Jacob
0 siblings, 1 reply; 5+ messages in thread
From: Srikanth Yalavarthi @ 2022-11-01 9:53 UTC (permalink / raw)
To: Nicolas Chautru, Maxime Coquelin; +Cc: dev, Srikanth Yalavarthi
Use helper function rte_mbuf_iova_set to set IOVA address
to fix compilation failures.
Below error was observed:
dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
‘struct rte_mbuf’ has no member named ‘buf_iova’
1145 | m_head->buf_iova = rte_malloc_virt2iova(data);
| ^~
Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
app/test-bbdev/test_bbdev_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 8cf4359a2c..b285d3f3a7 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs,
"rte malloc failed with %u bytes",
seg->length + 1024);
m_head->buf_addr = data;
- m_head->buf_iova = rte_malloc_virt2iova(data);
+ rte_mbuf_iova_set(m_head, rte_malloc_virt2iova(data));
m_head->data_off = 0;
m_head->data_len = seg->length;
} else {
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr
2022-11-01 9:53 [PATCH 1/1] test/bbdev: use helper function to set IOVA addr Srikanth Yalavarthi
@ 2022-11-03 6:31 ` Jerin Jacob
2022-11-03 7:24 ` [EXT] " Srikanth Yalavarthi
0 siblings, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2022-11-03 6:31 UTC (permalink / raw)
To: Srikanth Yalavarthi; +Cc: Nicolas Chautru, Maxime Coquelin, dev
On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> Use helper function rte_mbuf_iova_set to set IOVA address
> to fix compilation failures.
>
> Below error was observed:
>
> dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> ‘struct rte_mbuf’ has no member named ‘buf_iova’
> 1145 | m_head->buf_iova = rte_malloc_virt2iova(data);
> | ^~
>
> Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
Is this change came after rte_mbuf_iova_set() API introduction?
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> app/test-bbdev/test_bbdev_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 8cf4359a2c..b285d3f3a7 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs,
> "rte malloc failed with %u bytes",
> seg->length + 1024);
> m_head->buf_addr = data;
> - m_head->buf_iova = rte_malloc_virt2iova(data);
> + rte_mbuf_iova_set(m_head, rte_malloc_virt2iova(data));
> m_head->data_off = 0;
> m_head->data_len = seg->length;
> } else {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [EXT] Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr
2022-11-03 6:31 ` Jerin Jacob
@ 2022-11-03 7:24 ` Srikanth Yalavarthi
2022-11-03 7:36 ` Jerin Jacob
0 siblings, 1 reply; 5+ messages in thread
From: Srikanth Yalavarthi @ 2022-11-03 7:24 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Nicolas Chautru, Maxime Coquelin, dev, Srikanth Yalavarthi
> On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
> <syalavarthi@marvell.com> wrote:
> >
> > Use helper function rte_mbuf_iova_set to set IOVA address to fix
> > compilation failures.
> >
> > Below error was observed:
> >
> > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> > dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> > ‘struct rte_mbuf’ has no member named ‘buf_iova’
> > 1145 | m_head->buf_iova = rte_malloc_virt2iova(data);
> > | ^~
> >
> > Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
>
> Is this change came after rte_mbuf_iova_set() API introduction?
Yes, the change is need after rte_mbuf_iova_set API is added. Build failure is observed on x86 and ARM64.
>
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
>
>
> > ---
> > app/test-bbdev/test_bbdev_perf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-bbdev/test_bbdev_perf.c
> > b/app/test-bbdev/test_bbdev_perf.c
> > index 8cf4359a2c..b285d3f3a7 100644
> > --- a/app/test-bbdev/test_bbdev_perf.c
> > +++ b/app/test-bbdev/test_bbdev_perf.c
> > @@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data
> *bufs,
> > "rte malloc failed with %u bytes",
> > seg->length + 1024);
> > m_head->buf_addr = data;
> > - m_head->buf_iova = rte_malloc_virt2iova(data);
> > + rte_mbuf_iova_set(m_head,
> > + rte_malloc_virt2iova(data));
> > m_head->data_off = 0;
> > m_head->data_len = seg->length;
> > } else {
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [EXT] Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr
2022-11-03 7:24 ` [EXT] " Srikanth Yalavarthi
@ 2022-11-03 7:36 ` Jerin Jacob
2022-11-03 8:01 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2022-11-03 7:36 UTC (permalink / raw)
To: Srikanth Yalavarthi; +Cc: Nicolas Chautru, Maxime Coquelin, dev
On Thu, Nov 3, 2022 at 12:54 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> > On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
> > <syalavarthi@marvell.com> wrote:
> > >
> > > Use helper function rte_mbuf_iova_set to set IOVA address to fix
> > > compilation failures.
> > >
> > > Below error was observed:
> > >
> > > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> > > dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> > > ‘struct rte_mbuf’ has no member named ‘buf_iova’
> > > 1145 | m_head->buf_iova = rte_malloc_virt2iova(data);
> > > | ^~
> > >
> > > Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
> >
> > Is this change came after rte_mbuf_iova_set() API introduction?
> Yes, the change is need after rte_mbuf_iova_set API is added. Build failure is observed on x86 and ARM64.
Then, Please change Fixes: as the changeset introduced the rte_mbuf_iova_set()
> >
> > >
> > > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> >
> >
> > > ---
> > > app/test-bbdev/test_bbdev_perf.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/app/test-bbdev/test_bbdev_perf.c
> > > b/app/test-bbdev/test_bbdev_perf.c
> > > index 8cf4359a2c..b285d3f3a7 100644
> > > --- a/app/test-bbdev/test_bbdev_perf.c
> > > +++ b/app/test-bbdev/test_bbdev_perf.c
> > > @@ -1142,7 +1142,7 @@ init_op_data_objs(struct rte_bbdev_op_data
> > *bufs,
> > > "rte malloc failed with %u bytes",
> > > seg->length + 1024);
> > > m_head->buf_addr = data;
> > > - m_head->buf_iova = rte_malloc_virt2iova(data);
> > > + rte_mbuf_iova_set(m_head,
> > > + rte_malloc_virt2iova(data));
> > > m_head->data_off = 0;
> > > m_head->data_len = seg->length;
> > > } else {
> > > --
> > > 2.17.1
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [EXT] Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr
2022-11-03 7:36 ` Jerin Jacob
@ 2022-11-03 8:01 ` Akhil Goyal
0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2022-11-03 8:01 UTC (permalink / raw)
To: Jerin Jacob, Srikanth Yalavarthi; +Cc: Nicolas Chautru, Maxime Coquelin, dev
>
> On Thu, Nov 3, 2022 at 12:54 PM Srikanth Yalavarthi
> <syalavarthi@marvell.com> wrote:
> >
> > > On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi
> > > <syalavarthi@marvell.com> wrote:
> > > >
> > > > Use helper function rte_mbuf_iova_set to set IOVA address to fix
> > > > compilation failures.
> > > >
> > > > Below error was observed:
> > > >
> > > > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’:
> > > > dpdk/app/test-bbdev/test_bbdev_perf.c:1145:11: error:
> > > > ‘struct rte_mbuf’ has no member named ‘buf_iova’
> > > > 1145 | m_head->buf_iova = rte_malloc_virt2iova(data);
> > > > | ^~
> > > >
> > > > Fixes: 0acdb98667 ("test/bbdev: add FFT operations cases")
> > >
> > > Is this change came after rte_mbuf_iova_set() API introduction?
> > Yes, the change is need after rte_mbuf_iova_set API is added. Build failure is
> observed on x86 and ARM64.
>
> Then, Please change Fixes: as the changeset introduced the rte_mbuf_iova_set()
>
FFT patch was added after the new API was introduced. So Fixes should be the FFT patch only.
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-03 8:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 9:53 [PATCH 1/1] test/bbdev: use helper function to set IOVA addr Srikanth Yalavarthi
2022-11-03 6:31 ` Jerin Jacob
2022-11-03 7:24 ` [EXT] " Srikanth Yalavarthi
2022-11-03 7:36 ` Jerin Jacob
2022-11-03 8:01 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).