From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E921A034F; Mon, 11 Oct 2021 18:58:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37CC8410EF; Mon, 11 Oct 2021 18:58:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 453F3410E2 for <dev@dpdk.org>; Mon, 11 Oct 2021 18:58:34 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19BEHaOW030538; Mon, 11 Oct 2021 09:58:28 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by mx0b-0016f401.pphosted.com with ESMTP id 3bmpv4rm73-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Oct 2021 09:58:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HM/F0+iSD1IQYQMCWq3Ti98R7vDGacmVHq1oHVWJ5+CpKjzgxYRw06rXArDOXRV87OhDdMTx8L9LPU3Nz3+bvZ3n3/jNCd0IxU3AJHAHjZoxu+O4QLM3shgOr4eKH5vAl5beLDumYcmFniI/26zCtmyWNtY8Ij9gp01uYbzVEBVq/WhfCv3apqic3lx97TN9VYrUObqFAeQO/HKdfqE6i9FdLQp68CD/E6/ABX2BLfVRYW3EwGaOJsfK/xZjdX5hRb6DJVfeD3BjzoB/YV2DtgbFZHVOp7y3JWBoXPJDk0PduksL7M1CCNfKRIG+fz8NkmWe0nCjT/BQPZJGTarg/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sKJGC3OjJ1TESp5MXFttoHroQN5DOpfP3f5yvl4/pq0=; b=dV8Z3S/nzhSNup1X44Uyrv224tZkTo5HuVm+G3uZynVJiIrnd23Fr1QhdVJKxveaYxm1UVP4vfbGQrHgkxmYVuzSNYvpmF7QPLmPfCYE3fjDsjTY+XAYDmeSjmm+vmRE6+sBmdsO7xbr4Uo3UIHAju2Btw+BpcbdzLYM2WUGBBcEt10vHdN1tfCRaUb8JQ4KZGWsGpdk8RGf/BsZt6oMFj/CjWNZVmpN82OeSr3BWhPithhIk4guvI/T4i905P5sS6aO7bSe6UxYaFWD4IhhRaFyeVQyQyZoLwJlY5CzHqp/oLh5SRCkUBFfgeouGHI7x6+ERWT5J9ztziFDxc3dFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sKJGC3OjJ1TESp5MXFttoHroQN5DOpfP3f5yvl4/pq0=; b=JBi5bUYUkBO9QfA7VuSP6voXpACrCXERx8/g6VaTy1taMcryIVU7AbK+2FyDSynzQjTPpLSQMN88TbldL8ESYg8xbdL7Oa+JlSzR1P85+8OiR6PDKaoYPJHgBox3UZ/CBQ9FTkR2v6DDgY8Xtp3OCmVyvwqAqWlPsudvEY/6FkQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4651.namprd18.prod.outlook.com (2603:10b6:303:e6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Mon, 11 Oct 2021 16:58:25 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::c41e:707:3f91:71b8%8]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 16:58:25 +0000 From: Akhil Goyal <gakhil@marvell.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, Anoob Joseph <anoobj@marvell.com>, "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>, "fiona.trahe@intel.com" <fiona.trahe@intel.com>, "declan.doherty@intel.com" <declan.doherty@intel.com>, "matan@nvidia.com" <matan@nvidia.com>, "g.singh@nxp.com" <g.singh@nxp.com>, "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>, "jianjay.zhou@huawei.com" <jianjay.zhou@huawei.com>, "asomalap@amd.com" <asomalap@amd.com>, "ruifeng.wang@arm.com" <ruifeng.wang@arm.com>, "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "radu.nicolau@intel.com" <radu.nicolau@intel.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, Nagadheeraj Rottela <rnagadheeraj@marvell.com>, Ankur Dwivedi <adwivedi@marvell.com>, "ciara.power@intel.com" <ciara.power@intel.com>, Stephen Hemminger <stephen@networkplumber.org>, "ray.kinsella@intel.com" <ray.kinsella@intel.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com> Thread-Topic: [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields Thread-Index: AQHXvIV3wHmAuXgUlUGBHcAT2EMzxKvNe94AgACJd9A= Date: Mon, 11 Oct 2021 16:58:24 +0000 Message-ID: <CO6PR18MB4484178A39F0C08486B70662D8B59@CO6PR18MB4484.namprd18.prod.outlook.com> References: <20210731181327.660296-1-gakhil@marvell.com> <20211008204516.3497060-1-gakhil@marvell.com> <20211008204516.3497060-3-gakhil@marvell.com> <2663373.9MILaYa0Np@thomas> In-Reply-To: <2663373.9MILaYa0Np@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa72fe08-8bf9-4c5c-32db-08d98cd85717 x-ms-traffictypediagnostic: CO1PR18MB4651: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <CO1PR18MB465148E7A3CBFB4BC5275396D8B59@CO1PR18MB4651.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XCbiWNATm3UlpxqtKxH41eaYti1tP/YXhzqINiNMGYBn5rQo7C0Fr/DV0GFUbtdz27Jaox/2qUUuTbpch4UfiU9ZvpX1tvjDf5qm66mUExtcoAXl2mtoEy1nS06lFekvfcKyxyG4S7koLtzrNBcZJ+kXFKugCAcc1N8jd12eHjfB4zi7Y2lTEU/DQYphlnSallYYmg13agwDNnNHgsKBwjBBPmSr+8psbARc3dg5YbgdUx2bzZ0m3eJSPSCO/uj5+IutjOgoYhhxmDmIWRXoXsG8PFAiazVv7qTKJpbFhRoItjjVmJmZaba207vCSwQhcSGG87muym0wgWABBzihQ3hrssJCdAvXQZWOepM6wsD3JZwFNA9EVOKFlCQ61ZDAhwY6nJ1cpZTR2tYdttSzpLkTbpvM7n09jYmbY1m3x2Gt2+9Rrn+NH3NB2TLqJnFG+k9lO12WHpwVcTmWhMU+ToOM/htFWU1w+Z9lPIjh+U6+/ccVRIhTXMTvCxX+jDc/UpjCqekNDhghRpsxNjWR2Kp2CKnHgKRLeo9RD8D9lx4zqu+8yD5be7w2eL18O5tdEKCQOz8mXELo38zCgWormd6NdrTIePmmVnU9IA8TuNvBCQ8ibIRm9d8S3V/NmepCZsOUCkfPzSz+UZBp3F1mIzO5Q+I6Y4rtVCnSxN72wIZJcShEq4WMC/bSziaw/o61BFhv7Lx2NsDxeiPufSxQvw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(7416002)(66476007)(55016002)(54906003)(64756008)(66556008)(9686003)(66946007)(26005)(15650500001)(6506007)(8936002)(8676002)(316002)(55236004)(5660300002)(7696005)(38070700005)(52536014)(83380400001)(38100700002)(6916009)(2906002)(122000001)(66446008)(33656002)(76116006)(71200400001)(4326008)(86362001)(508600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bEwv4zI601d9OaXRclzoxVOswqYaKzhCYTlv0juugAwK8tF/1gVu3kCbgkuQ?= =?us-ascii?Q?h5Hd+TZiRIJJ8scFggojpwoH9twI6hzSwEuzWm6ekISPVdoEquYHWMT1znqG?= =?us-ascii?Q?zX+/YZJNLIvJtgjvyc89DqXgzZCsqztZZ/wXjQR173lt0f5HvwrAekJaeuHt?= =?us-ascii?Q?DNpz0NoUzBDDd3VaWZGv3o9nDG7nSfiks/VB/lHdtHJJrPaW9n46QhHNPJAr?= =?us-ascii?Q?9rRHsd3wsbzcbAdQG5c/3+fQkXk3GSK4U2Ju7BiKf7tlwgmxrKw8rACNGSsL?= =?us-ascii?Q?ifRZig8PcTe/8pS5x0a1hOLUXEp4SSq1HU4OknqR5s72D6sDySccy5Ahbb52?= =?us-ascii?Q?Osc2zmS55PTcu/xd0lqwLN2moj1kZP2hb1oJpiEMAIk2RFIg2tw9swd4s4gI?= =?us-ascii?Q?h2lHC1BYIEkqJwHIewOJMzbsUwAOsGlkz95FCoRasFTXV/udQHPmtlF+6mU9?= =?us-ascii?Q?yf5uXL0SSnKC5Gjqny9DGuOrMIvxUlGQ2PkZEMpvEEIr9b8VuaGpiNj8aygM?= =?us-ascii?Q?vDq0D7ZWUQz5sGVODCi5RK7oa8Cx6/mpuvhVRj+k5VaFqftgI5oRP1daC3Zw?= =?us-ascii?Q?S5e9bVAp1b9Pl6dDfEsCX2mgMVfgFzWOXMIokUTq/oFh792anegnxe9CnC5p?= =?us-ascii?Q?XbNzOPwJ7nLBDOsYAeMMJR/Qsvr5IhBJkovQTTP3aZVK33UnOfiRY68yOk+r?= =?us-ascii?Q?1lO411eqiCFOOozlUQIqMsRgRkIGzeMLuX1gDsyfhpFco0ImqCy6tj/HIk4b?= =?us-ascii?Q?W4t/7dUkMCnO8XeZFvainVHVt8sLXe+mF7K6JS6G15kOPKlPVoWctoxliS2l?= =?us-ascii?Q?Aqpsr7Iz/LFJdxZYvZrxHDHQjwB0Jx4sSGY2Z+e7wmizoT1fs6DwzlUsOB4B?= =?us-ascii?Q?X1U/AsVE9js8rom40L/I4f2Kuy4yq2SzFUjqFIfl8VSeJnI6O8tWBLGt20qw?= =?us-ascii?Q?9Ffj2XkdmF92VCmOGoAmm877uOP6q7J3cp7q0kxUw9TooPAjyW+adv7r1RP7?= =?us-ascii?Q?xpnE4vrXpL9AwNv/zCCofFj5ImBgACXXfMxi3tf0Vgqs16Sz+7/R9Gs66SpE?= =?us-ascii?Q?Sm3kRAgmxRDpSw5q3W3cyZwp6ytAsxCp8qJlSuJhgCMYbS4trfXtfC4wWVkB?= =?us-ascii?Q?U9WiUrJSYZ+yzUQkYm2/MAoQCayxzTUzTilhquJjB0vInXZqwKTFYg+We2Y9?= =?us-ascii?Q?rWvrCieqY024vhjHYyib8IxQzAiVPtwpEdsC0ivAY71wMTh5AqzqlWZIC6UU?= =?us-ascii?Q?jM12g4qLRO+3xxTC6peIPmHNQpa145CrpFKbs+ROLr+k44ANVOAWbyxS0Fx7?= =?us-ascii?Q?3s/xciSSjFgd07kiv4XKO9jb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa72fe08-8bf9-4c5c-32db-08d98cd85717 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 16:58:25.0015 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +5EtP/ZlpeGdZILa2ZIiHBkcXQXY9HRZwP1KHekIrn/nDJIPtn2c9FfaM5SlVVn4sDgCrOkMoTVQ6+PMFexAXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4651 X-Proofpoint-ORIG-GUID: DN5AFR7FIoqQFfKaIyBCgS-YBJHTpbsI X-Proofpoint-GUID: DN5AFR7FIoqQFfKaIyBCgS-YBJHTpbsI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-11_06,2021-10-11_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > 08/10/2021 22:45, Akhil Goyal: > > In struct rte_security_ipsec_sa_options, for every new option > > added, there is an ABI breakage, to avoid, a reserved_opts > > bitfield is added to for the remaining bits available in the > > structure. > > Now for every new sa option, these reserved_opts can be reduced > > and new option can be added. >=20 > How do you make sure this field is initialized to 0? >=20 Struct rte_security_ipsec_xform Is part of rte_security_capability as well As a configuration structure in session create. User, should ensure that if a device support that option(in capability), th= en only these options will take into effect or else it will be don't care for = the PMD. The initial values of capabilities are set by PMD statically based on the f= eatures that it support. So if someone sets a bit in reserved_opts, it will work only if PMD support= it And sets the corresponding field in capabilities. But yes, if a new field is added in future, and user sets the reserved_opts= by mistake And the PMD supports that feature as well, then that feature will be enable= d. This may or may not create issue depending on the feature which is enabled. Should I add a note in the comments to clarify that reserved_opts should be= set as 0 And future releases may change this without notice(But reserved in itself s= uggest that)? Adding an explicit check in session_create does not make sense to me. What do you suggest? Regards, Akhil