RE: [EXT] [PATCH v6 4/4] test/cryptodev: add tests for GCM with AAD

[Akhil Goyal <gakhil@marvell.com>]

> Adding one new unit test code for validating the features
> added as part of GCM with 64 byte AAD.
> The new test case adds one new test for GCM algo for both
> encrypt and decrypt operations.
> 
> Signed-off-by: Nishikant Nayak <nishikanta.nayak@intel.com>
> Acked-by: Ciara Power <ciara.power@intel.com>
> ---
What is the need for this new test vector? How is this case not covered in existing cases?
Can you explain in the patch description?
How is it different than gcm_test_case_aad_2 case and other gcm 128 cases?


> @@ -12719,16 +12737,22 @@ test_authenticated_decryption_oop(const struct
> aead_test_data *tdata)
> 
>  	/* Verify the capabilities */
>  	struct rte_cryptodev_sym_capability_idx cap_idx;
> +	const struct rte_cryptodev_symmetric_capability *capability;
>  	cap_idx.type = RTE_CRYPTO_SYM_XFORM_AEAD;
>  	cap_idx.algo.aead = tdata->algo;
> -	if (rte_cryptodev_sym_capability_get(ts_params->valid_devs[0],
> -			&cap_idx) == NULL)
> -		return TEST_SKIPPED;
> +	capability = rte_cryptodev_sym_capability_get(ts_params-
> >valid_devs[0],
> +		&cap_idx);
> 
>  	/* not supported with CPU crypto and raw data-path APIs*/
>  	if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO ||
>  			global_api_test_type == CRYPTODEV_RAW_API_TEST)
>  		return TEST_SKIPPED;
> +	if (capability == NULL)
> +		return TEST_SKIPPED;

You should check the capability just after it is retrieved.