From: Akhil Goyal <gakhil@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
Gagandeep Singh <g.singh@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Jun Yang <jun.yang@nxp.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: RE: [EXTERNAL] Re: [v2 7/7] crypto/dpaa2_sec: rework debug code
Date: Fri, 4 Oct 2024 16:00:52 +0000 [thread overview]
Message-ID: <CO6PR18MB448423CB5D677C1B6D1A0330D8722@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xcJV-=gG6HCQvgajH2dDuJOGwSsgPvuoT4dUBy+mx+qg@mail.gmail.com>
> Hello guys,
>
> On Tue, Aug 6, 2024 at 12:28 PM Gagandeep Singh <g.singh@nxp.com> wrote:
> >
> > From: Jun Yang <jun.yang@nxp.com>
> >
> > Output debug information according to various modes.
> >
> > Signed-off-by: Jun Yang <jun.yang@nxp.com>
> > ---
> > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 87 +++++++++++++++------
> > 1 file changed, 63 insertions(+), 24 deletions(-)
> >
> > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> > index 1e28c71b53..a293a21881 100644
> > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> > @@ -1095,7 +1095,7 @@ build_auth_fd(dpaa2_sec_session *sess, struct
> rte_crypto_op *op,
> >
> > static int
> > build_cipher_sg_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op,
> > - struct qbman_fd *fd, __rte_unused uint16_t bpid)
> > + struct qbman_fd *fd, uint16_t bpid)
> > {
> > struct rte_crypto_sym_op *sym_op = op->sym;
> > struct qbman_fle *ip_fle, *op_fle, *sge, *fle;
> > @@ -1105,6 +1105,10 @@ build_cipher_sg_fd(dpaa2_sec_session *sess, struct
> rte_crypto_op *op,
> > struct rte_mbuf *mbuf;
> > uint8_t *iv_ptr = rte_crypto_op_ctod_offset(op, uint8_t *,
> > sess->iv.offset);
> > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL)
> > + char debug_str[1024];
> > + int offset;
> > +#endif
> >
> > data_len = sym_op->cipher.data.length;
> > data_offset = sym_op->cipher.data.offset;
> > @@ -1210,14 +1214,26 @@ build_cipher_sg_fd(dpaa2_sec_session *sess,
> struct rte_crypto_op *op,
> > DPAA2_SET_FD_COMPOUND_FMT(fd);
> > DPAA2_SET_FD_FLC(fd, DPAA2_VADDR_TO_IOVA(flc));
> >
> > - DPAA2_SEC_DP_DEBUG(
> > - "CIPHER SG: fdaddr =%" PRIx64 " bpid =%d meta =%d"
> > - " off =%d, len =%d\n",
> > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL)
> > + offset = sprintf(debug_str,
> > + "CIPHER SG: fdaddr =%" PRIx64 ", from %s pool ",
> > DPAA2_GET_FD_ADDR(fd),
> > - DPAA2_GET_FD_BPID(fd),
> > - rte_dpaa2_bpid_info[bpid].meta_data_size,
> > - DPAA2_GET_FD_OFFSET(fd),
> > - DPAA2_GET_FD_LEN(fd));
> > + bpid < MAX_BPID ? "SW" : "BMAN");
> > + if (bpid < MAX_BPID) {
> > + offset += sprintf(&debug_str[offset],
> > + "bpid = %d ", bpid);
> > + }
> > + offset += sprintf(&debug_str[offset],
> > + "private size = %d ",
> > + mbuf->pool->private_data_size);
> > + offset += sprintf(&debug_str[offset],
> > + "off =%d, len =%d\n",
>
> DPAA2_SEC_DP_DEBUG already appends a \n, don't add a new one.
>
> > + DPAA2_GET_FD_OFFSET(fd), DPAA2_GET_FD_LEN(fd));
> > + DPAA2_SEC_DP_DEBUG("%s", debug_str);
>
> Indentation is wrong.
>
> > +#else
> > + RTE_SET_USED(bpid);
> > +#endif
> > +
> > return 0;
> > }
> >
> > @@ -1233,6 +1249,10 @@ build_cipher_fd(dpaa2_sec_session *sess, struct
> rte_crypto_op *op,
> > uint8_t *iv_ptr = rte_crypto_op_ctod_offset(op, uint8_t *,
> > sess->iv.offset);
> > struct rte_mbuf *dst;
> > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL)
> > + char debug_str[1024];
> > + int offset;
> > +#endif
> >
> > data_len = sym_op->cipher.data.length;
> > data_offset = sym_op->cipher.data.offset;
> > @@ -1324,14 +1344,23 @@ build_cipher_fd(dpaa2_sec_session *sess, struct
> rte_crypto_op *op,
> > DPAA2_SET_FLE_FIN(sge);
> > DPAA2_SET_FLE_FIN(fle);
> >
> > - DPAA2_SEC_DP_DEBUG(
> > - "CIPHER: fdaddr =%" PRIx64 " bpid =%d meta =%d"
> > - " off =%d, len =%d\n",
> > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL)
> > + offset = sprintf(debug_str,
> > + "CIPHER: fdaddr =%" PRIx64 ", from %s pool ",
> > DPAA2_GET_FD_ADDR(fd),
> > - DPAA2_GET_FD_BPID(fd),
> > - rte_dpaa2_bpid_info[bpid].meta_data_size,
> > - DPAA2_GET_FD_OFFSET(fd),
> > - DPAA2_GET_FD_LEN(fd));
> > + bpid < MAX_BPID ? "SW" : "BMAN");
> > + if (bpid < MAX_BPID) {
> > + offset += sprintf(&debug_str[offset],
> > + "bpid = %d ", bpid);
> > + }
> > + offset += sprintf(&debug_str[offset],
> > + "private size = %d ",
> > + dst->pool->private_data_size);
> > + offset += sprintf(&debug_str[offset],
> > + "off =%d, len =%d\n",
>
> Idem.
>
>
> > + DPAA2_GET_FD_OFFSET(fd), DPAA2_GET_FD_LEN(fd));
> > + DPAA2_SEC_DP_DEBUG("%s", debug_str);
> > +#endif
> >
> > return 0;
> > }
> > @@ -1564,6 +1593,10 @@ sec_fd_to_mbuf(const struct qbman_fd *fd, struct
> dpaa2_sec_qp *qp)
> > struct qbman_fle *fle;
> > struct rte_crypto_op *op;
> > struct rte_mbuf *dst, *src;
> > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL)
> > + char debug_str[1024];
> > + int offset;
> > +#endif
> >
> > if (DPAA2_FD_GET_FORMAT(fd) == qbman_fd_single)
> > return sec_simple_fd_to_mbuf(fd);
> > @@ -1602,15 +1635,21 @@ sec_fd_to_mbuf(const struct qbman_fd *fd, struct
> dpaa2_sec_qp *qp)
> > dst->data_len = len;
> > }
> >
> > - DPAA2_SEC_DP_DEBUG("mbuf %p BMAN buf addr %p,"
> > - " fdaddr =%" PRIx64 " bpid =%d meta =%d off =%d, len =%d\n",
> > - (void *)dst,
> > - dst->buf_addr,
> > - DPAA2_GET_FD_ADDR(fd),
> > - DPAA2_GET_FD_BPID(fd),
> > - rte_dpaa2_bpid_info[DPAA2_GET_FD_BPID(fd)].meta_data_size,
> > - DPAA2_GET_FD_OFFSET(fd),
> > - DPAA2_GET_FD_LEN(fd));
> > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL)
> > + offset = sprintf(debug_str, "Mbuf %p from %s pool ",
> > + dst, DPAA2_GET_FD_IVP(fd) ? "SW" : "BMAN");
> > + if (!DPAA2_GET_FD_IVP(fd)) {
> > + offset += sprintf(&debug_str[offset], "bpid = %d ",
> > + DPAA2_GET_FD_BPID(fd));
> > + }
> > + offset += sprintf(&debug_str[offset],
> > + "private size = %d ", dst->pool->private_data_size);
> > + offset += sprintf(&debug_str[offset],
> > + "addr %p, fdaddr =%" PRIx64 ", off =%d, len =%d\n",
>
> Idem.
>
>
> > + dst->buf_addr, DPAA2_GET_FD_ADDR(fd),
> > + DPAA2_GET_FD_OFFSET(fd), DPAA2_GET_FD_LEN(fd));
> > + DPAA2_SEC_DP_DEBUG("%s", debug_str);
> > +#endif
> >
> > /* free the fle memory */
> > if (likely(rte_pktmbuf_is_contiguous(src))) {
>
> I see this patch is already merged in next-crypto.
> Please, can this be fixed before reaching main?
>
Gagan,
This patch is removed from the crypto tree for now.
Please rework and send as separate patch.
next prev parent reply other threads:[~2024-10-04 16:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 8:41 [v1 0/7] DPAA2 crypto changes Gagandeep Singh
2024-08-06 8:41 ` [v1 1/7] crypto/dpaa2_sec: fix memory leak Gagandeep Singh
2024-08-06 8:41 ` [v1 2/7] common/dpaax: caamflib: fix PDCP SNOW-ZUC wdog DECO err Gagandeep Singh
2024-08-06 8:41 ` [v1 3/7] crypto/dpaa2_sec: enhance IPsec RFLC handling Gagandeep Singh
2024-08-06 8:41 ` [v1 4/7] crypto/dpaa2_sec: enhance pdcp FLC handling Gagandeep Singh
2024-08-06 8:41 ` [v1 5/7] net/dpaa2: support FLC stashing API Gagandeep Singh
2024-08-06 9:57 ` Hemant Agrawal
2024-08-06 8:41 ` [v1 6/7] crypto/dpaa2_sec: remove prefetch code in event mode Gagandeep Singh
2024-08-06 8:41 ` [v1 7/7] crypto/dpaa2_sec: rework debug code Gagandeep Singh
2024-08-06 8:47 ` Hemant Agrawal
2024-08-06 10:27 ` [v2 0/7] DPAA2 crypto changes Gagandeep Singh
2024-08-06 10:27 ` [v2 1/7] crypto/dpaa2_sec: fix memory leak Gagandeep Singh
2024-08-06 10:27 ` [v2 2/7] common/dpaax: caamflib: fix PDCP SNOW-ZUC wdog DECO err Gagandeep Singh
2024-08-06 10:27 ` [v2 3/7] net/dpaa2: support FLC stashing API Gagandeep Singh
2024-08-06 10:27 ` [v2 4/7] crypto/dpaa2_sec: enhance IPsec RFLC handling Gagandeep Singh
2024-08-06 10:27 ` [v2 5/7] crypto/dpaa2_sec: enhance pdcp FLC handling Gagandeep Singh
2024-08-06 10:27 ` [v2 6/7] crypto/dpaa2_sec: remove prefetch code in event mode Gagandeep Singh
2024-08-06 10:27 ` [v2 7/7] crypto/dpaa2_sec: rework debug code Gagandeep Singh
2024-10-04 13:36 ` David Marchand
2024-10-04 16:00 ` Akhil Goyal [this message]
2024-09-18 5:35 ` [EXTERNAL] [v2 0/7] DPAA2 crypto changes Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB448423CB5D677C1B6D1A0330D8722@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=jun.yang@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).