From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 009A1A00BE; Mon, 16 May 2022 20:54:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B5ED40A7A; Mon, 16 May 2022 20:54:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 4873E4068B for ; Mon, 16 May 2022 20:54:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24GBB0JF007593; Mon, 16 May 2022 11:54:39 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2047.outbound.protection.outlook.com [104.47.73.47]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g2bxsr8ye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 May 2022 11:54:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dj/XCjNBIhC+OXPLKSH9+n8D9JmVL7ajFjxVy1q1TfKWs51viSeGTZ7LMxNAwFo/3l0NrEEAwZbrjIkGYl8iowmB7q16GKJYolK9/5D6S9qo6ieqKjGukIzaNLZCulnS69taMcv1UxKZSTa1hiF7tG4V3lqeNFLwHoQL7/7VVIBf2z40G4PCDrvSSyCvjs3rEteUMifK73eY9YgFVXYY4cn908cZK2dtk4IRG7yHC/wwUDu3ur6MV2kCru+UcvGos7g4XMScH/vcDygwXmHaohgP9IxULBk2C135t4YugZ39LYHNPbu4ivQfWwy6gfgiOPZ3Nm9bgFeQ2xWBxFiApw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Ps4eofZrKvWVxldBW9TT2i/OMU1GNzhtoP0vktqtgI=; b=Sb4aYi/vutnja3QaTFnCRGONumNv9Pe/NBiDOCFsG0v7bSvd0lBMrowr4nn4VlZjKTULGcEK/ZIUl+/7q1EyrroqhUnCzZAV9zYpCIO2i8sMbumXn3liMBjCUha/kkZf8yi7WGzCat1RGMruNdx/yYqWAXjNyTPiFhxg4NnEqYkiDnotc/hMZcvR6LnWGJeeiMh+n9PfwX1wDH2wF0HTSw454BMMRgu0L1YKm0BBDFZ765fGJepCxJcas3hPS4xXDgg1gjTn3FVh+uj33m7g76OLtgc4nqTGCjQc84LnHTUt01FqdGII0BclWREhHnthOfA7O+GUx8VhSpBfXTVvMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Ps4eofZrKvWVxldBW9TT2i/OMU1GNzhtoP0vktqtgI=; b=AHqnNn6Vh7Qvz0z061YKEf4e9UsXuEGwaylTMVfNI1AaCk24x6fJiiPtlSNN42ZMiKzIAKI8J2r2zrnnBKgm4eC5Lf9StNhzUsbULVpwjRRSNJl72Y/R4yV2HZzz9wz3Y7NoArgfxbZLLeXj85VXa+gvtVOwOgT/XJmD704Vo5g= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BL1PR18MB4135.namprd18.prod.outlook.com (2603:10b6:208:31a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Mon, 16 May 2022 18:54:37 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::9c76:3b01:eb04:db4d%6]) with mapi id 15.20.5250.018; Mon, 16 May 2022 18:54:37 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [RFC PATCH] cryptodev: add basic asymmetric crypto capability structs Thread-Topic: [EXT] [RFC PATCH] cryptodev: add basic asymmetric crypto capability structs Thread-Index: AQHYS1GybfI0w+oHDUmB63Um8e8Gxa0iFfJg Date: Mon, 16 May 2022 18:54:37 +0000 Message-ID: References: <20220408140518.24634-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220408140518.24634-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38b4bda7-882f-44ca-11c0-08da376d8677 x-ms-traffictypediagnostic: BL1PR18MB4135:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NUuAQ60iWH54/pbFYijhchPmokQk7b/V1AoAsR+JErSxx5bv+YBCRkj4vhUj4ghu8TeTHqWvIsZUV8mYWcvxVmV+33F+YbSXxREFEta0dxmpMnc0BuEkXCEFa2v98ARlCne74ah3UnkhdyeVyRAPJpF+i0ad/LzmqKedTdKh6H03RmBZGY3ukIF2IGBEdEhCO08TehsgrFfEVRNQDbGeV3QoSgr4/gZP/IuV+rG0nP894BVj9bFfIkSbUao6zpvLlCWt2AvQZrrvYHaxQQ7hUkvmm7RqHtSk5gaiWQ1VbBApt6o9W1oDvCAg1m5VpcXRGwNJJSI2sQEBoeYvJ542wbg5oVUoAfuQjvoz+XlOCOl/fIbjadijAK1LeNlUR8BBENOwJy59YBqABnZJaUnL63Jzv2Ybl1beHxmKEy4PUreIAkSOQThB7hIRapFMip9rTvlDKgXjIOvVsgWyeOUHJPzyxFnaPQQbEbz/WILpSch5UKWyZfxWrqFCoNsMYudX2EZEC6NhnlvQdyq+MmLAI45VylEzkZ7rQEZRt/5hIEYeSaY2L5DHkSFH5xILKE+Yku5jRGgiF0WG3A/Miv+QAiIUV4uNyDGHB6lL36f0GH5OfrNPtGZa4UJ50JaPZoGdyFyGQgz5nniwFV49sfxS27SAxzToiX+30WTur+TJOwgoe0QPH8Q2ouPQ+m04q917PdXDZ/5MtifLeRqPpD/ClA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(2906002)(66946007)(71200400001)(508600001)(38070700005)(66556008)(66446008)(316002)(6506007)(4326008)(76116006)(55016003)(64756008)(26005)(55236004)(8936002)(33656002)(86362001)(5660300002)(52536014)(110136005)(83380400001)(66476007)(9686003)(38100700002)(122000001)(7696005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c/VdHJAIjGnUnjPHA4bmMOmnTL/LvTO44RiAeyCrRPSo1wAFh7zaGD58GM9l?= =?us-ascii?Q?E6r/v6T3BXUB01itSOXsWiysOV+b0gBhp4IIZ2J4WGvDBkBj3Ff5IuCVW0id?= =?us-ascii?Q?0hKt9RROBYJAG1Kpt7scb2sj6XSQCtjsPDOjmtgIBh5UuILVu8XEYEWCy3t3?= =?us-ascii?Q?WyH7BJ1EpLPTfYl70pssPomR/3NwN5EDBThTht2VBGkaFR9gfgx93znVV5Ms?= =?us-ascii?Q?xRtg8IMz1dt66XmfDlIYllTEWTQffbZthUbq7F5ef5NUd1C7kyj7yNE15a4X?= =?us-ascii?Q?GDEGqk9Dycj+eNH6rTm/dgsZJpsnO747iSAY6843OrJ0/MoiEZG46b3FjPn2?= =?us-ascii?Q?pOMhNBGy6K0yWgcDJK2wCV4mCYvX6wrix4v9wkBTdWQIU9WWGZVeiVsKv7gW?= =?us-ascii?Q?e351JhX+i3KA4WidqMSWHkrhFB0qdJfxaw1uVu0hKDOu5fE5lKfaaCdjQYVM?= =?us-ascii?Q?Jv6U8Lsl6nKOmB4onCNYVjreCR8Dc92DearUrObkUd5bDNwVWinSZ/0heE5B?= =?us-ascii?Q?CzAb7Dj/iGfnTJpECR0Rdut49+CVbUJXyKIBZs55dz9wg7TkapH4QaktdMyE?= =?us-ascii?Q?ABHW/S9+I/ov88K30DBW+1QvyRII6YG04OG4AE4IJMq2KiiPheUZtRtRSGb2?= =?us-ascii?Q?zmCZ12ur1TkB3fiYo5MO5f3hwcnjJRWR4GdYMcMvelV9JqpT3KVQDLNY+s6D?= =?us-ascii?Q?F9gwOhZu40Dji5WgnCYc3F3PgS0bzFjnRVURCVMOAqfMctPN26o7o0IAHaUL?= =?us-ascii?Q?KYBLBykifqA4YVwbiEXRz9cAwSWZkh6jRj47R5jUiF1fPPac+o6bvLuGxaKy?= =?us-ascii?Q?gOS9PurLn6pbiZGFqx6HUXR+3fHyo/3I7PTZJl0iL19g8fCUKtZOXmbeUFKC?= =?us-ascii?Q?MSjhsHtjTJ9rpHUtV7TwMwd2r/lY2HbUKiZ3f+ycG0ibMOztvCp/I9giS13O?= =?us-ascii?Q?lRZFsjHloJ2eqAmO4PUdPymaYUCXkRpijArfnOefDx+9DP9Nq0UZBTukkg0e?= =?us-ascii?Q?KbAEUQF1u6fAGsqbhx+kIJ6x69tgdiEZs7J7tFCUrzJs4rGVe3je7KA2ACBA?= =?us-ascii?Q?ICrFm0DmxSfL7j85Ks5hdjXNMH3pwO3849GNqEnsN+tVx1IWNrqH50woL4Ms?= =?us-ascii?Q?APinJ97XFIKu/n3IycHvq146jZZLk4fB1O4dlLFdlZsmPR5mgpNVvvNTqb2v?= =?us-ascii?Q?o6RuAcuszKWtPQZIC0jX+ZukadVysSTXRiXcgoHWHYonFMA2BYPjG7QNCinB?= =?us-ascii?Q?nMjZUedMGW1yPeSUDuY3Q5ifh3Ycaz45/K70IjZn2B2foWUf71SkU29q6UdT?= =?us-ascii?Q?l4l6Zlmbz4wffkfgo+ZDU99zDgtGN0sI5lfO8k8+yCvbGINaHnbqNnbikDjN?= =?us-ascii?Q?54fYIhRfqZBTgTrAC7x90HtQqyDnXMBa4yDTJgoS2RtPxjCe+5QFxrqgenbg?= =?us-ascii?Q?RkmG9RLDgT/0putz0pas5gHxyiQoXOiPDmgzu7UzTZYSBNxLVhoGGy4l64GJ?= =?us-ascii?Q?iZajDvDxItwTC9SunK+t+lwbGjGpo5J+IV6ZptNWg0ufD81bTBLquWcDB+5N?= =?us-ascii?Q?FaWvZdCYbQljTdymfoGrpCClS7aGChEeXRI4pekCUCnvDncycx/lbT2CP/CY?= =?us-ascii?Q?2ItkbkWkgpJPsvR+v3Hi1TwC75ghTRlPCJEQ5W7Q0hjjzFFUvEoIOcFdfaZl?= =?us-ascii?Q?+sYqbwflgcXDHRm7BqftYx0VuQhM1wKC9EotxKGhiv1fS86zXNcxe7PQxZQG?= =?us-ascii?Q?PDT8dWNZiQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38b4bda7-882f-44ca-11c0-08da376d8677 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 18:54:37.2791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BRKO0s+MuK+HtUnCWwkq1Dxngb7uJdd7ULJnVxNPHCRwg+B9wVeajdj7IpRQYUQZbzs7iS2ZC5RXNkahH3VKZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR18MB4135 X-Proofpoint-ORIG-GUID: JIpdbU4pTVntDqf3ZNXsjtR5Xl6tJYpB X-Proofpoint-GUID: JIpdbU4pTVntDqf3ZNXsjtR5Xl6tJYpB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-16_15,2022-05-16_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Arek, Are you planning for a formal patch for adding asym capabilities? > This commit adds basic structs to handle asymmetric crypto capability. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 47 +++++++++++++++++++++++++++++++++ > lib/cryptodev/rte_cryptodev.h | 8 ++++++ > 2 files changed, 55 insertions(+) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index cd24d4b07b..2d58fffee5 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -386,6 +386,26 @@ struct rte_crypto_rsa_op_param { > */ > }; >=20 > +struct rte_crypto_rsa_capability { > + uint64_t padding_type; > + /* Supported padding */ > + union { > + uint64_t hash; > + /* Supported hash functions, at least one > + * shall be supported */ > + uint64_t mgf; > + /* Supported masdk generation functions, > + * at least one shall be supported */ > + } padding; > + uint32_t max_key_len; > + /* Maximum supported key length */ > + uint8_t sign_message; > + /* If zero input should contain message digest, > + * otherwise it should be plain message */ > + uint8_t pkcs_plain_padding; > + /* PKCS1_5 padding without algorithm identifier */ > +}; > + > /** > * Diffie-Hellman Operations params. > * @note: > @@ -416,6 +436,19 @@ struct rte_crypto_dh_op_param { > */ > }; >=20 > +struct rte_crypto_dh_capability { > + union { > + uint32_t group_size; > + /**< Maximum size of underliying mod group */ > + uint64_t curves; > + /**< Supported elliptic curve ids */ > + /* uint64_t fixed_groups; ? */ > + /**< Supported fixed groups */ > + /* uint8_t custom_curves; ? */ > + /**< Supported custom curves */ > + }; > +}; > + > /** > * DSA Operations params > * > @@ -484,6 +517,13 @@ struct rte_crypto_ecdsa_op_param { > */ > }; >=20 > +struct rte_crypto_ecdsa_capability { > + uint64_t curves; > + /**< Supported elliptic curve ids */ > + /* uint8_t custom_curves; ? */ > + /**< Supported custom curves */ > +}; > + > /** > * Structure for EC point multiplication operation param > */ > @@ -498,6 +538,13 @@ struct rte_crypto_ecpm_op_param { > /**< Scalar to multiply the input point */ > }; >=20 > +struct rte_crypto_ecpm_capability { > + uint64_t curves; > + /**< Supported elliptic curve ids */ > + /* uint8_t custom_curves; ? */ > + /**< Supported custom curves */ > +}; > + > /** > * Asymmetric crypto transform data > * > diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.= h > index 45d33f4a50..79026dbb80 100644 > --- a/lib/cryptodev/rte_cryptodev.h > +++ b/lib/cryptodev/rte_cryptodev.h > @@ -176,6 +176,14 @@ struct rte_cryptodev_asymmetric_xform_capability { > /**< Range of modulus length supported by modulus based > xform. > * Value 0 mean implementation default > */ > + struct rte_crypto_ecdsa_capability ecdsa; > + /**< ECDSA capability */ > + struct rte_crypto_ecpm_capability ecpm; > + /**< ECPM capability */ > + struct rte_crypto_rsa_capability rsa; > + /**< RSA capability */ > + struct rte_crypto_dh_capability dh; > + /**< DH capability */ > }; > }; >=20 > -- > 2.30.2