From: Akhil Goyal <gakhil@marvell.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Ji, Kai" <kai.ji@intel.com>
Subject: RE: [EXT] [PATCH 0/4] cryptodev: add SM3 and SM4 algorithms
Date: Wed, 28 Sep 2022 11:05:10 +0000 [thread overview]
Message-ID: <CO6PR18MB44842723110D7B8A3D72213AD8549@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <PH0PR11MB5013826988E7EA39F9076AA49F549@PH0PR11MB5013.namprd11.prod.outlook.com>
> > > ShangMi 4 (SM4) is a block cipher used in the Chinese National
> > > Standard for Wireless LAN WAPI and also used with Transport Layer Security.
> > > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese
> > > National Standard.
> >
> > Add these full forms in comments of the enums that are added in patch 1 and 2
> I do not think we should, it is just current description of usage state of SM3/4.
> Especially that we do not put much effort into other algorithms, particularly with
> 3gpp algorithms which are all over the place with naming and comments.
Yes, we do not do so, as those algos are very common and does not have any other full form.
But SM3 and SM4 are relatively new and does not come up easily in search results if we just type SM3.
However, if we search for ShangMi 3, we get the RFC on first result.
next prev parent reply other threads:[~2022-09-28 11:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 6:08 Arek Kusztal
2022-08-17 6:08 ` [PATCH 1/4] cryptodev: add SM4 encryption algorithm Arek Kusztal
2022-08-17 6:08 ` [PATCH 2/4] cryptodev: add SM3 hash algorithm Arek Kusztal
2022-08-17 10:35 ` [EXT] " Anoob Joseph
2022-08-17 6:08 ` [PATCH 3/4] crypto/qat: add SM4 encryption algorithm Arek Kusztal
2022-08-17 6:08 ` [PATCH 4/4] crypto/qat : add SM3 hash algorithm Arek Kusztal
2022-09-21 19:34 ` [EXT] " Akhil Goyal
2022-09-21 19:37 ` [EXT] [PATCH 0/4] cryptodev: add SM3 and SM4 algorithms Akhil Goyal
2022-09-28 10:56 ` Kusztal, ArkadiuszX
2022-09-28 11:05 ` Akhil Goyal [this message]
2022-09-28 11:49 ` Kusztal, ArkadiuszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44842723110D7B8A3D72213AD8549@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).