From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 554F8A00C2; Wed, 28 Sep 2022 13:05:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45C004113D; Wed, 28 Sep 2022 13:05:16 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D14C34113C for ; Wed, 28 Sep 2022 13:05:14 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28SA4ciT003068; Wed, 28 Sep 2022 04:05:13 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jvjkk8g6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Sep 2022 04:05:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUVzsjYSEFL+g/Xf+AoYgPoI9zyM/nXg3FkAWqWazKj0pEFgpC//rKejBA+Fd30Q88AJdeL5QTqIcygnUXuG1JKPibUXK3EbD0BDox47GgYnKywwKvAHFX75PFy7JOXk0Q/GPQELT1QuxlyLAk8ugdY9WOUcExA84AbstXsKNDlWwCBCyUv9OjuoD0BuOu9ZYoVNIvyLgzhTB0bII8X1yNR53H3U9Kl4GgH26FWgTwxwrzo09J/3HzxW8oblvbjgTOnG5+gF/xVs9Wq2DE3MJJ3ZUeFqp6wMu1P+TQ6YVRoLk7FY+eAIcS7UZbljFinG81TxxUNSVQ8dagC9+MRC9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q2yP2ZoibQyozUw6AvVLsc4MN+f9GXvNVfTF3q5tOqY=; b=kor6i7ZxmIk60hYxCek4/3r58L1Ick8FQunB8Z10hyyy4O69E8YCK5QjNhO3jcrK9owuZhFkasnFUXNnc+UbHM/2MTVO+Ad9AdgvxXILkurrjvC9eyvM754T+Z3F5myvrCeO+MpFkuCyeIflvgZMgVROE2dS2QqhMdsFi8MJMo6ht7JmvoBCNXztQHUvW2BD9t6n/v0AAtSH47nfHqRqgZee7ezXd1aIEk6K36XCYh9Dqfff//d0lKMhKedMMg3n5wEBoW6oS6mXx6dBj5shKeWttyEj6jGb+3op9wM6PLtaDa/Rgf1QVPRTVFmtnpHN4BzUrQGluaBodXCsuZggEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q2yP2ZoibQyozUw6AvVLsc4MN+f9GXvNVfTF3q5tOqY=; b=l2LkoDMsGZ+spv2Ok0EO5FnJuXVZU2WANn1Y9R10k0CeSAEZg/IFIZnyTqO/7V0RqpJDyzXlPb8Z69htca4hmWMxz+aOMkrL8fSZyNxrH3JYHAn3BoHQe7Kr/o+uD/rDxmrvbtYZdcKqS42GMUWG4nnvQMNWKpK8v4P5qCTOKiw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB5109.namprd18.prod.outlook.com (2603:10b6:a03:438::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Wed, 28 Sep 2022 11:05:10 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5676.015; Wed, 28 Sep 2022 11:05:10 +0000 From: Akhil Goyal To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "Ji, Kai" Subject: RE: [EXT] [PATCH 0/4] cryptodev: add SM3 and SM4 algorithms Thread-Topic: [EXT] [PATCH 0/4] cryptodev: add SM3 and SM4 algorithms Thread-Index: AQHYsgl3BO9kWizkn0idri2hJgGlxa3qfnCQgApvboCAAAEBIA== Date: Wed, 28 Sep 2022 11:05:10 +0000 Message-ID: References: <20220817060856.78582-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SJ0PR18MB5109:EE_ x-ms-office365-filtering-correlation-id: d9b09893-ea37-4b5f-4824-08daa1414f3e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mHwaqBVkkTZG7uXdQ7/Nz0LiAX2wg+m77iWc9ksdPz6ck4M74qHIWtpPyoGUY4o84ajnwl8df1hIE6h5wOmB5h/+SsuTH82D0NKFQ8wtVfD9hYWCt4wzQ4YbFkiAWaOztgwC7QgXe+4AWN/GbEKmG/DUAOlVM8KCvqYHyUslU7S1emj/EEijT2zXG5QsBEMxeBkdGcxBuQlx/AKjJLpiVygBxM1RiOiffdoJyD/qXtslK81XczMy6+rhWNVf2QqqCjW0bwNE/SS0hUDFB5U9VK6t5IuImWLJAjRvjIk/VOSmdGjf/LsRya4WdlXbX2PLAzYQzBjdRS92MVcJgfo9Xtgq3/bqtW3N1Wyk2rgGe0O3JqBGffshQ6aeUCaK29fONa5oCdwT1fCOX1/5oOOZhWc6d3T0a7L0S5r0uddEpVcmajtxz/wMLHLERRzqG0fgDz+tFxvtPnYPHIv/WUM33UIRwbHwZxJ3OklIni8epBSbKWWm/jxuhilzV92y+37psiW9StLSLXZ3tnJv1mfa7WA6bwHHJODrT/V7o11QbK06K6+iqPb6YqCTlTl/c/1mTiu6lV/J37VSmTnABZK/+uyXR1QsPo8UEUcslHNy0t7EvXcLVbI3SlbdLJ1qpPs2cFQfDAFI7/x5dlAn2wHDb00rAAmKCZHJtH2puHbqeaA/+siS3HfUulqYxia10Fm7YJJ0bH4FPicNmW+zMcqXDcbYVwn/q9on9zEBtjIaANUqyTlLjHIQG3ty5MykjH6J4CW2q6MnZZyRNDG+xMmREA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(39860400002)(366004)(376002)(396003)(451199015)(122000001)(38100700002)(55016003)(52536014)(83380400001)(478600001)(110136005)(6506007)(71200400001)(26005)(7696005)(33656002)(5660300002)(4744005)(8936002)(9686003)(316002)(41300700001)(4326008)(55236004)(2906002)(8676002)(38070700005)(66446008)(66476007)(76116006)(64756008)(66556008)(86362001)(186003)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p9qLz5TLtqtAlYSBnXioYPhTK5cVi0vWhPhbsdJBnxezvHfYx/kvTo+M8Axk?= =?us-ascii?Q?yIX1JVIJ64RuPWDM3tcHTRG2EaS4DEAw1711eGtbEHiiTEWlEIuii2sjnkhW?= =?us-ascii?Q?huy7NO7SYHhsCqiEtkVTG8uwe7vPoJW/+oQBA/ir4XuzOXpWg/sQghRHpKdo?= =?us-ascii?Q?d1nQ4dd1YH1b8g0IsFJeRSQAt9np84oGZTcs+l8TeKIHQyDoSv1Jg8m6WzYZ?= =?us-ascii?Q?pofVJ6q08sZmSBIdBaqXDxOh5SBATRTPc9meHpb/EICZQW6eLEZSy447U1ht?= =?us-ascii?Q?ta2m8PpldR4gF3cUihK1u0vHvDz0UOS4dKQqXYyVZ58bQ+0mqLIWYoAyGXBU?= =?us-ascii?Q?Vy8ry88poP8jFVQiGN0uUrnrjveAK3b22u/Xqf3BELJvDPhAO0mIAQIf+ecA?= =?us-ascii?Q?zD8jWJqshNQQ4YJJ2MJwfu/lKf8iSz2WraqH8ovbLuKv1hIk6MwRK8+SrHyq?= =?us-ascii?Q?rdRoFWBLMLsxnccTX05zg0JCgmk4s3VK7tgLyhpr5Iy25WXMH2+oPrLaH/Rd?= =?us-ascii?Q?Ti+WfN5wovahDoksOn+QjxS+ZIBTCNgkTIBiroFhopTgYSf1LpXAn3p3S1c+?= =?us-ascii?Q?mBZpench/EpSv5tY+KE29cbWBqFhBDB7ItNpa/eWJDh3uVyTuu+HUsMxtQ+/?= =?us-ascii?Q?furtAakNV2y8axD3nJyDCUjnq2SzLAixuuFzcJ+YIDwCzR+X1qG7G5NIAMbt?= =?us-ascii?Q?S+O34IB75Ochzzax5h3RXsKtwixrQcfkNTSlW0yeUq637INarK8airv2GHTc?= =?us-ascii?Q?qK9+pYKrkclrHkRnJxjl+NPnEZSTML0bKVwzKYbwYR0ay8sGiWCxi6Bm41KV?= =?us-ascii?Q?lVHZFn70WWgbN1Aj9X3Mz9YH/GMZ1PORVRf5Hzr/90fOnz0A7E60UY+vaied?= =?us-ascii?Q?IM4bnXAtw3w8x1kRil04lF8i29g+rE/fv9CB/kGxuLozP7CKpg5PJsB0boLX?= =?us-ascii?Q?k5yzXGS4n/m606PGh4ElGpCq4lHTOoQCWVJ7N8QTFBjEkymEMIobTcRIpsgW?= =?us-ascii?Q?wdVi4i9NQzM3T5x07v1T7eUrW/eYOKHuFk3K9ay3rYFjk9BSwt4P+Z/eLj1y?= =?us-ascii?Q?jNtt4jb4YOfCtFtN3OE0NDrVhfnz+jw2Eh9WYRXrxv71US96W4Bug1gXrR2K?= =?us-ascii?Q?RZ6yxqHKu4W+chfR8MskLiWvRmSm7JWN6nH3vyj15OFQvMAhlvGaTS1Go7ZK?= =?us-ascii?Q?2KBPkKOPmGVgcgmaZ2aYc+sA3QmIfLAP+iFbQOWtb5wR/qH0Pw6gUOhfPTLn?= =?us-ascii?Q?3W6ephvS7dxvBjXnEBtLB7fO+uGD0tY8aRYmhFvsQqPygIoP/ADqr1rVrfOS?= =?us-ascii?Q?UgzND3/TtU2Q9Wzb99FlkGlTH10vc+zz7ij8AL2+0rMhZd4yYHmRmuzX080w?= =?us-ascii?Q?WZM6WnqEOIsr4rpjCGuIqZQqkBUFlWEtQxxq/3t1Dl9W7ZdVyxcoDoOJfWZi?= =?us-ascii?Q?1HX3JNMYTAoKolyZkSC32f0uYQXEFQ2zpYMJRzOTsocV3M6vqNWKlaH2LNgA?= =?us-ascii?Q?cu8QfE3kHPfO/JtMzCsbJn2JDtj8e/9wd0aEa8kPFGDIJMDIo+B/iVqb7kLj?= =?us-ascii?Q?G3RBTHaHGp18ltLZ2fk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9b09893-ea37-4b5f-4824-08daa1414f3e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 11:05:10.0462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O2tOlzDIJnXzX0wROytOmxmVgVB6XiXwikwUOoLkjX3sHX1V47BiyZnxbAgInwKgiM0SLWBxu4K7EFOEgQCmvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB5109 X-Proofpoint-GUID: utdqc5q26k_m9IBLTiH_R84sVwwguZNB X-Proofpoint-ORIG-GUID: utdqc5q26k_m9IBLTiH_R84sVwwguZNB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-28_04,2022-09-28_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > ShangMi 4 (SM4) is a block cipher used in the Chinese National > > > Standard for Wireless LAN WAPI and also used with Transport Layer Sec= urity. > > > ShangMi 3 (SM3) is a cryptographic hash function used in the Chinese > > > National Standard. > > > > Add these full forms in comments of the enums that are added in patch 1= and 2 > I do not think we should, it is just current description of usage state o= f SM3/4. > Especially that we do not put much effort into other algorithms, particul= arly with > 3gpp algorithms which are all over the place with naming and comments. Yes, we do not do so, as those algos are very common and does not have any = other full form. But SM3 and SM4 are relatively new and does not come up easily in search re= sults if we just type SM3. However, if we search for ShangMi 3, we get the RFC on first result.