* [PATCH] examples/ipsec-secgw: fix uninitialized memory access
@ 2022-03-25 11:29 Volodymyr Fialko
2022-04-28 4:42 ` [EXT] " Anoob Joseph
0 siblings, 1 reply; 4+ messages in thread
From: Volodymyr Fialko @ 2022-03-25 11:29 UTC (permalink / raw)
To: dev, Radu Nicolau, Akhil Goyal; +Cc: jerinj, Volodymyr Fialko
rte_flow_validate and rte_flow_create not always initialize flow error.
Using error.message in some error cases will cause read from
uninitialized memory.
Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director")
Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
examples/ipsec-secgw/flow.c | 2 +-
examples/ipsec-secgw/ipsec.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/flow.c b/examples/ipsec-secgw/flow.c
index 1a1ec7861c..c217b9e475 100644
--- a/examples/ipsec-secgw/flow.c
+++ b/examples/ipsec-secgw/flow.c
@@ -214,7 +214,7 @@ flow_init_single(struct flow_rule_entry *rule)
struct rte_flow_item pattern[MAX_RTE_FLOW_PATTERN] = {};
struct rte_flow_action action[MAX_RTE_FLOW_ACTIONS] = {};
struct rte_flow_attr attr = {};
- struct rte_flow_error err;
+ struct rte_flow_error err = {};
int ret;
attr.egress = 0;
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index 2d4a26c962..b66ff2b650 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -496,7 +496,7 @@ int
create_ipsec_esp_flow(struct ipsec_sa *sa)
{
int ret = 0;
- struct rte_flow_error err;
+ struct rte_flow_error err = {};
if (sa->direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) {
RTE_LOG(ERR, IPSEC,
"No Flow director rule for Egress traffic\n");
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory access
2022-03-25 11:29 [PATCH] examples/ipsec-secgw: fix uninitialized memory access Volodymyr Fialko
@ 2022-04-28 4:42 ` Anoob Joseph
2022-05-11 19:36 ` Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: Anoob Joseph @ 2022-04-28 4:42 UTC (permalink / raw)
To: Volodymyr Fialko, dev, Radu Nicolau, Akhil Goyal
Cc: Jerin Jacob Kollanukkaran, Volodymyr Fialko
>
> ----------------------------------------------------------------------
> rte_flow_validate and rte_flow_create not always initialize flow error.
> Using error.message in some error cases will cause read from uninitialized
> memory.
>
> Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director")
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> ---
> examples/ipsec-secgw/flow.c | 2 +-
> examples/ipsec-secgw/ipsec.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory access
2022-04-28 4:42 ` [EXT] " Anoob Joseph
@ 2022-05-11 19:36 ` Akhil Goyal
2022-05-11 19:41 ` Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2022-05-11 19:36 UTC (permalink / raw)
To: Anoob Joseph, Volodymyr Fialko, dev, Radu Nicolau
Cc: Jerin Jacob Kollanukkaran, Volodymyr Fialko
> > rte_flow_validate and rte_flow_create not always initialize flow error.
> > Using error.message in some error cases will cause read from uninitialized
> > memory.
> >
> > Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director")
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > ---
> > examples/ipsec-secgw/flow.c | 2 +-
> > examples/ipsec-secgw/ipsec.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory access
2022-05-11 19:36 ` Akhil Goyal
@ 2022-05-11 19:41 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2022-05-11 19:41 UTC (permalink / raw)
To: Anoob Joseph, Volodymyr Fialko, dev, Radu Nicolau
Cc: Jerin Jacob Kollanukkaran, Volodymyr Fialko, stable
> -----Original Message-----
> From: Akhil Goyal
> Sent: Thursday, May 12, 2022 1:06 AM
> To: Anoob Joseph <anoobj@marvell.com>; Volodymyr Fialko
> <vfialko@marvell.com>; dev@dpdk.org; Radu Nicolau
> <radu.nicolau@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Volodymyr Fialko
> <vfialko@marvell.com>
> Subject: RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory
> access
>
>
> > > rte_flow_validate and rte_flow_create not always initialize flow error.
> > > Using error.message in some error cases will cause read from uninitialized
> > > memory.
> > >
> > > Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director")
> > >
> > > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > > ---
> > > examples/ipsec-secgw/flow.c | 2 +-
> > > examples/ipsec-secgw/ipsec.c | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> >
> > Acked-by: Anoob Joseph <anoobj@marvell.com>
>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> Applied to dpdk-next-crypto
>
> Thanks.
Cc: stable@dpdk.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-11 19:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 11:29 [PATCH] examples/ipsec-secgw: fix uninitialized memory access Volodymyr Fialko
2022-04-28 4:42 ` [EXT] " Anoob Joseph
2022-05-11 19:36 ` Akhil Goyal
2022-05-11 19:41 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).