From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF9EBA00C2; Tue, 27 Sep 2022 21:16:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFED541133; Tue, 27 Sep 2022 21:16:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 88D3740694; Tue, 27 Sep 2022 21:16:43 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28RBDVMr018634; Tue, 27 Sep 2022 12:16:42 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2172.outbound.protection.outlook.com [104.47.57.172]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jt1dpbdn2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 12:16:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QNWH/TAfYcq/v/PGieK4MJ/xdWNrEPVk9Dg36obqrjSToyzkpmgnFcvhcHn7whv2iRQCTy/ABajgfmb8yC8pjujk7HXgEaMMvMfbHnv6JzVdsO1hyxeXTPQeZWJoPDNPp/fNgZX5Bz7chmoXhV6IFB+vHnk2RQwdVAuSHMos72CC9TMOuZ2uQZ0SpEaxjNe8J1KrYWJsit+aSJpXnZMdx5MrfcjRsk3N2rNtONUBdMOIZSpV+XE/Oipfa+3BwJYwYKwUmqDOYNz7V7C26PzfgBldrponaKb5HK6yPsbv4vlUWqodUIBOgddx2sb/fhyBTMsJxJuwAgHCdAgP+dG5rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7F7+Aa6YY6gjgc3FKXTqmAa3h3ijEfcAtAn6sXWWKog=; b=QaY6TBaDD+ohNR9lKAGYbtDUC3sTTRamQbiBYL+7V6Y7SoMrofyRdQpOn3+gi+4RnSioGgoU4AAVnWB7ga2RBEhSnrxJkuJnv/CR9K6FJU+wuU7EmVnJBXxlzJSScSy0MiK1rQoFdtmga6wX2EPycIMezPGUna8kngFkY4IN3B4Beoifj9HFUuQcvqNBf6DWO28tVPi3fXfEcKUrHjOwo18fjpfBvpnv4KavhKiM7AnySzfML2NYwTo7GnrL8uQZgLFBS7yPFu3C6luCJRqnv64rnwMH1qmtZXBzaGVBX14PUeMlKGD+62mLt5yMjJDAiaqQEuSfU+Pu5dBS40x9GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7F7+Aa6YY6gjgc3FKXTqmAa3h3ijEfcAtAn6sXWWKog=; b=Ke3/ScRijnj8gqgeS5+OGu1DIu34HMcVPEMMpZ4sScjqy4jx0c7HdaJM8u84Ihm41MOFhfX6PRfB6+FS7TWp0ZfOXAyeZD1sUdrfxX1i3mgBlqnSr+wgYOrO1V+7OmMqh9NyLDrbqINVPC6B4ZefPfgaD3svDVE01zx8X2q2wNg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SN7PR18MB4093.namprd18.prod.outlook.com (2603:10b6:806:101::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Tue, 27 Sep 2022 19:16:39 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5676.015; Tue, 27 Sep 2022 19:16:39 +0000 From: Akhil Goyal To: Anoob Joseph CC: Aakash Sasidharan , "dev@dpdk.org" , "techboard@dpdk.org" , Jerin Jacob Kollanukkaran , Thomas Monjalon , Hemant Agrawal , Sachin Saxena , Ciara Power Subject: RE: [PATCH 0/1] Add security perf application Thread-Topic: [PATCH 0/1] Add security perf application Thread-Index: AQHYrTbILTUNLo3EQ0mh0YdmXtVBKa20bRfwgAFwtgCAO9umAIACNQOA Date: Tue, 27 Sep 2022 19:16:39 +0000 Message-ID: References: <20220811035933.802-1-anoobj@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SN7PR18MB4093:EE_ x-ms-office365-filtering-correlation-id: fcb592bf-e380-4f09-a0ef-08daa0bccdd5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Bzlhqhs5OchfMRYr5e0YNpB8Vnpg+mnSeNd6/8haoL3S/ZQ/e+y9Sh8qjDcS1iWb52ix37Suz+eq+NSVPsCvClSQum+1Lrcsa3koZQrYm+aknMCnarIm/+W4gy7IQ7RIMzC4j1o40Cigca+fcPi52kd5Nk6OIyjP+f9vGqpuqkmgEFHCrfFT0RBinB72vUOUv/s0l/VvmAx179m37vuVBDYCkY43FXF2SUmgGYSktZkFvpbTOazVf94T6meA3Fg9E43LBkGW03hxLEmoB3FqEl6E0cQDCbxnLk5PxoV3I6229oLbfPPOVLxbMZNpKMVwN0qSCibHDRBimE3Fd79Hn/mQM1lo+oczI4vdwtqrQkN6CicRBZFc8m6zJNcCya9TTCGSlhOEJMPd00buJf7lEO0GlkS2Kc1mk6euciIRGPivYMHM5m2y2K7+i6it8PDPI1FPLTiGNtaNn/vaVNqPECSbX+7lgF4XI/47grZEvl7B2tzsbq0YYUgmJrvKjqC2sBUN2hFYHJ03xJ9e/AhNdBNOAAC6X9alujWHafxsN6kWoh1+XRK2AU1jY6+QmokDem/S3nSIci66P+wL/gbgjzhvznCSRw4CSOTBgyOtB9OioGYRbZMqjZu7qVTGWtey1bl/qeaQKwDVs780j5IN028+cePltSP8rep9E/xuEj2vc3otPRT6ccb260M1/anuPsunBz6zFjXJQfcNV3000YyfsyiMSmsEPkBIpytqv0N9VIGpty9IMZA7LghFCvQw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199015)(33656002)(54906003)(66899015)(86362001)(66946007)(15650500001)(5660300002)(6636002)(83380400001)(122000001)(186003)(38100700002)(76116006)(9686003)(55236004)(26005)(41300700001)(478600001)(316002)(6506007)(66476007)(7696005)(64756008)(71200400001)(66446008)(4326008)(8676002)(55016003)(38070700005)(8936002)(52536014)(2906002)(66556008)(6862004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4Zu4hxb1X3NLLIDPZAjV9+u75/cK6TyuCqhxYIQAssqZ01fGEFPl6MwmuCa5?= =?us-ascii?Q?e7/HGZULOqej4iwjbqvLeXmElL8vxq5keK2T689llbYMAAL95Sr2hV7vurP4?= =?us-ascii?Q?hPwnaitD6JhpbAUxE90cvtiRzp/ZpJmXI0wBN8e0iRw8PXzXtEZ+2fArbCdl?= =?us-ascii?Q?cSp8OiI0mF1RJb+YMBNl9uLdejMOdL+K33r9jG4hx8AbPGMbpuT3LnOgyBvs?= =?us-ascii?Q?b1llUW5h6yq2gO+JfmMftcUC+al9Wegv8pXcXJzCltKUQ/omkyh/GIcBvMuA?= =?us-ascii?Q?gdJOrtD+L1DAJOzIZ8uTsWQ0r6x1uQVzSfD5J9ipSaLjPkAlw7ujF5+H8xox?= =?us-ascii?Q?SbMTId4QRWtQ7GoBbCd9VpwuvN923dELfkC+KM9cew1+54+yvTn2EyLNg62b?= =?us-ascii?Q?/lkclzHzVQzLZ5xXQBwxyxmKFyKoT+R0pfHIXqHRWd4p+JUYXvkNGicfT7LK?= =?us-ascii?Q?lV1K0uATTaY/JQ+YLXJVPkcsQ0NhyeFoWcxOIoCk+xlghnQmqeoYDgz3z/Ko?= =?us-ascii?Q?W5dI1zzX7uK3MMATAaiVns/VwpAdCynkaaVhPAkOlX3BK5DZiWjMqMVZlcRe?= =?us-ascii?Q?PQrFexhMsy5DVAk64ceaFMWbH3Ho+ap6LgOl8imr5b5EStmrBxtebVl7+2fM?= =?us-ascii?Q?2K3F7InIxvzBJg2QMAy9mFDnbtqGPjbVMo3exQ033YigbbX+qvIgCt4Hi/AZ?= =?us-ascii?Q?tqBbuOKiYeB4h84db3xixupJumRylIyOO8mr97WXaEo+9AEkuBXjSRg0X87V?= =?us-ascii?Q?h4414otHk9bDsWIM5p185j9fJhBnMrswFEQTayfBCncvkZJ2W7OOrGE0gPU2?= =?us-ascii?Q?o6mwXx+XBA/i6QXT3JAatYtP/ONiqicaOCZOM+8Vc09EOIxUqeNj+VXiweZz?= =?us-ascii?Q?gUS4hJTjTb7vs5EUGMnO7fdXZ/rq00sap6OoBy1nblLx6v5s0l8V4xuMYc0d?= =?us-ascii?Q?/VSnffdhiukLfGhiB/8NsOuUCvUmac0QDV1fWXbyTPFGdkrXUyqI3fN3aiZ5?= =?us-ascii?Q?xxgsZbwIGQLIK49Qql4UsAq2ahVb42NFEtnsCC5TdmOHqMwhig/NjdJgzoXO?= =?us-ascii?Q?IowVuQvI0h5tXonfw1rR97lcCWy+k4U5dlNBOFkm63Zzc0CKoGm+j/6uNWE3?= =?us-ascii?Q?80GDiW9GxhogZ6YoDBtwTw+J0y7iY3zR0L1sJCJe0ng10uEyTkj22nk+0+XQ?= =?us-ascii?Q?8uTawj1KeRr+aRMyD3544G9mQrZcQl1gkWoGQj/VQW6O8CDA3lo+3rBacw1T?= =?us-ascii?Q?/HOYpueBBNwfq3/7IaYCWbeETzO4SfCIkNElC/4E/CZeJAW+gPV0OGe8lixj?= =?us-ascii?Q?TYPxz74qUGJss3TWAsplIW7VUl7RQwRKrkgNoasSkRsPczJF1gSZ/Ucl0w1r?= =?us-ascii?Q?AkwftssDUZdjWEMsls2zGzudM+obMGoouspgqjWSRCemiNrtFENJAQAueE4P?= =?us-ascii?Q?aj3RV0JAUpbFwJShg5JCgdVrEFSBBxTUb6XA/OgdP+hYni6vp2IXv7aGanml?= =?us-ascii?Q?W+dZKyFGGSqkFupoFbD0X2N14mFL0ThMY7Z3Mp193b1sS6rM5HI9oLrAxzpC?= =?us-ascii?Q?bVns0MKb1BtWGcJC20I=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcb592bf-e380-4f09-a0ef-08daa0bccdd5 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 19:16:39.3815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e/2O052CCqVbyYfMHSxTYBM9zJgN5RING4l5e9J0m9zy6yzYnA+MGalPR4IGgMRgruPwib4k0btUv/ksznH0VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB4093 X-Proofpoint-ORIG-GUID: HVE803CtH6SPnNJcEa297KbDunu2xleB X-Proofpoint-GUID: HVE803CtH6SPnNJcEa297KbDunu2xleB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_09,2022-09-27_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, > Hi Akhil, >=20 > Do you have any further comments? > > > > Subject: [PATCH 0/1] Add security perf application > > > > > > > > Add performance application to test security session create & > > > > destroy rates supported by the security enabled cryptodev PMD. The > > > > application would create specified number of sessions and captures > > > > the time taken for the same before proceeding to destroy of the > > > > same. When operating on multi-core, the number of sessions would be > > > > evenly distributed across all cores. > > > > > > > > The application would test with all combinations of cipher & auth > > > > algorithms supported by the PMD. > > > > > > > > The app is similar to 'test-flow-perf' tool which captures the rate > > > > at which flow rules can be created and destroyed. > > > > > > > Is it not good to add this into dpdk-test-crypto-perf? > > > > [Anoob] IMO, It is not good. Following are the reasons, > > > > Dpdk-test-crypto-perf is primarily for capturing crypto operation throu= ghputs. > > And so the framework allocates minimal number of sessions and the datap= ath > > function pointer etc deals with only one session. The entire framework > available > > in that application is for populating crypto_op and mbuf, which is not = required > > for this app. Touching that framework would mean throughput tests would= get > > affected, which I don't think is the right thing to do. And for PMDs li= ke Intel's > > (which don't have security support), it would be an unnecessary perform= ance > > drop. > > > > The proposed app currently runs for all supported ciphers while in dpdk= -test- > > crypto-perf, it runs only for a specific algorithm combination. If we w= ant to > limit > > the functionality of the proposed app to match dpdk-test-crypto-perf us= age, > > that also calls for a major rework. > > > > And the only thing that can be reused is probably cryptodev init & queu= e pair > > configuration. As you are well aware, security device can be cryptodev = or an > > ethdev. Dpdk-test-crypto-perf doesn't have support for initializing eth= dev and > > rightfully so. Adding this to an already complicated framework will be = counter > > productive in the long run. > > > > > Can we add as a separate .c file, say, cperf_test_sec_session.c in > > > test-crypto- perf folder and use the existing framework. > > > > [Anoob] As I mentioned earlier, nothing from the framework can be lever= aged > > for this application. If you insist on not having a new app, then all t= his can be > > integrated into dpdk-test-crypto-perf, but that will follow it's own pa= th from > > very early stage (mempool allocations etc need to happen differently). = And it > > would mean adding more command line options (which is currently at 37) = as > we > > add more options for measuring security perf. > > Are you planning to add more options is that app? if not, then adding just one more option about nb_sess would do trick in te= st-crypto-perf. You would just need to add 2 new functions (test_security_session_perf and = sec_conf_init) in a new .c file in app/test-crypto-perf/ and the mempool_init is being cal= led from cperf_initialize_cryptodev() which we can hook to get the nb_sessions from = the command line arguments. I do not suspect any changes in datapath - so it won't be an issue. The point is not about the things being common in the two apps. The point i= s whether we can accommodate in existing app or not. We cannot have too many different apps. We only introduce apps which are not possible to accommodate in existing on= es. I remember, there was discussion in past about having a new app for testing= multi-process for crypto. But that was dropped as we do not want too many apps. I agree that common part would be init only but it can scale for non-securi= ty sessions easily. Regards, Akhil