From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5C97A0548; Thu, 2 Jun 2022 16:27:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6947440691; Thu, 2 Jun 2022 16:27:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 40EF14021E for ; Thu, 2 Jun 2022 16:27:27 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 252AgxgR025897; Thu, 2 Jun 2022 07:25:22 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3geupu8uqt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 07:25:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RcP6Fl6SgMzCVHnpNcx4M6uHRaKdKmUS7SWc7EKdAQRPO0LWbPjF+gO6Ss9YdkusNkQNEDBCoRfRQod1fLOVntCE+NITLBeXZ/BvcsHXt6fuXhIf3LAESkSUW45fUeNHOX2yrvuYB/RTsW/yPctTQgQXm4KsB+AMNmzj/SavFR3tDdcGLdMuwY5ZksJ1w6RBN/5mBCHsWNK3bNtVwPSvOelIp5a2p2AndlZxyI1hrE+ZuiBzGGldFIj9JHkfrNd+ZBcpSR2Z8YMVQ+xaO4ko3TDNRYAeSMGQi/kkh+BohA9flEk8s44wOyH9noxxQffn7OIsVD9n6zlpiCXEUfeKDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zU4kgp7gG1R7trmbILoJZHd0HCbhDYhDu33MbF+2Xwk=; b=VZ3Ofz2mJuaPVCBIiLtbYrFniBJ7BaNakOuPa8Nr/vTJC0olM2B2J3qZiikS39jUk+WdrRB4jxCn8XIAlnKkqzD2euiD72gZ7ZBLyRIWOR1EK6rdsJdSbtli3MgpPFuwjc7SMWe0Aymug4cE+1r2wJRNeqxkT7j4h6mdpwLCsx0WL4ihZhoUNuvaaREHelAr1sqei/B8kDyVe69vvThLLmHTZ9bFdTTnHM4beGZ3jINappXYeVWWeQDE3b6PTzjO6xS3UD4Y+Kgt9brM0Mqh5VFbNxaK27LlHxAvX7iFVc3+V7JMPv93uFWPDLl0TkdP/agg+DGGvc0tIcwDr0pCtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zU4kgp7gG1R7trmbILoJZHd0HCbhDYhDu33MbF+2Xwk=; b=oP9eC2Yr2qULKIh3ESiybH2zWV1C7FpMDCfQp/eEbM+LY1xrZ8lxcOxE0/5qIO1VWnBEIHhWKUgZieVM6SA/SJnS2BeeOpwT5KRm3bYstzwWFrQs2gPk3nn8pTujCZwbumMs3KaXIKGekZS57FkXmS/hJWjQBTapYOnC3zfdCxE= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BY5PR18MB3124.namprd18.prod.outlook.com (2603:10b6:a03:194::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 2 Jun 2022 14:25:18 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%9]) with mapi id 15.20.5314.013; Thu, 2 Jun 2022 14:25:18 +0000 From: Akhil Goyal To: Ray Kinsella CC: Arek Kusztal , "dev@dpdk.org" , "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Thread-Topic: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Thread-Index: AQHYdZ/bx0HEzPS8JkuQdbyTlyoHTK08HsiAgAAOAgCAAADtIA== Date: Thu, 2 Jun 2022 14:25:18 +0000 Message-ID: References: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> <20220601090249.86865-7-arkadiuszx.kusztal@intel.com> <87y1yfp2mw.fsf@mdr78.vserver.site> In-Reply-To: <87y1yfp2mw.fsf@mdr78.vserver.site> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 502cf79f-76ae-437b-91dc-08da44a3b800 x-ms-traffictypediagnostic: BY5PR18MB3124:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B79UCzEb4NqDLVejIztMVPkUtnkkEJQNUDxxRmNNpgPSwi9+FL5+W1zdOxYhTOE1Ti+AAT4B+mvZIuIEaJ14HpHc/u3VR9Vzpn+7y0obRSRWMAMcVyxaoVbbK7o1IYGiUPFfOOZfqxRcx3DSZTCaJdUHxj8P0NDLhm6xeLrp4vLlmFPowCG2suMzqeFdReUHDdDmSIoXAN/pyK4XynE+WUDVIO6LxcLFXPgyGX20wC8eZzwoDFf0picMYWjWAtn+eCy/rnFBYypoJeiIBeZv+uZWQP5IXLxSy/Lx0xdfnjxOFR/2sOGjW0mrdF3fuYWrpH2ofRT5qnzOZrvjhIQJ04JitWAt/beYRXrdutXuyhBCEjJ7ZCTo1VDRL+K//S7m1f6x5SHtsgbkspmg/uu73Bzdjo8F/H2z/417BTj/MD8LqmU1NA/97TGD00IKTvPEfc5KSCCMxYBIP7pKvRGq6hZUIlkSvS2bOPAqRDYlC9rDfkS1tFIn5Ogfqqj/mPYRPDPzc7q0yOciU6D/2o7IX4kiUJ9pZOLApH/qIZVR1AdINWrmGRdRyGNhi3v2yikdP2Yz7exLOH3LwAHjm7Famo00n4v2zPT/Aa/jlsZZAvkgn1CovCdz/NRr1IJ7IjxIZ8lQ/S2YMWSWG6mP8kbOWAPvbp+8vG+vH/bsxx+z90Iu9YM1rpLKU2D3O8z+rPmUHChgjCvdT6jusSzd8I6Nyg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(52536014)(8676002)(55236004)(6916009)(54906003)(26005)(9686003)(186003)(83380400001)(316002)(38100700002)(71200400001)(6506007)(7696005)(4326008)(66946007)(66476007)(64756008)(66446008)(76116006)(66556008)(122000001)(33656002)(38070700005)(2906002)(8936002)(55016003)(508600001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p0IxKQIaxNOvk3qs8k8e75JH8h29Uyo4rdaynpkofocyhfYGneuG6mkwZO9L?= =?us-ascii?Q?zUnlaIpVEfKf4QfvjBuWT/P5dm79V5Rsa14jwcBQ5GtRTH6Dm17yzo2Z1RZ/?= =?us-ascii?Q?qnngMOuPUKOap2dDyNYt6se+2toQucorj7nc5N6UifDJrcjo/0deCy5fSznI?= =?us-ascii?Q?bxxA6/SJwJG1uWQiSUUMfajyuvLiNOeXzG/bhbDJAheHQTsbipoQuyg0Q5rs?= =?us-ascii?Q?PoJzCS1lBdJvXBpgMxG55f6x9AJbTVk2cfXVDHsdrpMECi26CyNHYeQlE1Kx?= =?us-ascii?Q?99ZLz9llgk2ubnTWgq7ouulWxHvLJlYTpRB/ieJ+13hOnEWONLFH2INU0PVk?= =?us-ascii?Q?Ojw9rwGqINrukbAKU26mE3ZmgSCKwKLDLVGZQLfqaJDNlYNOnNrFWQEYbxk6?= =?us-ascii?Q?ciDjS3SHfJtUIC2OmqFl5zgIS7NKaQ464tnQBOTnQDNDurGu/B82k98RZ2ea?= =?us-ascii?Q?1rlAG6TrzRUVd/DKFAO0o6Zv5ica32cHIqx7uRraEDmpYkiGyCuHS0hxwJWu?= =?us-ascii?Q?NOMqN5o9uOF5axChhzVS/gQ9PpBrigxB1CjhCcEbYTgQ6++0DBN3KE/b/z19?= =?us-ascii?Q?1QNKoHBlBHqfyEXdU7xQqPsMs1D4EdthcDg7UXB/p+/98sFAhDmQAoX2Pgx3?= =?us-ascii?Q?TV8Ylv+AEn8NKHcy6LIkoRaq+QVWv7HRkY5bDDdEqaw+9cV1mRgaxlfWukqs?= =?us-ascii?Q?5heK4VYTwsibHqh+hWwm74dof9c7XGB654K3vtWgsV/taXegTKQoTCwIIiUl?= =?us-ascii?Q?+WiuYe7+fqILd1iQiJC3ogx5cF37qNhnKkvcvJlnILkOwS2Wlu1a/9ksNwNX?= =?us-ascii?Q?FyEms7608Tjg8zkc7CUwsWFaBg1vyLYFSun2Ttrg9dSf1JEL7Rq/8h1fW00w?= =?us-ascii?Q?vHO0voGUBiQru/Vx3xY08aBEXQMfsq6zEpwAXo1y7+bKkt8sc3Xq9Fav8f9Z?= =?us-ascii?Q?uh6hoDoeaCakffm/0woH92+TNfK7RE9sAIJOTy8jYe2vj/NYDtyb2RY/kcx9?= =?us-ascii?Q?RGCEJzVxDPU+D8Doc35m1DgiQQB7bsKTgr0NRS8J7mmDbZ8RwXYYk7r8FMOt?= =?us-ascii?Q?KPj0kw9jXCtURcywdA1koW677XaNlGIF+JlKWugi1ZsWps17K0BrNy4dHnke?= =?us-ascii?Q?xxUamzFoMcpSjh8x6ri2zWJ6+840XN1QntMGLqKQ2fzzHzL9AqU11+5bRUg1?= =?us-ascii?Q?TYnIrXoV5MSLaZs/bGEaOLw33sLayM+FtfOjaXtHxjof44XgQ9ZOmvFzufId?= =?us-ascii?Q?EIxT+qCHVYiEKqgPncw+XSpp1nVAZaPp4Zi/LA2VYcHIh7xapGmplzmqJKXM?= =?us-ascii?Q?st6udvVqM9PdB1I1DMBkwn+fKip62C7Oxch8ubMo1thOA1slAK8eJhW7lr4r?= =?us-ascii?Q?RhRPAg+MfM81XDnXRoLges1N7CPGU68mO7OC9aY/LcMBaXRGUYfcP0Gn9OQs?= =?us-ascii?Q?dE64mGbje5/194Lsgu97kWtVlN+UwtllTZ0KpIBQtWnq5qgUvfN7jV5VLk4L?= =?us-ascii?Q?NXeO9/T7tI99UfzEke/1ByXBq5fQZmjQY8JY/7hVC9vSIHBDXCXWGxhe7vKj?= =?us-ascii?Q?2ZPjr84mVbSzGe2SA4UtgV0XEVt6aQzI5dMw/fr3l+D4gUiXk6IJmDcZqTFc?= =?us-ascii?Q?QnDzu5CuC05DWKKiPDAICiGVSJsaT+iii6anDqnXkJ9XzUP6VDDwAcKWBCKo?= =?us-ascii?Q?UW4WOpQaSq0iL4OPWiv2UxitfYJbtj4dP0Ee+73K2gt4I3lwGpLUhkHUEtG/?= =?us-ascii?Q?wPjYv+mYfw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 502cf79f-76ae-437b-91dc-08da44a3b800 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2022 14:25:18.3280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zH6Y/9T++PZBF3UGfDot6ze/pA3PH8i9+fzuqnoV7z3+0+25A8TA+dBM/veNG/ciV7yl3TJyhbAe+6kXIeiN7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3124 X-Proofpoint-GUID: PMmMCuQntp1j037Kpvc0dfeMde01i_ml X-Proofpoint-ORIG-GUID: PMmMCuQntp1j037Kpvc0dfeMde01i_ml X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-02_03,2022-06-02_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > Akhil Goyal writes: >=20 > >> - Added elliptic curve Diffie-Hellman parameters. > >> Point multiplication allows the user to process every phase of > >> ECDH, but for phase 1, user should not really care about the generator= . > >> The user does not even need to know what the generator looks like, > >> therefore setting ec xform would make this work. > >> > >> Signed-off-by: Arek Kusztal > >> --- > >> devtools/libabigail.abignore | 3 +++ > >> doc/guides/cryptodevs/features/default.ini | 1 + > >> doc/guides/prog_guide/cryptodev_lib.rst | 7 +++--- > >> doc/guides/rel_notes/release_22_07.rst | 2 ++ > >> lib/cryptodev/rte_crypto_asym.h | 38 > >> ++++++++++++++++++++++++++++++ > >> 5 files changed, 48 insertions(+), 3 deletions(-) > >> > >> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abigno= re > >> index 79ff15dc4e..6d174b291f 100644 > >> --- a/devtools/libabigail.abignore > >> +++ b/devtools/libabigail.abignore > >> @@ -27,6 +27,9 @@ > >> ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is > >> experimental > >> [suppress_type] > >> name =3D rte_crypto_asym_op > >> +; Ignore changes to rte_crypto_asym_xform_type, asymmetric crypto API= is > >> experimental > >> +[suppress_type] > >> + name =3D rte_crypto_asym_xform_type > >> > > This exception does not seem to work. > > Thomas and I are getting ABI issues even with this suppress rule. > > > > [C] 'function void rte_cryptodev_info_get(uint8_t, rte_cryptodev_info= *)' at > rte_cryptodev.c:1582:1 has some indirect sub-type changes: > > parameter 2 of type 'rte_cryptodev_info*' has sub-type changes: > > in pointed to type 'struct rte_cryptodev_info' at rte_cryptodev.h= :503:1: > > type size hasn't changed > > 1 data member change: > > type of 'const rte_cryptodev_capabilities* capabilities' chan= ged: > > in pointed to type 'const rte_cryptodev_capabilities': > > in unqualified underlying type 'struct rte_cryptodev_capa= bilities' at > rte_cryptodev.h:198:1: > > type size hasn't changed > > 1 data member change: > > type of 'anonymous data member union > {rte_cryptodev_symmetric_capability sym; > rte_cryptodev_asymmetric_capability asym;}' changed: > > type size hasn't changed > > 1 data member change: > > type of 'rte_cryptodev_asymmetric_capability asym= ' changed: > > type size hasn't changed > > 1 data member change: > > type of 'rte_cryptodev_asymmetric_xform_capab= ility > xform_capa' changed: > > type size hasn't changed > > 1 data member change: > > type of 'rte_crypto_asym_xform_type xform= _type' changed: > > type size hasn't changed > > 1 enumerator insertion: > > > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECDH' value '8' > > 2 enumerator changes: > > > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECPM' from value > '8' to '9' at rte_crypto_asym.h:80:1 > > > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END' > from value '9' to '10' at rte_crypto_asym.h:80:1 >=20 > Ok - will take a look see. Thomas has fixed the suppress rule while pulling on main.