From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23320A034C; Thu, 24 Feb 2022 20:02:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9D1D41143; Thu, 24 Feb 2022 20:02:39 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4E4A44113D for ; Thu, 24 Feb 2022 20:02:37 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21OHMmc2020124; Thu, 24 Feb 2022 11:02:36 -0800 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2176.outbound.protection.outlook.com [104.47.58.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ee5tpu3rb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Feb 2022 11:02:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J4zpH+cIt9hVfFy1OltLuZaEZ3+O5tNldL5OH80cZgUuW/pQ8WLi8YCbP8RdGmeZE5zWLDwB5t87wtxAXoEn26nRwsjHP/9RH+aRBu+Hj4wS1sXtGsZOlTuhBa1SMS7d2XjDM2rzjK/O7Lg5PORE7J0ji6TiU4Z64PNI/KzbT7o8YGpj4XWXcZv9HBJ86BrD+sQqJozQex/6nzHSgVuh50/bDK6tuWFJj5QIzVSm2MrILk3SdNmcRay39Sm0ewRF7Cz1SY3e1sUGLDAVM4eBRGU5RmXVXkNeoB7IHOALUo5Z9cRVHJHzTK67Uww/76mWHM5lrz2fUxVccn2HsYSv7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/BYnmFib5EPEZWYZLZPth4grZ4ggAYGn0cRsGf/ciUg=; b=Rm92vVbZh7fQtOkOZWoo+TLpxRroq0qhKiqUQbRDr62OmOzC7xvtk9Vw1pNfMBpM3eDR0m3BYj68DFCZCdmKPn9N11NdnQExzNDP3FBfyZtJdCd2VeYnKmxcGNMDbEbHNG/5Vxt4N9F1qHOrfRJiSfuXcS9WT2t7VNU80ufhm02hxbLLxm2Wdxl8+74WjSIhIVgg3No+Mi1d2PqWSrIpeJs5ZK6jWttRY72+p5bnTjJgfvgGsTiN1UgY8BQU9dVazm8p+yQ0xnJoxN7EuCcbcCACF1stMz4t0W8HUpYtcVnkoz1ZhYBhCjjUmYAAsMLZMKUNsiUwNm7PbFzxJqyxUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/BYnmFib5EPEZWYZLZPth4grZ4ggAYGn0cRsGf/ciUg=; b=IYVx1PXoKSTG7cDrf+lVhWdrwn3G+nb1o99yyLLB1pZl3kXsKHaqK4LHwj6yKu46Ni3X9u5U5BeoOAAOL03H1h7ygeHaUnk/qZcXaK7pDAjciswr1DV0qOeZMbCpaIkSOD5sQ8PKxAuB2TD/Q1Kw8ciUaXWw2Cq5E4qTsE1Bz6c= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SN4PR18MB4870.namprd18.prod.outlook.com (2603:10b6:806:1ee::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Thu, 24 Feb 2022 19:02:32 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1c79:10d9:2997:cd79]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1c79:10d9:2997:cd79%9]) with mapi id 15.20.5017.022; Thu, 24 Feb 2022 19:02:32 +0000 From: Akhil Goyal To: Kai Ji , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Topic: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine Thread-Index: AQHYJL4EORo6NVyl1EiyInoFeuBd/6yjGEFw Date: Thu, 24 Feb 2022 19:02:32 +0000 Message-ID: References: <20220218094408.49290-1-kai.ji@intel.com> <20220218115124.57745-1-kai.ji@intel.com> In-Reply-To: <20220218115124.57745-1-kai.ji@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5496092a-8cc1-4735-39b2-08d9f7c83641 x-ms-traffictypediagnostic: SN4PR18MB4870:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xoJ/AtE35C0eIMnBCU4gR6zYtvRTcHiRlV1/8ANhkGSlk/jlVG5JRjOCHNlUb390CpztB0/+cpBfz4GU+vh7n9ckzCFNxLGnRoBG+XI7fNwPJegrh9V301O0+62ca0VLJYihPV16zFKXmqX8+XivcZXgEusfSR6qhFzmOYtltiIAO3kXJfFlJ6OcmK/unFfe8zRirRF77tdd0krnGhHQGBuSzg3lkbZfpJEdIkcsVPq2fAH1DBe7b0G8VB9pRF9jGbPz9wBTuAO3w9Xf0UsBrzuomkbxt1whXer8t8wrD2RwwoNKljEtjm8M8euxir0pExV0GCOdft7ENPODAe7hiMSzGWjIYIzkAic/QkbzhtBndARcHREFmWOnMFzlm/sVdskK1xs/Uq3e6bOXWfIuqf7HH6Ne0Xtg4MOz9gmihc7RHLOJNeyaaYOKdHOZJJ9F6hSSAkle3Br+bBn5SLDKYpJjQI3tUXtVTpg4Sni/yl9Mxs48Gck7YVX8iaIsCxhsI0pcMmXs2I6uJhGxUiwzacKOpLCVBbQCTtwVMSY6oXG6PqJA7tkCDQn92nk3+9KHyuJ3kiBT+rf5lGXTooH77pRwAsQ+iq88v5+rizZG0G0+t3Wn2yFMbklMnMBz9Xg+cdYBjMLsaYmVh80hKPsV3VJar5AS2KizBhkBVcU6QDcFchdzTgQ53uT0hbXF7MoyVMTlySUYmk3n41KNKa3aBw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(66946007)(55236004)(7696005)(6506007)(26005)(2906002)(186003)(33656002)(76116006)(55016003)(66556008)(66476007)(66446008)(86362001)(64756008)(110136005)(4326008)(316002)(8676002)(38100700002)(71200400001)(122000001)(508600001)(38070700005)(52536014)(8936002)(83380400001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+6I+/tMA0z3dnCUraGWFE4SLtUR4LrDtYD30mcSA9ZqB/tuX9jI7ZGDGxjhH?= =?us-ascii?Q?IswbiazkRm6Ae7a9KmgpS5XgTDHDEyQRrc8XIE82kNsOqNSgEkSJ/q9SUMZR?= =?us-ascii?Q?7Yfd+vqMxtJGbToLcAdQZnAPOlFPhXl05gImb8V4F+e8lUJtzzHN8hHXT8dy?= =?us-ascii?Q?p8+Fr9kpiQ86IgjVPW214WjHyi80LNnkzyK7oGE9WjtGUI3TFoL5AY0zgcTS?= =?us-ascii?Q?TANHDP8z9v85Z9aDnnW5ImfZLfIEr4jUSJjnZ2gUGrSTXzS1tVUTRjnfkY9Y?= =?us-ascii?Q?5i1Qx7uR19iThjDvArv+FqIuT3APfu1k3D4MCn67LUHbeV5ZmMKDNOMF+CzV?= =?us-ascii?Q?SCFgvMFg1fsKNZ7gD6vieM/eDvc0ZZsrrDweKUlTYssUt7nzI7nHuU2JbmHf?= =?us-ascii?Q?RFZ12fqJlW1CmuMJ0fiaGbQLfduZqvTpdCBEyHDS3MueYUcIU/4n5q94Ijjc?= =?us-ascii?Q?8r+aMr2ftemZy+6wev3FCcevhcXLH7/2WoBpuwBr9wGjUKbdAweERBEjMvUK?= =?us-ascii?Q?MtJN2GJx7QBq2hGv26PmoLj+So+oZepXvIXr1w3KkB5JmFUr+Mp4H0cTYQbs?= =?us-ascii?Q?RgpyX94Uad6uM6Uyp8C4ERkOfItk6NVLzoRiZk45zopjl6PG3bY/hyXcRNTY?= =?us-ascii?Q?gQv1Eunwz3GufK9/RDhXd2/bBTPWu4xFzXn2Jcogva97r4C9s4F6aY3Pm3EV?= =?us-ascii?Q?DX+0qUwE98R5CiZqC3xeiwZ2fL2vj1qDFDb45qmaf9u5RnpJFF33neGx2U6M?= =?us-ascii?Q?FzDsqPbnsliQpi29iV4j6vkUfhxazlgdWBTm/9NBrDWBKWmE29XJ+ffTr0PU?= =?us-ascii?Q?f5dKNx8p/Ou6SyUT/IH30qwWJ2A53GCCYgXiSiYZd1rMY+U4lu+oAjSIGgRM?= =?us-ascii?Q?DZV4EelWDJdOaGnlZlhaE7QlxrIFyazlOjWZU+ZIjpaQRCLaLYWDD28nB79a?= =?us-ascii?Q?qWTPTL1RnGYCtMaiC2V/ApE3pWHzmTHpImKOP1tmx5QSgiuoRjG43gcajD78?= =?us-ascii?Q?mnPUzpI8BB+jZPO6b+9iwEditxlB3567ldZXvJAUT/BRmTrDnkl7pCTDI4t+?= =?us-ascii?Q?Cunq8R1jMwwkfFyhGEil7wftJpD6S09zYJs4m/sv3/lf7S6Q9XKQkRAjil6x?= =?us-ascii?Q?c/luN5WmCV1WXJyCR+/PXhMjUcUC8KC5i7+oofvZILYbRv3siOng5o4RTdqs?= =?us-ascii?Q?7sohWuyvGmQNBetmpo1Csiqeu3MUNC4M4x/7uMZ2Nb6nmy/PIf0fbEMtTT4j?= =?us-ascii?Q?4yDvvwF1GWSlajPDE801jb0TtV7Uy7AoBYcWJ+5p4Q4w528PNQ3AO4QmsGWJ?= =?us-ascii?Q?aJ1PLQNUNpfJXOM1IJPaIoztn5YQl8klqlDhLdlPTW517/G2sdttbZuvcv6y?= =?us-ascii?Q?otisoJZDz7gs/qW7MvPXyEo3v4xyOtasvSdHQkICGt/Q8xEXeeHuOtxt1EG7?= =?us-ascii?Q?gINyw+EayRakEyVpK0/mOhq6HxLAX3ucDKdsA59QZffss8xpgRNC+P474aIE?= =?us-ascii?Q?AHR83p29CAbgBycdy18jdxAcyTsQBOJ1THlO0geRNjwYjzXkC7saSUzdKQp/?= =?us-ascii?Q?NM+rryiEz5j9a49Xmi6KWf9vfykKHjKrF/FYYzxzkRyQAsxzWa26SmOX6cTx?= =?us-ascii?Q?Oze8kTs/7YwBjTwsAJvJ2sA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5496092a-8cc1-4735-39b2-08d9f7c83641 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 19:02:32.4775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dToz9Yx1lLYOoMfLmu1fVfDackiTyQNz+B/9ovUZWOVB0uApgTMbIqYp0JrB8bW0JbQUBbgOiL76vUpHhXVVfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR18MB4870 X-Proofpoint-ORIG-GUID: lSRKVH5l81GzunABNRJz6J-vjl_npBed X-Proofpoint-GUID: lSRKVH5l81GzunABNRJz6J-vjl_npBed X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-02-24_04,2022-02-24_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > This patch update the symmetric EVP routine in crypto openssl pmd > to adopt openssl 3.0 library. >=20 > Signed-off-by: Kai Ji >=20 > v5: > - checkpatch fix >=20 > v4: > - code comments addressed >=20 > v3: > - rebase to 22.03-RC1 > - enable openssl 3.0 lagacy library of DES > - remove local ctx in combined op as EVP_CIPHER_CTX_copy refuse copy > without > a valid dup function pointer. >=20 > v2: > - minor code fix >=20 > --- Openssl driver is not getting compiled with openssl3.0 Are you ignoring the warnings? | ^~ In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:12, from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: /usr/local/include/openssl/dh.h:223:27: note: declared here 223 | OSSL_DEPRECATEDIN_3_0 int DH_generate_key(DH *dh); | ^~~~~~~~~~~~~~~ ../drivers/crypto/openssl/rte_openssl_pmd.c: In function 'process_openssl_r= sa_op': ../drivers/crypto/openssl/rte_openssl_pmd.c:2068:3: error: 'RSA_public_encr= ypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddeprecated-declarations] 2068 | ret =3D RSA_public_encrypt(op->rsa.message.length, | ^~~ In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: /usr/local/include/openssl/rsa.h:282:5: note: declared here 282 | int RSA_public_encrypt(int flen, const unsigned char *from, unsigne= d char *to, | ^~~~~~~~~~~~~~~~~~ ../drivers/crypto/openssl/rte_openssl_pmd.c:2081:3: error: 'RSA_private_dec= rypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddeprecated-declarations] 2081 | ret =3D RSA_private_decrypt(op->rsa.cipher.length, | ^~~ In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: /usr/local/include/openssl/rsa.h:291:5: note: declared here 291 | int RSA_private_decrypt(int flen, const unsigned char *from, unsign= ed char *to, | ^~~~~~~~~~~~~~~~~~~ ../drivers/crypto/openssl/rte_openssl_pmd.c:2091:3: error: 'RSA_private_enc= rypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddeprecated-declarations] 2091 | ret =3D RSA_private_encrypt(op->rsa.message.length, | ^~~ In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: /usr/local/include/openssl/rsa.h:285:5: note: declared here 285 | int RSA_private_encrypt(int flen, const unsigned char *from, unsign= ed char *to, | ^~~~~~~~~~~~~~~~~~~ ../drivers/crypto/openssl/rte_openssl_pmd.c:2107:3: error: 'RSA_public_decr= ypt' is deprecated: Since OpenSSL 3.0 [-Werror=3Ddeprecated-declarations] 2107 | ret =3D RSA_public_decrypt(op->rsa.sign.length, | ^~~ In file included from ../drivers/crypto/openssl/openssl_pmd_private.h:11, from ../drivers/crypto/openssl/rte_openssl_pmd.c:16: /usr/local/include/openssl/rsa.h:288:5: note: declared here 288 | int RSA_public_decrypt(int flen, const unsigned char *from, unsigne= d char *to, | ^~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ninja: build stopped: subcommand failed.