From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47128A034C; Fri, 21 Jan 2022 10:16:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D255442734; Fri, 21 Jan 2022 10:16:55 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 099EE40042 for ; Fri, 21 Jan 2022 10:16:53 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20L05sw8016719; Fri, 21 Jan 2022 01:16:50 -0800 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dqhytsehm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jan 2022 01:16:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J4BNPYDVyitjW3HkeH3ygKuXKzwOMKWvSjVmP7VCcPVO2+U+qQOB8cg8gNQb0wxOSWfLKjm+ZN4XfBSD8RG1u7QuwWZoF/1v1rkHBeY98mIWu7AZzFwmWbCW1n+cRD7T64AQKeUXOc2d3FzJPtNFvDR7OMObJF3f/dJksnTR+rEL00YI/s/Tw/7lNnSF1uzEyEhamLFDWVOaxgpMQ5ogpm0CbbjDw/IOXuxCrXZEnAC4ryCXA1x9GcuR8uQaU1HaylfVm4lqxPtza+XtUHZHUHd10OGM9aTscm56bCqOMRv/+StGAeO+C6omBCrb2zo3XjnCXeOS9slmfzuEc6uEhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mGacevmFi+oj7HYMERVeZP7QLKj5/UiKNAk+WFbCBEs=; b=f/u/LG6bMvvS0dFFlSr2HGVUwRrPM9YobMGRCfOM0poVtmsWyf2u1M+lQjrGmpHqOnHsv1VIfehoxeNHsJPU3XMaWr/banCAzAldgklZnaOqKPNSAnj+8Wexy0pRSEwrn0mnEeXUBucRCrFx6GB8p2W3MP1RsrnH9rWprG8XguKkQJW+r32GJBhS0kqyDa5GuIy/IHKQ3X3rHElXaCFRbhr4ycSRYMy48qTUSLeegGj35zRv4Ypgi57449F0duNiwL0vQ5I0+nwqYMUBSGOYX46UD0wV+PAP79+MXobew56K9nxp+sY0BwdsyBOVj6qjQuUm43sQS8fN452NKZMeqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGacevmFi+oj7HYMERVeZP7QLKj5/UiKNAk+WFbCBEs=; b=avh9pI42Erc333baRszV2NUU/UnWv87o1/lw4oIUWjJIf5UaAzgpoNY3aNdB90ugaiH447ZC2oVBGSvKfMeEvs2/FWk6cohsy81aeqSXrAkslz4Wl0RLkySwEt+VszyxYWc5apdJJb4wkZqa2M4u2CCqYdTOiyDRnKcrOzRvIfU= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BN8PR18MB2467.namprd18.prod.outlook.com (2603:10b6:408:99::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.12; Fri, 21 Jan 2022 09:16:47 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ecd1:2b8:57bd:7780%8]) with mapi id 15.20.4909.012; Fri, 21 Jan 2022 09:16:47 +0000 From: Akhil Goyal To: Thomas Monjalon , Jerin Jacob Kollanukkaran , Anoob Joseph CC: Archana Muniganti , Tejasree Kondoj , "dev@dpdk.org" , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v3 21/29] crypto/cnxk: add more info on command timeout Thread-Topic: [EXT] Re: [PATCH v3 21/29] crypto/cnxk: add more info on command timeout Thread-Index: AQHX8yeC3nXzoZnToEeGx2ZJ5yoG8axeGDIAgA9PlBA= Date: Fri, 21 Jan 2022 09:16:47 +0000 Message-ID: References: <1639676975-1316-1-git-send-email-anoobj@marvell.com> <1639732811-1440-1-git-send-email-anoobj@marvell.com> <1639732811-1440-22-git-send-email-anoobj@marvell.com> <8925463.rMLUfLXkoz@thomas> In-Reply-To: <8925463.rMLUfLXkoz@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1152012-b0e3-4e7b-4be3-08d9dcbec00d x-ms-traffictypediagnostic: BN8PR18MB2467:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:862; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: icUNMwhbYEOs1ETzqugB2i3mBp2A+A/X6Bpz1pL1F0WRolBr+59wDNeut1b/3kA1sdDyizqEGrmX30aEEZFq38YAYBViRARTpfrCpw85MvwfVZyP6DnRZEZXLZO6EE8CIKoQ3tshmmNMRV7N2kYJwo0SK0E2ycCw7vvFGn70vfgEGpWs+FVbobNisPZfD/X4ODuSNkQqqAh9GGdv+qHhVVPHA0B5N4CanIFu5Hdwx4QHTK7jk7cKx3Ko1WvOwJPc0ufK/3z0yKMNwLH0PPHLCw6dMSRinVd87AtDOEw6YKc2lkOBlroE27fl/WDYDbannlB7hPbskpjy5YZV5jCQlp6BDbTAlvaJU/KrhtFj7ouRuBM6tkatfcUFDLoxvmb9sjingAYwD+CG31ZA0qUVB9qDglausmIVSfCJYi5WKWIajrMzGXLe5sqxvP8z/r6cLbjgvNlVvnbFuHVeEJvb1Zc9tiPWfdm9Zw+3wdv7WcLN2pf4vlTK/j9a3X91gD/Bq6CvCMLRwwdtX6dIcHZDAlowGCZo9mL0xsnWAyUEOTcbZINdz82N+q6b6d39eNlXLaXzxdDHrMy3z9wNXndt1d+YXb0mBin+ZbyWa2I7rBxHmJpqA3SIdAaAHV4P3ZcBeoGxnv5EAcxr7vlsxGncLO0ZZFEAi+mG9iENFLldylSNMfEyztWuaWAlqqwwxBiVfEALVHLdDAsH5y/ozSL/aw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6636002)(38100700002)(122000001)(55016003)(508600001)(8936002)(52536014)(316002)(110136005)(54906003)(33656002)(8676002)(5660300002)(71200400001)(186003)(38070700005)(9686003)(55236004)(66946007)(66556008)(66476007)(2906002)(86362001)(76116006)(4326008)(26005)(83380400001)(7696005)(66446008)(64756008)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7hVzt1IYZDB+/7XASQjo743w9IWDMkanMKmEhDfEJQsPDPDjfH70YbLVfzzu?= =?us-ascii?Q?5AIjJCiMYTsyiyN8fLHSnw/gebXLefTCHYiQEyo+B4PCD7jq3ofg7RizKXyy?= =?us-ascii?Q?SZ+qt2fehsOlXLWJIGzNWyAkYQF5Dhy+2q3liCiRK967ygAwwkEP09Qobde6?= =?us-ascii?Q?Lz1fqpxzfjhk5MFWsgiBlQVewaYzCo7/dSz9jXMOHkSzwKMRlpcmj7XVIOxy?= =?us-ascii?Q?fGh2MXShKhCZrvWVE48WvCLd9rJPXiCaoB5Np5w4+szQOmzmrmm8zwsHOfL1?= =?us-ascii?Q?pmOS6fWYZwxOpJDeAsLdxZbmBwosLDUoIEL8hIfPFmLJuh9wRs9GfcUbcS4F?= =?us-ascii?Q?+95vSyUsT1tKO2c96+rZPWrRmTM0AG+V4a3Vctcv8caDhVa3lQboBUSU/tYP?= =?us-ascii?Q?BuQkA65E4Zv2jNwkGrD/vJTBDeduIDMarf4ON3eAvs8MC7BhBfPnrFFUv7hK?= =?us-ascii?Q?BIbRXP7Dwru+pILVAbO5WpZJCCixqPNKYaoxyQ1W7OzZ5PTNmXGGHvAFHRQ4?= =?us-ascii?Q?selqB42czNF9jjQ9KB4LAU7Zco4vKy7kmemWCysG/T2FR1SK2PSV2mEMg+zh?= =?us-ascii?Q?qB0e3RVk1zCt5mUJtOAEcVEKXWQp0N4De+iimWtUzV5WETzA4bOkhYLj6e5f?= =?us-ascii?Q?3K1DjkZAJs83mp3Z1Dv81d2umpEiIkrD0X5ktwzBXF6+CcU4LA6+NsKTAls3?= =?us-ascii?Q?LwYBYDJoqLa3PG4NcgzeHsDSt05GmVWvRvKmP7lQNNf6ELLmfl9D20uq02Ul?= =?us-ascii?Q?VRb8KJWRTZEdPZ33Ixnh/1jqLugg+QJiM5jTsRBWjKs6xx5i+UjaJoiJxdiS?= =?us-ascii?Q?JGixKxm20IyNWF5PHOiN1u8tarJ5MRX2mZmPfXhdEbKWD5j5fWlAB6c2jsxb?= =?us-ascii?Q?zpIu4OPc46vNYVcCoZq5y7osSq78zB3U3WNtyjSxHmE1M/GimNLEvFxXV1ej?= =?us-ascii?Q?UnnDm5rOIUgCpuXYvgTqJJYzZZQq9n8sxL6op0HQL6up4UiVOLrRArTV0k+A?= =?us-ascii?Q?0naWN8PNSU/+In/3jonhsna3X8JGBnS33j74I0zYEakWpS/Rcht/A7ojcIL9?= =?us-ascii?Q?yFaS0almnpFxc/IPLIYkWyWQjheNGYHZ7Toy7jkI52WLrx9o+l6FJ5EUlQue?= =?us-ascii?Q?XsqKHBtQr4Sn/G3t4gZjLCo6Vv39Q36iEXvKju8ApPszfMh1PxlR5H9mzhHx?= =?us-ascii?Q?tqUhoiacqjrUTQFcynIarNF+M/iNBmiMej3z5g6NTcAM9RbAZOV0/jxpIrQc?= =?us-ascii?Q?/N+ZS5lnALipwDCG542sE1YXLgGoEgSyr6cVXnznu72XZO5wqzgzM3i45tOD?= =?us-ascii?Q?4T3dnR5IDxPkfbjVEnXnn4hUwuCDJ3OCgp8imzdiIja3EOgiSHuKwpZdh8YM?= =?us-ascii?Q?cnV6c1sD2TPlA0UzvPWaIyVbGLIKmhMOf5RF73AKzypE3OUXDUfNaEerGC/b?= =?us-ascii?Q?vMjcctEKkH8a4I1k6XYsuIFsc+VKYNqKpu7Xddf+azqqnjle5RQDPz05aB28?= =?us-ascii?Q?5k6kuR1qx4GFTul7JYgcLAK/P5w87OuQtW+nMAJqQ4LAaal9gyg4ZySkuPFa?= =?us-ascii?Q?5IfoV04C8Tvs7gpAdUAqKKh6NBoi0gNZpv+mj6QJNGBDnkKGqJgZu52v8r9K?= =?us-ascii?Q?SA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1152012-b0e3-4e7b-4be3-08d9dcbec00d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2022 09:16:47.2067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b7Y25C6aehV0RA0DEEGvjCVu4w5+3irr4DvAl69ARyv+Tv72KPIHzUQBYZ+raea2soFydPxxTbY2F4c8X6zzvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2467 X-Proofpoint-ORIG-GUID: FhwzJ6p0mCLRf1enUhNQp9mXLY0nzcU9 X-Proofpoint-GUID: FhwzJ6p0mCLRf1enUhNQp9mXLY0nzcU9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-21_06,2022-01-20_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > 17/12/2021 10:20, Anoob Joseph: > > Print more info when command timeout happens. Print software and > > hardware queue information. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Tejasree Kondoj > > --- > > +void > > +cnxk_cpt_dump_on_err(struct cnxk_cpt_qp *qp) > > +{ > > + struct pending_queue *pend_q =3D &qp->pend_q; > > + uint64_t inflight, enq_ptr, deq_ptr, insts; > > + union cpt_lf_q_inst_ptr inst_ptr; > > + union cpt_lf_inprog lf_inprog; > > + > > + plt_print("Lcore ID: %d, LF/QP ID: %d", rte_lcore_id(), qp->lf.lf_id)= ; > > + plt_print(""); > > + plt_print("S/w pending queue:"); > > + plt_print("\tHead: %ld", pend_q->head); > > + plt_print("\tTail: %ld", pend_q->tail); > > + plt_print("\tMask: 0x%lx", pend_q->pq_mask); > > + plt_print("\tInflight count: %ld", > > + pending_queue_infl_cnt(pend_q->head, pend_q->tail, > > + pend_q->pq_mask)); > > + > > + plt_print(""); > > + plt_print("H/w pending queue:"); > > + > > + lf_inprog.u =3D plt_read64(qp->lf.rbase + CPT_LF_INPROG); > > + inflight =3D lf_inprog.s.inflight; > > + plt_print("\tInflight in engines: %ld", inflight); > > + > > + inst_ptr.u =3D plt_read64(qp->lf.rbase + CPT_LF_Q_INST_PTR); > > + > > + enq_ptr =3D inst_ptr.s.nq_ptr; > > + deq_ptr =3D inst_ptr.s.dq_ptr; > > + > > + if (enq_ptr >=3D deq_ptr) > > + insts =3D enq_ptr - deq_ptr; > > + else > > + insts =3D (enq_ptr + pend_q->pq_mask + 1 + 320 + 40) - deq_ptr; > > + > > + plt_print("\tNQ ptr: 0x%lx", enq_ptr); > > + plt_print("\tDQ ptr: 0x%lx", deq_ptr); > > + plt_print("Insts waiting in CPT: %ld", insts); > > + > > + plt_print(""); > > + roc_cpt_afs_print(qp->lf.roc_cpt); > > +} >=20 > This functions is wrong. You cannot print 64-bit values with %l. > In 32-bit mode, compilation will fail. > Please use PRIx64. >=20 > Note: this mistake is warned by the script devtools/checkpatches.sh > Warning in drivers/crypto/cnxk/cnxk_cryptodev_ops.c: > Using %l format, prefer %PRI*64 if type is [u]int64_t I believe there is something wrong in the reporting; it said 1 warning which is for spell check of head and in the end a line is added for another warning. I skipped this issue as it was a false positive for spelling. Did not see t= he last line. WARNING:TYPO_SPELLING: 'tHead' may be misspelled - perhaps 'thread'? #157: FILE: drivers/crypto/cnxk/cnxk_cryptodev_ops.c:718: + plt_print(" Head: %ld", pend_q->head); total: 0 errors, 1 warnings, 84 lines checked ^^^^^^^^^^=09 Warning in drivers/crypto/cnxk/cnxk_cryptodev_ops.c: Using %l format, prefer %PRI*64 if type is [u]int64_t >=20 > I will wait for the next-crypto tree to be fixed. >=20 Following changes are mage in this patch on crypto tree. diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cnxk= /cnxk_cryptodev_ops.c index 0ce54d7bf0..67a2d9b08e 100644 --- a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c @@ -715,10 +715,10 @@ cnxk_cpt_dump_on_err(struct cnxk_cpt_qp *qp) plt_print("Lcore ID: %d, LF/QP ID: %d", rte_lcore_id(), qp->lf.lf_i= d); plt_print(""); plt_print("S/w pending queue:"); - plt_print("\tHead: %ld", pend_q->head); - plt_print("\tTail: %ld", pend_q->tail); - plt_print("\tMask: 0x%lx", pend_q->pq_mask); - plt_print("\tInflight count: %ld", + plt_print("\tHead: %"PRIu64"", pend_q->head); + plt_print("\tTail: %"PRIu64"", pend_q->tail); + plt_print("\tMask: 0x%"PRIx64"", pend_q->pq_mask); + plt_print("\tInflight count: %"PRIu64"", pending_queue_infl_cnt(pend_q->head, pend_q->tail, pend_q->pq_mask)); @@ -727,7 +727,7 @@ cnxk_cpt_dump_on_err(struct cnxk_cpt_qp *qp) lf_inprog.u =3D plt_read64(qp->lf.rbase + CPT_LF_INPROG); inflight =3D lf_inprog.s.inflight; - plt_print("\tInflight in engines: %ld", inflight); + plt_print("\tInflight in engines: %"PRIu64"", inflight); inst_ptr.u =3D plt_read64(qp->lf.rbase + CPT_LF_Q_INST_PTR); @@ -739,9 +739,9 @@ cnxk_cpt_dump_on_err(struct cnxk_cpt_qp *qp) else insts =3D (enq_ptr + pend_q->pq_mask + 1 + 320 + 40) - deq_= ptr; - plt_print("\tNQ ptr: 0x%lx", enq_ptr); - plt_print("\tDQ ptr: 0x%lx", deq_ptr); - plt_print("Insts waiting in CPT: %ld", insts); + plt_print("\tNQ ptr: 0x%"PRIx64"", enq_ptr); + plt_print("\tDQ ptr: 0x%"PRIx64"", deq_ptr); + plt_print("Insts waiting in CPT: %"PRIu64"", insts); plt_print(""); roc_cpt_afs_print(qp->lf.roc_cpt);