From: Akhil Goyal <gakhil@marvell.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Nicolas Chautru <nicolas.chautru@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "trix@redhat.com" <trix@redhat.com>,
"mdr@ashroe.eu" <mdr@ashroe.eu>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"hernan.vargas@intel.com" <hernan.vargas@intel.com>
Subject: RE: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function
Date: Mon, 10 Oct 2022 10:08:49 +0000 [thread overview]
Message-ID: <CO6PR18MB44843CB0E09B814D31BF9C09D8209@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <692bde86-9d88-4bc3-00eb-b095038a2744@redhat.com>
> > diff --git a/drivers/baseband/acc/version.map
> b/drivers/baseband/acc/version.map
> > index b4ff13e38f..27fbbe3de5 100644
> > --- a/drivers/baseband/acc/version.map
> > +++ b/drivers/baseband/acc/version.map
> > @@ -6,4 +6,5 @@ EXPERIMENTAL {
> > global:
> >
> > rte_acc10x_configure;
> > + rte_acc200_configure;
> > };
>
> This is same comment as for ACC100 vs. ACC101.
> Having a single API would be the way to go, given the prototype of the
> functions are identical.
>
> Keep acc200 function, but internal only, rte_acc_configure() would call
> the acc100/acc101/acc200/accXXX based on the device ID.
>
+1 for this.
I believe a bbdev API should be defined to be used by each of the PMD.
So that application can be agnostic of the underneath device.
I would recommend to send a deprecation notice to remove all the pmd APIs
going forward. We can take it for now, but these need to be replaced with generic API
as soon as possible. No new such PMD API would be accepted going forward.
next prev parent reply other threads:[~2022-10-10 10:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 21:38 [PATCH v9 00/14] bbdev ACC200 PMD Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 01/14] baseband/acc100: remove unused registers Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 02/14] baseband/acc100: refactor to segregate common code Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 03/14] baseband/acc: rename directory from acc100 to acc Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 04/14] baseband/acc: introduce PMD for ACC200 Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 05/14] baseband/acc: add HW register definitions " Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 06/14] baseband/acc: add info get function " Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 07/14] baseband/acc: add queue configuration " Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 08/14] baseband/acc: add LDPC processing functions Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 09/14] baseband/acc: add LTE " Nicolas Chautru
2022-10-10 9:47 ` Maxime Coquelin
2022-10-10 17:33 ` Chautru, Nicolas
2022-10-10 18:08 ` Akhil Goyal
2022-10-11 21:24 ` Chautru, Nicolas
2022-10-07 21:38 ` [PATCH v9 10/14] baseband/acc: add support for FFT operations Nicolas Chautru
2022-10-10 9:50 ` Maxime Coquelin
2022-10-07 21:38 ` [PATCH v9 11/14] baseband/acc: support interrupt Nicolas Chautru
2022-10-10 9:53 ` Maxime Coquelin
2022-10-07 21:38 ` [PATCH v9 12/14] baseband/acc: add device status and vf2pf comms Nicolas Chautru
2022-10-07 21:38 ` [PATCH v9 13/14] baseband/acc: add PF configure companion function Nicolas Chautru
2022-10-10 10:02 ` Maxime Coquelin
2022-10-10 10:08 ` Akhil Goyal [this message]
2022-10-10 17:10 ` [EXT] " Chautru, Nicolas
2022-10-10 18:12 ` Akhil Goyal
2022-10-11 21:18 ` Chautru, Nicolas
2022-10-12 7:19 ` Maxime Coquelin
2022-10-13 1:02 ` Chautru, Nicolas
2022-10-13 1:30 ` Chautru, Nicolas
2022-10-13 7:21 ` Akhil Goyal
2022-10-07 21:38 ` [PATCH v9 14/14] baseband/acc: simplify meson dependency Nicolas Chautru
2022-10-10 10:03 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44843CB0E09B814D31BF9C09D8209@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=hernan.vargas@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mdr@ashroe.eu \
--cc=nicolas.chautru@intel.com \
--cc=stephen@networkplumber.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).