DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] test/crypto: fix the bug of AES-ECB test
@ 2025-01-16  8:35 Shaokai Zhang
  2025-03-02 20:25 ` [EXTERNAL] " Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Shaokai Zhang @ 2025-01-16  8:35 UTC (permalink / raw)
  To: dev; +Cc: gakhil, fanzhang.oss, stable, Joey Xing

The test vector aes_test_data_19 plaintext is 192 bytes and this vector
is used to test 192-byte plaintext, but test vector plaintext.len
value is incorrectly assigned to 64.

The test vector aes_test_data_20 plaintext length is 256 bytes, but
testcase comment incorrectly describes it as "192-byte plaintext".

Fixes: c94c520b4163 ("crypto/aesni_mb: support AES-ECB")
Cc: stable@dpdk.org

Signed-off-by: Shaokai Zhang <felix.zhang@jaguarmicro.com>
Reviewed-by: Joey Xing <joey.xing@jaguarmicro.com>
---
 app/test/test_cryptodev_aes_test_vectors.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/test/test_cryptodev_aes_test_vectors.h b/app/test/test_cryptodev_aes_test_vectors.h
index 7127156cc4..505e603b7e 100644
--- a/app/test/test_cryptodev_aes_test_vectors.h
+++ b/app/test/test_cryptodev_aes_test_vectors.h
@@ -833,11 +833,11 @@ static const struct blockcipher_test_data aes_test_data_19 = {
 	},
 	.plaintext = {
 		.data = plaintext_aes192ecb_192bytes,
-		.len = 64
+		.len = 192
 	},
 	.ciphertext = {
 		.data = ciphertext_aes192ecb_192bytes,
-		.len = 64
+		.len = 192
 	}
 };
 
@@ -5103,7 +5103,7 @@ static const struct blockcipher_test_case aes_cipheronly_test_cases[] = {
 		.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,
 	},
 	{
-		.test_descr = "AES-256-ECB Decryption (192-byte plaintext)",
+		.test_descr = "AES-256-ECB Decryption (256-byte plaintext)",
 		.test_data = &aes_test_data_20,
 		.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,
 	},
-- 
2.47.1.windows.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [EXTERNAL] [PATCH] test/crypto: fix the bug of AES-ECB test
  2025-01-16  8:35 [PATCH] test/crypto: fix the bug of AES-ECB test Shaokai Zhang
@ 2025-03-02 20:25 ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2025-03-02 20:25 UTC (permalink / raw)
  To: Shaokai Zhang, dev; +Cc: fanzhang.oss, stable, Joey Xing

> The test vector aes_test_data_19 plaintext is 192 bytes and this vector
> is used to test 192-byte plaintext, but test vector plaintext.len
> value is incorrectly assigned to 64.
> 
> The test vector aes_test_data_20 plaintext length is 256 bytes, but
> testcase comment incorrectly describes it as "192-byte plaintext".
> 
> Fixes: c94c520b4163 ("crypto/aesni_mb: support AES-ECB")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shaokai Zhang <felix.zhang@jaguarmicro.com>
> Reviewed-by: Joey Xing <joey.xing@jaguarmicro.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-02 20:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-16  8:35 [PATCH] test/crypto: fix the bug of AES-ECB test Shaokai Zhang
2025-03-02 20:25 ` [EXTERNAL] " Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).