From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71DB8A00C3; Wed, 21 Sep 2022 20:37:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1ABEF40691; Wed, 21 Sep 2022 20:37:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 5D7E64067C for ; Wed, 21 Sep 2022 20:37:10 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28LBQ1f4032741; Wed, 21 Sep 2022 11:37:05 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jr1qmhp29-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Sep 2022 11:37:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XrcZn6gbwZActXiItYIq1DVUXMzfkqje0CKno+WYLWbWfl6xLca+OM1la9q02xrv7NJW76PsREafSNzXBVKzuw7xtGI+BuRIWkHbbOw4N0AfY1RW9h1bAwtnvvPvwBwHS8MLp0C3AwJtK5Zo9TL/x4baKOz7i+zeGl5COViVu/d/UAgL0JoTCPc5/9d2jb417GNNecL/yHlX1UrTlycnlNghi3Ophe/AXFMOKGMNQciis8qmIGdVXrOKO0kwFS4UcupWLVrsHqA0t8DwnS1i0I6+xzq5z78I6+zd5Ir3B3T63YRNO1vHce63DZ6SB/I4VRKzqIb5S9sfyDxZeSbxxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vKfxCpTmfNfP+nOmtYXqWgKQX7blE+TvsoSfdKAKdqc=; b=m0MZzfl7TbIeXRCduK3i7Qew+JkfQp3NpU423qVWmkm/Gycu3eK+YTv2OBqnX++oNpkmV4PtCeeVvbpIJRvEGWf00TI7p38XZHIZ2TusM7bGVcf5F0lvnk7NXKCjC+drzWc207Dwy0MsZ9Gk/qT5NRiG+YChSGjIs/+4o2dJP4ce9FcLWO5gcQ+VNuNfSUDDKOl4CoDnzGknP/IlMvwkYS4/36xVGz8YgVn3DFZNuZfrOEVrug/ZoQGcfM/JGiaAdFEEVrdSdoxLydXKY0qz9hSQ6laX8DZ5Z0yszw49JOr2xDZBBr2ze64Sj+7P7zFN1EyCJox8iTk54NU5hiFC9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vKfxCpTmfNfP+nOmtYXqWgKQX7blE+TvsoSfdKAKdqc=; b=gYfjExCCvAJ8vHiY0Uq9ps0kxrbIbxAVv9rmykqYLiUasuoY0SB/o9MJD3t/c/Of4khUP2JG8b/njDKU4uY6ljIXFQC7YVJs97oPE12wy7s6Pwz2hM+WGR8nKCYY5FSBv3uuZdHgaz/p2utP2sLU5inqv/+YMkELRNd1HzcBWKM= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by PH0PR18MB4457.namprd18.prod.outlook.com (2603:10b6:510:ef::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 18:37:00 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7cea:d050:5433:8c74]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::7cea:d050:5433:8c74%7]) with mapi id 15.20.5654.017; Wed, 21 Sep 2022 18:37:00 +0000 From: Akhil Goyal To: Akhil Goyal , "Zhang, Roy Fan" , "Ji, Kai" , "dev@dpdk.org" CC: Anoob Joseph , "hemant.agrawal@nxp.com" , Chandubabu Namburu , Ruifeng Wang , "ajit.khaparde@broadcom.com" , Michael Shamis , Nagadheeraj Rottela , "matan@nvidia.com" , Jay Zhou Subject: RE: [EXT] [dpdk-dev v1] lib/cryptodev: multi-process IPC request handler Thread-Topic: [EXT] [dpdk-dev v1] lib/cryptodev: multi-process IPC request handler Thread-Index: AQHYoUSUm03CEnbBzEOYSpZ7tshzPq2RnMNAgA5x7wCABJ8ywIAGVFmAgAABziCAP4tmYA== Date: Wed, 21 Sep 2022 18:37:00 +0000 Message-ID: References: <20220726230804.90036-1-kai.ji@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|PH0PR18MB4457:EE_ x-ms-office365-filtering-correlation-id: 708683ce-3923-4345-afcc-08da9c00458b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6mcfWmKF5m48SVvR6W+7nmnzWuWrDBmD14MG0W5Ns8qC6WWd2q0rTnyFOo11AcmX0Sz1GyXgAnCWf7Ajbh2lnum9u2WXHw4Nk2anyOpMkCNW1CdrSGh27fEdG4PFXDnowu93FQ0jgk4cauuoKuEdGtiw/QFOL2UfmA2Cfay/lKxBbfEls5CNmL8KpaEgMA7faXWl0HGNFEXLAjzs9oChjQ/tFT6XN1gqPQAvyODjvt63Pz9dKUH1Zjgy2Z/nb0xdqQst4RthsTAYXAJcsCpIIL/wJbI8mUjZnPUyi0aKNRQLh5FsjTqK35scXA7oB6GFeJeK2u4eBJeCuN8FSwJtnMe14wgHvEbSi37/oi77NToe6zlUQpD814N5Uyal8e2HYRkzi3uQGgOJ8F5TkMtAJFMijhdNZ8dZ8m96064NorOk0/VQndn1w96DhDmVDywhNf3I4d6wPdbPVgWR2rUxb0CiAuAUzOFXsK0IFfLuZMIyInwU7NJdJu84nALCBW5Q6io/ZxNknXGKeS1VTI592VSreY9gQSawLFVsO1mMQs1L+H7OGwV7QTTwSS6lQrmTQDVqWBxB8KcdfmnrAju0808nQhH9MTgDVdSAEb7UBkn1APCzqvXNc/3FOrN55sV4+tZQmggppcT6IHX8MN3gtyqV+yaUGuujtxKRWvnpHPwT38Fu6PXK7T0DuwalebTH22dX4n0tovETKy2IKz/4uGCp0ZbR3mUkOJCPR/MkScuYhSDyfe2YA/9G1UcWwyODlhtYsE6AiBUseBCGZtwlOg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(451199015)(38070700005)(7696005)(6506007)(71200400001)(9686003)(26005)(55236004)(66446008)(66476007)(66556008)(54906003)(64756008)(86362001)(110136005)(4326008)(76116006)(66946007)(8676002)(41300700001)(55016003)(33656002)(38100700002)(122000001)(83380400001)(186003)(478600001)(5660300002)(316002)(2906002)(8936002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4U83YaO5dJgeeyfBY+pk5xTvdMRql1m/7qpCinc9aV5IKy37s0DhTOSMUcxC?= =?us-ascii?Q?peWBQ6mOYdTcSfq6N0pc62PmoG8GKtWMlwo7slbJ8wm9pPWpAo0xjukmnDeU?= =?us-ascii?Q?3zfVpr+0OVg053GXmQIAp9so0EVHY3Z2rHFUPidOhUJIFDp5t1NYpAa2lZsU?= =?us-ascii?Q?H7AqTMLKcHlmq3p7/5I637XLk0+nVkWO+ekvlFSnwGpOdP6dWU9KLQOJ3AaP?= =?us-ascii?Q?0cVYlB3R8vWl1FKgc+qPY0bKW+e1wVmI63AhlQ46eOIZL9XaTxUM3Ypbmyre?= =?us-ascii?Q?zUfK9QtDr0Oy8kwIj70O2aaoGliPeGx2Z96EQMU9nlv0TkufEbz9kPPyOkUt?= =?us-ascii?Q?6pPAmkP/2gY6ErhyA8bKNOdvBvyjbsTGVn6uhzOfmxTcs5mTohqNfvT54qMh?= =?us-ascii?Q?1N4PqiCo7AVYL+c1K8IGKdmMkTuf+Fhw5ImwgH3DNdP+1emkaVJv10wlEUKX?= =?us-ascii?Q?EGp3/JJ1mLHZpY/ksEfCeDq5rV2zOQzlrZdK3vPDgSJJUg4ceuW3bkwhjG7F?= =?us-ascii?Q?g51TU8icV41RtjaBdkY4eP8m5KEsfEhzkKUtq6xIquMoQhHU1eTmawadSHC5?= =?us-ascii?Q?Rq1WFS8M841Aa50BOqc4DfSQ4XbY9VTSyZjE2YMZ2voS6VEt+nBBrrKw3fMs?= =?us-ascii?Q?ifyczL+sABO5K8KaGQFg+pbhxN7FlvEBVQNc6iws8Bu/dIwVP9jwUO43gPL3?= =?us-ascii?Q?C6NZkk1jx9HRxzZqXfnTcQ38cFE8xKdbZyLemFxD2hRiaX2c1clyXVybm7+B?= =?us-ascii?Q?DheAoh775fNlI82ltG6uYTr1wZiJUhfYHGY0mTSOy0+75aPIN1vqxQBAGXWN?= =?us-ascii?Q?bRYAnPYBIzmZSbBISi/eB2UFqyo9SO562d9he9KP7qGLAB2cV8ZDOU+FvDgY?= =?us-ascii?Q?zwhNiAAUE/HXauKTkqffbk0ZFNofRKy1GZTxSdU4TKXnkulUSYrDVpXp0t1V?= =?us-ascii?Q?3fMks1CbbTXDUHEmPP7IEWFpg+1nT2cMoypW38JDHRK09FcYslYOUDxFS6il?= =?us-ascii?Q?eJWmm3/Ddhwp1uBVqcHdRe6Ft4PQRMenMyMTq66IFdao+Fci28p9OIsPK3HB?= =?us-ascii?Q?nEDqXlg8f/qXshuGGOwOJ+wjnBTM3MqWIyf4aCUP8LIaukiw/4I4g7B+VAXN?= =?us-ascii?Q?OYdiLTg5771qn7/eOBuyy+85dROyRR56+AHyP9ldMSeNHhT3+lDl7z1l7dMY?= =?us-ascii?Q?tjrzzA+k8rlyfwWeepo3eZTOSQ+9AaDHXR4y+Q2WxWa7XoWN/90NYnAkiwYL?= =?us-ascii?Q?le5D9B/ukrDaAHjTuJONYGjq3ghrHJBM0uGNqoUsAnCh5Hkg6BB4Lrh/SkfW?= =?us-ascii?Q?aWgMfNdQJLRxr0KOyF5ZaqceUitSVoCt2XWqaSRFT9aSfevVaWfZ0xxR3CJc?= =?us-ascii?Q?W9e++v9PddZFYT6+wM3TWhIX+Tnxocag5ObmwDSC/Z0uedp1JdBsjRb6UmWY?= =?us-ascii?Q?s8wcJpPs58UgMhWrxGYlU1EkU61/ApaVzWWz64MhPzdxlLXBVuII5I0RoWy6?= =?us-ascii?Q?JVr7lxy4nHbnzOKrSyjG1I56l7VQqrv9A7A9sFQrvNb+Az15tT+TPliM4RR0?= =?us-ascii?Q?OITb0/RuR69uKLrFyisWFvW0OK98OT5Y2OX4H65C?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 708683ce-3923-4345-afcc-08da9c00458b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 18:37:00.6423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3YV6WU6meSjae3m8xvS6winABI7kgOV0R82MQ+GBwt7zOLGNr1tYvjl6U/CWBaTlBzjpClLIb+GKnU2EPxyBBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4457 X-Proofpoint-GUID: Wd21ktShQ4dTOPeGUAfz5wiCPh9six6m X-Proofpoint-ORIG-GUID: Wd21ktShQ4dTOPeGUAfz5wiCPh9six6m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-21_09,2022-09-20_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: RE: [EXT] [dpdk-dev v1] lib/cryptodev: multi-process IPC request= handler >=20 > > > > > > Instead an "in_use" parameter can be added which can tell if sone oth= er > > > process is using it or not. > > > And this in_use param also need not be exposed to user. It can be > > > completely hidden in the PMD. > > > User will get an error number(probably -EUSERS) indicating the queue = pair is > > > already in use. > > > > Great idea. That's what I am after too. So can I sum up the following c= hange? > > > > - each queue pair has a "in_use" param. I believe we can refine this a = bit by > > a "not_in_use", "in_use_by_primary" and "in_use_by_secondary" enum. > This is specific to the PMD. Each PMD may have its own implementation. >=20 > > - the secondary process may request to configure a queue pair by sendin= g > > message to primary > > - as of requesting freeing a queue pair > > - primary can free any queue pair. > > - but for secondary to free a queue pair, we have a problem: > > - we may allow secondary to request freeing the queue pair if it > > is "in_use_by_secondary". But then there may be a security > > issue as a secondary can free a queue pair used by different > > secondary process. > Is it not possible to save pid(inside PMD) of the requesting process in q= ueue > private data > which is being configured? >=20 > > - or we may not allow secondary process to request freeing > > any queue pair, it is securer, but less flexible. > > Any update on this? Marking this as Changes requested. Please see that this change can only go in RC1 or else defer to next cycle.