From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0EF5A0C49; Tue, 20 Jul 2021 11:01:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73B234068F; Tue, 20 Jul 2021 11:01:32 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A98BC4068B for ; Tue, 20 Jul 2021 11:01:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16K906CI024861; Tue, 20 Jul 2021 02:01:27 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2172.outbound.protection.outlook.com [104.47.58.172]) by mx0a-0016f401.pphosted.com with ESMTP id 39wa68bt65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 02:01:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7aNNEcL5caRZPR2uWenzEP49HcyTy+LniEgNAQsr+uiqTswSGJAlnh6IQ5VXRoYY3jHmsya3EUS97EY8N3htVVLg4x8QX7Go8iu6R1haIAvMFus8newkljt8F+Q1wXhceeDgkgU5i1itbK2bL4ARUPVWJ1UzeKodRi4usYNk3nneTzSFDDeMqNSJfdQVnxHGBiw4Y/zgzo8fFcXxKuUYh946Y0eH3S9T9qYkJbUuhglC0jsH0e5efuVVaggGMtJxlLlqeQJnvlhGbGBj++I8QtfPJed7p6IKswiyD/jjeiwJ5JVs0legixeI4SyH5/pp34TQlvYqq/Ib9h/ntWMpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NqhKZ7xTQsAotZOCWi6Dq6pa9pD33hv+jcTa1djlmEo=; b=Q3h7Vyb0bHuSYBDX/Tp7o1dLFPICk9tqlHilLStIPMfGsYyTJM4FZDwYjwi343DZu2FkNtNhQoXGkcCQtr8JH6PzCOiy7pUUtVn3rc1ijFn5Cudj/ymiZTEZOEi7rXFJKxOuZIawRsUmhofvf2eGhW5blO8j1Hbgau8r2fZdTphUg9tkyE1ikizG8ZqyTjK4S/tKz/ZpHQSCeS4REDmw1KE+rC7q38bYZbSf1PB9KagF2QRLs0JqbFY4yFg4BuH7kcODc6mqgtZjCKpC2UFwXa7uN2OYn7RnwCAO47mDrpEJJkXwYshnu/DjjNjC5lmFqjHEZqHj3dTBX5oR10tJkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NqhKZ7xTQsAotZOCWi6Dq6pa9pD33hv+jcTa1djlmEo=; b=Vj3ccZK+aDATjKhjTBZSyBAFrFLg53lqPGWzTY00gLtfu/ODUnlakG0lJ6D/UY4nx3by5Btw7Ky5Aawj7INqbhMnuzltaz3bVpRAWdbdREjyBiy56aXh6BeFbt/NZCkIb2VkPpH3n9V2TAiH1EJTd2131dW7NJZrBCYJGaCRSeg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4555.namprd18.prod.outlook.com (2603:10b6:303:fe::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Tue, 20 Jul 2021 09:01:24 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 09:01:24 +0000 From: Akhil Goyal To: Suanming Mou , Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations Thread-Index: AQHXeZhbnCd1uXT6C0q3QumS/R7iw6tGAAiAgAWXxACAAABzIA== Date: Tue, 20 Jul 2021 09:01:24 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> <20210715164126.54073-4-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80f3756d-f2c0-4c04-6ac7-08d94b5cf3aa x-ms-traffictypediagnostic: CO1PR18MB4555: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9hEJGT88yQAqDFJLmLY3qJAANfc2Za41MfLl0BlhDbNOQ5E4ML9idaRLaSn1PzHhJl8jhDl90D9oCqIGp9TCFmgfHodoazkb0HNlov5AgmLluX01hPnkJzEuyIzQHtHDuTiQec1nCjAAxU5OuHK5hFKq4MnK3BEk6ZF/zvMBkxi/YGWTQhRJjivB6YYFpG5+Trv7GCLXWvri3w/JVrku7jzbZoPGcsK1qY7Ov3tx1e3it5xG6ZDO2tAznoZuyOGropX+9vjijfEjCF0bMTfLrIAByRpNWi5WWvdy7mX0vJqMN90LmRipBwLiKt2+khtzbzG0Wn66nrCGAn27HmjtVmUM1E+Wm+Zkga2kBIKWGr2b6WUmJt4xpRf1Ck6I3DKQ2q2gfNBqh+ECkojoFyFGdaYW3uq0/ufimC+/mXoiFFyopo0Z+MssTB8GT70tELB0lFOKvZ5KfaJekhsvaavlbPekhgD/DfpkHp9ktOAIbNLF+1qBYptu5oC/AIKNCrII4MuuYYg2peAxjNmmIG4IOAohvJqCrAg76cLbAwzKTO0Lc9aRzXVvuhl8oCtgF+LUmgetsCJjqC9yNZ0N0/ATVhU8wO9wvqcX+cJSEZlDmXaqzElQX4J1j1SmGU8zgPITdX/uGwYWWTBicqw4qS5SH9+g5AST/5boak0C5jmdqxFSO320ONF73nsKgFoyWIy8Kihg9d7vLHrIttywZ3Hw6Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(316002)(5660300002)(64756008)(66476007)(86362001)(6506007)(52536014)(53546011)(2906002)(66556008)(66446008)(55236004)(66946007)(71200400001)(478600001)(55016002)(186003)(76116006)(8936002)(9686003)(26005)(4326008)(38100700002)(122000001)(33656002)(7696005)(8676002)(110136005)(83380400001)(54906003)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/fi1NRUXtYyfDJ3GPQFz/CkDSBW/f69dHRckpNgxfEMgrgaJVXeZNizqd0zZ?= =?us-ascii?Q?R7xBHFqz7n69kYgjr8vhLOnxKIY31DvqfrsXR/z/udFlr/1bxHv1fM8gj9+k?= =?us-ascii?Q?asJpRW9tyV+yIEcFc1v6Bq6oKaaeFbWeNjXxwO+7fLQG25nneikuTdqvUljH?= =?us-ascii?Q?qOGMkkZteW1ppZBTOqYegJmPZh7xZ9dtoBVP6GaX69FU1Yc0Gi1h27fSQyaX?= =?us-ascii?Q?ht8FgN71z0uD4f9Oge6RNriJPQ3zxBCOLgHkogAUMOq51X3bQ6pjQheA321R?= =?us-ascii?Q?P7MzARJB40OFaclpiMEn5/rfEW9DbTL0G8vJ4nfKJko3mknpo6vszjDwhlOm?= =?us-ascii?Q?f8XGd8FouuaNGoRVRGPf/iY0jpjh/76zAE1+LkUtNhJ0DzKSw+a+BmBWj5Q3?= =?us-ascii?Q?qFaLRF7NGz5VHvxvixFALNbDpNuUniop4C6oCTBR8Nl0q3QHdFRkU7BEP4th?= =?us-ascii?Q?Z4C+DJn9tpuyBfux9010wXpp8hwesbvwT2sKDd6PrLDfM3vr1ABMXVxhJYRu?= =?us-ascii?Q?gagLc8h5GcSgBdOfleyGswQ04DZSR+5DTPh3UtPam606tDsV+UgpPppWC87s?= =?us-ascii?Q?pwYSgpQvoI3rtFg8L63YexEEWbvNr7LFO9YIUiosGAdi/OVktvpMAcYloulw?= =?us-ascii?Q?YQenqk15489KW/scmN0wpniTOS8do07pW2/kzRWnS83629bd3PjYdUsnhLK3?= =?us-ascii?Q?pjCNSLc6xBtIq4am4DiKjwgPYUrpD36oayY9iUhh931pw9yCNhZRKzGirlK4?= =?us-ascii?Q?dNSVOT73ZJhaeR5zX+yz7R/riD9JV01gAjiuXB0xhCOi0ssTE588umqCQd0q?= =?us-ascii?Q?HMI0woSvJyEX6bncczEpppzVO6BdTsG58XeVeiXBr8qieyJlIzskLbCquIJt?= =?us-ascii?Q?C4RFcex6KejMCq5rndr9ZuHKCEuNWpVvXodfpCPJsoh7ZvTnJKN6FhF9vBQ8?= =?us-ascii?Q?/mC+7sAbFULsG5oh4PJPpyCxQ/0NDuQ+Iq3X2hE0PCQul6OfMdki/s9T9S7n?= =?us-ascii?Q?nwfcKrEfKFBoyIb8O+AAqqzkwiJXiw+JbRAQzRLxMtA5vUeryVUwR+wiHxb8?= =?us-ascii?Q?haw1/1oHoQnI6fOLa/mhRIgHZOUWl675Ha+WmXEjwZ5s214ocrVuB3E7qFvM?= =?us-ascii?Q?ZD7X+osUOEviWKPuAMC2A9MctjxnYK4bdT+wPMCnf/mzgHTMH463zvjhxRvs?= =?us-ascii?Q?7lElVSsjwHS70eFnoD8Q/MiJrLGPmF7cAm4An+AQ6l1pzw7lBfKjOcUTeKJj?= =?us-ascii?Q?4WqAfU/nqof9MfSelMgfq89/rVsSIjr/eCPbHJwcifbU3lgh6Cn1Qz4uqBG6?= =?us-ascii?Q?9rZ36l3OCwiWIpJlCWMd8FBM?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80f3756d-f2c0-4c04-6ac7-08d94b5cf3aa X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 09:01:24.6105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gvz8oeCrlIT/ggptQOBLTxjbTppjB5zg3lNM7/Iji4fZr07GTwKEk9z8Lq9AWgTPM4vhsIxs0Vlv4FmuT4oBCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4555 X-Proofpoint-GUID: oDreMx1r-HkwKt1hbJT1LbbypHoZlISd X-Proofpoint-ORIG-GUID: oDreMx1r-HkwKt1hbJT1LbbypHoZlISd X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-20_04:2021-07-19, 2021-07-20 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Suanming Mou > Sent: Tuesday, July 20, 2021 2:29 PM > To: Akhil Goyal ; Shiri Kuzin ; > dev@dpdk.org > Cc: Matan Azrad ; david.marchand@redhat.com > Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations >=20 >=20 >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Saturday, July 17, 2021 3:40 AM > > To: Shiri Kuzin ; dev@dpdk.org > > Cc: Matan Azrad ; Suanming Mou > > ; david.marchand@redhat.com > > Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations > > > doc/guides/cryptodevs/mlx5.rst | 10 ++ > > > drivers/crypto/mlx5/mlx5_crypto.c | 172 ++++++++++++++++++++++= +- > > > 3 files changed, 182 insertions(+), 5 deletions(-) > > > > > > static const struct rte_driver mlx5_drv =3D { @@ -39,6 +68,49 @@ sta= tic > > > const struct rte_driver mlx5_drv =3D { > > > > > > static struct cryptodev_driver mlx5_cryptodev_driver; > > > > > > +struct mlx5_crypto_session { > > > + uint32_t bs_bpt_eo_es; > > > + /* > > > + * bsf_size, bsf_p_type, encryption_order and encryption standard, > > > + * saved in big endian format. > > > + */ > > > > Normally the comments are added before the variable. Or add /**< for > post > > comment. >=20 > Yes, you are right for the "normal" case, I think the main reason here is= that > all the mlx related PMDs are putting the comment after the variable, so i= n > fact put the comments after the variable is the normal case for mlx PMDs. > Let's try to keep it in normal case to not make other mlx PMD familiar > developers confusing. >=20 Please use "/**<" for post commenting.