From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A40A043CF8; Tue, 19 Mar 2024 09:23:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EE5340298; Tue, 19 Mar 2024 09:23:26 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 3A97740289 for ; Tue, 19 Mar 2024 09:23:25 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42J4xfBo007952; Tue, 19 Mar 2024 01:23:24 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3wxka4un7g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Mar 2024 01:23:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dDuZ3RmuLCDqXJ2vXZDJtUkJjql2yIqV5ROgGxHMSSndP5OOLWDXLkujf9+fTHm3gcqXY3HOEwBPbE+vW8rgablBkBlcOA85aYEa08vVH0kRAMQ7CHuJ9ShfVroB7wpBT6sJe64meUvPIY8OEbvpVIhAfXPUCSR1IuTS+ExLlR0zy6zbQIkmn9aWffhH9XcD3Ri5Nkh/LM75KWgwTfMoKxH3nEkjZei72LydfcSjqZL3yQkoxLvMuh+LA1zRUFYBMilxPjvUe4uKq3tWJ4i8cowUlJVaVulIbPQyoVasJimBbnAI04dKdqA+9ZZlz/hSf5wPCOUiuUvaUElHCXetgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MmEVAVcVFqSTI5Z0JKVnOnHY1cO/Axj3MU6jsXsBdCc=; b=Kqd18FWo21HRpJMi06d2GzSwMjd590g3NA/toERRJkCg4wde6fFAjZUEPRoXbX59ctmrJeCA0zRFLkdOyVcX72UFook2IUClV0T7AjHgZn58+j/aEmkhkEhwSWNjEvZg66Qm0gi4De7k4auqOnB2RHHzAb4jpGYMG3TsCmcgyr33+wAqygKTJ4RFqJxZbGCLBaGyjuiLkTxef1g5BX3bJeUiALP6tXEIP+rIFdK3e14RBXKrnFy1jemh/brDILjjK5tQSdU3XdMQSYFOt1iFSc8DTQlkQ5yEXK3uehpxWdgmc5yYs53NbfjXzQM5FeTHRLZV8XOR2cRJkuR9DqS+5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MmEVAVcVFqSTI5Z0JKVnOnHY1cO/Axj3MU6jsXsBdCc=; b=JF/BS97QKQ0LOoQQDAB6rQAhJhCRNkqoUto0LCkmx0iJb9D3x1EiAQUs2jPZALcSydVTI4mDTdr1CSFOa1blSp+dP9OmtMcKjFCePOhRaz/CgEnvTEfYsWtqCgdY88jvVIRrBSMJUA+o5VGFMfZb31wGaxUebXeiZOfR2z9RIjA= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by BL1PR18MB4357.namprd18.prod.outlook.com (2603:10b6:208:31e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.29; Tue, 19 Mar 2024 08:23:21 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::4e74:4cf3:63b6:b149%4]) with mapi id 15.20.7386.025; Tue, 19 Mar 2024 08:23:21 +0000 From: Akhil Goyal To: Suanming Mou , Anoob Joseph , "ciara.power@intel.com" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Topic: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Index: AQHaP742RYhcx/RoTEimHsaTWSKaH7E3+RBQgAbJLACAAGrzwA== Date: Tue, 19 Mar 2024 08:23:21 +0000 Message-ID: References: <20240105100104.908543-1-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|BL1PR18MB4357:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s203nBqULq5zLQiBBsxL5jVRA5zfZU/C+r8PFdJHTI5M8NMND1fayFah0yxMi819edqt9v49kYnTubOULBB/5vVxYDU9Ir8RyTp6jysISuTv3pXQsS9K64YJWHy6Ru+d96I8fl9zgAK+84zLTswGWukJeOG+wcvuEqaJ6uchRMaFtFIQ9GjQvalTqssR0TX9eKy9H0eSzxph7CAew3NGUPXsvVB5OFH5xj9/KXDRk9MwiPiWtsbitpq0h44jPnUxQIDhRDXlwjHoMTo2glRkn8GIIhNUYdKzM4+YAPetTP9OS4V9iNzFUH/OzZwl17stULNoeDDt1dN/+g+mP9516ZdRUJoqT/bIJZdpN+kSzJ/QLoDKAdWA/rQAsZtLY2Rtb+AJQXggDHNG/pWHnmjRcLlloanvdos5oeXC/hBFvZV/k/Dl6aXZ0n1jPQ55mDPKKvsVujU1D7lLNgDTFwl20HGwVwyuOFwo6hC2lScHs6XI/rM3HFxEhPt0oAhyERrlgN/uYShlUAqEv8n2mncUOwyOrt65d9l+NWWy8M/wPU7vYXoL9cpWFtlPkI1zISQLYW/I8uixy+8dg+GNdgFMJiRa1HQN+QgVC2WiAuRbp6l0bKJufoWLNLC5uLHYrXuJfg1KAcFlQ/N/Lz6N9Mjbq4jq43/y+3az+PxRJrhwiYM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KI0ovFgk2kXH3JN6O822FQZXAl456LvzAQGcoUAD3hef9x2bDesvZH1FFY/+?= =?us-ascii?Q?IpTDsZ17gM08Tcgf2/fXwydYJAcd9yYTpxes91j6f95eLdEuAKFDV4G3QaCG?= =?us-ascii?Q?5aEseXX66CsNMhHZQlVtYDje7vvWxxutrlhzPKk/a51a9LPdXD8qMCFk+xMP?= =?us-ascii?Q?IGQgRpQH5Ow13jL13kvGhCc1wwrxFbGd7wZSFN9XEQnd/slsra2xit8jixW8?= =?us-ascii?Q?/AQmczDV/UTjtRpTeFXKOUh0E3TJS37J/ZEqxqlexU/C/dhAxzGS20ka6Fq0?= =?us-ascii?Q?BkObTFFQhQJAJkTP9PHKwT2PvBR6bgzzvzYc+GaUdo8cazFHQ3FWiz5vk8VV?= =?us-ascii?Q?2ZBYzznqWZA85aGTs4lTE6f1aClAmTW/giy5A2Z6D6VL4JUbOLJO8Jo8UAqZ?= =?us-ascii?Q?GfSwH/nninNcmDS1EwbtudkbIzNkpp9HJzRRoDEMAVAFGHSRRDWDKC+4sXHz?= =?us-ascii?Q?eO3fifRUI2f1OKlWvEEV15paCelVgJ7OKq1aB+UTHLTCQRAzTiDXd3AOvd7Z?= =?us-ascii?Q?YA6lBu9KOG0PePhFduB2fALWSWqernyagHIkWP8pxJrP5ZgzJEux0jB2HwNR?= =?us-ascii?Q?m+UC1cbD/kcpXERohziyx8lzXxYaFppHbZVshvbKl4SjPUTpwcNg606d3H/p?= =?us-ascii?Q?VQNWNGp8Y22swqt87Pxz9w0Y5GPt7prTnJPE1agLvfpOz6eLlzjgGi7vuM8F?= =?us-ascii?Q?ExHiLl7yE70ET7gFDqnxPteIaHdDFBN1JPPMuYCKh2YMhdcuUQSm9uEcyUI7?= =?us-ascii?Q?kQLzUFO0gXXW2h1/zujkK0BtPYFp+6yOL0/Ns+/tow2a1D75/GhhgvXIgkAn?= =?us-ascii?Q?d0GuS5AJzGTPLAwyjoa0MXw/KZbO6kY9Ubm8h+K+b/2Ri6/idiVLVqQQIdCC?= =?us-ascii?Q?FSmKL4Qe04502jXI4r0O2VYgBKHvTKzVfE1HkQpqw0iZCXLo0Zu83ZOGL3wh?= =?us-ascii?Q?dl/qEY/pLvz+OPFYTHvkwx/ACuIta0Og72bEEMdKFsNVPvyKjx85ad/D3ITr?= =?us-ascii?Q?d0n9IXjcDehYzEp6PBy3oWB3K1Cl0WEeD9eLdlcdLHOpq7c2M7TPcHdgbUYC?= =?us-ascii?Q?SApYkb1xD1bOdb1VGJwQ1kp5I1m5srxk+DkatSbWksQsUHcQtJMpgEP5YPyo?= =?us-ascii?Q?YwwAQqXmYApzBv7d/DuobHQFmZ4uX8ZJTFz5yAw9wudBQ7bIkr9QtXgG+q0V?= =?us-ascii?Q?PGBgU+v9HGRzKAAKAAsYEySpWEjHEKr/JERHtsTqVcdWkO2myfPivevl2QOr?= =?us-ascii?Q?0K1BSJ5I4MN9/ojOZctGV0iYhabSpQI5Abicop5PGvURWBvyep65b59ygYT4?= =?us-ascii?Q?GB2//b8QCXMWWzAthurB4GSk+31jC1YIKy1qMl0o0WrfpUEBE29Lj7huUUX9?= =?us-ascii?Q?9FcWXbGnDewh2xs0q34vJLRvtX6JEDK6hr0bWiTbM7AVMbMo9PBhh/T0Zc8s?= =?us-ascii?Q?0hVLtdCo0AKvMsgzj5Ye9WXCko1BbEM44l2xuTktNF1wsP2a+hpB1VaiolOV?= =?us-ascii?Q?a9dGsuzKwuo6e41lNXmONLfNfmNKQpb6zmy83Qn81MMcTeVB79E0Ft7ez0N/?= =?us-ascii?Q?QTFnXwPKEZFCZoq9v149qWevlKikJLqVaO4yDqGxr0Ugxb/gQx3O7uZv+2PF?= =?us-ascii?Q?xHx50PH5mdexyzY2XNTPAass714HzULqFjdrE9X6CCrO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33f4171d-2244-452c-f7c1-08dc47edd6c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 08:23:21.5513 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tIXUgSn7zq6atnrUrGFhOOAiVwU4YLjb1sjMMF/u4N37y74njQQhjMsP5RzfQs1AotNgIRtnIPe21YpH+7NqnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR18MB4357 X-Proofpoint-GUID: mRkJTwE7LHA4sPlD8lMGveK8qNH6YXtg X-Proofpoint-ORIG-GUID: mRkJTwE7LHA4sPlD8lMGveK8qNH6YXtg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-18_12,2024-03-18_03,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > + if (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && > > > + (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || > > > + options->cipher_op =3D=3D RTE_CRYPTO_CIPHER_OP_DECRYPT) && > > > + !options->out_of_place) { > > > + RTE_LOG(ERR, USER1, "Only out-of-place is allowed in > > > throughput decryption.\n"); > > > + return -EINVAL; > > > + } > > > > This check is blocking cipher_only decryption which should pass irrespe= ctive of > > inplace/oop and Data correct/incorrect. >=20 > Sorry, in that case I will remove "options->cipher_op =3D=3D > RTE_CRYPTO_CIPHER_OP_DECRYPT" and only kept " options->aead_op =3D=3D > RTE_CRYPTO_AEAD_OP_DECRYPT ", what do you think? I would suggest to check for "auth_op =3D=3D RTE_CRYPTO_AUTH_OP_VERIFY" Instead of cipher_op. Ciara, What do you suggest? You were also seeing some issues in this patch.