From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5D054541F; Thu, 13 Jun 2024 20:04:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5184402E4; Thu, 13 Jun 2024 20:04:01 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 526084027C for ; Thu, 13 Jun 2024 20:03:59 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45DDDfvV031536; Thu, 13 Jun 2024 11:03:57 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2042.outbound.protection.outlook.com [104.47.70.42]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3yr1fh1a1x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jun 2024 11:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVcKd43qiWHzn3tNeWp9nxGJIAn/yJfm2VSFf9KtTWhtj57BLQRNs97ptQnF/sJ3BEgwF7kZCHFrkVUhwE2RdjostleLPd0WC/VFRsmlshp+7Ld5MkxmEMI5SaJhmA+32JVTgFOJrDBhNgTwIYYzzX5G9pIsU0nReP4mE7/UL4M8RGBArSAbVnXJCyjFkiiCJCJlD26PyxbIVmtd6MeFe2/L5EgNXAsgLbynfa9fcx28kc34N8oA3UJb6IwZMWaNhXQOkdGLFknF9pQa3155cXFhTftU66Qlp5sUN/b3Dtesm9r7jKLm55fvK+PCYrDRO44LG4goyPEvYRO+qZrgCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YkQ2I/irrVis0o+3UR+WyecNyRMuzRfuakMqp9RqAlY=; b=ictadv3829lE/s/tXkOwf9EyC4lP0l927BdQR7RrKqIHwYMrwfMQZ5eUl2VTzdnw5MnzeLlWID3HcygircE4VU4MTP+tGSgthQuaLIQk/PNr/4k7TUFnTp8orEMAtGlVk+5b0K36ZAdjw5KDITet/ICU/k66UT+CuhJ7yOtqBzq5WHxMthSDf/phS7a7eyjvGi9sFE2eULTIITI1eMuZniNNqSoC00iNgD93OQMG8r6PYVyGsNr3G+YAP++NDfW4H2exPlo9lIfpeLvl5X9bcmOLpe2b9CWrTox+3wkNGMoYk1h66Jl4RtSIkc62FZskRTaeWc3GX0AnDa0TqJ5lhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkQ2I/irrVis0o+3UR+WyecNyRMuzRfuakMqp9RqAlY=; b=ZmSwFvva2cV2Ahs0QBH9sXr6tLr7b6MV6GF22T3jd38CYu7qO3Ni8dQAcYRAbHS7XSSUKGShc3tG6pZSCPQeJwTjaOQW5xECvWThh5eqnCdg9bz69KFK72RfT8ebnP8GAPkvSkncjxo8NqxjD2O6eCVxt4n075t5NuMYmplOt6s= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SA6PR18MB6294.namprd18.prod.outlook.com (2603:10b6:806:417::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Thu, 13 Jun 2024 18:03:54 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d%6]) with mapi id 15.20.7677.019; Thu, 13 Jun 2024 18:03:54 +0000 From: Akhil Goyal To: "Kundapura, Ganapati" , "dev@dpdk.org" , "Gujjar, Abhinandan S" , "john.mcnamara@intel.com" , "Richardson, Bruce" CC: =?iso-8859-1?Q?Morten_Br=F8rup?= , "ferruh.yigit@amd.com" , "fanzhang.oss@gmail.com" , "thomas@monjalon.net" Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Topic: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Index: AQHasdYqBA7BiFARTUmhLk6iVntHPbGvZbfQgAA31SCAAAr8AIAAAGqQgAAs6ACAAAeTgIAKqh8QgAuMlNA= Date: Thu, 13 Jun 2024 18:03:54 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> <20240529144025.4089318-1-ganapati.kundapura@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F4DC@smartserver.smartshare.dk> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SA6PR18MB6294:EE_ x-ms-office365-filtering-correlation-id: cfa781d9-9685-47fa-8fe2-08dc8bd33034 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230035|1800799019|366011|376009|38070700013; x-microsoft-antispam-message-info: =?iso-8859-1?Q?Nr7E9zyu0VFlV0Dh6Z37mgzWwHYJMxv23mqJpGK8Tso/v1A+VN3EVgQbVf?= =?iso-8859-1?Q?mtqch5AJJ8tyPqVZCnzUqQqzV5IUXJzlxJLFHocWxnpdCz2NOsfAxdabZC?= =?iso-8859-1?Q?MFHaVZa+eOfjdiOzkDt4AfpMB5ORu+qpBrDwY94YkxrV08yxOhPbqz7HTj?= =?iso-8859-1?Q?+7kRGpqCpufIcF+iedkEdp9LUyRi517QGtsOvDF3WHsjSBIvwMmLqZBtAb?= =?iso-8859-1?Q?l3QgdSRL300GgCUzh9XVruJYo9syl3RL8wcFtdon8QO1HIzD+H080gL0yb?= =?iso-8859-1?Q?Q6hYZKbwYm21ijuR+dz3+agwnzt+H4pnDgASVAqGqWqEOg7CS7KK/uai3L?= =?iso-8859-1?Q?MsXEWKdlEBuxxsxGZweVan8PVcRJEdpn+qy0WrnnZO8h8gTlzglDC3S5OO?= =?iso-8859-1?Q?YbenhS41towv7k/gRK7jtZafUAZYxTsA7eMQx1lq2lAd/edVMGpTYklNUj?= =?iso-8859-1?Q?9n3OFujTYUbOSmcUQigjkBaLHdmTJxooWKb85pJ4JMvW9l1hwuxZ55kYdV?= =?iso-8859-1?Q?AkL7yKpLE3Z//T+62E9sRhoLezJfwIGjCB9EAg8EhU7BOF6O5IHrxJlEFX?= =?iso-8859-1?Q?t1EcmYDXTrOw6XiewYXokzjNWpdOe/fak7S2DGFLqqIKulM/IzeArDBkOZ?= =?iso-8859-1?Q?pAUui0/TDsCTmi0zsuVYbnMPYbTUSi/48VfVoJY8Z/Sasa2FjdPymOpV/T?= =?iso-8859-1?Q?owdO2p+dcf8tC+PF748Wnip1U87is5h3RsTji1fPR9QRPr7OibMD/mDtw4?= =?iso-8859-1?Q?oO2VTkbxZZl8HEiDM2+uP0ICrylryrINaua6/g3W5F8op4Iu5nwkCy7kUG?= =?iso-8859-1?Q?KSDMucQ4rbvdlHR98K3m7WqidJPYyRNwqGf+SAS22rlJbl9GoBvk6LtnU7?= =?iso-8859-1?Q?q7gyX/Jw18aCx5ZiqZcJTD+n0tFsV/CW2iXgfytazEkF504gAlXmhH0W8s?= =?iso-8859-1?Q?WhFQUSnD11OUHPA2RtwR4n0BOu1E7aJObttZ7HpViM6ePtRTWppHCkUPLI?= =?iso-8859-1?Q?+i2X6aCKxL00OB+c+EPyquHbe/GRTkWXGoJXvNTzocu+Or0OUdaKtB6Czb?= =?iso-8859-1?Q?YPJO+TZ2x8skiYtiduR1/wZSniLIffvuNIZIhI9/xYGglUBAwkokAq4Stl?= =?iso-8859-1?Q?5pXYOYdD50vFKFZlyR+4kZPIU/MBN5PF6qx1VaJQ85k29Elpbfe/OC/uAd?= =?iso-8859-1?Q?09knoOqLqVxmZj0ZA4quB+yH1QLEo8EBkR0oj4mFL9+0G/CRz1UcQpZ7JC?= =?iso-8859-1?Q?TDYYSNFYcXjLZiqusN1rLvuaFLlI8PRDuudrHObwskywb5Okmcz3Or1EG8?= =?iso-8859-1?Q?9kFYfFrkisUaVCKMNiS2h9AmZhoFqIe4WjJ2WX/H2X350IOfmKXkYg+ubD?= =?iso-8859-1?Q?e8KaWC+migB7ajcyQRHmAOpa8wnAqPbtUTBXK0eCeTcrTtZkP1JqA=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230035)(1800799019)(366011)(376009)(38070700013); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?3PeqtNi2+z/X+bjsooO8EFSXjfkuL5QFiLrSpZMjW6wQ6ltffv3q2gUAz3?= =?iso-8859-1?Q?zXiG2skK86PX3EivyJtm1F/hletZA0eOSMH0/7fjEvBsmw1XgJPgbv9KWd?= =?iso-8859-1?Q?KrR0OZQ1+SXcYOeLkkCKwzoOPpCnyfyLWtPaWDlum6LmN6Tp6ny07KUPiA?= =?iso-8859-1?Q?GYEjP/bFVuaLgz0blEgxVxJO/XefMzajcX30MnuJ6LkMRmLnp9W7d7d31r?= =?iso-8859-1?Q?pCpAbY30DapkwSgv0zv9cINIHfYl+6/pSN0cAPLYM3sf5cjibdmXwIx8O/?= =?iso-8859-1?Q?2HHaF+MmG+4NuWpYj7CqggI50iI2RrcgztHRA+F8bdH7MWtdREIt+7Dwa8?= =?iso-8859-1?Q?HDL7bVx6psY54Q44RZX3EobrrV/CMzSy5JAHWO3FzvqncrZHdb1od2jWNb?= =?iso-8859-1?Q?/UyBV+x4gD2fkhs4sCpPRcmBcAgnmV9PwleeT/jOynn0MeCNduF7oGXUOA?= =?iso-8859-1?Q?9bZT0BnzKKfFb9TsEng1yVZeSYuvsTIBlPKMLgExp2qxXk/FKzLy8BE041?= =?iso-8859-1?Q?mosJYWkL9AC7ClR1ba6ZrWSg4C1ZRrgRSIE/MoclfJig1EBaGD7zqQVZ64?= =?iso-8859-1?Q?yXTSl58fB8vtREB0L/N9ezs/Lv/JLa6UxABo+HCUJQSfOXa5p5nKPCL4hr?= =?iso-8859-1?Q?n4K7DoKu5PKYDOK7Fe1eDyhFC1eJQ6rD56RIBgwhC9e1x9deqHDA1z/Ju+?= =?iso-8859-1?Q?LHk4gGc/A4Znm+K0uX4p/zt+6DtcpvLlUXa5+w7ZCu4ziuUqgxSoTpzzzp?= =?iso-8859-1?Q?i/i/Cacp8gE6sMwTwEVriqh1oR7cAPKpSdcOBsOiu/XdmahRgfvV/onO8F?= =?iso-8859-1?Q?PPMVaD0OM5aRHNxAepCgaE8aSIDd8rCUBp/MAub1SM31yheRa2va5Rh+6U?= =?iso-8859-1?Q?sL2oHAGAwyCHopg8PY0cyEJTiRqI09+bQL13n1t5KpAW2TPRp2wOgTkJWM?= =?iso-8859-1?Q?gthbMjwZSQQ2e/AGHienbkTeDTszFmwSeW4uV1pYSyWTES8m3D/1aHhDq7?= =?iso-8859-1?Q?H2EOCEAdHBMwYlNxq0JFHnUJUNMPN/lsogQdPouD+k66aBwvcv3TQN5XDt?= =?iso-8859-1?Q?KSSiNm0719+x+T4z64BYXE2OecBo2iPa+vTP91noyYdOpQeXZcRL1F9DJ5?= =?iso-8859-1?Q?39el9H0m0NVQ+jMGp+3yKPpE5GrXpDYPfmxfS0QcwCAXA65ZzqTn0uqck5?= =?iso-8859-1?Q?qpXjmLXngY/1hflbbtGZDO7IxTWG3ZXHdKm49udwbLA6/YbQER2Fy0Ez7Q?= =?iso-8859-1?Q?5ZGssHZV8Mz14Tvhi2TmYeKYypBhU1aM48GIBh8WeSa7J55Z/pGa7mWBqf?= =?iso-8859-1?Q?4baBn9rsaANr5/VzeMkN6+EfGdFWQuc4Z1prOODGjbPKYCxaMA1c7MoRgp?= =?iso-8859-1?Q?f1KQ1IUW1sGezdnYlWFOUjP4/RCJPr9rcdooGbmEjV7FI4RyXajr0qEolG?= =?iso-8859-1?Q?+KQ5l7Ej1FJ4tMH2/kwFyHRz/ij9E1dbEij9e/0Tsod9B2rGZ7UV5z5M4P?= =?iso-8859-1?Q?YNMgvhiHm+ejTtiYipjepv/RQHinggZ0Zydc0FiXjEPk7wjmKMgNoEk3cA?= =?iso-8859-1?Q?obUyp9Aj88O8RiDSbqWGas9xm2sTxqCCV4l1R831cohShwmo6b/miB8DJ+?= =?iso-8859-1?Q?2v23H0WnFczQrwAO/sGUyoNm6xQbT1CGR7?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfa781d9-9685-47fa-8fe2-08dc8bd33034 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2024 18:03:54.2829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0JlYQzIYryg7SZb0919YgRAq8Vp3M9LU7zaVdlQPbqFWoiMJlrVHu1Mr2dPGf6pWqXOGJBovStSFUQncaxznEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA6PR18MB6294 X-Proofpoint-GUID: FT3oOIUxQ0AfrDfiN3x3SJ3oge8Hyb16 X-Proofpoint-ORIG-GUID: FT3oOIUxQ0AfrDfiN3x3SJ3oge8Hyb16 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_11,2024-06-13_02,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > From: Kundapura, Ganapati [mailto:ganapati.kundapura@intel.com] > > > Sent: Thursday, 30 May 2024 16.22 > > > > > > Hi, > > > > > > > From: Akhil Goyal > > > > Sent: Thursday, May 30, 2024 5:17 PM > > > > > > > > > > > #if may not be needed in application. > > > > > > > Test should be skipped if API is not available/supported. > > > > > > > > > > > > It's needed otherwise application developer has to check the > > > > > implementation for supported/not supported or else run the applic= ation > > > > > to get to know whether api is supported or not. > > > > > > > > > > > > > Application is always required to check the return value or else it= will > > > miss the > > > > other errors that the API can return. > > > Currently RTE_CRYPTO_CALLBACKS is enabled by default and test applica= tion > > > checks the > > > return value of the APIs. This patch fixes build issues on compiling = the DPDK > > > with unsetting > > > RTE_CRYPTO_CALLBACKS. > > > > > > > > > > > > diff --git a/lib/cryptodev/rte_cryptodev.c > > > > > > > > b/lib/cryptodev/rte_cryptodev.c index 886eb7a..2e0890f 1006= 44 > > > > > > > > --- a/lib/cryptodev/rte_cryptodev.c > > > > > > > > +++ b/lib/cryptodev/rte_cryptodev.c > > > > > > > > @@ -628,6 +628,7 @@ > > > > > > rte_cryptodev_asym_xform_capability_check_hash( > > > > > > > > return ret; > > > > > > > > } > > > > > > > > > > > > > > > > +#if RTE_CRYPTO_CALLBACKS > > > > > > > > /* spinlock for crypto device enq callbacks */ static > > > > > > > > rte_spinlock_t rte_cryptodev_callback_lock =3D > > > > > > > RTE_SPINLOCK_INITIALIZER; > > > > > > > > > > > > > > > > @@ -744,6 +745,7 @@ cryptodev_cb_init(struct rte_cryptodev > *dev) > > > > > > > > cryptodev_cb_cleanup(dev); > > > > > > > > return -ENOMEM; > > > > > > > > } > > > > > > > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > > > > > > > > > > > > > > > > > > > @@ -1485,6 +1491,7 @@ rte_cryptodev_queue_pair_setup(uint8_= t > > > > > > dev_id, > > > > > > > > uint16_t queue_pair_id, > > > > > > > > socket_id); > > > > > > > > } > > > > > > > > > > > > > > > > +#if RTE_CRYPTO_CALLBACKS > > > > > > > > struct rte_cryptodev_cb * > > > > > > > > rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > > > > > > uint16_t qp_id, > > > > > > > > @@ -1763,6 +1770,7 @@ > > > > rte_cryptodev_remove_deq_callback(uint8_t > > > > > > dev_id, > > > > > > > > rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > > > > > > > return ret; > > > > > > > > } > > > > > > > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > > > > > > > > > > > There is an issue here. > > > > > > > The APIs are visible in .h file and are available for applica= tion to > > > use. > > > > > > > But the API implementation is compiled out. > > > > > > > Rather, you should add a return ENOTSUP from the beginning of= the > > > > > > > APIs if RTE_CRYPTO_CALLBACKS is enabled. > > > > > > > With this approach application will not need to put #if in it= s code. > > > > > API declarations wrapped under the macro changes in next patch. > > > > > > > > No, that is not the correct way. Application should check the retur= n value. > > > > And we cannot force it to add ifdefs. > > > Test application is indeed checking the return value. Ifdefs are adde= d to > > > avoid build issues on compiling with RTE_CRYPTO_CALLBACKS is turned o= ff > > > Which is on by default. > > > > The test application should be able to build and run, regardless if the= DPDK > library > > was built with RTE_CRYPTO_CALLBACKS defined or not. > > > > The test application should not assume that the DPDK library was built = with the > > same RTE_CRYPTO_CALLBACKS configuration (i.e. defined or not) as the te= st > > application. > > > > > Even ethdev callbacks also doesn't return -ENOTSUP > > > on setting/unsetting RTE_ETHDEV_RXTX_CALLBACKS config. > > > > That would be a bug in the ethdev library. > > I just checked the ethdev source code (/source/lib/ethdev/rte_ethdev.c)= , and > all > > the add/remove rx/tx callback functions fail with ENOTSUP if > > RTE_ETHDEV_RXTX_CALLBACKS is not defined. > > Please note that some ethdev callbacks are not rx/tx callbacks, and thu= s are not > > gated by RTE_ETHDEV_RXTX_CALLBACKS. >=20 > Hi Ganapati, > Can you send a new version incorporating above comments and > work on similar lines as ethdev is currently doing. >=20 > I believe as Morten pointed out, use of ifdef is as per DPDK convention, > So better move it that way. > We can discuss later if we can incorporate these in meson options. >=20 Any update on this?