From: Akhil Goyal <gakhil@marvell.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>,
Declan Doherty <declan.doherty@intel.com>,
Fan Zhang <royzhang1980@gmail.com>,
Ashish Gupta <ashishg@marvell.com>, Ray Kinsella <mdr@ashroe.eu>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "acc@openeuler.org" <acc@openeuler.org>
Subject: RE: [EXT] [PATCH resend v5 2/6] crypto/uadk: support basic operations
Date: Tue, 25 Oct 2022 14:18:02 +0000 [thread overview]
Message-ID: <CO6PR18MB44845802BECB276352D0E56AD8319@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20221024134409.1896776-3-zhangfei.gao@linaro.org>
> +/* Maximum length for digest (SHA-512 needs 64 bytes) */
> +#define DIGEST_LENGTH_MAX 64
> +
> +struct uadk_qp {
> + /* Ring for placing process packets */
> + struct rte_ring *processed_pkts;
> + /* Queue pair statistics */
> + struct rte_cryptodev_stats qp_stats;
> + /* Queue Pair Identifier */
> + uint16_t id;
> + /* Unique Queue Pair Name */
> + char name[RTE_CRYPTODEV_NAME_MAX_LEN];
> + /* Buffer used to store the digest generated
> + * by the driver when verifying a digest provided
> + * by the user (using authentication verify operation)
> + */
> + uint8_t temp_digest[DIGEST_LENGTH_MAX];
> +} __rte_cache_aligned;
> +
Same comment as on 1/6.
It is better to move the structure definitions in header file.
next prev parent reply other threads:[~2022-10-25 14:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 13:44 [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
2022-10-24 13:44 ` [PATCH resend v5 1/6] " Zhangfei Gao
2022-10-25 14:08 ` [EXT] " Akhil Goyal
2022-10-24 13:44 ` [PATCH resend v5 2/6] crypto/uadk: support basic operations Zhangfei Gao
2022-10-25 14:18 ` Akhil Goyal [this message]
2022-10-24 13:44 ` [PATCH resend v5 3/6] crypto/uadk: support enqueue/dequeue operations Zhangfei Gao
2022-10-24 13:44 ` [PATCH resend v5 4/6] crypto/uadk: support cipher algorithms Zhangfei Gao
2022-10-25 14:28 ` [EXT] " Akhil Goyal
2022-10-24 13:44 ` [PATCH resend v5 5/6] crypto/uadk: support auth algorithms Zhangfei Gao
2022-10-25 14:38 ` [EXT] " Akhil Goyal
2022-10-26 10:02 ` Zhangfei Gao
2022-10-24 13:44 ` [PATCH resend v5 6/6] test/crypto: add cryptodev_uadk_autotest Zhangfei Gao
2022-10-25 14:54 ` [EXT] " Akhil Goyal
2022-10-26 9:57 ` Zhangfei Gao
2022-10-25 14:59 ` [EXT] [PATCH resend v5 0/6] crypto/uadk: introduce uadk crypto driver Akhil Goyal
2022-10-26 9:53 ` Zhangfei Gao
2022-10-26 10:16 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44845802BECB276352D0E56AD8319@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=acc@openeuler.org \
--cc=ashishg@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=royzhang1980@gmail.com \
--cc=thomas@monjalon.net \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).