DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 1/1] doc: notice to add new ipsec event subtypes
@ 2022-06-24 13:35 Vamsi Attunuru
  2022-06-24 18:18 ` Akhil Goyal
  2022-06-27  5:29 ` [PATCH v2 1/1] doc: announce addition of " Vamsi Attunuru
  0 siblings, 2 replies; 10+ messages in thread
From: Vamsi Attunuru @ 2022-06-24 13:35 UTC (permalink / raw)
  To: dev; +Cc: jerinj, vattunuru, gakhil, ferruh.yigit, thomas, mdr

Based on discussion in below email thread, the new event subtypes can be
added in 22.11 release with fixing any compatability issues mentioned in
the mail thread.

https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c53d..83da1c62ac 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -107,6 +107,11 @@ Deprecation Notices
   alternative is implemented.
   The legacy actions should be removed in DPDK 22.11.
 
+* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
+  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
+  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
+  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
+
 * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
   ``rte_cryptodev_asym_session`` to remove unnecessary indirection between
   session and the private data of session. An opaque pointer can be exposed
-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH 1/1] doc: notice to add new ipsec event subtypes
  2022-06-24 13:35 [PATCH 1/1] doc: notice to add new ipsec event subtypes Vamsi Attunuru
@ 2022-06-24 18:18 ` Akhil Goyal
  2022-06-27  5:29 ` [PATCH v2 1/1] doc: announce addition of " Vamsi Attunuru
  1 sibling, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2022-06-24 18:18 UTC (permalink / raw)
  To: Vamsi Krishna Attunuru, dev
  Cc: Jerin Jacob Kollanukkaran, Vamsi Krishna Attunuru, ferruh.yigit,
	thomas, mdr, andrew.rybchenko, Konstantin Ananyev,
	bruce.richardson, rasland, david.marchand

> Subject: [PATCH 1/1] doc: notice to add new ipsec event subtypes

Title should be
doc: announce addition of new IPsec event subtypes
> 
> Based on discussion in below email thread, the new event subtypes can be
> added in 22.11 release with fixing any compatability issues mentioned in
> the mail thread.
> 
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> gakhil@marvell.com/
> 
Description should be 

New event subtypes need to be added for notifying expiry events upon reaching
IPsec SA soft packet expiry and hard packet/byte expiry limits. This would be 
added in DPDK 22.11.

You can give the reference to patch after --- so that it is not visible in git log

Adding more people for acks.

> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Other that this
Acked-by: Akhil Goyal <gakhil@marvell.com>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-06-24 13:35 [PATCH 1/1] doc: notice to add new ipsec event subtypes Vamsi Attunuru
  2022-06-24 18:18 ` Akhil Goyal
@ 2022-06-27  5:29 ` Vamsi Attunuru
  2022-07-06  9:49   ` Zhang, Roy Fan
  2022-07-12 15:03   ` Thomas Monjalon
  1 sibling, 2 replies; 10+ messages in thread
From: Vamsi Attunuru @ 2022-06-27  5:29 UTC (permalink / raw)
  To: dev; +Cc: jerinj, vattunuru, gakhil, ferruh.yigit, thomas, anoobj, mdr

New event subtypes need to be added for notifying expiry events
upon reaching IPsec SA soft packet expiry and hard packet/byte
expiry limits. This would be added in DPDK 22.11.

Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
More details on new event subtype proposal discussion are in below email thread.
https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/

v2: rephrase title and git log.
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c53d..83da1c62ac 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -107,6 +107,11 @@ Deprecation Notices
   alternative is implemented.
   The legacy actions should be removed in DPDK 22.11.
 
+* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
+  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
+  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
+  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
+
 * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
   ``rte_cryptodev_asym_session`` to remove unnecessary indirection between
   session and the private data of session. An opaque pointer can be exposed
-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-06-27  5:29 ` [PATCH v2 1/1] doc: announce addition of " Vamsi Attunuru
@ 2022-07-06  9:49   ` Zhang, Roy Fan
  2022-07-11 14:53     ` Jerin Jacob
  2022-07-12 15:03   ` Thomas Monjalon
  1 sibling, 1 reply; 10+ messages in thread
From: Zhang, Roy Fan @ 2022-07-06  9:49 UTC (permalink / raw)
  To: Vamsi Attunuru, dev; +Cc: jerinj, gakhil, ferruh.yigit, thomas, anoobj, mdr

> -----Original Message-----
> From: Vamsi Attunuru <vattunuru@marvell.com>
> Sent: Monday, June 27, 2022 6:30 AM
> To: dev@dpdk.org
> Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
> ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
> mdr@ashroe.eu
> Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
> 
> New event subtypes need to be added for notifying expiry events
> upon reaching IPsec SA soft packet expiry and hard packet/byte
> expiry limits. This would be added in DPDK 22.11.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> More details on new event subtype proposal discussion are in below email
> thread.
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> gakhil@marvell.com/
> 
> v2: rephrase title and git log.
> ---
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-07-06  9:49   ` Zhang, Roy Fan
@ 2022-07-11 14:53     ` Jerin Jacob
  2022-07-12 11:44       ` Andrew Rybchenko
  0 siblings, 1 reply; 10+ messages in thread
From: Jerin Jacob @ 2022-07-11 14:53 UTC (permalink / raw)
  To: Zhang, Roy Fan
  Cc: Vamsi Attunuru, dev, jerinj, gakhil, ferruh.yigit, thomas, anoobj, mdr

On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan <roy.fan.zhang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Vamsi Attunuru <vattunuru@marvell.com>
> > Sent: Monday, June 27, 2022 6:30 AM
> > To: dev@dpdk.org
> > Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
> > ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
> > mdr@ashroe.eu
> > Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
> >
> > New event subtypes need to be added for notifying expiry events
> > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > expiry limits. This would be added in DPDK 22.11.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > More details on new event subtype proposal discussion are in below email
> > thread.
> > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
> > gakhil@marvell.com/
> >
> > v2: rephrase title and git log.
> > ---
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-07-11 14:53     ` Jerin Jacob
@ 2022-07-12 11:44       ` Andrew Rybchenko
  2022-07-17 10:07         ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Andrew Rybchenko @ 2022-07-12 11:44 UTC (permalink / raw)
  To: Jerin Jacob, Zhang, Roy Fan
  Cc: Vamsi Attunuru, dev, jerinj, gakhil, thomas, anoobj, mdr

On 7/11/22 17:53, Jerin Jacob wrote:
> On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan <roy.fan.zhang@intel.com> wrote:
>>
>>> -----Original Message-----
>>> From: Vamsi Attunuru <vattunuru@marvell.com>
>>> Sent: Monday, June 27, 2022 6:30 AM
>>> To: dev@dpdk.org
>>> Cc: jerinj@marvell.com; vattunuru@marvell.com; gakhil@marvell.com;
>>> ferruh.yigit@intel.com; thomas@monjalon.net; anoobj@marvell.com;
>>> mdr@ashroe.eu
>>> Subject: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
>>>
>>> New event subtypes need to be added for notifying expiry events
>>> upon reaching IPsec SA soft packet expiry and hard packet/byte
>>> expiry limits. This would be added in DPDK 22.11.
>>>
>>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
>>> Acked-by: Akhil Goyal <gakhil@marvell.com>
>>> ---
>>> More details on new event subtype proposal discussion are in below email
>>> thread.
>>> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-
>>> gakhil@marvell.com/
>>>
>>> v2: rephrase title and git log.
>>> ---
>> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-06-27  5:29 ` [PATCH v2 1/1] doc: announce addition of " Vamsi Attunuru
  2022-07-06  9:49   ` Zhang, Roy Fan
@ 2022-07-12 15:03   ` Thomas Monjalon
  2022-07-12 15:30     ` [EXT] " Akhil Goyal
  1 sibling, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2022-07-12 15:03 UTC (permalink / raw)
  To: Vamsi Attunuru; +Cc: dev, jerinj, vattunuru, gakhil, ferruh.yigit, anoobj, mdr

27/06/2022 07:29, Vamsi Attunuru:
> New event subtypes need to be added for notifying expiry events
> upon reaching IPsec SA soft packet expiry and hard packet/byte
> expiry limits. This would be added in DPDK 22.11.
> 
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> More details on new event subtype proposal discussion are in below email thread.
> https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/
> 
> v2: rephrase title and git log.
> ---
> +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to add
> +  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> +  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> +  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.

While at it, would you consider avoiding future ABI breakage
with RTE_ETH_EVENT_IPSEC_MAX?




^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [EXT] Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-07-12 15:03   ` Thomas Monjalon
@ 2022-07-12 15:30     ` Akhil Goyal
  2022-07-12 20:44       ` Thomas Monjalon
  0 siblings, 1 reply; 10+ messages in thread
From: Akhil Goyal @ 2022-07-12 15:30 UTC (permalink / raw)
  To: Thomas Monjalon, Vamsi Krishna Attunuru
  Cc: dev, Jerin Jacob Kollanukkaran, Vamsi Krishna Attunuru,
	ferruh.yigit, Anoob Joseph, mdr

> 27/06/2022 07:29, Vamsi Attunuru:
> > New event subtypes need to be added for notifying expiry events
> > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > expiry limits. This would be added in DPDK 22.11.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > More details on new event subtype proposal discussion are in below email
> thread.
> > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/> >
> > v2: rephrase title and git log.
> > ---
> > +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to
> add
> > +  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> > +  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> > +  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
> 
> While at it, would you consider avoiding future ABI breakage
> with RTE_ETH_EVENT_IPSEC_MAX?

For MAX values there is already a generic notice. Do you want to mention this here as well?
IMO, it is not required. We can work on it, but do not need explicit mention here.

Regards,
Akhil

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXT] Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-07-12 15:30     ` [EXT] " Akhil Goyal
@ 2022-07-12 20:44       ` Thomas Monjalon
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2022-07-12 20:44 UTC (permalink / raw)
  To: Vamsi Krishna Attunuru, Akhil Goyal
  Cc: dev, Jerin Jacob Kollanukkaran, Vamsi Krishna Attunuru,
	ferruh.yigit, Anoob Joseph, mdr

12/07/2022 17:30, Akhil Goyal:
> > 27/06/2022 07:29, Vamsi Attunuru:
> > > New event subtypes need to be added for notifying expiry events
> > > upon reaching IPsec SA soft packet expiry and hard packet/byte
> > > expiry limits. This would be added in DPDK 22.11.
> > >
> > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > > ---
> > > More details on new event subtype proposal discussion are in below email
> > thread.
> > > https://patches.dpdk.org/project/dpdk/patch/20220416192530.173895-8-gakhil@marvell.com/> >
> > > v2: rephrase title and git log.
> > > ---
> > > +* ethdev: The enum ``rte_eth_event_ipsec_subtype`` would be extended to
> > add
> > > +  new subtype values ``RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY``,
> > > +  ``RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY`` and
> > > +  ``RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY`` in DPDK 22.11.
> > 
> > While at it, would you consider avoiding future ABI breakage
> > with RTE_ETH_EVENT_IPSEC_MAX?
> 
> For MAX values there is already a generic notice. Do you want to mention this here as well?
> IMO, it is not required. We can work on it, but do not need explicit mention here.

OK I forgot we had already a generic notice.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes
  2022-07-12 11:44       ` Andrew Rybchenko
@ 2022-07-17 10:07         ` Thomas Monjalon
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2022-07-17 10:07 UTC (permalink / raw)
  To: Jerin Jacob, Vamsi Attunuru
  Cc: Zhang, Roy Fan, dev, dev, jerinj, gakhil, anoobj, mdr, Andrew Rybchenko

> >>> New event subtypes need to be added for notifying expiry events
> >>> upon reaching IPsec SA soft packet expiry and hard packet/byte
> >>> expiry limits. This would be added in DPDK 22.11.
> >>>
> >>> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> >>> Acked-by: Akhil Goyal <gakhil@marvell.com>
> >> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied, thanks.




^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-07-17 10:07 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 13:35 [PATCH 1/1] doc: notice to add new ipsec event subtypes Vamsi Attunuru
2022-06-24 18:18 ` Akhil Goyal
2022-06-27  5:29 ` [PATCH v2 1/1] doc: announce addition of " Vamsi Attunuru
2022-07-06  9:49   ` Zhang, Roy Fan
2022-07-11 14:53     ` Jerin Jacob
2022-07-12 11:44       ` Andrew Rybchenko
2022-07-17 10:07         ` Thomas Monjalon
2022-07-12 15:03   ` Thomas Monjalon
2022-07-12 15:30     ` [EXT] " Akhil Goyal
2022-07-12 20:44       ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).