* [PATCH] test/crypto: remove unused variable
@ 2025-02-20 13:28 Shaokai Zhang
2025-03-02 20:29 ` [EXTERNAL] " Akhil Goyal
0 siblings, 1 reply; 2+ messages in thread
From: Shaokai Zhang @ 2025-02-20 13:28 UTC (permalink / raw)
To: dev; +Cc: gakhil, fanzhang.oss, Joey Xing
In the new session framework, each crypto session no longer requires
the session_priv_mpool, and it is no longer referenced during testsuite
setup. However, the structure `struct crypto_testsuite_params` still
contains the session_priv_mpool member, which may lead to
the misunderstanding that session_priv_mpool still needs initialization.
Fixes: bdce2564dbf7 ("cryptodev: rework session framework")
Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
Signed-off-by: Shaokai Zhang <felix.zhang@jaguarmicro.com>
Reviewed-by: Joey Xing <joey.xing@jaguarmicro.com>
---
app/test/test_cryptodev.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h
index bb54a33d62..190a220c73 100644
--- a/app/test/test_cryptodev.h
+++ b/app/test/test_cryptodev.h
@@ -87,7 +87,6 @@ struct crypto_testsuite_params {
struct rte_mempool *large_mbuf_pool;
struct rte_mempool *op_mpool;
struct rte_mempool *session_mpool;
- struct rte_mempool *session_priv_mpool;
struct rte_cryptodev_config conf;
struct rte_cryptodev_qp_conf qp_conf;
--
2.47.1.windows.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [EXTERNAL] [PATCH] test/crypto: remove unused variable
2025-02-20 13:28 [PATCH] test/crypto: remove unused variable Shaokai Zhang
@ 2025-03-02 20:29 ` Akhil Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2025-03-02 20:29 UTC (permalink / raw)
To: Shaokai Zhang, dev; +Cc: fanzhang.oss, Joey Xing
> In the new session framework, each crypto session no longer requires
> the session_priv_mpool, and it is no longer referenced during testsuite
> setup. However, the structure `struct crypto_testsuite_params` still
> contains the session_priv_mpool member, which may lead to
> the misunderstanding that session_priv_mpool still needs initialization.
>
> Fixes: bdce2564dbf7 ("cryptodev: rework session framework")
> Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
>
> Signed-off-by: Shaokai Zhang <felix.zhang@jaguarmicro.com>
> Reviewed-by: Joey Xing <joey.xing@jaguarmicro.com>
Cc: stable@dpdk.org
Acked-by: Akhil Goyal <gakhil@marvell.com>
Updated .mailmap
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-02 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-20 13:28 [PATCH] test/crypto: remove unused variable Shaokai Zhang
2025-03-02 20:29 ` [EXTERNAL] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).