[PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver

DPDK patches and discussions
 help / color / mirror / Atom feed

* [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
@ 2022-10-08  8:37 Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 1/6] " Zhangfei Gao
                   ` (6 more replies)
  0 siblings, 7 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-08  8:37 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc, Zhangfei Gao

Introduce a new crypto PMD for hardware accelerators based on UADK [1].

UADK is a framework for user applications to access hardware accelerators.
UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share
the same page table between IOMMU and MMU.
Thereby user application can directly use virtual address for device dma,
which enhances the performance as well as easy usability.

[1] https://github.com/Linaro/uadk

Test:
sudo dpdk-test --vdev=crypto_uadk (--log-level=6)
RTE>>cryptodev_uadk_autotest
RTE>>quit

resend:
Rebase on next/for-main, which just merged series "cryptodev: rework session framework".

update in v3:
Split patches according to Akhil's suggestions
Please split the patches as below.
1. introduce driver - create files with meson.build and with probe/remove
   and device ops defined but not implemented. You do not need to write empty functions.
   Add basic documentation also which defines what the driver is.
   You can explain the build dependency here.
2. define queue structs and setup/remove APIs
3. Add data path
4. implement cipher op. Add capabilities and documentation of what is supported in each of the patch. Add feature flags etc.
5. implement auth,  add capabilities and documentation
6. test app changes.

Update in v2:
Change uadk_supported_platform to uadk_crypto_version, which matches better
than platform.
enum uadk_crypto_version {
	UADK_CRYPTO_V2,
	UADK_CRYPTO_V3,
};

Update in v1, compared with rfc

Suggested from Akhil Goyal <gakhil@marvell.com>
Only consider crypto PMD first
Split patch into small (individually compiled) patches.
Update MAINTAINERS and doc/guides/cryptodevs/features/uadk.ini

Zhangfei Gao (6):
  crypto/uadk: introduce uadk crypto driver
  crypto/uadk: support basic operations
  crypto/uadk: support enqueue/dequeue operations
  crypto/uadk: support cipher algorithms
  crypto/uadk: support auth algorithms
  test/crypto: add cryptodev_uadk_autotest

 MAINTAINERS                             |    6 +
 app/test/test_cryptodev.c               |    7 +
 app/test/test_cryptodev.h               |    1 +
 doc/guides/cryptodevs/features/uadk.ini |   55 ++
 doc/guides/cryptodevs/index.rst         |    1 +
 doc/guides/cryptodevs/uadk.rst          |   74 ++
 drivers/crypto/meson.build              |    1 +
 drivers/crypto/uadk/meson.build         |   36 +
 drivers/crypto/uadk/uadk_crypto_pmd.c   | 1145 +++++++++++++++++++++++
 drivers/crypto/uadk/version.map         |    3 +
 10 files changed, 1329 insertions(+)
 create mode 100644 doc/guides/cryptodevs/features/uadk.ini
 create mode 100644 doc/guides/cryptodevs/uadk.rst
 create mode 100644 drivers/crypto/uadk/meson.build
 create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c
 create mode 100644 drivers/crypto/uadk/version.map

-- 
2.36.1

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH resend v3 1/6] crypto/uadk: introduce uadk crypto driver
  2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
@ 2022-10-08  8:37 ` Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 2/6] crypto/uadk: support basic operations Zhangfei Gao
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-08  8:37 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc, Zhangfei Gao

Introduce a new crypto PMD for hardware accelerators based on UADK [1].

UADK is a framework for user applications to access hardware accelerators.
UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share
the same page table between IOMMU and MMU.
Thereby user application can directly use virtual address for device dma,
which enhances the performance as well as easy usability.

This patch adds the basic framework.

[1] https://github.com/Linaro/uadk

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 MAINTAINERS                             |   6 ++
 doc/guides/cryptodevs/features/uadk.ini |  33 +++++++
 doc/guides/cryptodevs/index.rst         |   1 +
 doc/guides/cryptodevs/uadk.rst          |  53 ++++++++++
 drivers/crypto/meson.build              |   1 +
 drivers/crypto/uadk/meson.build         |  36 +++++++
 drivers/crypto/uadk/uadk_crypto_pmd.c   | 122 ++++++++++++++++++++++++
 drivers/crypto/uadk/version.map         |   3 +
 8 files changed, 255 insertions(+)
 create mode 100644 doc/guides/cryptodevs/features/uadk.ini
 create mode 100644 doc/guides/cryptodevs/uadk.rst
 create mode 100644 drivers/crypto/uadk/meson.build
 create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c
 create mode 100644 drivers/crypto/uadk/version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index 5472fccf61..ed00b9afd1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1064,6 +1064,12 @@ M: Kai Ji <kai.ji@intel.com>
 F: drivers/crypto/scheduler/
 F: doc/guides/cryptodevs/scheduler.rst
 
+HiSilicon UADK crypto
+M: Zhangfei Gao <zhangfei.gao@linaro.org>
+F: drivers/crypto/uadk/
+F: doc/guides/cryptodevs/uadk.rst
+F: doc/guides/cryptodevs/features/uadk.ini
+
 Intel QuickAssist
 M: Kai Ji <kai.ji@intel.com>
 F: drivers/crypto/qat/
diff --git a/doc/guides/cryptodevs/features/uadk.ini b/doc/guides/cryptodevs/features/uadk.ini
new file mode 100644
index 0000000000..df5ad40e3d
--- /dev/null
+++ b/doc/guides/cryptodevs/features/uadk.ini
@@ -0,0 +1,33 @@
+;
+; Supported features of the 'uadk' crypto driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+HW Accelerated         = Y
+
+;
+; Supported crypto algorithms of the 'uadk' crypto driver.
+;
+[Cipher]
+
+;
+; Supported authentication algorithms of the 'uadk' crypto driver.
+;
+[Auth]
+
+;
+; Supported AEAD algorithms of the 'uadk' crypto driver.
+;
+[AEAD]
+
+;
+; Supported Asymmetric algorithms of the 'uadk' crypto driver.
+;
+[Asymmetric]
+
+;
+; Supported Operating systems of the 'uadk' crypto driver.
+;
+[OS]
+Linux = Y
diff --git a/doc/guides/cryptodevs/index.rst b/doc/guides/cryptodevs/index.rst
index 39cca6dbde..cb4ce227e9 100644
--- a/doc/guides/cryptodevs/index.rst
+++ b/doc/guides/cryptodevs/index.rst
@@ -30,5 +30,6 @@ Crypto Device Drivers
     scheduler
     snow3g
     qat
+    uadk
     virtio
     zuc
diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst
new file mode 100644
index 0000000000..a170224cac
--- /dev/null
+++ b/doc/guides/cryptodevs/uadk.rst
@@ -0,0 +1,53 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright 2022-2023 Huawei Technologies Co.,Ltd. All rights reserved.
+    Copyright 2022-2023 Linaro ltd.
+
+UADK Crypto Poll Mode Driver
+=======================================================
+
+UADK crypto PMD provides poll mode driver
+All cryptographic operations are using UADK crypto API.
+Hardware accelerators using UADK are supposed to be supported.
+
+
+Features
+--------
+
+UADK crypto PMD has support for:
+
+
+Test steps
+-----------
+
+   .. code-block:: console
+
+	1. Build
+	cd dpdk
+	mkdir build
+	meson build (--reconfigure)
+	cd build
+	ninja
+	sudo ninja install
+
+	2. Prepare
+	echo 1024 > /sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages
+	echo 1024 > /sys/devices/system/node/node1/hugepages/hugepages-2048kB/nr_hugepages
+	echo 1024 > /sys/devices/system/node/node2/hugepages/hugepages-2048kB/nr_hugepages
+	echo 1024 > /sys/devices/system/node/node3/hugepages/hugepages-2048kB/nr_hugepages
+	mkdir -p /mnt/huge_2mb
+	mount -t hugetlbfs none /mnt/huge_2mb -o pagesize=2MB
+
+	3. Run test app
+
+Dependency
+------------
+
+UADK crypto PMD relies on UADK library [1]
+
+UADK is a framework for user applications to access hardware accelerators.
+UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share
+the same page table between IOMMU and MMU.
+As a result, user application can directly use virtual address for device dma,
+which enhances the performance as well as easy usability.
+
+[1] https://github.com/Linaro/uadk
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index 147b8cf633..ee5377deff 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -18,6 +18,7 @@ drivers = [
         'octeontx',
         'openssl',
         'scheduler',
+        'uadk',
         'virtio',
 ]
 
diff --git a/drivers/crypto/uadk/meson.build b/drivers/crypto/uadk/meson.build
new file mode 100644
index 0000000000..dda6c6b257
--- /dev/null
+++ b/drivers/crypto/uadk/meson.build
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2022-2023 Huawei Technologies Co.,Ltd. All rights reserved.
+# Copyright 2022-2023 Linaro ltd.
+
+if not is_linux
+    build = false
+    reason = 'only supported on Linux'
+    subdir_done()
+endif
+
+if arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_64')
+    build = false
+    reason = 'only supported on aarch64'
+    subdir_done()
+endif
+
+sources = files(
+        'uadk_crypto_pmd.c',
+)
+
+deps += 'bus_vdev'
+dep = cc.find_library('libwd_crypto', required: false)
+if not dep.found()
+	build = false
+	reason = 'missing dependency, "libwd_crypto"'
+else
+	ext_deps += dep
+endif
+
+dep = cc.find_library('libwd', required: false)
+if not dep.found()
+	build = false
+	reason = 'missing dependency, "libwd"'
+else
+	ext_deps += dep
+endif
diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c
new file mode 100644
index 0000000000..ec9bb174c7
--- /dev/null
+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c
@@ -0,0 +1,122 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2022-2023 Huawei Technologies Co.,Ltd. All rights reserved.
+ * Copyright 2022-2023 Linaro ltd.
+ */
+
+#include <bus_vdev_driver.h>
+#include <cryptodev_pmd.h>
+#include <rte_bus_vdev.h>
+#include <rte_comp.h>
+#include <stdlib.h>
+#include <uadk/wd_cipher.h>
+#include <uadk/wd_digest.h>
+#include <uadk/wd_sched.h>
+
+enum uadk_crypto_version {
+	UADK_CRYPTO_V2,
+	UADK_CRYPTO_V3,
+};
+
+struct uadk_crypto_priv {
+	enum uadk_crypto_version version;
+} __rte_cache_aligned;
+
+static uint8_t uadk_cryptodev_driver_id;
+
+RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO);
+
+#define UADK_LOG(level, fmt, ...)  \
+	rte_log(RTE_LOG_ ## level, uadk_crypto_logtype,  \
+		"%s() line %u: " fmt "\n", __func__, __LINE__,  \
+		## __VA_ARGS__)
+
+static struct rte_cryptodev_ops uadk_crypto_pmd_ops = {
+		.dev_configure		= NULL,
+		.dev_start		= NULL,
+		.dev_stop		= NULL,
+		.dev_close		= NULL,
+		.stats_get		= NULL,
+		.stats_reset		= NULL,
+		.dev_infos_get		= NULL,
+		.queue_pair_setup	= NULL,
+		.queue_pair_release	= NULL,
+		.sym_session_get_size	= NULL,
+		.sym_session_configure	= NULL,
+		.sym_session_clear	= NULL,
+};
+
+static int
+uadk_cryptodev_probe(struct rte_vdev_device *vdev)
+{
+	struct rte_cryptodev_pmd_init_params init_params = {
+		.name = "",
+		.private_data_size = sizeof(struct uadk_crypto_priv),
+		.max_nb_queue_pairs =
+				RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS,
+	};
+	enum uadk_crypto_version version = UADK_CRYPTO_V2;
+	struct uadk_crypto_priv *priv;
+	struct rte_cryptodev *dev;
+	struct uacce_dev *udev;
+	const char *name;
+
+	udev = wd_get_accel_dev("cipher");
+	if (!udev)
+		return -ENODEV;
+
+	if (!strcmp(udev->api, "hisi_qm_v2"))
+		version = UADK_CRYPTO_V2;
+
+	free(udev);
+
+	name = rte_vdev_device_name(vdev);
+	if (name == NULL)
+		return -EINVAL;
+
+	dev = rte_cryptodev_pmd_create(name, &vdev->device, &init_params);
+	if (dev == NULL) {
+		UADK_LOG(ERR, "driver %s: create failed", init_params.name);
+		return -ENODEV;
+	}
+
+	dev->dev_ops = &uadk_crypto_pmd_ops;
+	dev->driver_id = uadk_cryptodev_driver_id;
+	dev->dequeue_burst = NULL;
+	dev->enqueue_burst = NULL;
+	dev->feature_flags = RTE_CRYPTODEV_FF_HW_ACCELERATED;
+	priv = dev->data->dev_private;
+	priv->version = version;
+
+	rte_cryptodev_pmd_probing_finish(dev);
+
+	return 0;
+}
+
+static int
+uadk_cryptodev_remove(struct rte_vdev_device *vdev)
+{
+	struct rte_cryptodev *cryptodev;
+	const char *name;
+
+	name = rte_vdev_device_name(vdev);
+	if (name == NULL)
+		return -EINVAL;
+
+	cryptodev = rte_cryptodev_pmd_get_named_dev(name);
+	if (cryptodev == NULL)
+		return -ENODEV;
+
+	return rte_cryptodev_pmd_destroy(cryptodev);
+}
+
+static struct rte_vdev_driver uadk_crypto_pmd = {
+	.probe       = uadk_cryptodev_probe,
+	.remove      = uadk_cryptodev_remove,
+};
+
+static struct cryptodev_driver uadk_crypto_drv;
+
+#define UADK_CRYPTO_DRIVER_NAME crypto_uadk
+RTE_PMD_REGISTER_VDEV(UADK_CRYPTO_DRIVER_NAME, uadk_crypto_pmd);
+RTE_PMD_REGISTER_CRYPTO_DRIVER(uadk_crypto_drv, uadk_crypto_pmd.driver,
+			       uadk_cryptodev_driver_id);
diff --git a/drivers/crypto/uadk/version.map b/drivers/crypto/uadk/version.map
new file mode 100644
index 0000000000..c2e0723b4c
--- /dev/null
+++ b/drivers/crypto/uadk/version.map
@@ -0,0 +1,3 @@
+DPDK_22 {
+	local: *;
+};
-- 
2.36.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH resend v3 2/6] crypto/uadk: support basic operations
  2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 1/6] " Zhangfei Gao
@ 2022-10-08  8:37 ` Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 3/6] crypto/uadk: support enqueue/dequeue operations Zhangfei Gao
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-08  8:37 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc, Zhangfei Gao

Support the basic dev control operations: configure, close, start,
stop and get info, as well as queue pairs operations.

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/crypto/uadk/uadk_crypto_pmd.c | 213 ++++++++++++++++++++++++--
 1 file changed, 204 insertions(+), 9 deletions(-)

diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c
index ec9bb174c7..1d1a4b2897 100644
--- a/drivers/crypto/uadk/uadk_crypto_pmd.c
+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c
@@ -12,6 +12,25 @@
 #include <uadk/wd_digest.h>
 #include <uadk/wd_sched.h>
 
+/* Maximum length for digest (SHA-512 needs 64 bytes) */
+#define DIGEST_LENGTH_MAX 64
+
+struct uadk_qp {
+	/* Ring for placing process packets */
+	struct rte_ring *processed_pkts;
+	/* Queue pair statistics */
+	struct rte_cryptodev_stats qp_stats;
+	/* Queue Pair Identifier */
+	uint16_t id;
+	/* Unique Queue Pair Name */
+	char name[RTE_CRYPTODEV_NAME_MAX_LEN];
+	/* Buffer used to store the digest generated
+	 * by the driver when verifying a digest provided
+	 * by the user (using authentication verify operation)
+	 */
+	uint8_t temp_digest[DIGEST_LENGTH_MAX];
+} __rte_cache_aligned;
+
 enum uadk_crypto_version {
 	UADK_CRYPTO_V2,
 	UADK_CRYPTO_V3,
@@ -30,16 +49,192 @@ RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO);
 		"%s() line %u: " fmt "\n", __func__, __LINE__,  \
 		## __VA_ARGS__)
 
+static const struct rte_cryptodev_capabilities uadk_crypto_v2_capabilities[] = {
+	/* End of capabilities */
+	RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
+};
+
+/* Configure device */
+static int
+uadk_crypto_pmd_config(struct rte_cryptodev *dev __rte_unused,
+		       struct rte_cryptodev_config *config __rte_unused)
+{
+	return 0;
+}
+
+/* Start device */
+static int
+uadk_crypto_pmd_start(struct rte_cryptodev *dev __rte_unused)
+{
+	return 0;
+}
+
+/* Stop device */
+static void
+uadk_crypto_pmd_stop(struct rte_cryptodev *dev __rte_unused)
+{
+}
+
+/* Close device */
+static int
+uadk_crypto_pmd_close(struct rte_cryptodev *dev __rte_unused)
+{
+	return 0;
+}
+
+/* Get device statistics */
+static void
+uadk_crypto_pmd_stats_get(struct rte_cryptodev *dev,
+			  struct rte_cryptodev_stats *stats)
+{
+	int qp_id;
+
+	for (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {
+		struct uadk_qp *qp = dev->data->queue_pairs[qp_id];
+
+		stats->enqueued_count += qp->qp_stats.enqueued_count;
+		stats->dequeued_count += qp->qp_stats.dequeued_count;
+		stats->enqueue_err_count += qp->qp_stats.enqueue_err_count;
+		stats->dequeue_err_count += qp->qp_stats.dequeue_err_count;
+	}
+}
+
+/* Reset device statistics */
+static void
+uadk_crypto_pmd_stats_reset(struct rte_cryptodev *dev __rte_unused)
+{
+	int qp_id;
+
+	for (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {
+		struct uadk_qp *qp = dev->data->queue_pairs[qp_id];
+
+		memset(&qp->qp_stats, 0, sizeof(qp->qp_stats));
+	}
+}
+
+/* Get device info */
+static void
+uadk_crypto_pmd_info_get(struct rte_cryptodev *dev,
+			 struct rte_cryptodev_info *dev_info)
+{
+	struct uadk_crypto_priv *priv = dev->data->dev_private;
+
+	if (dev_info != NULL) {
+		dev_info->driver_id = dev->driver_id;
+		dev_info->driver_name = dev->device->driver->name;
+		dev_info->max_nb_queue_pairs = 128;
+		/* No limit of number of sessions */
+		dev_info->sym.max_nb_sessions = 0;
+		dev_info->feature_flags = dev->feature_flags;
+
+		if (priv->version == UADK_CRYPTO_V2)
+			dev_info->capabilities = uadk_crypto_v2_capabilities;
+	}
+}
+
+/* Release queue pair */
+static int
+uadk_crypto_pmd_qp_release(struct rte_cryptodev *dev, uint16_t qp_id)
+{
+	struct uadk_qp *qp = dev->data->queue_pairs[qp_id];
+
+	if (qp) {
+		rte_ring_free(qp->processed_pkts);
+		rte_free(qp);
+		dev->data->queue_pairs[qp_id] = NULL;
+	}
+
+	return 0;
+}
+
+/* set a unique name for the queue pair based on its name, dev_id and qp_id */
+static int
+uadk_pmd_qp_set_unique_name(struct rte_cryptodev *dev,
+			    struct uadk_qp *qp)
+{
+	unsigned int n = snprintf(qp->name, sizeof(qp->name),
+				  "uadk_crypto_pmd_%u_qp_%u",
+				  dev->data->dev_id, qp->id);
+
+	if (n >= sizeof(qp->name))
+		return -EINVAL;
+
+	return 0;
+}
+
+/* Create a ring to place process packets on */
+static struct rte_ring *
+uadk_pmd_qp_create_processed_pkts_ring(struct uadk_qp *qp,
+				       unsigned int ring_size, int socket_id)
+{
+	struct rte_ring *r = qp->processed_pkts;
+
+	if (r) {
+		if (rte_ring_get_size(r) >= ring_size) {
+			UADK_LOG(INFO, "Reusing existing ring %s for processed packets",
+				 qp->name);
+			return r;
+		}
+
+		UADK_LOG(ERR, "Unable to reuse existing ring %s for processed packets",
+			 qp->name);
+		return NULL;
+	}
+
+	return rte_ring_create(qp->name, ring_size, socket_id,
+			       RING_F_EXACT_SZ);
+}
+
+static int
+uadk_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
+			 const struct rte_cryptodev_qp_conf *qp_conf,
+			 int socket_id)
+{
+	struct uadk_qp *qp;
+
+	/* Free memory prior to re-allocation if needed. */
+	if (dev->data->queue_pairs[qp_id] != NULL)
+		uadk_crypto_pmd_qp_release(dev, qp_id);
+
+	/* Allocate the queue pair data structure. */
+	qp = rte_zmalloc_socket("uadk PMD Queue Pair", sizeof(*qp),
+				RTE_CACHE_LINE_SIZE, socket_id);
+	if (qp == NULL)
+		return (-ENOMEM);
+
+	qp->id = qp_id;
+	dev->data->queue_pairs[qp_id] = qp;
+
+	if (uadk_pmd_qp_set_unique_name(dev, qp))
+		goto qp_setup_cleanup;
+
+	qp->processed_pkts = uadk_pmd_qp_create_processed_pkts_ring(qp,
+				qp_conf->nb_descriptors, socket_id);
+	if (qp->processed_pkts == NULL)
+		goto qp_setup_cleanup;
+
+	memset(&qp->qp_stats, 0, sizeof(qp->qp_stats));
+
+	return 0;
+
+qp_setup_cleanup:
+	if (qp) {
+		rte_free(qp);
+		qp = NULL;
+	}
+	return -EINVAL;
+}
+
 static struct rte_cryptodev_ops uadk_crypto_pmd_ops = {
-		.dev_configure		= NULL,
-		.dev_start		= NULL,
-		.dev_stop		= NULL,
-		.dev_close		= NULL,
-		.stats_get		= NULL,
-		.stats_reset		= NULL,
-		.dev_infos_get		= NULL,
-		.queue_pair_setup	= NULL,
-		.queue_pair_release	= NULL,
+		.dev_configure		= uadk_crypto_pmd_config,
+		.dev_start		= uadk_crypto_pmd_start,
+		.dev_stop		= uadk_crypto_pmd_stop,
+		.dev_close		= uadk_crypto_pmd_close,
+		.stats_get		= uadk_crypto_pmd_stats_get,
+		.stats_reset		= uadk_crypto_pmd_stats_reset,
+		.dev_infos_get		= uadk_crypto_pmd_info_get,
+		.queue_pair_setup	= uadk_crypto_pmd_qp_setup,
+		.queue_pair_release	= uadk_crypto_pmd_qp_release,
 		.sym_session_get_size	= NULL,
 		.sym_session_configure	= NULL,
 		.sym_session_clear	= NULL,
-- 
2.36.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH resend v3 3/6] crypto/uadk: support enqueue/dequeue operations
  2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 1/6] " Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 2/6] crypto/uadk: support basic operations Zhangfei Gao
@ 2022-10-08  8:37 ` Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 4/6] crypto/uadk: support cipher algorithms Zhangfei Gao
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-08  8:37 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc, Zhangfei Gao

This commit adds the enqueue and dequeue operations.

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 drivers/crypto/uadk/uadk_crypto_pmd.c | 53 ++++++++++++++++++++++++++-
 1 file changed, 51 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c
index 1d1a4b2897..051d6726b0 100644
--- a/drivers/crypto/uadk/uadk_crypto_pmd.c
+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c
@@ -240,6 +240,55 @@ static struct rte_cryptodev_ops uadk_crypto_pmd_ops = {
 		.sym_session_clear	= NULL,
 };
 
+static uint16_t
+uadk_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
+			  uint16_t nb_ops)
+{
+	struct uadk_qp *qp = queue_pair;
+	struct rte_crypto_op *op;
+	uint16_t enqd = 0;
+	int i, ret;
+
+	for (i = 0; i < nb_ops; i++) {
+		op = ops[i];
+		op->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;
+
+		if (op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
+			op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+
+		if (op->status != RTE_CRYPTO_OP_STATUS_ERROR) {
+			ret = rte_ring_enqueue(qp->processed_pkts, (void *)op);
+			if (ret < 0)
+				goto enqueue_err;
+			qp->qp_stats.enqueued_count++;
+			enqd++;
+		} else {
+			/* increment count if failed to enqueue op */
+			qp->qp_stats.enqueue_err_count++;
+		}
+	}
+
+	return enqd;
+
+enqueue_err:
+	qp->qp_stats.enqueue_err_count++;
+	return enqd;
+}
+
+static uint16_t
+uadk_crypto_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,
+			  uint16_t nb_ops)
+{
+	struct uadk_qp *qp = queue_pair;
+	unsigned int nb_dequeued;
+
+	nb_dequeued = rte_ring_dequeue_burst(qp->processed_pkts,
+			(void **)ops, nb_ops, NULL);
+	qp->qp_stats.dequeued_count += nb_dequeued;
+
+	return nb_dequeued;
+}
+
 static int
 uadk_cryptodev_probe(struct rte_vdev_device *vdev)
 {
@@ -276,8 +325,8 @@ uadk_cryptodev_probe(struct rte_vdev_device *vdev)
 
 	dev->dev_ops = &uadk_crypto_pmd_ops;
 	dev->driver_id = uadk_cryptodev_driver_id;
-	dev->dequeue_burst = NULL;
-	dev->enqueue_burst = NULL;
+	dev->dequeue_burst = uadk_crypto_dequeue_burst;
+	dev->enqueue_burst = uadk_crypto_enqueue_burst;
 	dev->feature_flags = RTE_CRYPTODEV_FF_HW_ACCELERATED;
 	priv = dev->data->dev_private;
 	priv->version = version;
-- 
2.36.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH resend v3 4/6] crypto/uadk: support cipher algorithms
  2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
                   ` (2 preceding siblings ...)
  2022-10-08  8:37 ` [PATCH resend v3 3/6] crypto/uadk: support enqueue/dequeue operations Zhangfei Gao
@ 2022-10-08  8:37 ` Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 5/6] crypto/uadk: support auth algorithms Zhangfei Gao
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-08  8:37 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc, Zhangfei Gao

Cipher algorithms:

* ``RTE_CRYPTO_CIPHER_AES_ECB``
* ``RTE_CRYPTO_CIPHER_AES_CBC``
* ``RTE_CRYPTO_CIPHER_AES_XTS``
* ``RTE_CRYPTO_CIPHER_DES_CBC``

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 doc/guides/cryptodevs/features/uadk.ini |  10 +
 doc/guides/cryptodevs/uadk.rst          |   6 +
 drivers/crypto/uadk/uadk_crypto_pmd.c   | 330 +++++++++++++++++++++++-
 3 files changed, 341 insertions(+), 5 deletions(-)

diff --git a/doc/guides/cryptodevs/features/uadk.ini b/doc/guides/cryptodevs/features/uadk.ini
index df5ad40e3d..005e08ac8d 100644
--- a/doc/guides/cryptodevs/features/uadk.ini
+++ b/doc/guides/cryptodevs/features/uadk.ini
@@ -4,12 +4,22 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Features]
+Symmetric crypto       = Y
 HW Accelerated         = Y
 
 ;
 ; Supported crypto algorithms of the 'uadk' crypto driver.
 ;
 [Cipher]
+AES CBC (128)  = Y
+AES CBC (192)  = Y
+AES CBC (256)  = Y
+AES ECB (128)  = Y
+AES ECB (192)  = Y
+AES ECB (256)  = Y
+AES XTS (128)  = Y
+AES XTS (256)  = Y
+DES CBC        = Y
 
 ;
 ; Supported authentication algorithms of the 'uadk' crypto driver.
diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst
index a170224cac..054f5103cc 100644
--- a/doc/guides/cryptodevs/uadk.rst
+++ b/doc/guides/cryptodevs/uadk.rst
@@ -15,6 +15,12 @@ Features
 
 UADK crypto PMD has support for:
 
+Cipher algorithms:
+
+* ``RTE_CRYPTO_CIPHER_AES_ECB``
+* ``RTE_CRYPTO_CIPHER_AES_CBC``
+* ``RTE_CRYPTO_CIPHER_AES_XTS``
+* ``RTE_CRYPTO_CIPHER_DES_CBC``
 
 Test steps
 -----------
diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c
index 051d6726b0..8e2e3b7877 100644
--- a/drivers/crypto/uadk/uadk_crypto_pmd.c
+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c
@@ -31,12 +31,35 @@ struct uadk_qp {
 	uint8_t temp_digest[DIGEST_LENGTH_MAX];
 } __rte_cache_aligned;
 
+enum uadk_chain_order {
+	UADK_CHAIN_ONLY_CIPHER,
+	UADK_CHAIN_NOT_SUPPORTED
+};
+
+struct uadk_crypto_session {
+	handle_t handle_cipher;
+	enum uadk_chain_order chain_order;
+
+	/* IV parameters */
+	struct {
+		uint16_t length;
+		uint16_t offset;
+	} iv;
+
+	/* Cipher Parameters */
+	struct {
+		enum rte_crypto_cipher_operation direction;
+		struct wd_cipher_req req;
+	} cipher;
+} __rte_cache_aligned;
+
 enum uadk_crypto_version {
 	UADK_CRYPTO_V2,
 	UADK_CRYPTO_V3,
 };
 
 struct uadk_crypto_priv {
+	bool env_cipher_init;
 	enum uadk_crypto_version version;
 } __rte_cache_aligned;
 
@@ -50,6 +73,86 @@ RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO);
 		## __VA_ARGS__)
 
 static const struct rte_cryptodev_capabilities uadk_crypto_v2_capabilities[] = {
+	{	/* AES ECB */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_AES_ECB,
+				.block_size = 16,
+				.key_size = {
+					.min = 16,
+					.max = 32,
+					.increment = 8
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
+	{	/* AES CBC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_AES_CBC,
+				.block_size = 16,
+				.key_size = {
+					.min = 16,
+					.max = 32,
+					.increment = 8
+				},
+				.iv_size = {
+					.min = 16,
+					.max = 16,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
+	{	/* AES XTS */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_AES_XTS,
+				.block_size = 1,
+				.key_size = {
+					.min = 32,
+					.max = 64,
+					.increment = 32
+				},
+				.iv_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
+	{	/* DES CBC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
+			{.cipher = {
+				.algo = RTE_CRYPTO_CIPHER_DES_CBC,
+				.block_size = 8,
+				.key_size = {
+					.min = 8,
+					.max = 8,
+					.increment = 0
+				},
+				.iv_size = {
+					.min = 8,
+					.max = 8,
+					.increment = 0
+				}
+			}, }
+		}, }
+	},
 	/* End of capabilities */
 	RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
 };
@@ -77,8 +180,15 @@ uadk_crypto_pmd_stop(struct rte_cryptodev *dev __rte_unused)
 
 /* Close device */
 static int
-uadk_crypto_pmd_close(struct rte_cryptodev *dev __rte_unused)
+uadk_crypto_pmd_close(struct rte_cryptodev *dev)
 {
+	struct uadk_crypto_priv *priv = dev->data->dev_private;
+
+	if (priv->env_cipher_init) {
+		wd_cipher_env_uninit();
+		priv->env_cipher_init = false;
+	}
+
 	return 0;
 }
 
@@ -225,6 +335,159 @@ uadk_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
 	return -EINVAL;
 }
 
+static unsigned int
+uadk_crypto_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
+{
+	return sizeof(struct uadk_crypto_session);
+}
+
+static enum uadk_chain_order
+uadk_get_chain_order(const struct rte_crypto_sym_xform *xform)
+{
+	enum uadk_chain_order res = UADK_CHAIN_NOT_SUPPORTED;
+
+	if (xform != NULL) {
+		if (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER) {
+			if (xform->next == NULL)
+				res = UADK_CHAIN_ONLY_CIPHER;
+		}
+	}
+
+	return res;
+}
+
+static int
+uadk_set_session_cipher_parameters(struct rte_cryptodev *dev,
+				   struct uadk_crypto_session *sess,
+				   struct rte_crypto_sym_xform *xform)
+{
+	struct uadk_crypto_priv *priv = dev->data->dev_private;
+	struct rte_crypto_cipher_xform *cipher = &xform->cipher;
+	struct wd_cipher_sess_setup setup = {0};
+	struct sched_params params = {0};
+	int ret;
+
+	if (!priv->env_cipher_init) {
+		ret = wd_cipher_env_init(NULL);
+		if (ret < 0)
+			return -EINVAL;
+		priv->env_cipher_init = true;
+	}
+
+	sess->cipher.direction = cipher->op;
+	sess->iv.offset = cipher->iv.offset;
+	sess->iv.length = cipher->iv.length;
+
+	switch (cipher->algo) {
+	/* Cover supported cipher algorithms */
+	case RTE_CRYPTO_CIPHER_AES_CTR:
+		setup.alg = WD_CIPHER_AES;
+		setup.mode = WD_CIPHER_CTR;
+		sess->cipher.req.out_bytes = 64;
+		break;
+	case RTE_CRYPTO_CIPHER_AES_ECB:
+		setup.alg = WD_CIPHER_AES;
+		setup.mode = WD_CIPHER_ECB;
+		sess->cipher.req.out_bytes = 16;
+		break;
+	case RTE_CRYPTO_CIPHER_AES_CBC:
+		setup.alg = WD_CIPHER_AES;
+		setup.mode = WD_CIPHER_CBC;
+		if (cipher->key.length == 16)
+			sess->cipher.req.out_bytes = 16;
+		else
+			sess->cipher.req.out_bytes = 64;
+		break;
+	case RTE_CRYPTO_CIPHER_AES_XTS:
+		setup.alg = WD_CIPHER_AES;
+		setup.mode = WD_CIPHER_XTS;
+		if (cipher->key.length == 16)
+			sess->cipher.req.out_bytes = 32;
+		else
+			sess->cipher.req.out_bytes = 512;
+		break;
+	default:
+		ret = -ENOTSUP;
+		goto env_uninit;
+	}
+
+	params.numa_id = -1;	/* choose nearby numa node */
+	setup.sched_param = &params;
+	sess->handle_cipher = wd_cipher_alloc_sess(&setup);
+	if (!sess->handle_cipher) {
+		UADK_LOG(ERR, "uadk failed to alloc session!\n");
+		ret = -EINVAL;
+		goto env_uninit;
+	}
+
+	ret = wd_cipher_set_key(sess->handle_cipher, cipher->key.data, cipher->key.length);
+	if (ret) {
+		wd_cipher_free_sess(sess->handle_cipher);
+		UADK_LOG(ERR, "uadk failed to set key!\n");
+		ret = -EINVAL;
+		goto env_uninit;
+	}
+
+	return 0;
+
+env_uninit:
+	wd_cipher_env_uninit();
+	priv->env_cipher_init = false;
+	return ret;
+}
+
+static int
+uadk_crypto_sym_session_configure(struct rte_cryptodev *dev,
+				  struct rte_crypto_sym_xform *xform,
+				  struct rte_cryptodev_sym_session *session)
+{
+	struct rte_crypto_sym_xform *cipher_xform = NULL;
+	struct uadk_crypto_session *sess = CRYPTODEV_GET_SYM_SESS_PRIV(session);
+	int ret;
+
+	if (unlikely(!sess)) {
+		UADK_LOG(ERR, "Session not available");
+		return -EINVAL;
+	}
+
+	sess->chain_order = uadk_get_chain_order(xform);
+	switch (sess->chain_order) {
+	case UADK_CHAIN_ONLY_CIPHER:
+		cipher_xform = xform;
+		break;
+	default:
+		return -ENOTSUP;
+	}
+
+	if (cipher_xform) {
+		ret = uadk_set_session_cipher_parameters(dev, sess, cipher_xform);
+		if (ret != 0) {
+			UADK_LOG(ERR,
+				"Invalid/unsupported cipher parameters");
+			return ret;
+		}
+	}
+
+	return 0;
+}
+
+static void
+uadk_crypto_sym_session_clear(struct rte_cryptodev *dev __rte_unused,
+			      struct rte_cryptodev_sym_session *session)
+{
+	struct uadk_crypto_session *sess = CRYPTODEV_GET_SYM_SESS_PRIV(session);
+
+	if (unlikely(sess == NULL)) {
+		UADK_LOG(ERR, "Session not available");
+		return;
+	}
+
+	if (sess->handle_cipher) {
+		wd_cipher_free_sess(sess->handle_cipher);
+		sess->handle_cipher = 0;
+	}
+}
+
 static struct rte_cryptodev_ops uadk_crypto_pmd_ops = {
 		.dev_configure		= uadk_crypto_pmd_config,
 		.dev_start		= uadk_crypto_pmd_start,
@@ -235,16 +498,54 @@ static struct rte_cryptodev_ops uadk_crypto_pmd_ops = {
 		.dev_infos_get		= uadk_crypto_pmd_info_get,
 		.queue_pair_setup	= uadk_crypto_pmd_qp_setup,
 		.queue_pair_release	= uadk_crypto_pmd_qp_release,
-		.sym_session_get_size	= NULL,
-		.sym_session_configure	= NULL,
-		.sym_session_clear	= NULL,
+		.sym_session_get_size	= uadk_crypto_sym_session_get_size,
+		.sym_session_configure	= uadk_crypto_sym_session_configure,
+		.sym_session_clear	= uadk_crypto_sym_session_clear,
 };
 
+static void
+uadk_process_cipher_op(struct rte_crypto_op *op,
+		       struct uadk_crypto_session *sess,
+		       struct rte_mbuf *msrc, struct rte_mbuf *mdst)
+{
+	uint32_t off = op->sym->cipher.data.offset;
+	int ret;
+
+	if (!sess) {
+		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
+		return;
+	}
+
+	sess->cipher.req.src = rte_pktmbuf_mtod_offset(msrc, uint8_t *, off);
+	sess->cipher.req.in_bytes = op->sym->cipher.data.length;
+	sess->cipher.req.dst = rte_pktmbuf_mtod_offset(mdst, uint8_t *, off);
+	sess->cipher.req.out_buf_bytes = sess->cipher.req.in_bytes;
+	sess->cipher.req.iv_bytes = sess->iv.length;
+	sess->cipher.req.iv = rte_crypto_op_ctod_offset(op, uint8_t *,
+							sess->iv.offset);
+	if (sess->cipher.direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT)
+		sess->cipher.req.op_type = WD_CIPHER_ENCRYPTION;
+	else
+		sess->cipher.req.op_type = WD_CIPHER_DECRYPTION;
+
+	do {
+		ret = wd_do_cipher_sync(sess->handle_cipher, &sess->cipher.req);
+	} while (ret == -WD_EBUSY);
+
+	if (sess->cipher.req.out_buf_bytes > sess->cipher.req.in_bytes)
+		op->status = RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED;
+
+	if (ret)
+		op->status = RTE_COMP_OP_STATUS_ERROR;
+}
+
 static uint16_t
 uadk_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
 			  uint16_t nb_ops)
 {
 	struct uadk_qp *qp = queue_pair;
+	struct uadk_crypto_session *sess = NULL;
+	struct rte_mbuf *msrc, *mdst;
 	struct rte_crypto_op *op;
 	uint16_t enqd = 0;
 	int i, ret;
@@ -252,6 +553,23 @@ uadk_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
 	for (i = 0; i < nb_ops; i++) {
 		op = ops[i];
 		op->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;
+		msrc = op->sym->m_src;
+		mdst = op->sym->m_dst ? op->sym->m_dst : op->sym->m_src;
+
+		if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) {
+			if (likely(op->sym->session != NULL))
+				sess = CRYPTODEV_GET_SYM_SESS_PRIV(
+					op->sym->session);
+		}
+
+		switch (sess->chain_order) {
+		case UADK_CHAIN_ONLY_CIPHER:
+			uadk_process_cipher_op(op, sess, msrc, mdst);
+			break;
+		default:
+			op->status = RTE_CRYPTO_OP_STATUS_ERROR;
+			break;
+		}
 
 		if (op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
 			op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
@@ -327,7 +645,9 @@ uadk_cryptodev_probe(struct rte_vdev_device *vdev)
 	dev->driver_id = uadk_cryptodev_driver_id;
 	dev->dequeue_burst = uadk_crypto_dequeue_burst;
 	dev->enqueue_burst = uadk_crypto_enqueue_burst;
-	dev->feature_flags = RTE_CRYPTODEV_FF_HW_ACCELERATED;
+	dev->feature_flags = RTE_CRYPTODEV_FF_HW_ACCELERATED |
+			     RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |
+			     RTE_CRYPTODEV_FF_SYM_SESSIONLESS;
 	priv = dev->data->dev_private;
 	priv->version = version;
 
-- 
2.36.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH resend v3 5/6] crypto/uadk: support auth algorithms
  2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
                   ` (3 preceding siblings ...)
  2022-10-08  8:37 ` [PATCH resend v3 4/6] crypto/uadk: support cipher algorithms Zhangfei Gao
@ 2022-10-08  8:37 ` Zhangfei Gao
  2022-10-08  8:37 ` [PATCH resend v3 6/6] test/crypto: add cryptodev_uadk_autotest Zhangfei Gao
  2022-10-10  7:55 ` [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Akhil Goyal
  6 siblings, 0 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-08  8:37 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc, Zhangfei Gao

Hash algorithms:

* ``RTE_CRYPTO_AUTH_MD5``
* ``RTE_CRYPTO_AUTH_MD5_HMAC``
* ``RTE_CRYPTO_AUTH_SHA1``
* ``RTE_CRYPTO_AUTH_SHA1_HMAC``
* ``RTE_CRYPTO_AUTH_SHA224``
* ``RTE_CRYPTO_AUTH_SHA224_HMAC``
* ``RTE_CRYPTO_AUTH_SHA256``
* ``RTE_CRYPTO_AUTH_SHA256_HMAC``
* ``RTE_CRYPTO_AUTH_SHA384``
* ``RTE_CRYPTO_AUTH_SHA384_HMAC``
* ``RTE_CRYPTO_AUTH_SHA512``
* ``RTE_CRYPTO_AUTH_SHA512_HMAC``

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 doc/guides/cryptodevs/features/uadk.ini |  12 +
 doc/guides/cryptodevs/uadk.rst          |  15 +
 drivers/crypto/uadk/uadk_crypto_pmd.c   | 459 ++++++++++++++++++++++++
 3 files changed, 486 insertions(+)

diff --git a/doc/guides/cryptodevs/features/uadk.ini b/doc/guides/cryptodevs/features/uadk.ini
index 005e08ac8d..2e8a37a2b3 100644
--- a/doc/guides/cryptodevs/features/uadk.ini
+++ b/doc/guides/cryptodevs/features/uadk.ini
@@ -25,6 +25,18 @@ DES CBC        = Y
 ; Supported authentication algorithms of the 'uadk' crypto driver.
 ;
 [Auth]
+MD5          = Y
+MD5 HMAC     = Y
+SHA1         = Y
+SHA1 HMAC    = Y
+SHA224       = Y
+SHA224 HMAC  = Y
+SHA256       = Y
+SHA256 HMAC  = Y
+SHA384       = Y
+SHA384 HMAC  = Y
+SHA512       = Y
+SHA512 HMAC  = Y
 
 ;
 ; Supported AEAD algorithms of the 'uadk' crypto driver.
diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst
index 054f5103cc..23ed70e82b 100644
--- a/doc/guides/cryptodevs/uadk.rst
+++ b/doc/guides/cryptodevs/uadk.rst
@@ -22,6 +22,21 @@ Cipher algorithms:
 * ``RTE_CRYPTO_CIPHER_AES_XTS``
 * ``RTE_CRYPTO_CIPHER_DES_CBC``
 
+Hash algorithms:
+
+* ``RTE_CRYPTO_AUTH_MD5``
+* ``RTE_CRYPTO_AUTH_MD5_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA1``
+* ``RTE_CRYPTO_AUTH_SHA1_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA224``
+* ``RTE_CRYPTO_AUTH_SHA224_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA256``
+* ``RTE_CRYPTO_AUTH_SHA256_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA384``
+* ``RTE_CRYPTO_AUTH_SHA384_HMAC``
+* ``RTE_CRYPTO_AUTH_SHA512``
+* ``RTE_CRYPTO_AUTH_SHA512_HMAC``
+
 Test steps
 -----------
 
diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c
index 8e2e3b7877..a166efa36c 100644
--- a/drivers/crypto/uadk/uadk_crypto_pmd.c
+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c
@@ -33,11 +33,15 @@ struct uadk_qp {
 
 enum uadk_chain_order {
 	UADK_CHAIN_ONLY_CIPHER,
+	UADK_CHAIN_ONLY_AUTH,
+	UADK_CHAIN_CIPHER_AUTH,
+	UADK_CHAIN_AUTH_CIPHER,
 	UADK_CHAIN_NOT_SUPPORTED
 };
 
 struct uadk_crypto_session {
 	handle_t handle_cipher;
+	handle_t handle_digest;
 	enum uadk_chain_order chain_order;
 
 	/* IV parameters */
@@ -51,6 +55,13 @@ struct uadk_crypto_session {
 		enum rte_crypto_cipher_operation direction;
 		struct wd_cipher_req req;
 	} cipher;
+
+	/* Authentication Parameters */
+	struct {
+		struct wd_digest_req req;
+		enum rte_crypto_auth_operation operation;
+		uint16_t digest_length;
+	} auth;
 } __rte_cache_aligned;
 
 enum uadk_crypto_version {
@@ -60,6 +71,7 @@ enum uadk_crypto_version {
 
 struct uadk_crypto_priv {
 	bool env_cipher_init;
+	bool env_auth_init;
 	enum uadk_crypto_version version;
 } __rte_cache_aligned;
 
@@ -73,6 +85,252 @@ RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO);
 		## __VA_ARGS__)
 
 static const struct rte_cryptodev_capabilities uadk_crypto_v2_capabilities[] = {
+	{	/* MD5 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_MD5_HMAC,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 16,
+					.max = 16,
+					.increment = 0
+				},
+				.iv_size = { 0 }
+			}, }
+		}, }
+	},
+	{	/* MD5 */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_MD5,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 16,
+					.max = 16,
+					.increment = 0
+				},
+			}, }
+		}, }
+	},
+	{	/* SHA1 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 20,
+					.max = 20,
+					.increment = 0
+				},
+				.iv_size = { 0 }
+			}, }
+		}, }
+	},
+	{	/* SHA1 */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA1,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 20,
+					.max = 20,
+					.increment = 0
+				},
+			}, }
+		}, }
+	},
+	{	/* SHA224 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 28,
+					.max = 28,
+					.increment = 0
+				},
+				.iv_size = { 0 }
+			}, }
+		}, }
+	},
+	{	/* SHA224 */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA224,
+				.block_size = 64,
+					.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 28,
+					.max = 28,
+					.increment = 0
+				},
+			}, }
+		}, }
+	},
+	{	/* SHA256 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 32,
+					.max = 32,
+					.increment = 0
+				},
+				.iv_size = { 0 }
+			}, }
+		}, }
+	},
+	{	/* SHA256 */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA256,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 32,
+					.max = 32,
+					.increment = 0
+				},
+			}, }
+		}, }
+	},
+	{	/* SHA384 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
+				.block_size = 128,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 48,
+					.max = 48,
+					.increment = 0
+				},
+				.iv_size = { 0 }
+			}, }
+		}, }
+	},
+	{	/* SHA384 */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA384,
+				.block_size = 64,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 48,
+					.max = 48,
+					.increment = 0
+					},
+			}, }
+		}, }
+	},
+	{	/* SHA512 HMAC */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
+				.block_size = 128,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 64,
+					.max = 64,
+					.increment = 0
+				},
+				.iv_size = { 0 }
+			}, }
+		}, }
+	},
+	{	/* SHA512 */
+		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+		{.sym = {
+			.xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+			{.auth = {
+				.algo = RTE_CRYPTO_AUTH_SHA512,
+				.block_size = 128,
+				.key_size = {
+					.min = 0,
+					.max = 0,
+					.increment = 0
+				},
+				.digest_size = {
+					.min = 64,
+					.max = 64,
+					.increment = 0
+				},
+			}, }
+		}, }
+	},
 	{	/* AES ECB */
 		.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
 		{.sym = {
@@ -189,6 +447,11 @@ uadk_crypto_pmd_close(struct rte_cryptodev *dev)
 		priv->env_cipher_init = false;
 	}
 
+	if (priv->env_auth_init) {
+		wd_digest_env_uninit();
+		priv->env_auth_init = false;
+	}
+
 	return 0;
 }
 
@@ -347,9 +610,19 @@ uadk_get_chain_order(const struct rte_crypto_sym_xform *xform)
 	enum uadk_chain_order res = UADK_CHAIN_NOT_SUPPORTED;
 
 	if (xform != NULL) {
+		if (xform->type == RTE_CRYPTO_SYM_XFORM_AUTH) {
+			if (xform->next == NULL)
+				res = UADK_CHAIN_ONLY_AUTH;
+			else if (xform->next->type ==
+					RTE_CRYPTO_SYM_XFORM_CIPHER)
+				res = UADK_CHAIN_AUTH_CIPHER;
+		}
+
 		if (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER) {
 			if (xform->next == NULL)
 				res = UADK_CHAIN_ONLY_CIPHER;
+			else if (xform->next->type == RTE_CRYPTO_SYM_XFORM_AUTH)
+				res = UADK_CHAIN_CIPHER_AUTH;
 		}
 	}
 
@@ -436,12 +709,119 @@ uadk_set_session_cipher_parameters(struct rte_cryptodev *dev,
 	return ret;
 }
 
+/* Set session auth parameters */
+static int
+uadk_set_session_auth_parameters(struct rte_cryptodev *dev,
+				 struct uadk_crypto_session *sess,
+				 struct rte_crypto_sym_xform *xform)
+{
+	struct uadk_crypto_priv *priv = dev->data->dev_private;
+	struct wd_digest_sess_setup setup = {0};
+	struct sched_params params = {0};
+	int ret;
+
+	if (!priv->env_auth_init) {
+		ret = wd_digest_env_init(NULL);
+		if (ret < 0)
+			return -EINVAL;
+		priv->env_auth_init = true;
+	}
+
+	sess->auth.operation = xform->auth.op;
+	sess->auth.digest_length = xform->auth.digest_length;
+
+	switch (xform->auth.algo) {
+	case RTE_CRYPTO_AUTH_MD5:
+	case RTE_CRYPTO_AUTH_MD5_HMAC:
+		setup.mode = (xform->auth.algo == RTE_CRYPTO_AUTH_MD5) ?
+			     WD_DIGEST_NORMAL : WD_DIGEST_HMAC;
+		setup.alg = WD_DIGEST_MD5;
+		sess->auth.req.out_buf_bytes = 16;
+		sess->auth.req.out_bytes = 16;
+		break;
+	case RTE_CRYPTO_AUTH_SHA1:
+	case RTE_CRYPTO_AUTH_SHA1_HMAC:
+		setup.mode = (xform->auth.algo == RTE_CRYPTO_AUTH_SHA1) ?
+			     WD_DIGEST_NORMAL : WD_DIGEST_HMAC;
+		setup.alg = WD_DIGEST_SHA1;
+		sess->auth.req.out_buf_bytes = 20;
+		sess->auth.req.out_bytes = 20;
+		break;
+	case RTE_CRYPTO_AUTH_SHA224:
+	case RTE_CRYPTO_AUTH_SHA224_HMAC:
+		setup.mode = (xform->auth.algo == RTE_CRYPTO_AUTH_SHA224) ?
+			     WD_DIGEST_NORMAL : WD_DIGEST_HMAC;
+		setup.alg = WD_DIGEST_SHA224;
+		sess->auth.req.out_buf_bytes = 28;
+		sess->auth.req.out_bytes = 28;
+		break;
+	case RTE_CRYPTO_AUTH_SHA256:
+	case RTE_CRYPTO_AUTH_SHA256_HMAC:
+		setup.mode = (xform->auth.algo == RTE_CRYPTO_AUTH_SHA256) ?
+			     WD_DIGEST_NORMAL : WD_DIGEST_HMAC;
+		setup.alg = WD_DIGEST_SHA256;
+		sess->auth.req.out_buf_bytes = 32;
+		sess->auth.req.out_bytes = 32;
+		break;
+	case RTE_CRYPTO_AUTH_SHA384:
+	case RTE_CRYPTO_AUTH_SHA384_HMAC:
+		setup.mode = (xform->auth.algo == RTE_CRYPTO_AUTH_SHA384) ?
+			     WD_DIGEST_NORMAL : WD_DIGEST_HMAC;
+		setup.alg = WD_DIGEST_SHA384;
+		sess->auth.req.out_buf_bytes = 48;
+		sess->auth.req.out_bytes = 48;
+		break;
+	case RTE_CRYPTO_AUTH_SHA512:
+	case RTE_CRYPTO_AUTH_SHA512_HMAC:
+		setup.mode = (xform->auth.algo == RTE_CRYPTO_AUTH_SHA512) ?
+			     WD_DIGEST_NORMAL : WD_DIGEST_HMAC;
+		setup.alg = WD_DIGEST_SHA512;
+		sess->auth.req.out_buf_bytes = 64;
+		sess->auth.req.out_bytes = 64;
+		break;
+	default:
+		ret = -ENOTSUP;
+		goto env_uninit;
+	}
+
+	params.numa_id = -1;	/* choose nearby numa node */
+	setup.sched_param = &params;
+	sess->handle_digest = wd_digest_alloc_sess(&setup);
+	if (!sess->handle_digest) {
+		UADK_LOG(ERR, "uadk failed to alloc session!\n");
+		ret = -EINVAL;
+		goto env_uninit;
+	}
+
+	/* if mode is HMAC, should set key */
+	if (setup.mode == WD_DIGEST_HMAC) {
+		ret = wd_digest_set_key(sess->handle_digest,
+					xform->auth.key.data,
+					xform->auth.key.length);
+		if (ret) {
+			UADK_LOG(ERR, "uadk failed to alloc session!\n");
+			wd_digest_free_sess(sess->handle_digest);
+			sess->handle_digest = 0;
+			ret = -EINVAL;
+			goto env_uninit;
+		}
+	}
+
+	return 0;
+
+env_uninit:
+	wd_digest_env_uninit();
+	priv->env_auth_init = false;
+	return ret;
+}
+
 static int
 uadk_crypto_sym_session_configure(struct rte_cryptodev *dev,
 				  struct rte_crypto_sym_xform *xform,
 				  struct rte_cryptodev_sym_session *session)
 {
 	struct rte_crypto_sym_xform *cipher_xform = NULL;
+	struct rte_crypto_sym_xform *auth_xform = NULL;
 	struct uadk_crypto_session *sess = CRYPTODEV_GET_SYM_SESS_PRIV(session);
 	int ret;
 
@@ -455,6 +835,17 @@ uadk_crypto_sym_session_configure(struct rte_cryptodev *dev,
 	case UADK_CHAIN_ONLY_CIPHER:
 		cipher_xform = xform;
 		break;
+	case UADK_CHAIN_ONLY_AUTH:
+		auth_xform = xform;
+		break;
+	case UADK_CHAIN_CIPHER_AUTH:
+		cipher_xform = xform;
+		auth_xform = xform->next;
+		break;
+	case UADK_CHAIN_AUTH_CIPHER:
+		auth_xform = xform;
+		cipher_xform = xform->next;
+		break;
 	default:
 		return -ENOTSUP;
 	}
@@ -468,6 +859,15 @@ uadk_crypto_sym_session_configure(struct rte_cryptodev *dev,
 		}
 	}
 
+	if (auth_xform) {
+		ret = uadk_set_session_auth_parameters(dev, sess, auth_xform);
+		if (ret != 0) {
+			UADK_LOG(ERR,
+				"Invalid/unsupported auth parameters");
+			return ret;
+		}
+	}
+
 	return 0;
 }
 
@@ -486,6 +886,11 @@ uadk_crypto_sym_session_clear(struct rte_cryptodev *dev __rte_unused,
 		wd_cipher_free_sess(sess->handle_cipher);
 		sess->handle_cipher = 0;
 	}
+
+	if (sess->handle_digest) {
+		wd_digest_free_sess(sess->handle_digest);
+		sess->handle_digest = 0;
+	}
 }
 
 static struct rte_cryptodev_ops uadk_crypto_pmd_ops = {
@@ -539,6 +944,49 @@ uadk_process_cipher_op(struct rte_crypto_op *op,
 		op->status = RTE_COMP_OP_STATUS_ERROR;
 }
 
+static void
+uadk_process_auth_op(struct uadk_qp *qp, struct rte_crypto_op *op,
+		     struct uadk_crypto_session *sess,
+		     struct rte_mbuf *msrc, struct rte_mbuf *mdst)
+{
+	uint32_t srclen = op->sym->auth.data.length;
+	uint32_t off = op->sym->auth.data.offset;
+	uint8_t *dst = qp->temp_digest;
+	int ret;
+
+	if (!sess) {
+		op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
+		return;
+	}
+
+	sess->auth.req.in = rte_pktmbuf_mtod_offset(msrc, uint8_t *, off);
+	sess->auth.req.in_bytes = srclen;
+	sess->auth.req.out = dst;
+
+	do {
+		ret = wd_do_digest_sync(sess->handle_digest, &sess->auth.req);
+	} while (ret == -WD_EBUSY);
+
+	if (sess->auth.operation == RTE_CRYPTO_AUTH_OP_VERIFY) {
+		if (memcmp(dst, op->sym->auth.digest.data,
+				sess->auth.digest_length) != 0) {
+			op->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;
+		}
+	} else {
+		uint8_t *auth_dst;
+
+		auth_dst = op->sym->auth.digest.data;
+		if (auth_dst == NULL)
+			auth_dst = rte_pktmbuf_mtod_offset(mdst, uint8_t *,
+					op->sym->auth.data.offset +
+					op->sym->auth.data.length);
+		memcpy(auth_dst, dst, sess->auth.digest_length);
+	}
+
+	if (ret)
+		op->status = RTE_COMP_OP_STATUS_ERROR;
+}
+
 static uint16_t
 uadk_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
 			  uint16_t nb_ops)
@@ -566,6 +1014,17 @@ uadk_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
 		case UADK_CHAIN_ONLY_CIPHER:
 			uadk_process_cipher_op(op, sess, msrc, mdst);
 			break;
+		case UADK_CHAIN_ONLY_AUTH:
+			uadk_process_auth_op(qp, op, sess, msrc, mdst);
+			break;
+		case UADK_CHAIN_CIPHER_AUTH:
+			uadk_process_cipher_op(op, sess, msrc, mdst);
+			uadk_process_auth_op(qp, op, sess, mdst, mdst);
+			break;
+		case UADK_CHAIN_AUTH_CIPHER:
+			uadk_process_auth_op(qp, op, sess, msrc, mdst);
+			uadk_process_cipher_op(op, sess, msrc, mdst);
+			break;
 		default:
 			op->status = RTE_CRYPTO_OP_STATUS_ERROR;
 			break;
-- 
2.36.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH resend v3 6/6] test/crypto: add cryptodev_uadk_autotest
  2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
                   ` (4 preceding siblings ...)
  2022-10-08  8:37 ` [PATCH resend v3 5/6] crypto/uadk: support auth algorithms Zhangfei Gao
@ 2022-10-08  8:37 ` Zhangfei Gao
  2022-10-10  7:55 ` [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Akhil Goyal
  6 siblings, 0 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-08  8:37 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc, Zhangfei Gao

Example:
sudo dpdk-test --vdev=crypto_uadk --log-level=6
RTE>>cryptodev_uadk_autotest
RTE>>quit

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
 app/test/test_cryptodev.c | 7 +++++++
 app/test/test_cryptodev.h | 1 +
 2 files changed, 8 insertions(+)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c6d47a035e..3449d41cf6 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -16427,6 +16427,12 @@ test_cryptodev_qat(void)
 	return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
 }
 
+static int
+test_cryptodev_uadk(void)
+{
+	return run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_UADK_PMD));
+}
+
 static int
 test_cryptodev_virtio(void)
 {
@@ -16770,6 +16776,7 @@ REGISTER_TEST_COMMAND(cryptodev_sw_mvsam_autotest, test_cryptodev_mrvl);
 REGISTER_TEST_COMMAND(cryptodev_dpaa2_sec_autotest, test_cryptodev_dpaa2_sec);
 REGISTER_TEST_COMMAND(cryptodev_dpaa_sec_autotest, test_cryptodev_dpaa_sec);
 REGISTER_TEST_COMMAND(cryptodev_ccp_autotest, test_cryptodev_ccp);
+REGISTER_TEST_COMMAND(cryptodev_uadk_autotest, test_cryptodev_uadk);
 REGISTER_TEST_COMMAND(cryptodev_virtio_autotest, test_cryptodev_virtio);
 REGISTER_TEST_COMMAND(cryptodev_octeontx_autotest, test_cryptodev_octeontx);
 REGISTER_TEST_COMMAND(cryptodev_caam_jr_autotest, test_cryptodev_caam_jr);
diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h
index 29a7d4db2b..abd795f54a 100644
--- a/app/test/test_cryptodev.h
+++ b/app/test/test_cryptodev.h
@@ -74,6 +74,7 @@
 #define CRYPTODEV_NAME_CN9K_PMD		crypto_cn9k
 #define CRYPTODEV_NAME_CN10K_PMD	crypto_cn10k
 #define CRYPTODEV_NAME_MLX5_PMD		crypto_mlx5
+#define CRYPTODEV_NAME_UADK_PMD		crypto_uadk
 
 
 enum cryptodev_api_test_type {
-- 
2.36.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
                   ` (5 preceding siblings ...)
  2022-10-08  8:37 ` [PATCH resend v3 6/6] test/crypto: add cryptodev_uadk_autotest Zhangfei Gao
@ 2022-10-10  7:55 ` Akhil Goyal
  2022-10-10  9:30   ` Zhangfei Gao
  6 siblings, 1 reply; 15+ messages in thread
From: Akhil Goyal @ 2022-10-10  7:55 UTC (permalink / raw)
  To: Zhangfei Gao, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc

Hi Zhangfei,

I see below compilation error after executing the steps mentioned in UADK README. It would be better if you could add compilation steps for UADK in uadk.rst as well.

gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
make  all-recursive
make[1]: Entering directory '/home/gakhil/up/uadk'
Making all in .
make[2]: Entering directory '/home/gakhil/up/uadk'
depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -Wall -Werror -fno-strict-aliasing -I./include  -DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -MD -MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD -MP -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -Wall -Werror -fno-strict-aliasing -I./include  -DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo wd_mempool.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c  -fPIC -DPIC -o .libs/wd_mempool.o
depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -Wall -Werror -fno-strict-aliasing -I./include  -DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT v1/wd.lo -MD -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -MD -MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
In file included from v1/wd.c:30:
./v1/wd_util.h:354:2: error: #error "no platform mb, define one before compiling"
  354 | #error "no platform mb, define one before compiling"
      |  ^~~~~
make[2]: *** [Makefile:788: v1/wd.lo] Error 1
make[2]: Leaving directory '/home/gakhil/up/uadk'
make[1]: *** [Makefile:859: all-recursive] Error 1
make[1]: Leaving directory '/home/gakhil/up/uadk'
make: *** [Makefile:565: all] Error 2

> -----Original Message-----
> From: Zhangfei Gao <zhangfei.gao@linaro.org>
> Sent: Saturday, October 8, 2022 2:08 PM
> To: Akhil Goyal <gakhil@marvell.com>; Declan Doherty
> <declan.doherty@intel.com>; Fan Zhang <roy.fan.zhang@intel.com>; Ashish
> Gupta <ashishg@marvell.com>; Ray Kinsella <mdr@ashroe.eu>
> Cc: dev@dpdk.org; acc@openeuler.org; Zhangfei Gao
> <zhangfei.gao@linaro.org>
> Subject: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
> 
> External Email
> 
> ----------------------------------------------------------------------
> Introduce a new crypto PMD for hardware accelerators based on UADK [1].
> 
> UADK is a framework for user applications to access hardware accelerators.
> UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share
> the same page table between IOMMU and MMU.
> Thereby user application can directly use virtual address for device dma,
> which enhances the performance as well as easy usability.
> 
> [1] https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Linaro_uadk&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=Dn
> L7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=riOYJQEEoq2hZSApJn-
> _dXs6fqKRm8wqS-cJ48j15-
> zpW3dOS8NrcrsBD7wC4cqY&s=irxZ2g1W2PchLQnfMPsNb8WJpjCS_-
> Y_sdVRQT6wwo0&e=
> 
> Test:
> sudo dpdk-test --vdev=crypto_uadk (--log-level=6)
> RTE>>cryptodev_uadk_autotest
> RTE>>quit
> 
> resend:
> Rebase on next/for-main, which just merged series "cryptodev: rework session
> framework".
> 
> update in v3:
> Split patches according to Akhil's suggestions
> Please split the patches as below.
> 1. introduce driver - create files with meson.build and with probe/remove
>    and device ops defined but not implemented. You do not need to write empty
> functions.
>    Add basic documentation also which defines what the driver is.
>    You can explain the build dependency here.
> 2. define queue structs and setup/remove APIs
> 3. Add data path
> 4. implement cipher op. Add capabilities and documentation of what is
> supported in each of the patch. Add feature flags etc.
> 5. implement auth,  add capabilities and documentation
> 6. test app changes.
> 
> Update in v2:
> Change uadk_supported_platform to uadk_crypto_version, which matches
> better
> than platform.
> enum uadk_crypto_version {
> 	UADK_CRYPTO_V2,
> 	UADK_CRYPTO_V3,
> };
> 
> Update in v1, compared with rfc
> 
> Suggested from Akhil Goyal <gakhil@marvell.com>
> Only consider crypto PMD first
> Split patch into small (individually compiled) patches.
> Update MAINTAINERS and doc/guides/cryptodevs/features/uadk.ini
> 
> Zhangfei Gao (6):
>   crypto/uadk: introduce uadk crypto driver
>   crypto/uadk: support basic operations
>   crypto/uadk: support enqueue/dequeue operations
>   crypto/uadk: support cipher algorithms
>   crypto/uadk: support auth algorithms
>   test/crypto: add cryptodev_uadk_autotest
> 
>  MAINTAINERS                             |    6 +
>  app/test/test_cryptodev.c               |    7 +
>  app/test/test_cryptodev.h               |    1 +
>  doc/guides/cryptodevs/features/uadk.ini |   55 ++
>  doc/guides/cryptodevs/index.rst         |    1 +
>  doc/guides/cryptodevs/uadk.rst          |   74 ++
>  drivers/crypto/meson.build              |    1 +
>  drivers/crypto/uadk/meson.build         |   36 +
>  drivers/crypto/uadk/uadk_crypto_pmd.c   | 1145 +++++++++++++++++++++++
>  drivers/crypto/uadk/version.map         |    3 +
>  10 files changed, 1329 insertions(+)
>  create mode 100644 doc/guides/cryptodevs/features/uadk.ini
>  create mode 100644 doc/guides/cryptodevs/uadk.rst
>  create mode 100644 drivers/crypto/uadk/meson.build
>  create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c
>  create mode 100644 drivers/crypto/uadk/version.map
> 
> --
> 2.36.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-10  7:55 ` [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Akhil Goyal
@ 2022-10-10  9:30   ` Zhangfei Gao
  2022-10-10  9:57     ` Akhil Goyal
  0 siblings, 1 reply; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-10  9:30 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc



On 2022/10/10 下午3:55, Akhil Goyal wrote:
> Hi Zhangfei,
>
> I see below compilation error after executing the steps mentioned in UADK README. It would be better if you could add compilation steps for UADK in uadk.rst as well.

Sure

Will add something like this

Build & Install UADK on ARM
--------------------

```
     git clone https://github.com/Linaro/uadk.git
     cd uadk
     ./cleanup.sh
     ./autogen.sh
     ./conf.sh
     make
     sudo make install
```
* If get error:"cannot find -lnuma", please install the libnuma-dev

>
> gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
> make  all-recursive
> make[1]: Entering directory '/home/gakhil/up/uadk'
> Making all in .
> make[2]: Entering directory '/home/gakhil/up/uadk'
> depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -Wall -Werror -fno-strict-aliasing -I./include  -DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -MD -MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD -MP -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
> depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -Wall -Werror -fno-strict-aliasing -I./include  -DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo wd_mempool.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c  -fPIC -DPIC -o .libs/wd_mempool.o
> depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -Wall -Werror -fno-strict-aliasing -I./include  -DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT v1/wd.lo -MD -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -MD -MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
> In file included from v1/wd.c:30:
> ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before compiling"
>    354 | #error "no platform mb, define one before compiling"
>        |  ^~~~~
> make[2]: *** [Makefile:788: v1/wd.lo] Error 1
> make[2]: Leaving directory '/home/gakhil/up/uadk'
> make[1]: *** [Makefile:859: all-recursive] Error 1
> make[1]: Leaving directory '/home/gakhil/up/uadk'
> make: *** [Makefile:565: all] Error 2
By the way, what platform are you using.
I can not reproduce this error.

Thanks





^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-10  9:30   ` Zhangfei Gao
@ 2022-10-10  9:57     ` Akhil Goyal
  2022-10-11  9:22       ` Akhil Goyal
  0 siblings, 1 reply; 15+ messages in thread
From: Akhil Goyal @ 2022-10-10  9:57 UTC (permalink / raw)
  To: Zhangfei Gao, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc

> > gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
> > make  all-recursive
> > make[1]: Entering directory '/home/gakhil/up/uadk'
> > Making all in .
> > make[2]: Entering directory '/home/gakhil/up/uadk'
> > depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
> Wall -Werror -fno-strict-aliasing -I./include  -
> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -MD -
> MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
> > mv -f $depbase.Tpo $depbase.Plo
> > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -
> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD -MP
> -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
> > depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
> Wall -Werror -fno-strict-aliasing -I./include  -
> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT
> wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo
> wd_mempool.c &&\
> > mv -f $depbase.Tpo $depbase.Plo
> > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -
> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT
> wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c  -fPIC
> -DPIC -o .libs/wd_mempool.o
> > depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
> Wall -Werror -fno-strict-aliasing -I./include  -
> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT v1/wd.lo -MD
> -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
> > mv -f $depbase.Tpo $depbase.Plo
> > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasing -
> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -MD -
> MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
> > In file included from v1/wd.c:30:
> > ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before
> compiling"
> >    354 | #error "no platform mb, define one before compiling"
> >        |  ^~~~~
> > make[2]: *** [Makefile:788: v1/wd.lo] Error 1
> > make[2]: Leaving directory '/home/gakhil/up/uadk'
> > make[1]: *** [Makefile:859: all-recursive] Error 1
> > make[1]: Leaving directory '/home/gakhil/up/uadk'
> > make: *** [Makefile:565: all] Error 2
> By the way, what platform are you using.
> I can not reproduce this error.
> 
I am compiling on Intel XEON server with ubuntu 18.04

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-10  9:57     ` Akhil Goyal
@ 2022-10-11  9:22       ` Akhil Goyal
  2022-10-11  9:58         ` Zhangfei Gao
  2022-10-14  3:03         ` Zhangfei Gao
  0 siblings, 2 replies; 15+ messages in thread
From: Akhil Goyal @ 2022-10-11  9:22 UTC (permalink / raw)
  To: Zhangfei Gao, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc

> > > gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
> > > make  all-recursive
> > > make[1]: Entering directory '/home/gakhil/up/uadk'
> > > Making all in .
> > > make[2]: Entering directory '/home/gakhil/up/uadk'
> > > depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > > /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
> > Wall -Werror -fno-strict-aliasing -I./include  -
> > DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> > DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -MD -
> > MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
> > > mv -f $depbase.Tpo $depbase.Plo
> > > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> aliasing -
> > I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> > DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD -
> MP
> > -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
> > > depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > > /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
> > Wall -Werror -fno-strict-aliasing -I./include  -
> > DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> > DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT
> > wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo
> > wd_mempool.c &&\
> > > mv -f $depbase.Tpo $depbase.Plo
> > > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> aliasing -
> > I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> > DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT
> > wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c  -
> fPIC
> > -DPIC -o .libs/wd_mempool.o
> > > depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > > /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
> > Wall -Werror -fno-strict-aliasing -I./include  -
> > DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> > DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT v1/wd.lo -
> MD
> > -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
> > > mv -f $depbase.Tpo $depbase.Plo
> > > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> aliasing -
> > I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> > DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -
> MD -
> > MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
> > > In file included from v1/wd.c:30:
> > > ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before
> > compiling"
> > >    354 | #error "no platform mb, define one before compiling"
> > >        |  ^~~~~
> > > make[2]: *** [Makefile:788: v1/wd.lo] Error 1
> > > make[2]: Leaving directory '/home/gakhil/up/uadk'
> > > make[1]: *** [Makefile:859: all-recursive] Error 1
> > > make[1]: Leaving directory '/home/gakhil/up/uadk'
> > > make: *** [Makefile:565: all] Error 2
> > By the way, what platform are you using.
> > I can not reproduce this error.
> >
> I am compiling on Intel XEON server with ubuntu 18.04

Any update??

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-11  9:22       ` Akhil Goyal
@ 2022-10-11  9:58         ` Zhangfei Gao
  2022-10-14  3:03         ` Zhangfei Gao
  1 sibling, 0 replies; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-11  9:58 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc

Hi, Akhil

On 2022/10/11 下午5:22, Akhil Goyal wrote:
>>>> gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
>>>> make  all-recursive
>>>> make[1]: Entering directory '/home/gakhil/up/uadk'
>>>> Making all in .
>>>> make[2]: Entering directory '/home/gakhil/up/uadk'
>>>> depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
>>> Wall -Werror -fno-strict-aliasing -I./include  -
>>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
>>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -MD -
>>> MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
>>>> mv -f $depbase.Tpo $depbase.Plo
>>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
>> aliasing -
>>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
>>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD -
>> MP
>>> -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
>>>> depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
>>> Wall -Werror -fno-strict-aliasing -I./include  -
>>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
>>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT
>>> wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo
>>> wd_mempool.c &&\
>>>> mv -f $depbase.Tpo $depbase.Plo
>>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
>> aliasing -
>>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
>>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT
>>> wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c  -
>> fPIC
>>> -DPIC -o .libs/wd_mempool.o
>>>> depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
>>> Wall -Werror -fno-strict-aliasing -I./include  -
>>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
>>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT v1/wd.lo -
>> MD
>>> -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
>>>> mv -f $depbase.Tpo $depbase.Plo
>>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
>> aliasing -
>>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
>>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -
>> MD -
>>> MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
>>>> In file included from v1/wd.c:30:
>>>> ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before
>>> compiling"
>>>>     354 | #error "no platform mb, define one before compiling"
>>>>         |  ^~~~~
>>>> make[2]: *** [Makefile:788: v1/wd.lo] Error 1
>>>> make[2]: Leaving directory '/home/gakhil/up/uadk'
>>>> make[1]: *** [Makefile:859: all-recursive] Error 1
>>>> make[1]: Leaving directory '/home/gakhil/up/uadk'
>>>> make: *** [Makefile:565: all] Error 2
>>> By the way, what platform are you using.
>>> I can not reproduce this error.
>>>
>> I am compiling on Intel XEON server with ubuntu 18.04
> Any update??

Looks the uadk library only considers ARM local build for some time.
I am in checking how to cross-compile on x86.
Sorry for the inconvenience.

Thanks


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-11  9:22       ` Akhil Goyal
  2022-10-11  9:58         ` Zhangfei Gao
@ 2022-10-14  3:03         ` Zhangfei Gao
  2022-10-14 11:28           ` Akhil Goyal
  1 sibling, 1 reply; 15+ messages in thread
From: Zhangfei Gao @ 2022-10-14  3:03 UTC (permalink / raw)
  To: Akhil Goyal, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc

Hi, Akhil

On 2022/10/11 下午5:22, Akhil Goyal wrote:
>>>> gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
>>>> make  all-recursive
>>>> make[1]: Entering directory '/home/gakhil/up/uadk'
>>>> Making all in .
>>>> make[2]: Entering directory '/home/gakhil/up/uadk'
>>>> depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
>>> Wall -Werror -fno-strict-aliasing -I./include  -
>>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
>>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -MD -
>>> MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
>>>> mv -f $depbase.Tpo $depbase.Plo
>>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
>> aliasing -
>>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
>>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD -
>> MP
>>> -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
>>>> depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
>>> Wall -Werror -fno-strict-aliasing -I./include  -
>>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
>>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT
>>> wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo
>>> wd_mempool.c &&\
>>>> mv -f $depbase.Tpo $depbase.Plo
>>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
>> aliasing -
>>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
>>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT
>>> wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c  -
>> fPIC
>>> -DPIC -o .libs/wd_mempool.o
>>>> depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.    -
>>> Wall -Werror -fno-strict-aliasing -I./include  -
>>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
>>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT v1/wd.lo -
>> MD
>>> -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
>>>> mv -f $depbase.Tpo $depbase.Plo
>>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
>> aliasing -
>>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
>>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -
>> MD -
>>> MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
>>>> In file included from v1/wd.c:30:
>>>> ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before
>>> compiling"
>>>>     354 | #error "no platform mb, define one before compiling"
>>>>         |  ^~~~~
>>>> make[2]: *** [Makefile:788: v1/wd.lo] Error 1
>>>> make[2]: Leaving directory '/home/gakhil/up/uadk'
>>>> make[1]: *** [Makefile:859: all-recursive] Error 1
>>>> make[1]: Leaving directory '/home/gakhil/up/uadk'
>>>> make: *** [Makefile:565: all] Error 2
>>> By the way, what platform are you using.
>>> I can not reproduce this error.
>>>
>> I am compiling on Intel XEON server with ubuntu 18.04
> Any update??
The uadk lib needs cross-compile on x86.
Toolchain: 
https://releases.linaro.org/components/toolchain/binaries/latest-7/aarch64-linux-gnu/
Details are documented in https://github.com/Linaro/uadk/blob/master/INSTALL

Considering the confusion caused by simple build info in README,
We are planning to remove the simple build step in README, only keeps 
INSTALL.
https://github.com/Linaro/uadk/pull/510

Since there are some dependent libraries (libz & openssl) causes 
cross-compile complicated.
We are planning to omit build tests if not found these libs
https://github.com/Linaro/uadk/pull/508

Only libnuma is must required for lib.
Fortunately the numa cross compile is simple

https://github.com/Linaro/uadk/blob/master/INSTALL
     $git clone https://github.com/numactl/numactl.git
     $cd numactl
     $./autogen.sh
     $autoconf -i
     $CC=aarch64-linux-gnu-gcc ./configure --host=i386-linux-gnu 
--target=aarch64-linux-gnu --prefix=${LIBROOT}/usr/local
     $make
     $make install

Do you think we still need paste uadk build steps (and cross-compile steps)
on dpdk doc/guides/cryptodevs/uadk.rst

Sorry for the confusion.

Thanks

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-14  3:03         ` Zhangfei Gao
@ 2022-10-14 11:28           ` Akhil Goyal
  2022-10-14 12:02             ` Akhil Goyal
  0 siblings, 1 reply; 15+ messages in thread
From: Akhil Goyal @ 2022-10-14 11:28 UTC (permalink / raw)
  To: Zhangfei Gao, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc

Hi Zhangfei,
> Hi, Akhil
> 
> On 2022/10/11 下午5:22, Akhil Goyal wrote:
> >>>> gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
> >>>> make  all-recursive
> >>>> make[1]: Entering directory '/home/gakhil/up/uadk'
> >>>> Making all in .
> >>>> make[2]: Entering directory '/home/gakhil/up/uadk'
> >>>> depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> >>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
> -
> >>> Wall -Werror -fno-strict-aliasing -I./include  -
> >>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> >>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -
> MD -
> >>> MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
> >>>> mv -f $depbase.Tpo $depbase.Plo
> >>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> >> aliasing -
> >>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> >>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD
> -
> >> MP
> >>> -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
> >>>> depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> >>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
> -
> >>> Wall -Werror -fno-strict-aliasing -I./include  -
> >>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> >>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT
> >>> wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo
> >>> wd_mempool.c &&\
> >>>> mv -f $depbase.Tpo $depbase.Plo
> >>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> >> aliasing -
> >>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> >>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT
> >>> wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c  -
> >> fPIC
> >>> -DPIC -o .libs/wd_mempool.o
> >>>> depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> >>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.
> -
> >>> Wall -Werror -fno-strict-aliasing -I./include  -
> >>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> >>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT v1/wd.lo
> -
> >> MD
> >>> -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
> >>>> mv -f $depbase.Tpo $depbase.Plo
> >>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> >> aliasing -
> >>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> >>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -
> >> MD -
> >>> MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
> >>>> In file included from v1/wd.c:30:
> >>>> ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before
> >>> compiling"
> >>>>     354 | #error "no platform mb, define one before compiling"
> >>>>         |  ^~~~~
> >>>> make[2]: *** [Makefile:788: v1/wd.lo] Error 1
> >>>> make[2]: Leaving directory '/home/gakhil/up/uadk'
> >>>> make[1]: *** [Makefile:859: all-recursive] Error 1
> >>>> make[1]: Leaving directory '/home/gakhil/up/uadk'
> >>>> make: *** [Makefile:565: all] Error 2
> >>> By the way, what platform are you using.
> >>> I can not reproduce this error.
> >>>
> >> I am compiling on Intel XEON server with ubuntu 18.04
> > Any update??
> The uadk lib needs cross-compile on x86.
> Toolchain:
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__releases.linaro.org_components_toolchain_binaries_latest-2D7_aarch64-
> 2Dlinux-
> 2Dgnu_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey
> 3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jDO3kZ8m02cjnNdNxbSoW7V9DE
> o6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=2-
> jhckUNn9LCXbLaFaAEdl_5seC82SCXxvkVQEPnNz0&e=
> Details are documented in https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Linaro_uadk_blob_master_INSTALL&d=DwIDaQ&c=nKjWec2b
> 6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m
> =91MX2Cs8jDO3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9
> Q8&s=pyjDRDPApEQXxPjZ4q0QlXT5DgmAAYdZtNscFbRp8lk&e=
> 
> Considering the confusion caused by simple build info in README,
> We are planning to remove the simple build step in README, only keeps
> INSTALL.
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Linaro_uadk_pull_510&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7x
> tfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jD
> O3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=m6I26
> VelKVBjODnByclMKGtmaSEN2kv8ACeZsWbPTg4&e=
> 
> Since there are some dependent libraries (libz & openssl) causes
> cross-compile complicated.
> We are planning to omit build tests if not found these libs
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Linaro_uadk_pull_508&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7x
> tfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jD
> O3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=tcbWSI
> hyL8b2mX4-Ta54bR4kH2fNkezlmVD24I09mTc&e=
> 
> Only libnuma is must required for lib.
> Fortunately the numa cross compile is simple
> 
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_Linaro_uadk_blob_master_INSTALL&d=DwIDaQ&c=nKjWec2b
> 6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m
> =91MX2Cs8jDO3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9
> Q8&s=pyjDRDPApEQXxPjZ4q0QlXT5DgmAAYdZtNscFbRp8lk&e=
>      $git clone https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_numactl_numactl.git&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xt
> fQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jD
> O3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=hZdhP
> WLMGMgV9tP7nEQY1G_iWnODYJMCfR41whWchSU&e=
>      $cd numactl
>      $./autogen.sh
>      $autoconf -i
>      $CC=aarch64-linux-gnu-gcc ./configure --host=i386-linux-gnu
> --target=aarch64-linux-gnu --prefix=${LIBROOT}/usr/local
>      $make
>      $make install
> 
> Do you think we still need paste uadk build steps (and cross-compile steps)
> on dpdk doc/guides/cryptodevs/uadk.rst
> 
Is it not possible to use pkg-config?

Also while building on DPDK which config file is needed?
Do you need that also to be cross compiled?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver
  2022-10-14 11:28           ` Akhil Goyal
@ 2022-10-14 12:02             ` Akhil Goyal
  0 siblings, 0 replies; 15+ messages in thread
From: Akhil Goyal @ 2022-10-14 12:02 UTC (permalink / raw)
  To: Zhangfei Gao, Declan Doherty, Fan Zhang, Ashish Gupta, Ray Kinsella
  Cc: dev, acc

> Hi Zhangfei,
> > Hi, Akhil
> >
> > On 2022/10/11 下午5:22, Akhil Goyal wrote:
> > >>>> gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make
> > >>>> make  all-recursive
> > >>>> make[1]: Entering directory '/home/gakhil/up/uadk'
> > >>>> Making all in .
> > >>>> make[2]: Entering directory '/home/gakhil/up/uadk'
> > >>>> depbase=`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > >>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -
> I.
> > -
> > >>> Wall -Werror -fno-strict-aliasing -I./include  -
> > >>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> > >>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT wd.lo -
> > MD -
> > >>> MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\
> > >>>> mv -f $depbase.Tpo $depbase.Plo
> > >>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> > >> aliasing -
> > >>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> > >>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -
> MD
> > -
> > >> MP
> > >>> -MF .deps/wd.Tpo -c wd.c  -fPIC -DPIC -o .libs/wd.o
> > >>>> depbase=`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > >>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -
> I.
> > -
> > >>> Wall -Werror -fno-strict-aliasing -I./include  -
> > >>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> > >>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT
> > >>> wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo
> > >>> wd_mempool.c &&\
> > >>>> mv -f $depbase.Tpo $depbase.Plo
> > >>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> > >> aliasing -
> > >>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> > >>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT
> > >>> wd_mempool.lo -MD -MP -MF .deps/wd_mempool.Tpo -c wd_mempool.c
> -
> > >> fPIC
> > >>> -DPIC -o .libs/wd_mempool.o
> > >>>> depbase=`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> > >>>> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -
> I.
> > -
> > >>> Wall -Werror -fno-strict-aliasing -I./include  -
> > >>> DUADK_VERSION_NUMBER="\"UADK version: 2.3.37\"" -
> > >>> DUADK_RELEASED_TIME="\"Released Jun 11, 2022\""  -g -O2 -MT
> v1/wd.lo
> > -
> > >> MD
> > >>> -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\
> > >>>> mv -f $depbase.Tpo $depbase.Plo
> > >>>> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-
> > >> aliasing -
> > >>> I./include "-DUADK_VERSION_NUMBER=\"UADK version: 2.3.37\"" "-
> > >>> DUADK_RELEASED_TIME=\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo
> -
> > >> MD -
> > >>> MP -MF v1/.deps/wd.Tpo -c v1/wd.c  -fPIC -DPIC -o v1/.libs/wd.o
> > >>>> In file included from v1/wd.c:30:
> > >>>> ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before
> > >>> compiling"
> > >>>>     354 | #error "no platform mb, define one before compiling"
> > >>>>         |  ^~~~~
> > >>>> make[2]: *** [Makefile:788: v1/wd.lo] Error 1
> > >>>> make[2]: Leaving directory '/home/gakhil/up/uadk'
> > >>>> make[1]: *** [Makefile:859: all-recursive] Error 1
> > >>>> make[1]: Leaving directory '/home/gakhil/up/uadk'
> > >>>> make: *** [Makefile:565: all] Error 2
> > >>> By the way, what platform are you using.
> > >>> I can not reproduce this error.
> > >>>
> > >> I am compiling on Intel XEON server with ubuntu 18.04
> > > Any update??
> > The uadk lib needs cross-compile on x86.
> > Toolchain:
> > https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__releases.linaro.org_components_toolchain_binaries_latest-
> 2D7_aarch64-
> > 2Dlinux-
> >
> 2Dgnu_&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey
> >
> 3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jDO3kZ8m02cjnNdNxbSoW7V9DE
> > o6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=2-
> > jhckUNn9LCXbLaFaAEdl_5seC82SCXxvkVQEPnNz0&e=
> > Details are documented in https://urldefense.proofpoint.com/v2/url?u=https-
> >
> 3A__github.com_Linaro_uadk_blob_master_INSTALL&d=DwIDaQ&c=nKjWec2b
> >
> 6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m
> >
> =91MX2Cs8jDO3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9
> > Q8&s=pyjDRDPApEQXxPjZ4q0QlXT5DgmAAYdZtNscFbRp8lk&e=
> >
> > Considering the confusion caused by simple build info in README,
> > We are planning to remove the simple build step in README, only keeps
> > INSTALL.
> > https://urldefense.proofpoint.com/v2/url?u=https-
> >
> 3A__github.com_Linaro_uadk_pull_510&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7x
> >
> tfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jD
> >
> O3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=m6I26
> > VelKVBjODnByclMKGtmaSEN2kv8ACeZsWbPTg4&e=
> >
> > Since there are some dependent libraries (libz & openssl) causes
> > cross-compile complicated.
> > We are planning to omit build tests if not found these libs
> > https://urldefense.proofpoint.com/v2/url?u=https-
> >
> 3A__github.com_Linaro_uadk_pull_508&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7x
> >
> tfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jD
> >
> O3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=tcbWSI
> > hyL8b2mX4-Ta54bR4kH2fNkezlmVD24I09mTc&e=
> >
> > Only libnuma is must required for lib.
> > Fortunately the numa cross compile is simple
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-
> >
> 3A__github.com_Linaro_uadk_blob_master_INSTALL&d=DwIDaQ&c=nKjWec2b
> >
> 6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m
> >
> =91MX2Cs8jDO3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9
> > Q8&s=pyjDRDPApEQXxPjZ4q0QlXT5DgmAAYdZtNscFbRp8lk&e=
> >      $git clone https://urldefense.proofpoint.com/v2/url?u=https-
> >
> 3A__github.com_numactl_numactl.git&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xt
> >
> fQ&r=DnL7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=91MX2Cs8jD
> >
> O3kZ8m02cjnNdNxbSoW7V9DEo6KPhTRzdWILxa_DQzYPoa5c5Lq9Q8&s=hZdhP
> > WLMGMgV9tP7nEQY1G_iWnODYJMCfR41whWchSU&e=
> >      $cd numactl
> >      $./autogen.sh
> >      $autoconf -i
> >      $CC=aarch64-linux-gnu-gcc ./configure --host=i386-linux-gnu
> > --target=aarch64-linux-gnu --prefix=${LIBROOT}/usr/local
> >      $make
> >      $make install
> >
> > Do you think we still need paste uadk build steps (and cross-compile steps)
> > on dpdk doc/guides/cryptodevs/uadk.rst
> >
> Is it not possible to use pkg-config?
> 
> Also while building on DPDK which config file is needed?
> Do you need that also to be cross compiled?

And even if I do manual copy of numa(lib and headers) in the toolchain (which I believe should not be done).

I still see issues in installing uadk.
It does not allow to install in a directory and does not make a pkgconfig file which can be used by DPDK to build the crypto driver.
 Please check how other PMDs are doing with external libs.
In DPDK, we take external dependent libs via pkg-config only.

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-10-14 12:04 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-08  8:37 [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Zhangfei Gao
2022-10-08  8:37 ` [PATCH resend v3 1/6] " Zhangfei Gao
2022-10-08  8:37 ` [PATCH resend v3 2/6] crypto/uadk: support basic operations Zhangfei Gao
2022-10-08  8:37 ` [PATCH resend v3 3/6] crypto/uadk: support enqueue/dequeue operations Zhangfei Gao
2022-10-08  8:37 ` [PATCH resend v3 4/6] crypto/uadk: support cipher algorithms Zhangfei Gao
2022-10-08  8:37 ` [PATCH resend v3 5/6] crypto/uadk: support auth algorithms Zhangfei Gao
2022-10-08  8:37 ` [PATCH resend v3 6/6] test/crypto: add cryptodev_uadk_autotest Zhangfei Gao
2022-10-10  7:55 ` [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Akhil Goyal
2022-10-10  9:30   ` Zhangfei Gao
2022-10-10  9:57     ` Akhil Goyal
2022-10-11  9:22       ` Akhil Goyal
2022-10-11  9:58         ` Zhangfei Gao
2022-10-14  3:03         ` Zhangfei Gao
2022-10-14 11:28           ` Akhil Goyal
2022-10-14 12:02             ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).