From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4B86A0544; Mon, 10 Oct 2022 09:57:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9918040E50; Mon, 10 Oct 2022 09:57:20 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 67E3A40041 for ; Mon, 10 Oct 2022 09:57:19 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 299LtvcW007444; Mon, 10 Oct 2022 00:55:12 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2042.outbound.protection.outlook.com [104.47.73.42]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3k36jpn0ue-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Oct 2022 00:55:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N5AgTGgV9uI8dcC/rh6LiyMQ6WpHf/ipxn+fDANElX3xz7focYmziGdivH+InoJoAskKw9d3fYiT3GvUSamwwoJ5TAbU5suwXxPYktqq5eA9koHJP61s0nvrBqsYv51I3e7fKXVERUhz253vgkrGnq3Wa8xE/5owosIVNz/A6z/WS7b8XCJXVs0UFolCxrrIBm/qhoWqev9Zfl/zhUWKLU8d1299u8E4cGxwq5MXL+wAbsP2A4em0ZR/X8szJTd/xzmq82BFY1uf9xagAcHCT3AzhixZX4BxbC44Qh7MMFbr/J5JxMol2y6d4k2uCqoRtgZu4MwirtOPP6RGXqCslw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1AW2EGwb/gpbZEUxsNOnB6ne/naB8utGqI8k6nQm7s=; b=M+xIAzOnIP+5AHcrUHkGaST5FTsvHfXJp/GTRfO/gBED0lE/qeGwJLPZN2USdxtqEPTNZ/CRBnMSBQ0TxEm72dRED6WnSMGkKV/MZl3roU2l/upREJ9FEss4Ym3Tz/0Jy8P9dfKz+nwthlQsH9eYqnCdjNmmA0FIfqssY3gBk21c9JfSMLRhRR6IqjSmHm0cTvwLCx7xcZDGONKGhpz66p3PIo8scPYovfp3Hu6ugtssesDSG3U5kuS5vNFKKtTv69KB0GgA9eYMrgzyVM/czetXF1RZPoyoPXl1e9sr0C09hVYdL/p+GweCl35P0gpLuA9f5TJrcoKoyFM6UGB1WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1AW2EGwb/gpbZEUxsNOnB6ne/naB8utGqI8k6nQm7s=; b=tidyMx5Jb4KGSpyIdm+xvJlNHbq2BSK1xOGsj1wQ1vrtUcyCD+1lXU0LVwWBGgDR51GZZxmSy6lrz83tthRmaPBEsSCxJc/0/NJMF+nGh7s+r0IAPpsMptuukkKmLHbJykawBgi6xkdL0CGvDTXoI/TOw0B1tf/VG8nRshplFAA= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SA0PR18MB3648.namprd18.prod.outlook.com (2603:10b6:806:9d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct 2022 07:55:09 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5676.033; Mon, 10 Oct 2022 07:55:08 +0000 From: Akhil Goyal To: Zhangfei Gao , Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella CC: "dev@dpdk.org" , "acc@openeuler.org" Subject: RE: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Thread-Topic: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto driver Thread-Index: AQHY2vFkjMSnEA3b0ki7+RtBjjWWDq4HRHNw Date: Mon, 10 Oct 2022 07:55:08 +0000 Message-ID: References: <20221008083747.6559-1-zhangfei.gao@linaro.org> In-Reply-To: <20221008083747.6559-1-zhangfei.gao@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SA0PR18MB3648:EE_ x-ms-office365-filtering-correlation-id: 1c71e0c0-e571-45b8-42e4-08daaa94c08e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AWRIX1i7Nmu4hPnmWZfI/pGWxHQanXr7xSUuMD/np06pLuW5hOa2XCXOTzQiYEv0WMQbPJ4481hYR/lEW3/ji5W/cmvzyhR1/gJDJ76ZTSHvobETj4yBCj1B0NwCimzx8BxbCzz0+Yxbh6UYtLgHv46xEPjLjRdlYG4vQtuqniUK6RIfW5hsPHHVCKbOOjg2EzUqElBwqUmMl+5Vu2NkI7e4fpeRfD+MpowKhwpo8Fs9Ce9JCSLa1RoB2o5msKCPExFyxqDyJ4V01xzPD5IhVJqvev5J/zjSy2h5cKrLe0Azxvufv5eDREgRdI0Labg+FP+x7Lm3dJmS+tipcvAPqBvl3fPaR5zhQOd1tuam7a5n41SwfIxoifT1HBSlmgmCQoF7dsT5wlVDzCFCFJ3PAse87tauSIolJke/a/V/QnErHibZeVX9cJL5aRkOpt4DwPWLRfGcwfJlG4+2+ewPs/vsWutsoXggqPxP7vJJ4oPCjGz4gWpDUV8ujJV1fGuHEckNYE6rShqnrve2ycGkl2urzGsmPgh/f3Z5WsKhAqqtqbmcE7MesWfrBhWF8Uo/g0DT8YdsNkDXwCTLBZsusoZhKMheASZWUOdrmA8IjXZ+a3/nCUbnsCzf3n4B5TKRn7tMe2+gpiJZijhcqiidYV3l5xHhMju1p+AQ7dxVoEGO35Sm2VTf+cK5lFpIbHMDY3KaIn/zaKmbaFoVl7s5MB9hibtGtWcRsOgg1kc/+ZvCDzqaeuLRGtrONrCue+8V8a0W6vIL/YJqDyCYqd4vOebJgmBoMn6VhL+1qlfQdc0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199015)(38100700002)(122000001)(38070700005)(33656002)(86362001)(2906002)(186003)(83380400001)(5660300002)(52536014)(6506007)(7696005)(66556008)(9686003)(26005)(53546011)(55236004)(55016003)(8676002)(64756008)(4326008)(76116006)(66946007)(66476007)(66446008)(110136005)(54906003)(71200400001)(966005)(41300700001)(19627235002)(316002)(8936002)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qIcVp/Gy7e3t0wWA+rAEI3iUobJw3ev0rL/D3QDGmtTkfoiTP4+IkTbqh9bW?= =?us-ascii?Q?3Z4uipyOVxa+nlW/2Kt5MMRE+GsVukbQO5haTpv6X6E/RoxEjaSB6TqO3cYX?= =?us-ascii?Q?60PT4FQfNs8Wmqs/3cQhwh7VcQ+LXQnCnUHTvNL63iUR9gEchylW9QmIJcmE?= =?us-ascii?Q?AMuTZ7HyzbsuMAQLIPT22Op7pQ2zCMfZZ3k5M2QWeI3VLK3XqPDUI4x56SwQ?= =?us-ascii?Q?vWLpPaCZRV1jnSyMReed4TbbzRhHmEsbB0wjAexvnLP4ygdrdxjIB/6LliH6?= =?us-ascii?Q?ivQ6MrAviz9id4n63nvQ+mjteaf+1+tNYwN4sj9BzrK8KIB7a5ckGNomIzyH?= =?us-ascii?Q?xWYeRgS02UP7yewPYD9ifFn4RyUX9/TPcuxZa88oLTSlMsFrXNaBauaJIYPJ?= =?us-ascii?Q?8QFIKfpQ8C1d/QzJS9ZvkebnbEFVWvzCS7QkPI7MmvhRnH54qr31p1icEsJd?= =?us-ascii?Q?qpUcNye082mQf/kkAukrchkosjy9WC2iButAAybh8QCTQDzhEMgpejk7OumE?= =?us-ascii?Q?Wm92zwMzMSZJy+uapv/2sVJ62+b7HFGixtX3hQlh33P1gSFoAIVnApeSwx3G?= =?us-ascii?Q?tk0wnGdpGixrocCqJ/uIwIsGcOIgMZmA7HRIvdyU8DrXcH/Wbfhdmn968MW0?= =?us-ascii?Q?+Zh/cHLZt9bXrc/vuAmXcBfT5YvkaRvoG/m2WZHXEMC/Dgl9NicQ+/UysbG3?= =?us-ascii?Q?SSan2u/XeRaHrM76Lt8vL/pO7G0CzWk88wJ4tK1p7pOob80x3pm+dwZ8/LHe?= =?us-ascii?Q?Bz8BpKe433X4n3U2eD5b209nKZiZTN4xLASYyttqyYP0IZPJUDeoyvYBE5dO?= =?us-ascii?Q?ssqNZjmbPfzRJ4Kb7+tl6hiQkt48LtvMBi0+iRVd/vWvDZVXHXs6IgqOxA3y?= =?us-ascii?Q?y5LO24UYmudIUjkKx5GIda9a26K0fTBJyE15O97599HN9N/rzXecYlPHpmyF?= =?us-ascii?Q?ZYfqPVjc4R5yIO2bKVohmoWXjoPn/yIMdeMWW5y94Q8d9krXcFQMw2quwHTq?= =?us-ascii?Q?WwUXumFla3FeAmXZCKbwQnVL7Zd+Uf27eE0ry1SkM8io4rB/b/hkV0lqGePM?= =?us-ascii?Q?0gQjpdDtFeIIUrwgnmHNKJLmBcVRii8YD9vNslM7tr3mcFSl6yIP3luIRTfC?= =?us-ascii?Q?4u5Rv2EaxQ2DGGlPL3GcPd7HNjVC3MD9wnOs+HWGjfVHnTLoLhdnUV9bTiyX?= =?us-ascii?Q?ukmGzLBwnkBr2NwO2NTTPFyrprG86zGHfLSQtcktgmTqy6M72idw5ZW4F9p9?= =?us-ascii?Q?9gNu/iMRn7FvLSXFYsxxt3u8HdlBcO7aDOSDKHyeYWBRTMGMdS48eHI5ErkU?= =?us-ascii?Q?vyY/GIgH1l2f61e+/Svd/LgaHmMoE+huv9aHbDs7/Hc9LDTniegkdvaQo2KX?= =?us-ascii?Q?0xBJMpt38pW2R7wB/XtZnSAI4ojpfyVjtGd2lAzSKN4xUMCUajcmdgDd57pg?= =?us-ascii?Q?uQEY/uCkf2jwaWRZkBV4DfjBwNI4ScWqzYkOYOTDXHtuYwn/2JuqJoZ08Jfe?= =?us-ascii?Q?RE6slLZJGYPzWUxSUhLFOWhtZ69qi2NolBHnKXJelWx+rsz9ZChSnTN3mvoe?= =?us-ascii?Q?NmVg735k0L2Wgj3QE07zG5U6xbn8lc5jJKpxT00t?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c71e0c0-e571-45b8-42e4-08daaa94c08e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 07:55:08.8307 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RgaJHamzSA3f4cEYMRTy7IQ+2hUW/R8JJ5rM8Yu81zWkbcZGyHz6uc7qr0rIhEWoMRLBVpxfJYtnn7w+V5XdUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3648 X-Proofpoint-GUID: LeSYfw7fXWhu5QtFkaT6xEjlbZYj9Ly6 X-Proofpoint-ORIG-GUID: LeSYfw7fXWhu5QtFkaT6xEjlbZYj9Ly6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Zhangfei, I see below compilation error after executing the steps mentioned in UADK R= EADME. It would be better if you could add compilation steps for UADK in ua= dk.rst as well. gakhil@cavium-SR1-T640:/home/gakhil/up/uadk$ make make all-recursive make[1]: Entering directory '/home/gakhil/up/uadk' Making all in . make[2]: Entering directory '/home/gakhil/up/uadk' depbase=3D`echo wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ./libtool --tag=3DCC --mode=3Dcompile gcc -DHAVE_CONFIG_H -I. = -Wall -Werror -fno-strict-aliasing -I./include -DUADK_VERSION_NUMBER=3D= "\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME=3D"\"Released Jun 11, 2022\= "" -g -O2 -MT wd.lo -MD -MP -MF $depbase.Tpo -c -o wd.lo wd.c &&\ mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasi= ng -I./include "-DUADK_VERSION_NUMBER=3D\"UADK version: 2.3.37\"" "-DUADK_R= ELEASED_TIME=3D\"Released Jun 11, 2022\"" -g -O2 -MT wd.lo -MD -MP -MF .dep= s/wd.Tpo -c wd.c -fPIC -DPIC -o .libs/wd.o depbase=3D`echo wd_mempool.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ./libtool --tag=3DCC --mode=3Dcompile gcc -DHAVE_CONFIG_H -I. = -Wall -Werror -fno-strict-aliasing -I./include -DUADK_VERSION_NUMBER=3D= "\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME=3D"\"Released Jun 11, 2022\= "" -g -O2 -MT wd_mempool.lo -MD -MP -MF $depbase.Tpo -c -o wd_mempool.lo w= d_mempool.c &&\ mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasi= ng -I./include "-DUADK_VERSION_NUMBER=3D\"UADK version: 2.3.37\"" "-DUADK_R= ELEASED_TIME=3D\"Released Jun 11, 2022\"" -g -O2 -MT wd_mempool.lo -MD -MP = -MF .deps/wd_mempool.Tpo -c wd_mempool.c -fPIC -DPIC -o .libs/wd_mempool.o depbase=3D`echo v1/wd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ./libtool --tag=3DCC --mode=3Dcompile gcc -DHAVE_CONFIG_H -I. = -Wall -Werror -fno-strict-aliasing -I./include -DUADK_VERSION_NUMBER=3D= "\"UADK version: 2.3.37\"" -DUADK_RELEASED_TIME=3D"\"Released Jun 11, 2022\= "" -g -O2 -MT v1/wd.lo -MD -MP -MF $depbase.Tpo -c -o v1/wd.lo v1/wd.c &&\ mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -DHAVE_CONFIG_H -I. -Wall -Werror -fno-strict-aliasi= ng -I./include "-DUADK_VERSION_NUMBER=3D\"UADK version: 2.3.37\"" "-DUADK_R= ELEASED_TIME=3D\"Released Jun 11, 2022\"" -g -O2 -MT v1/wd.lo -MD -MP -MF v= 1/.deps/wd.Tpo -c v1/wd.c -fPIC -DPIC -o v1/.libs/wd.o In file included from v1/wd.c:30: ./v1/wd_util.h:354:2: error: #error "no platform mb, define one before comp= iling" 354 | #error "no platform mb, define one before compiling" | ^~~~~ make[2]: *** [Makefile:788: v1/wd.lo] Error 1 make[2]: Leaving directory '/home/gakhil/up/uadk' make[1]: *** [Makefile:859: all-recursive] Error 1 make[1]: Leaving directory '/home/gakhil/up/uadk' make: *** [Makefile:565: all] Error 2 > -----Original Message----- > From: Zhangfei Gao > Sent: Saturday, October 8, 2022 2:08 PM > To: Akhil Goyal ; Declan Doherty > ; Fan Zhang ; Ashish > Gupta ; Ray Kinsella > Cc: dev@dpdk.org; acc@openeuler.org; Zhangfei Gao > > Subject: [EXT] [PATCH resend v3 0/6] crypto/uadk: introduce uadk crypto d= river >=20 > External Email >=20 > ---------------------------------------------------------------------- > Introduce a new crypto PMD for hardware accelerators based on UADK [1]. >=20 > UADK is a framework for user applications to access hardware accelerators= . > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share > the same page table between IOMMU and MMU. > Thereby user application can directly use virtual address for device dma, > which enhances the performance as well as easy usability. >=20 > [1] https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__github.com_Linaro_uadk&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DDn > L7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=3DriOYJQEEoq2hZSApJn- > _dXs6fqKRm8wqS-cJ48j15- > zpW3dOS8NrcrsBD7wC4cqY&s=3DirxZ2g1W2PchLQnfMPsNb8WJpjCS_- > Y_sdVRQT6wwo0&e=3D >=20 > Test: > sudo dpdk-test --vdev=3Dcrypto_uadk (--log-level=3D6) > RTE>>cryptodev_uadk_autotest > RTE>>quit >=20 > resend: > Rebase on next/for-main, which just merged series "cryptodev: rework sess= ion > framework". >=20 > update in v3: > Split patches according to Akhil's suggestions > Please split the patches as below. > 1. introduce driver - create files with meson.build and with probe/remove > and device ops defined but not implemented. You do not need to write e= mpty > functions. > Add basic documentation also which defines what the driver is. > You can explain the build dependency here. > 2. define queue structs and setup/remove APIs > 3. Add data path > 4. implement cipher op. Add capabilities and documentation of what is > supported in each of the patch. Add feature flags etc. > 5. implement auth, add capabilities and documentation > 6. test app changes. >=20 > Update in v2: > Change uadk_supported_platform to uadk_crypto_version, which matches > better > than platform. > enum uadk_crypto_version { > UADK_CRYPTO_V2, > UADK_CRYPTO_V3, > }; >=20 > Update in v1, compared with rfc >=20 > Suggested from Akhil Goyal > Only consider crypto PMD first > Split patch into small (individually compiled) patches. > Update MAINTAINERS and doc/guides/cryptodevs/features/uadk.ini >=20 > Zhangfei Gao (6): > crypto/uadk: introduce uadk crypto driver > crypto/uadk: support basic operations > crypto/uadk: support enqueue/dequeue operations > crypto/uadk: support cipher algorithms > crypto/uadk: support auth algorithms > test/crypto: add cryptodev_uadk_autotest >=20 > MAINTAINERS | 6 + > app/test/test_cryptodev.c | 7 + > app/test/test_cryptodev.h | 1 + > doc/guides/cryptodevs/features/uadk.ini | 55 ++ > doc/guides/cryptodevs/index.rst | 1 + > doc/guides/cryptodevs/uadk.rst | 74 ++ > drivers/crypto/meson.build | 1 + > drivers/crypto/uadk/meson.build | 36 + > drivers/crypto/uadk/uadk_crypto_pmd.c | 1145 +++++++++++++++++++++++ > drivers/crypto/uadk/version.map | 3 + > 10 files changed, 1329 insertions(+) > create mode 100644 doc/guides/cryptodevs/features/uadk.ini > create mode 100644 doc/guides/cryptodevs/uadk.rst > create mode 100644 drivers/crypto/uadk/meson.build > create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c > create mode 100644 drivers/crypto/uadk/version.map >=20 > -- > 2.36.1