* [dpdk-dev] [PATCH] examples/ipsec-secgw: accept inline proto pkts in single sa
@ 2021-10-06 7:16 Nithin Dabilpuram
2021-10-06 7:20 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
0 siblings, 1 reply; 5+ messages in thread
From: Nithin Dabilpuram @ 2021-10-06 7:16 UTC (permalink / raw)
To: Radu Nicolau, Akhil Goyal; +Cc: dev, jerinj, anoobj, Nithin Dabilpuram
In inline protocol SA's, plain ipv4 and ipv6 packets are delivered to
application unlike inline crypto or lookaside. Hence fix the application
to not drop them when working in single SA mode.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
examples/ipsec-secgw/ipsec-secgw.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index 7ad94cb..96fbae2 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -848,16 +848,6 @@ process_pkts_inbound_nosp(struct ipsec_ctx *ipsec_ctx,
struct rte_mbuf *m;
uint32_t nb_pkts_in, i, idx;
- /* Drop any IPv4 traffic from unprotected ports */
- free_pkts(traffic->ip4.pkts, traffic->ip4.num);
-
- traffic->ip4.num = 0;
-
- /* Drop any IPv6 traffic from unprotected ports */
- free_pkts(traffic->ip6.pkts, traffic->ip6.num);
-
- traffic->ip6.num = 0;
-
if (app_sa_prm.enable == 0) {
nb_pkts_in = ipsec_inbound(ipsec_ctx, traffic->ipsec.pkts,
--
2.8.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa
2021-10-06 7:16 [dpdk-dev] [PATCH] examples/ipsec-secgw: accept inline proto pkts in single sa Nithin Dabilpuram
@ 2021-10-06 7:20 ` Nithin Dabilpuram
2021-10-07 13:16 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Nithin Dabilpuram @ 2021-10-06 7:20 UTC (permalink / raw)
To: Radu Nicolau, Akhil Goyal; +Cc: dev, jerinj, anoobj, Nithin Dabilpuram
In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
delivered to application unlike inline crypto or lookaside.
Hence fix the application to not drop them when working in
single SA mode.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
v2:
- Fixed commit message.
examples/ipsec-secgw/ipsec-secgw.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index 7ad94cb..96fbae2 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -848,16 +848,6 @@ process_pkts_inbound_nosp(struct ipsec_ctx *ipsec_ctx,
struct rte_mbuf *m;
uint32_t nb_pkts_in, i, idx;
- /* Drop any IPv4 traffic from unprotected ports */
- free_pkts(traffic->ip4.pkts, traffic->ip4.num);
-
- traffic->ip4.num = 0;
-
- /* Drop any IPv6 traffic from unprotected ports */
- free_pkts(traffic->ip6.pkts, traffic->ip6.num);
-
- traffic->ip6.num = 0;
-
if (app_sa_prm.enable == 0) {
nb_pkts_in = ipsec_inbound(ipsec_ctx, traffic->ipsec.pkts,
--
2.8.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa
2021-10-06 7:20 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
@ 2021-10-07 13:16 ` Akhil Goyal
2021-10-07 15:38 ` Ananyev, Konstantin
0 siblings, 1 reply; 5+ messages in thread
From: Akhil Goyal @ 2021-10-07 13:16 UTC (permalink / raw)
To: Nithin Kumar Dabilpuram, Radu Nicolau, hemant.agrawal, Ananyev,
Konstantin, Bernard Iremonger
Cc: dev, Jerin Jacob Kollanukkaran, Anoob Joseph, Nithin Kumar Dabilpuram
> Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single
> sa
>
> In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
> delivered to application unlike inline crypto or lookaside.
> Hence fix the application to not drop them when working in
> single SA mode.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> ---
>
Acked-by: Akhil Goyal <gakhil@marvell.com>
@Konstantin/Bernard: Any objections?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa
2021-10-07 13:16 ` Akhil Goyal
@ 2021-10-07 15:38 ` Ananyev, Konstantin
2021-10-16 13:34 ` Akhil Goyal
0 siblings, 1 reply; 5+ messages in thread
From: Ananyev, Konstantin @ 2021-10-07 15:38 UTC (permalink / raw)
To: Akhil Goyal, Nithin Kumar Dabilpuram, Nicolau, Radu,
hemant.agrawal, Iremonger, Bernard
Cc: dev, Jerin Jacob Kollanukkaran, Anoob Joseph, Nithin Kumar Dabilpuram
> > Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single
> > sa
> >
> > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
> > delivered to application unlike inline crypto or lookaside.
> > Hence fix the application to not drop them when working in
> > single SA mode.
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > ---
> >
> Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> @Konstantin/Bernard: Any objections?
None from me.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa
2021-10-07 15:38 ` Ananyev, Konstantin
@ 2021-10-16 13:34 ` Akhil Goyal
0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2021-10-16 13:34 UTC (permalink / raw)
To: Ananyev, Konstantin, Nithin Kumar Dabilpuram, Nicolau, Radu,
hemant.agrawal, Iremonger, Bernard
Cc: dev, Jerin Jacob Kollanukkaran, Anoob Joseph, Nithin Kumar Dabilpuram
>
> > > Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in
> single
> > > sa
> > >
> > > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are
> > > delivered to application unlike inline crypto or lookaside.
> > > Hence fix the application to not drop them when working in
> > > single SA mode.
> > >
> > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > > ---
> > >
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > @Konstantin/Bernard: Any objections?
>
> None from me.
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-16 13:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 7:16 [dpdk-dev] [PATCH] examples/ipsec-secgw: accept inline proto pkts in single sa Nithin Dabilpuram
2021-10-06 7:20 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2021-10-07 13:16 ` Akhil Goyal
2021-10-07 15:38 ` Ananyev, Konstantin
2021-10-16 13:34 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).