RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

[Akhil Goyal <gakhil@marvell.com>]

>  /**
> diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
> index 2c2c2edeb7..7d683fd728 100644
> --- a/lib/cryptodev/rte_cryptodev.h
> +++ b/lib/cryptodev/rte_cryptodev.h
> @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability {
>  	/**< Transform type: RSA/MODEXP/DH/DSA/MODINV */
> 
>  	uint32_t op_types;
> -	/**< bitmask for supported rte_crypto_asym_op_type */
> +	/**< bitmask for supported rte_crypto_asym_op_type or
> +	 * rte_crypto_asym_ke_type
> +	 */

How is this supposed to work?
Ke_type and op_type are 2 separate enums which can have same value.
How will the user identify which one to use?
Shouldn't we split this too?

> 
>  	__extension__
>  	union {
> diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
> index f0abfaa47d..dbf1f62199 100644
> --- a/lib/cryptodev/version.map
> +++ b/lib/cryptodev/version.map
> @@ -108,6 +108,7 @@ EXPERIMENTAL {
> 
>  	#added in 22.07
>  	rte_cryptodev_session_event_mdata_set;
> +	rte_crypto_asym_ke_strings;
>  };
> 
>  INTERNAL {
> --
> 2.13.6