From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80DBDA00C5; Fri, 11 Feb 2022 15:29:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16E0441144; Fri, 11 Feb 2022 15:29:21 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9F11A410E5 for ; Fri, 11 Feb 2022 15:29:19 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21B7wbUM013056; Fri, 11 Feb 2022 06:29:16 -0800 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e5134dy1j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Feb 2022 06:29:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dH1sWQh8FHdZ99Wf/TEk10nDnWx6PwRFcOF71JHvs29r81mJ6L4ZV4f1BeAz1vLEJA5uHNo+Nb2SmCYWH/bvDHkTzgM/IfSzqr8VsgA4k93Pars8kyMT5Jv5elXd5NCyONgscjUHtjL0dkZjl1sqYABQYV7XImyQcUD3pG+dETU7dt8rbnXqtkz20Q6a2uT8VQmxV8bnQOZ6r9wx8gxk54EDnh3GcJZt4RX9SKTeqawEUHoBdyefb03zzUXysu/49aNabSRgqNNhEav9vuHA9rc52f3176KxLALRtkAo75sstyXm6DGHHFXfhi2pkRCsWH9PnV6Cmcq3CEXdhVrEFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LWRio7XavFbl8dlwFDdNnFsWfPOyRzajDxLuTbB8Z8o=; b=idpM4QaFLWmxF3b9heAS4pcjsAYzTYHwc1Lows36xtoNi9GWe1HAoV2tntbLQ1vXz2ds+m5f0Vl4o6a+fb06YbBdYhGBCGYq2WbJpyQi5dRDi1vmPuVvzLoxvjVzrorziMtAfP+uBoReZ58qSbs8NPTMvKAf27496QZiDg3H46GRld63Rz8R66hbtxSmkvrMw5Y1siFVVGXY2umwDAUsw5DyJkr0U8Jpcvbj3yA/NgjeDKPkO79i1nu7EAmEkBthtoTl0sL43P3uQZsaOBpWD5EwehHIPpg5HVjrpkrUMg5ZfKD2BVWSR8x0rq9zI2sB5c5EBQOH24ihUEs8HvT47A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LWRio7XavFbl8dlwFDdNnFsWfPOyRzajDxLuTbB8Z8o=; b=NixKI6dwTQrvwruxtkznavj5IZNDsjp9jlcAvw+i5ktV3tkmxQ4JDewHtlKMMzQ8dbphFw4iO6ymActlpxjuMtlQlbxvDG1F5n/g3b5ldSwACx6EuQHaQsBy1N8gFepQ3scX1uSwN8fHrGgp1YSIhmTwGbu9kHF4/VjpzNgPIHw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CY4PR18MB1096.namprd18.prod.outlook.com (2603:10b6:903:a8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 11 Feb 2022 14:29:12 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::d4c9:8800:1431:88e1]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::d4c9:8800:1431:88e1%5]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022 14:29:12 +0000 From: Akhil Goyal To: Ciara Power , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" , Anoob Joseph , "mdr@ashroe.eu" Subject: RE: [EXT] [PATCH v7 0/5] crypto: improve asym session usage Thread-Topic: [EXT] [PATCH v7 0/5] crypto: improve asym session usage Thread-Index: AQHYHynbydBeBEvTNkmEeFcjayuZNqyOaNjA Date: Fri, 11 Feb 2022 14:29:12 +0000 Message-ID: References: <20220209153854.2740455-1-ciara.power@intel.com> <20220211092909.4169919-1-ciara.power@intel.com> In-Reply-To: <20220211092909.4169919-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ac49af4-f9bb-4c93-4076-08d9ed6adfb1 x-ms-traffictypediagnostic: CY4PR18MB1096:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nh5isdRHqGO+BS9vdaN3CmVn3wFEB4fhjzDNNrh35oIPP2/sapHDm4JkpUwSVYqaeXtjf+2POnzZJRl4pK1BiwESjPMFglokpRJ87G3BO/lsrN72sZ4vdmuCc7nRPS7aXQz1334MwluDjWtPVEelK/lBaPqOCoTNpuCBd0VIiTrMgg/l/p0JRd+I5FthLAyYbmF5k7Dgql4+q3QFfGfnhuRGSEJiiJ1JWrfggKFuD6GhZPZyqi4uanehhkOOWwh22yjXPaBVM1dhWlCZN+NO3C84F5Oy2h7VMC5Ba3YdEmfv1Uj79CfNdC8ByV0ppNJ2B4dDCJzANO80Y8qGftCZ84IkRB1tSqxjMPaYdGLGw+dIK+DFWp2NKu++Bu1akMMgRM9zDF4G9T5F7yU0m5i8l+Z9OfmyWb/D6em4nZqPXFOVNmLT+iJDcgcxtWAG/4Mxt601nR2U9/UTlxmO4N7q85YDrO5j/yChIT1L3/V5FevZNmWJrbaDwlAyizNnHqsxXvd/6PHrkuHC2wCpr58vKr5BL0GzQqwjoGnbK1KGT0bo50P1eeOGCC5oJ2awV9avDVNopvspJGPBYERKj+ZYhV/B7x4qifxm9fSA1HoPwZm1JgDK/ASzhbKN251q7lYKoctz321+wx1++738R9p5eISbIJgrw3q3Z2PeCdC/uvW2tyeNInFsdnpR+J0nsZgCUrR4EgsmlZ07lFDtuKJD7g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(38100700002)(122000001)(55236004)(6506007)(38070700005)(7696005)(54906003)(110136005)(55016003)(316002)(33656002)(508600001)(8676002)(66476007)(66446008)(76116006)(8936002)(52536014)(9686003)(66556008)(64756008)(4326008)(66946007)(186003)(26005)(71200400001)(83380400001)(2906002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pk3WXbCC/EelDeuZNPfaVnBpO3rWS3VJ/7Uyj233id1qFDTRWo85O3dN6asN?= =?us-ascii?Q?zBwv5TopkGk7w3/zdBTBF7PtZUNadlajbULDs4qRw6AND2s664XEruto/pYs?= =?us-ascii?Q?/CqMXhrRRotIjYcWOWQuJGvXsTxZKIj55Lpu0q5NSq1gXnww+Ww1ym0WJu8a?= =?us-ascii?Q?COjM33D8Z8gLeF9ORmnxBKNl7lzg9YUCm2msFyTbOsIJbLY58H0pcCeHsmUB?= =?us-ascii?Q?ginko7XWbDkpWZVfcbdvbSXlrf6M8fSfDyCqP/bONdc1reSOSuZdRq3QONen?= =?us-ascii?Q?uGD68uNzynYg+ecsxYj88wAzb2CXX82Sni4/Jfp75CKOb5bO1v/IeKYmKLfu?= =?us-ascii?Q?19syx7axBrpO+LM9n7MyuzFvUTKyKx9vrrXiwkrnIaNvrW/ShZChySL+RI4+?= =?us-ascii?Q?h2TZ7SUEqZi7tCsA0FGqVam6uoIywOMRFHGL7R7nQPvBYcQRIberg4sIm65t?= =?us-ascii?Q?5lkX68rnb+V6bHvwsDWPUSmH4834rrAUJm7YPUHIbDMzJcmpcMyjnGe7nOMM?= =?us-ascii?Q?KC4jXCYcsjuvsUjc/BmLOfyaFbKOVdVOpj9kzKVeHllOwERFXtDrirHeZTAM?= =?us-ascii?Q?aBkEjrbiPKM6EF7b9KmchAPY6p5atw9TNoxRK7tlHLvjy5ue0BxoY9qMewYZ?= =?us-ascii?Q?uhO9T+LMYx3k0tDL9L0S2OPEF00z0PZH5FdLlhnZoNQUWJCdAm2Idr3CDwSp?= =?us-ascii?Q?RUCLWcVz9MpwjVSvKsPP/Zkb2w0Gmx5QDqt8FIZd+tcefM5ANo2V/AnRuCm/?= =?us-ascii?Q?C+jt4W6ml3W/YoZ/4qnrirhMpaKyQP03IHif9qP13Fk1mtHxJCDpI6n+khD9?= =?us-ascii?Q?75kA33BjoDe6omlVmOX6evgtud19H4oe/2+nUkEGiHLM5DcfrGAD+BpzybR9?= =?us-ascii?Q?0WTYDWfhmh8R+sN2cNxy4DgZ9iCyh3aoLrJ+UllheVSq22Y4moMlCpqwg5zr?= =?us-ascii?Q?qo9zhUvEI12Bmh81qok1oYaAjS6UieqRPPZBZlPIB/tq5KODVzhMqW8wDQPa?= =?us-ascii?Q?m9Aa3fIaylRqcr8NZv28pWuZ1Lv5gjyKh/UUqM1FTZ/rrZqgANpjXYkrZ2jy?= =?us-ascii?Q?gbrmner4xMKj3+cGNR2henlqziQF1tYOih9xt0QznuEVa+nGX6XGdhgEVbnE?= =?us-ascii?Q?6NgLa/UhQ9TtZGYm7qVQf4WWGAdPAMVSvwDy+PF1EuSnQ5HTOh59O0njhkqv?= =?us-ascii?Q?bh+7CfrpM/log8Yi2ZhziZgG7oSfyYGju5YiA7ws44hZlg64+vR0RkUecUyE?= =?us-ascii?Q?8vjqmXOqQ5fXjAu7Z4fEF325UsQ+72OwPldB2ioRBaB///FQA1Oi9PPeOjKc?= =?us-ascii?Q?6kMJ1C3Zu7OlAEQvnI2DLMTgSrYO56MMaqJTUpjeDgg9sTHBE6MuAGDpxN/5?= =?us-ascii?Q?4hk4kEzIr276gfQgQiNRDKvcQCVAmY58olHIAZZZIqVLV7wKkn2l95mchByG?= =?us-ascii?Q?u2PB8ck0Sk1q2fGpo0BBBPms2XoL02crIrH6u/pmFM/SMFTqWekUTPZk3AxO?= =?us-ascii?Q?MEwQSuTYZlXCvhCtwT5gG8KE+aif46gPtIH+MpV5+PGsAjkfEH/A77p4bHqN?= =?us-ascii?Q?7EYeX8KeFHOFGC5d83iFb1yiE69fn1l/47M28NCkH69ed2/93e1fN/082f9R?= =?us-ascii?Q?1nJjSNYc8CUORfPk90aVrt0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ac49af4-f9bb-4c93-4076-08d9ed6adfb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 14:29:12.3950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eMxz/poSBoL/Txw1OEikkURtDy7qKtlPezfszy6+uhe4TZ0yFro64O2Yrazu4JGzNKtyTrRyDPt4/17T82TuIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1096 X-Proofpoint-GUID: uj8uFyKXw_Uay2jSJmq3tGu_3BHrfmGb X-Proofpoint-ORIG-GUID: uj8uFyKXw_Uay2jSJmq3tGu_3BHrfmGb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-11_05,2022-02-11_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > This patchset includes improvements for the asymmetric session. > The main change is to the session structure, which is now a single > mempool object, rather than having pointers to private data elsewhere. > This session structure is now hidden in an internal header, > so the app will never use it directly. >=20 > Some other changes include adding a user data API, and modifying > the return value for the create session function. > This create session function now also initialises the session, > and subsequently the clear/free functions have been merged into one. >=20 > Sample code in the programmer's guide that showed basic steps for > using Asymmetric crypto in DPDK has been replaced with literal includes > in the first patch of this patchset. This ensures all subsequent code > changes in the patchset are automatically reflected in the documentation. >=20 > v7: Removed unused parameter to avoid compilation warning. >=20 > v6: > - Reordered variable declarations to follow cnxk file format. > - Added fix for crypto perf app asymmetric modex operation, there > is no longer a need for private mempool, and the > rte_cryptodev_asym_session_pool_create API should be used. >=20 > v5: > - Modified which patch the sess parameter is passed to session create > trace function. > - Reworded create session function description. > - Removed get API for session private data, can be accessed directly. > - Modified test application to create a session mempool for > TEST_NUM_SESSIONS rather than TEST_NUM_SESSIONS * 2. >=20 > v4: > - Added new patch to add literal includes usage in programmer's guide. > - Merged asym crypto session clear and free functions. > - Reordered some function parameters. > - Updated trace function for asym crypto session create. > - Fixed cnxk clear, the PMD no longer needs to put private data > back into a mempool. > - Renamed struct field for max private session size. > - Replaced __extension__ with RTE_STD_C11. > - Moved some parameter validity checks to before functional code. > - Reworded release note. > - Removed mempool parameter from session configure function. > - Removed docs code additions, these are included due to patch 1 > changing sample doc to use literal includes. > - Initialised session variables as NULL. > - Added possible error return values in user data API comment. >=20 > v3: > - Added documentation in relevant patches. > - Fixed setting user data size. > - Fixed hiding structure, it should not be hidden from PMDs. > - Fixed some other small formatting issues. > - Increased size of max_priv_session_sz to uint16_t. > - Removed trace for asym session init function that was > previously removed. >=20 > Ciara Power (5): > doc: replace asym crypto code with literal includes > crypto: use single buffer for asymmetric session > crypto: hide asym session structure > crypto: add asym session user data API > crypto: modify return value for asym session create >=20 > app/test-crypto-perf/cperf_ops.c | 22 +- > app/test-crypto-perf/cperf_test_throughput.c | 8 +- > app/test-crypto-perf/main.c | 31 +- > app/test/test_cryptodev_asym.c | 380 ++++++------------- > app/test/test_cryptodev_mod_test_vectors.h | 4 + > doc/guides/prog_guide/cryptodev_lib.rst | 212 +++-------- > doc/guides/rel_notes/release_22_03.rst | 14 + > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 8 +- > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 8 +- > drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 22 +- > drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 3 +- > drivers/crypto/octeontx/otx_cryptodev_ops.c | 32 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 4 +- > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 24 +- > drivers/crypto/qat/qat_asym.c | 54 +-- > drivers/crypto/qat/qat_asym.h | 5 +- > lib/cryptodev/cryptodev_pmd.h | 36 +- > lib/cryptodev/cryptodev_trace_points.c | 9 +- > lib/cryptodev/rte_cryptodev.c | 258 ++++++++----- > lib/cryptodev/rte_cryptodev.h | 136 ++++--- > lib/cryptodev/rte_cryptodev_trace.h | 38 +- > lib/cryptodev/version.map | 9 +- > 22 files changed, 528 insertions(+), 789 deletions(-) >=20 Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.