From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A269CA0548; Thu, 2 Jun 2022 15:35:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6842A40691; Thu, 2 Jun 2022 15:35:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id E51364021E for ; Thu, 2 Jun 2022 15:35:47 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 252Agxbu025897; Thu, 2 Jun 2022 06:33:43 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2170.outbound.protection.outlook.com [104.47.58.170]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3geupu8mcd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 06:33:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z5ukYvfLWnSWe7wPGAKM+hMufU/GGTFgydNso0xHuAC2w/neAvbEqv6mHesD8xdJLbg3LEDPIbj1vC+DU4M0zuEaDgH8MwJiqnE8p4PYcEF1Vdb2vY2r1NwYxfDBjlBr3PunAtGu/HGloqgclknZ8x2lucwTPAW5xa2nFWEH0gmw7oIUO624Vpc6MFhJAzUCg7JGztt2wPbMctTlokqWt4XhknV9fZVCS50K6HZjpl0824jHZKUYuBvQ3Xp+WfLKTHr74hX/j5lrKhNgAUEzOZ+HzGCYm7lVKg5b4KIhKohBHbBXRNzDmaQZt25z7ltIDtMJ0Qjf4cjGaADR17EB+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o1yu+lCRv7iHmpzuCqu1j6hAB6BdvCGiG6J2zFp61Mo=; b=j+a3m9ZqCyoH5/fed/EIvhfYEkjQxYi22uM18nebT4IRzX55SpN4/LM2tzfSh1KEbuHWfhjJ8ghWkkWMEz8Ig5qDC3qdqLGEs1XXwxEjQSdZSqyffC9v8X2MLFuTgjAYC3BBf2NTDCi9cKbadDMA3OulVt3aaoiskGEJqtTGKDqK0EovNGVOtZ5GzUDY5toN4L4iOKlOiAdBqxyeDgrfncxw/sppZqG5rsWLnIKdayXgUT5FA8Hvr25EY81nqJzmpCkCqKoK9H5TMrp64lXhDAPKXqfqrzv+wPP9KSPwPMHwUgb+DUN7qCuczdw0Fj+0jAVObK7S81P5T9IkbJg1gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o1yu+lCRv7iHmpzuCqu1j6hAB6BdvCGiG6J2zFp61Mo=; b=K4o+2IAdI1wdiVd2elmS5JDvdWRooPrAsxi1bQyYNbFzsqe1a1CKWTuPIbEgfyrblAwPeKauLgmpR1s8R5v2GfGDcY147n/3KHd7YNr+RPRcdyf4mXnQkzAeiYq450BoIjf8LO5tpSKh8vAmTpebwrT03MFFFOx2xPDZEfDroVc= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM5PR18MB1162.namprd18.prod.outlook.com (2603:10b6:3:29::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 2 Jun 2022 13:33:40 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%9]) with mapi id 15.20.5314.013; Thu, 2 Jun 2022 13:33:40 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" , Ray Kinsella CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Thread-Topic: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Thread-Index: AQHYdZ/bx0HEzPS8JkuQdbyTlyoHTK08HsiA Date: Thu, 2 Jun 2022 13:33:39 +0000 Message-ID: References: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> <20220601090249.86865-7-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220601090249.86865-7-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ef0a9feb-6e3d-4178-287b-08da449c8178 x-ms-traffictypediagnostic: DM5PR18MB1162:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YVhbAeLNHqRbWUUd8n3BLuDV54S4mYE8aKcPAuD8POYo2PMIP9F+3NwkXIpJhywCBos/3l7mcU+/oPwB7DVJ3a1vDoRoGAr+UYLQITOvT9iMupMN3c1R1kMLfA4B6u8IfIUciotRZ+/i+JoB7T3T7bD7HjTmNYzNVzxa8xUbt5ZQ/CU1Q695UYdkJEF9ynMiFQBZ1lnGufM+LU9E9NJRzfQE+3NM93Sz38d5dNvLmcyo6sUe6MxzbWGMUB/griYNLJRzpGo5cQNbF2DcrVzxhRprXAR24SwbBA4MWeyDg4veKk9UW5UfZlroEaM4sfYAJ/0znmbaoAUflGIyNGc6v0Nu478snZ9XBHJh0zWfTXPOQ0fsaq4895i5MWdR7XXVgyOC0l2C+eXfDedFWvqPflP37AcnKecJnhqN+A4gTHHKs8XCINSf/ZFJKujMYL2qVWEPbHSwX7dArDgn2GF3cHk0chvrUbOlOXnAdGpFJIo+PJ+myxptBPixEp5d2iqqxdsJCwPKxA54fxNeEeka5BFW573jhfCC6ZsCuFJjxPEgVkDFK2t0LtOf9X+VHoBvPR3t5jSDV6YGh7NG/cpjTp5ezEcRBfHZrWPz94/OQ+UBrQKe500HL8fjCvhiZkCuaUqbUqPaTIhRxflRwskTjedGGDaxcO9T6q6sAdtW/BknXydZ5HbXXDAgf2ExSypxf0yU7h9yAiZbpsWrN62yJg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(8676002)(66476007)(66446008)(66556008)(64756008)(186003)(55016003)(4326008)(110136005)(6506007)(86362001)(76116006)(66946007)(71200400001)(508600001)(7696005)(33656002)(122000001)(38070700005)(316002)(2906002)(55236004)(8936002)(9686003)(52536014)(26005)(38100700002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mjFhg14xMkXhnEsJUCkYh5HL4pGb9mnHvJNbM9GndUgNrguGCN23bVn+uk9O?= =?us-ascii?Q?b2ydOBjoddYuKmG0ryev1KpwhZtt2COyZG2SY7/Z8Vf+TZKTWUi3MVs0r+Y7?= =?us-ascii?Q?2KMyA2wRu9213jfu1BFfw1dpV07kSpDl0AYPXRBOvX/Yz1t45UE0wtorBHuJ?= =?us-ascii?Q?U5LEN4RbX0/ekJNbOUYhI47CW9/I5Urc4LFAPVVAS9c1gu/sRGGPKL7aD1Jx?= =?us-ascii?Q?HDDepbfr0dnfcBYJBqMd7I5Ja/hXJ4mEZLGx1sUh/xfd3GlMuDmT4x0abrQo?= =?us-ascii?Q?lo9dtSQY5d5xIKkbqY44MVQOikb+svVQdHQOiF7wbwb2DjKIaKBlOin9u9CO?= =?us-ascii?Q?+Gcg/uTK1uHg6UHpDL5DG6cDx3/pyjtgkvQqv3w6NMLpMDgTNlv0bIIWcONt?= =?us-ascii?Q?iZwfDTzddboBZTm/taqebHSkYGAdwHPfCw92jMK+n1EDMKyj9KBgDOgsYmPP?= =?us-ascii?Q?M01mfA5anJodeMAIEuQ/JGlt046IjqY3loBfd9VHg7Xb5xtju2WBVKJfZKjI?= =?us-ascii?Q?5QDuMfO/OIaQV5hbUfP4TnOrPaHZgf7zQi2dwYpJVsSsUUQMZRnB1RtppvUr?= =?us-ascii?Q?cCBjbkQ9oXNb/h/2pew2Ef2ISjBNy3xiguyUl86FwxxABiDIt187WN/mOjfF?= =?us-ascii?Q?TX8HVGDGO2VajXBGaDSZ44DYd7DRynHqHj6zrBp22Iuehx+EmqYxa0W5zWBB?= =?us-ascii?Q?3gABfEVkgvRthnD4gjlWNEllfPGiYPnPWEQQE9MHRmTxFCWicHV57gMMiM7P?= =?us-ascii?Q?/ZMghKfHe7LujVpmTE02hj0Wr/U4PkSlyhsH+VqkUg+pKkCIRVX0fC8KIkWb?= =?us-ascii?Q?uSKT/JzR73rxJlBaczvpPSolhwDlSiLMZwrZkv9b8HWmR+sg/5DcKf+bmL+9?= =?us-ascii?Q?hLMm+Ifx1/CAMbNJWfka8zNG4T1l0nwA9XsSCMacbWHR1xUKVl0NgCkrt7us?= =?us-ascii?Q?uY14ag/+ZBY2UYiSQcN1g9cpnDMaGdhgW1+s9qVPvD5wzslQ5NE3v7oEXkps?= =?us-ascii?Q?Xv3rrjQW3ailhqxkxwDtOhoSbaV86vVS1tznTndn3pWHkkLhU7dzw5JG4KGr?= =?us-ascii?Q?QXxZtV0YJWGkzoeQUi5Pe6+VuyZllKw9973frzB63D/x8HaIXavQh0Agp72P?= =?us-ascii?Q?tolRPHHH0rgjhqy/O0GtYStYgwbl8LGxxEF2yJHNMovSP7sVyxFeuZ+A1Y1X?= =?us-ascii?Q?GJxPXtQchZ0WS+E/4p2jd8YsCrwVN5RwNOEiJgZ8L6rDVecK/h4Aw/MHLQ0r?= =?us-ascii?Q?ho5QfqJXaiMk6Vc6Ggddc7gQmeSXUyNDVAASLg41BZdEEmD6+1mh6gKOfeYZ?= =?us-ascii?Q?3KeZEZaNQq43IVhIYaKVu7MQiI/fhnLE/86PwX1EIN59leJVnlSnlhZ3i5ie?= =?us-ascii?Q?NRATBOdBSwxBl/QYs+vorbcj6J2DJe7IdIcaR9sKf4fBJ6hCaljHCKVaAA4q?= =?us-ascii?Q?/yN8U+fGlJ/wh9lAxpPOhZUJ/VVxH5yPEq8FvVDBv77fCLBnOvO9T/UoR3Ln?= =?us-ascii?Q?MflkC9yBIbEGn1hk+YRwXba1evvj5aibW5g+rHhaFWl0LcrKdLtUVKSfm/is?= =?us-ascii?Q?HbyU91kAmQ2NfsrX9jQr2fg6JDDmMeBkG/Regcq3FFbtCWFQq+AyMurfvWBM?= =?us-ascii?Q?HrB99bZjBEMEvkfTg2sTROzRacqSMQP9naaJOL8b5uwfVs3O7AKTIgRgdkN/?= =?us-ascii?Q?pwEaQoCfXebkzBzm+1AVjp/lG017IlS99/yo0o/PUu68ZY6Pt7ZRBJNIKUjR?= =?us-ascii?Q?/VrV5BppIw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef0a9feb-6e3d-4178-287b-08da449c8178 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2022 13:33:40.3444 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yM5dA5fiM9YIAdTLVyQAUO+AnJKtbVuV07XSau8YxhJOCSBISqzi79wFRWdhOhzv4AS/vGBzhNSlLsGfOUU1hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1162 X-Proofpoint-GUID: XtKpeJbJ7iyLj_tSZnMer7nrik3YSPA2 X-Proofpoint-ORIG-GUID: XtKpeJbJ7iyLj_tSZnMer7nrik3YSPA2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-02_03,2022-06-02_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Added elliptic curve Diffie-Hellman parameters. > Point multiplication allows the user to process every phase of > ECDH, but for phase 1, user should not really care about the generator. > The user does not even need to know what the generator looks like, > therefore setting ec xform would make this work. >=20 > Signed-off-by: Arek Kusztal > --- > devtools/libabigail.abignore | 3 +++ > doc/guides/cryptodevs/features/default.ini | 1 + > doc/guides/prog_guide/cryptodev_lib.rst | 7 +++--- > doc/guides/rel_notes/release_22_07.rst | 2 ++ > lib/cryptodev/rte_crypto_asym.h | 38 > ++++++++++++++++++++++++++++++ > 5 files changed, 48 insertions(+), 3 deletions(-) >=20 > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 79ff15dc4e..6d174b291f 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -27,6 +27,9 @@ > ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is > experimental > [suppress_type] > name =3D rte_crypto_asym_op > +; Ignore changes to rte_crypto_asym_xform_type, asymmetric crypto API is > experimental > +[suppress_type] > + name =3D rte_crypto_asym_xform_type >=20 This exception does not seem to work. Thomas and I are getting ABI issues even with this suppress rule. [C] 'function void rte_cryptodev_info_get(uint8_t, rte_cryptodev_info*)' = at rte_cryptodev.c:1582:1 has some indirect sub-type changes: parameter 2 of type 'rte_cryptodev_info*' has sub-type changes: in pointed to type 'struct rte_cryptodev_info' at rte_cryptodev.h:503= :1: type size hasn't changed 1 data member change: type of 'const rte_cryptodev_capabilities* capabilities' changed: in pointed to type 'const rte_cryptodev_capabilities': in unqualified underlying type 'struct rte_cryptodev_capabili= ties' at rte_cryptodev.h:198:1: type size hasn't changed 1 data member change: type of 'anonymous data member union {rte_cryptodev_symme= tric_capability sym; rte_cryptodev_asymmetric_capability asym;}' changed: type size hasn't changed 1 data member change: type of 'rte_cryptodev_asymmetric_capability asym' ch= anged: type size hasn't changed 1 data member change: type of 'rte_cryptodev_asymmetric_xform_capabilit= y xform_capa' changed: type size hasn't changed 1 data member change: type of 'rte_crypto_asym_xform_type xform_typ= e' changed: type size hasn't changed 1 enumerator insertion: 'rte_crypto_asym_xform_type::RTE_CRYPTO_A= SYM_XFORM_ECDH' value '8' 2 enumerator changes: 'rte_crypto_asym_xform_type::RTE_CRYPTO_A= SYM_XFORM_ECPM' from value '8' to '9' at rte_crypto_asym.h:80:1 'rte_crypto_asym_xform_type::RTE_CRYPTO_A= SYM_XFORM_TYPE_LIST_END' from value '9' to '10' at rte_crypto_asym.h:80:1