From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B26CA0093; Thu, 13 Oct 2022 15:01:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 818BF42F73; Thu, 13 Oct 2022 15:01:43 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 53B9242EAF for ; Thu, 13 Oct 2022 15:01:42 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29D9IAcG010374; Thu, 13 Oct 2022 06:01:41 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2045.outbound.protection.outlook.com [104.47.56.45]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3k6fwv8phs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Oct 2022 06:01:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etVIEUo6iDkrI1y6KC7FKJBAVqioq5DPMmP7+mLBB2lRzFmaMopPVwPdagwPeOFe2RDe04SEvgt9JvEJY+rAfnjNYqT9cX0uHACpmsMMl6CQnj74OpaHZ+Izna0DmQQDbLbc6pafgILu2wTFJAvZQcr0gtUwzu4EG9JSuupnnzLLetocIFH15VFjSTcQBwp9sq1+ykW8PGeMVgBTxhHxcj2+EyPVxuE1mDKfvTp4Di49vHhUN/z60uqlDO/TBkgl3dQvPchOUAwSMjT5tFzK9f8whzkancFq40m8FCVzGzxKTrgHSEidz7YEg6p4mNJUhCBhTxBSMb+MDnSeqXNN3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P6/6MeHNVXro1pfmKetoPNyizXHLhqEbTkfgdNBQmcE=; b=m6Ot0C3OmObCwlZEsavNJcZ/JAusJjvbsaE/tK8tTwFi/37Bi9UOSzWpigCQItdKjhcoRdm3PleG/6pKCsaFVMu1LvxgnZ6IcGnIkDsrZSykrwmxvWWA9HwgEvjzDK0yO4Hp9ZTjOmhSzmIeOvkTci+E42X6k9tMIlE1O6RpRyeRWzcNehfbFm67KmVJZ2/lLWop71+JCeFvpQb6q27zOEtTcV3UeZ5HYuvUtWrhfNb99nUmXHdNAMQI1AxS/PY26pX4Hzpn3EJC0epm/IsjtGou3oVB6LOoh1e+gA5Fl5CWhfP9+cyFKq7aeqQ5GdA/sQyc3iiKRMR16kuvGafQ/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P6/6MeHNVXro1pfmKetoPNyizXHLhqEbTkfgdNBQmcE=; b=KdpoAfXnG1GnUaqlujy0/FOAVIl1ADEo8Ylz/2BSOh3jFkp7yf+0GirL56jTduNGVCXeLX94zKXNXeaG0itrH6vWfHGs98xpSuh9eoaHpH3K7u7E85vtWV4z/O4qi5UNjyiAFYpUgdPWFXZ1pzJFBT1xblpVMx8Q1MIIA25z1QQ= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB4464.namprd18.prod.outlook.com (2603:10b6:a03:3bb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct 2022 13:01:39 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5709.019; Thu, 13 Oct 2022 13:01:38 +0000 From: Akhil Goyal To: Hernan Vargas , "dev@dpdk.org" , "trix@redhat.com" , "maxime.coquelin@redhat.com" CC: "nicolas.chautru@intel.com" , "qi.z.zhang@intel.com" Subject: RE: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11 Thread-Topic: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11 Thread-Index: AQHY3aNMW3epBF+ww0uwR9eBJEC8Rq4MS4iA Date: Thu, 13 Oct 2022 13:01:38 +0000 Message-ID: References: <20221012025346.204394-1-hernan.vargas@intel.com> In-Reply-To: <20221012025346.204394-1-hernan.vargas@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SJ0PR18MB4464:EE_ x-ms-office365-filtering-correlation-id: d7cfe472-8b13-4bed-c016-08daad1b1113 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WxEV72SauFiRHfYMJGG87MxvBBB05njwRjdal+GNLvZpPf8g4bh8XJZONVd5rDP41lWOydALVdxOi/HgFzJN4xYRfAoaWVXr/Qv6C2ZeTNjK81ciCQoKCg8LrlerInKqH/bfl12yF1j7UCcOrDdh4ZRvtG3QPjzywAJ0ODucHnO41emjD1UEvlir1tkivYMJzJt4ui7UBnfRNjYH9MThPHU960bKPePrEQsPLXQn4gzO07OGBE8tsaCcOSq39J4e85YOoAPLmHz/Q4bxnjHVHdV5vQ+afzGWAZ04mKfOyqRURaXmLsCmMvNzg/sT9iqCmxbUZA81/Q8qmXYLtwK5fJa3zfbQ2M2OTaKBSwfubkf3QhBPUpJMR9CMHlYaESKv8/q3QhknH36929EGqqLw35cgm4OmbOAOz7O7VmOOhkLvoOJstbgGbDhOGx9/j6q0DhjNOp3951Ov2X4c5vcuoRS6QucXEEVtGu4b8gfot0UNo4zMkMpR2VJYXc0siT+w3qGcx6sDyLUCvDO7XU7nrs4rPPNXfv9Y6PvArWnETVUsYqzIx3yGxeYZtX7h8RtIIa+qh6qUZHuS/+UJnyzAwd3TyPfmrdhbQXFP/d44/K0PB4ck9SfkF1CwIXtIAybQLgRD/Hc4+pxUD6aoFK4i6ahHkrSh6yevVFhA+EOt2GJcSqx93aCt3GzXCUyNbPbUIDHf5bY0K8focLDFpCOaAtrIVTW6ZA2w3Yww3SU5LNQy6y9hWc9DgGLBxxt8VZOS+p0o0k4VY5J0TgeKShIAuA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(451199015)(478600001)(71200400001)(122000001)(86362001)(110136005)(5660300002)(54906003)(64756008)(66446008)(4326008)(7696005)(6506007)(52536014)(8676002)(8936002)(66946007)(76116006)(66556008)(66476007)(83380400001)(38100700002)(186003)(33656002)(2906002)(38070700005)(55016003)(9686003)(26005)(55236004)(41300700001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9h2CrlxNIxxQwBGW8blC80Oj/O9axqU91zIL81pyc56Yn7T2QK/Ynbsrrz4N?= =?us-ascii?Q?v4T0vliq9Glb4Mc/ciDI5ne46Olc/PPAPzCGupiK8LP4fg7ns3YtKPg2Bf+/?= =?us-ascii?Q?Rg1qXSfQHsLc4Z5AMCqkUAFyI2c12pkZVj9m2o9gIhO2bS2cIwsUz1j+SloM?= =?us-ascii?Q?/p/EDtRLTFpWcZLgHlWYfjMsZDY1RTlqBuTyxi5nMz1wfln7jAxg+3UbDQse?= =?us-ascii?Q?/azppTEv9GXT9KrduAwuYPdoe+uTy/cmxnjLFBpwDPf6gKTtwkD9I814J2m3?= =?us-ascii?Q?B/iUfY8ryk29h04O/BQ1JtLomoRp9h7UzdzdMy4ZC6HZzylg618cL74hLQb0?= =?us-ascii?Q?t+1rJBk7+KVbk+nUCpaD28EQmsN/e4awo0i1Ky3zIXj3Yf0/kouid82rInTr?= =?us-ascii?Q?Z1UPVIHOL3RypJ3NjLXTZ310Tkpx5GSksHw3nnepxX2LpCcix6YJgXUkboUC?= =?us-ascii?Q?y2Ztht1sn9Bq77ZO6TE8WaIGpLDgK8DRPip+BWZXXoPKmw5R3ZPjxOMIL5q0?= =?us-ascii?Q?T3UG+kGkBuGk11r2QETD6WR9g5ySN0IsOq2Vv+twX1TBFH4UZmtq2LKdhM7U?= =?us-ascii?Q?DfimHWZTAekHUJXGHeIkqb97xOlAqZ4jtrA4ehzDsDnaRHcT9QuHik0FqZB/?= =?us-ascii?Q?KI+pmLqhbSuZXVfXC9PG1Qn+yv/P7L21NVOwje6fTwXxFO3555UyhfEqD1R+?= =?us-ascii?Q?QIj3ORtLqX5pLWRWJ5+91aeUXKM8QeoS9CHMFdkteL9viVgtA7R9hmteDLBS?= =?us-ascii?Q?+QrRpw/p7oLAN9vplypPzQIshu3acyPXtlgitQJS3O23/ziGGXvhK2DzKUBP?= =?us-ascii?Q?lQIeTna/I5MERLQLNIIUT6zih0P4RwkV18YYem00Ip0JZTajpRmM8PskLhfU?= =?us-ascii?Q?aQ27zq2cdf+8jMTWsGzx1j10dMczY5fsLGGyJNejV3Oq7p00clsDcdZ4TvG0?= =?us-ascii?Q?zFIRIRNAWUEpVJ3kWP322CHKh3wQDF/srHrx8P/lp13pZwz6gfRZzaVxEEAo?= =?us-ascii?Q?TeYkxoTRMWovshJQS8XgQVqPNaXyoOvcMPDpfDey/2AHZ46QgyzZXlTQcPaa?= =?us-ascii?Q?w8XT/L4B66bioOIOVKKmcSAEmK2L/YyIxUECu9GMOFquMCuDWMjHhCWpKaXV?= =?us-ascii?Q?iMUWWv66QPaE3VH7YkWXMUZ7RDuEiSGPwdjBDTr+eJ2rX5uTY0za6DjYoMcE?= =?us-ascii?Q?WP6H4qQbGlk3lsOftDUhjEeVlXOdyUv5CjUcvGuBtRXeHILXqDrlTOXRwLOR?= =?us-ascii?Q?UGr7UHZXgtO9JJ3S98ulcYPHomJtFQu+N3IiwVSC0KB6oAntgZIwcoRhjrH5?= =?us-ascii?Q?IS/2uReNrrBLQ1A0L9nPZ0TPgBukVxLW/2t/EC8SuWYxgLlwf9vgcDDsU3w/?= =?us-ascii?Q?bKQbAN5TZ6NboFtMzZOV8f+AfDEmo9a4Pep8IwoQ/Y8fkEPQA4/Qe/h4Xuf3?= =?us-ascii?Q?uGn+ehxwuSaH8BiqjVe3LvYLCTKUEnTxHhAq8Su02Y4QNoT3iQFxssB20cbs?= =?us-ascii?Q?971V7WPU0mMbNCWbyvGHrEtaRIwejne3LXpmxgsGvm+G0r8EfzZk99dluan3?= =?us-ascii?Q?WhE0zG4yJAgHWxBQWJu/d+4DD/m0PKRhEPGrOG9y?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7cfe472-8b13-4bed-c016-08daad1b1113 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 13:01:38.7169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AEd29KYl/q2pn1JEDnalSjBDotg9xcG6uP0I9Nv8FgfxZeHiANrs4TzP4j7JYQYbfdWaOi6t4n49/o1hhEh3aQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4464 X-Proofpoint-GUID: ry6RXKW6TRQ58oCjWPeaJcMtqkTDfdXT X-Proofpoint-ORIG-GUID: ry6RXKW6TRQ58oCjWPeaJcMtqkTDfdXT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-13_08,2022-10-13_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Hernan Vargas (30): > baseband/acc100: fix ring availability calculation > baseband/acc100: add function to check AQ availability > baseband/acc100: memory leak fix > baseband/acc100: add LDPC encoder padding function > baseband/acc100: check turbo dec/enc input > baseband/acc100: check for unlikely operation vals > baseband/acc100: enforce additional check on FCW > baseband/acc100: allocate ring/queue mem when NULL > baseband/acc100: reduce input length for CRC24B > baseband/acc100: fix clearing PF IR outside handler > baseband/acc100: set device min alignment to 1 > baseband/acc100: add protection for NULL HARQ input > baseband/acc100: reset pointer after rte_free > baseband/acc100: fix debug print for LDPC FCW > baseband/acc100: add enqueue status > baseband/acc100: add scatter-gather support > baseband/acc100: add HARQ index helper function > baseband/acc100: enable input validation by default > baseband/acc100: added LDPC transport block support > baseband/acc100: update validate LDPC enc/dec > baseband/acc100: implement configurable queue depth > baseband/acc100: add queue stop operation > baseband/acc100: update uplink CB input length > baseband/acc100: rename ldpc encode function arg > baseband/acc100: update log messages > baseband/acc100: store FCW from first CB descriptor > baseband/acc100: update device info > baseband/acc100: add ring companion address > baseband/acc100: add workaround for deRM corner cases > baseband/acc100: configure PMON control registers >=20 > drivers/baseband/acc/acc100_pmd.h | 5 + > drivers/baseband/acc/acc_common.h | 10 + > drivers/baseband/acc/meson.build | 21 + > drivers/baseband/acc/rte_acc100_pmd.c | 1197 ++++++++++++++++++++----- > 4 files changed, 1010 insertions(+), 223 deletions(-) >=20 Hi Hernan/Nicolas, I see some ifdefs being used in the code and there is no documentation for = them On when and how to enable/disable them. It would be much like a dead code which is not compiled at all, if any of the build target does not enable them. Is it possible to replace them with runtime devargs instead of compile time= ifdefs?