From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ADE9A054D; Tue, 31 May 2022 20:15:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B7E440A87; Tue, 31 May 2022 20:15:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C06FA40A84 for ; Tue, 31 May 2022 20:15:00 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24VGAOar012175; Tue, 31 May 2022 11:14:59 -0700 Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2048.outbound.protection.outlook.com [104.47.56.48]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3gdpabghks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 May 2022 11:14:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9flhwVhUvGOHzLG0YY0lwMVAWR+F6qrOXmK4xK5NJ2ZCHPXCeLlHUgKq5Sy0fV3IWmwI+lxrrtou2voUknA2KINRyGfVw/XUu81mL3BY/JgtdULiO6eP8+V2CsdArctd7IJQcUniG2WFb2Dk2oIrMS8qTCHLioozsk+qHsKUPlt1RAj2fqVefhY7ObpPwWa7qiaUwa+v4zdHn8CjI5KtgeZpwi0NxfPAsuXHPfCisujIFqy4kXoOAkqZcMkFtrFr2M9CZOHXmEVNLGdifKRrKnAQgUhnW9idMtKWjMCbUA/MRHW82A3Zy6lkNZHZ8XS7d4+vO2Xg7/F0+9eLWmrPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y5arcL59SZXiwMqRbl/NC3dPYYsSE7lcP+xy/EtY5RY=; b=gTnSsN4xPdSRII8q5O8IvrbQenu1oZrB5T8hnFH5vmGWzNUJc0T5peScKoSYrlj17Gmfxw93jOL5Uzxe+Vgl0D3/Jdymi1q2GszwNUc6Q8Ah4wqaUb9STJL4u1WD144UNSxnJ9NgYbE4Bw5+vAS/cKyGoD2wMKD6gsev3arCCBUlQnS4BKjQcUUeEHrBjs794ni/MGIJX/4t/PHbWQstatPQUL4IDqP5oL+spEyaGv9a2Y917S2E7l4TW8YptBO+3++GjlNSCBkKl4brIl1SYec8BjC4rhYZDlV2qbPKseXDcIn1LKBTk6yfofzstHxbhgC5/ALLAJieHm5qcFKyzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5arcL59SZXiwMqRbl/NC3dPYYsSE7lcP+xy/EtY5RY=; b=BC6e9SHHTxPP2FnYFGw3jN2CZYW9AcGu/RYzl1MGY6Q0TfQ515jqKUzIyjE/haa43s2ZIsm0fpBtq6VxsqfsnPIsTWLSlDxRjrsg4lvZicMxnMMqDuqLkMjdA3DnXbLPCnCr4ndyPQbEpOVLVkbruSVHHLxYHdSDIckjG1kF46Y= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by DM6PR18MB2635.namprd18.prod.outlook.com (2603:10b6:5:184::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 18:14:56 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%9]) with mapi id 15.20.5314.012; Tue, 31 May 2022 18:14:56 +0000 From: Akhil Goyal To: Akhil Goyal , Gagandeep Singh , "dev@dpdk.org" Subject: RE: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations Thread-Topic: [EXT] [PATCH v3 1/7] app/test-crypto-perf: support SDAP for PDCP operations Thread-Index: AQHYbAEVPTFjFIBZi02ZoEOjCcZ9xq0xN4vggAWswwCAABlDQIACXssA Date: Tue, 31 May 2022 18:14:56 +0000 Message-ID: References: <20220517033858.40394-2-g.singh@nxp.com> <20220520042104.3784908-1-g.singh@nxp.com> <20220520042104.3784908-2-g.singh@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6312ced1-ba1e-4872-61a3-08da4331779d x-ms-traffictypediagnostic: DM6PR18MB2635:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u15mYnVIawdo7aHby290sMeBftJEM98XK3FqcWqc3QqNDgSQkIiqjKe76dEmhhpOQSZQjE5AOUeawfAuIabXF8AjPNWhaY54r54MSaQI2Z0V5M1fTwIXOdjNsEjiNA9DTM9e4evix7jYc4m/ovfdhgc5/0i54hYloYLJFTRja+SuhPun3EYPxYJd7R+GezvUn9NpSi8N4mrO5Y1YRsXWNJg/tz5Ga/9oX7xHseBpF0BpIidShKwNLCbtecxcDwZogLjJ0Tq0BZn9h6VN4Xnq9hM8Ibq+YbH4yWBcZGundZ+8BVIHk8Ncrs7Dh7KAY48R5cCl4QECOsb9QWOBrnpwLaO98B2iTy7sXhotfe5alPcxxbqe1aswBzaBPHR0J3HmLge3/6V7ZAhYY95C1Ek11gu327RDOsFPVejKfiJVLdcr6d5nH1lC3q+nphe4BcMh9lrXtn95qP+qbJ3CBtXNdtP2DBuDdifeVtnNRtBdJC3IFpBoF8bGvOReOEeZVSnRjOvR1SyO+/DSba6NdzQjXO97dmYEsJC3b/FCV2Lbc4M0o7P3ll81eY8WWCDxEJZiF3PlTZq1IJVrZQcgI7kMKz3go/MHMY33ivPz6caRejxZU39IUKs0akfIe++1P3N2yGVjmcKd8wS0FMlWOfj7KBAe4pKaw0BuyGFUQjIx6vJIzv4TVfFrGQUV1svjF9+j3IPTHG3CTwI8aVOF5s+jzg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(86362001)(76116006)(508600001)(38100700002)(8936002)(5660300002)(316002)(71200400001)(4744005)(66946007)(66446008)(52536014)(64756008)(110136005)(66556008)(66476007)(26005)(9686003)(55236004)(7696005)(2906002)(6506007)(186003)(38070700005)(122000001)(33656002)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l6DxZ8kjKmYH9VKG3sLSMSb5/Uvv/3nnhiivH7E3XberIm2ieff2XjyAc/TA?= =?us-ascii?Q?Y2nhcZ5VTOcRT6wjIW2UU+4SqKMUlWeZV5N1PQEIXO6FzRwOV1LRF09XgH7Z?= =?us-ascii?Q?KPmatyGZrAX2kA3Nq286AqT/9AQ27tlKritN7zzFqhAMN0kdxVEY0GFiSvzt?= =?us-ascii?Q?7mxvM4zKYflB8eb+BbQG+MtRBebhcy961qDJOsA7YBxbxLE9MC2g/yAEqH4n?= =?us-ascii?Q?bgI44qS17pF5jwitOTelHX4BQfsEJvMzFDlFiTkLtLDr4kJdaWeI81ojSWna?= =?us-ascii?Q?1moRMsvxN8shpS3jDnhxcTkmNZVqSNKqTYtU+q1K08umnI1hanElH8M+wNdC?= =?us-ascii?Q?qcDnZJMCj+CUFxgcFt4vfBg+CJfG8ze+j4GFy1rfWj20sR8K1KWBgD3Bh6Ax?= =?us-ascii?Q?URAwB3X0OFI+Itm2TVKIdejt1Uabk9kRBQGcVCxadLQWANNDuYL4D1CFgSpa?= =?us-ascii?Q?aSQboCNkJiqpDp+m3lN56b5hEg86kEQ3mO9h5l2EJD7l0yZpSfrMAsyV7NVy?= =?us-ascii?Q?qazfEf05p641J+5/N21o82Ktd9xg48OWanvE+rMxMarqEJryPHde24Adh8rR?= =?us-ascii?Q?KTAfFcnKSndkNV9fgkIOVZ9LG2/j3dfMeEEgzS1Ph4mylzf3bDvbGe+LBSo1?= =?us-ascii?Q?/pkrimwQBADPGr1zTWcfPLd9aoua/6v/kf+IfelMnIGcs9fU9cDfSxSIJgHB?= =?us-ascii?Q?X185236K+GKosLsHYERgsZDeL5IA8P26dAtry1b45PGjYbfv/mDJZbHnItxC?= =?us-ascii?Q?wdByEzkIWgNZOcsD7hB16gDrq7KxHfZAVNJ2ZVSxaGbgqJ3lbnvI9JIat9oa?= =?us-ascii?Q?aRT13hLYM+GAV6j0n71w8RuM+cmCYwRXLP+6fNyD+e5RnykEUejuUuRXc7or?= =?us-ascii?Q?xr4jzunh2tq9xtC3dP7jNlvEtMDeOud82NokNxvvugXL5NYGQ+UTem22pnX9?= =?us-ascii?Q?/24JJb7Z1NzMnmpoUTv7N3TKxb5FnDlXTv6kv5JZ5UR4IBqDMBdRNr4+eJLD?= =?us-ascii?Q?7HmSQi9HUK0VUhjZE9I7UocBsBohV5M41auuGBO8FxxUTW5Vd3MjU+YykqHB?= =?us-ascii?Q?9z37RV+ec/HhMoo+sYrL5AbqE1varyRkuDvogB6+BiycFSS7AWZ9msE+vj44?= =?us-ascii?Q?7tVtyiDH2Sk4GvJdB96JPK2I4Xtulzemmsp8DI1Yo16V/dbcO9+gV8253PJJ?= =?us-ascii?Q?ck4us0XMog48HOu+zipe7ETZQS+bEsLc8AfsDxLR+GOqr9tDRQj6BE6qWqyZ?= =?us-ascii?Q?69YNvBAiI3GA2O4IQ+PsvmGdX93arhFmTrAnHbrpoHWCtJiapU+YEeVzMxTV?= =?us-ascii?Q?SZsYM4YfH3FQtob1YzjnEiVyroBYUBNUA2l0MXGcSGQolnKpMv8NVY98j+kP?= =?us-ascii?Q?tCe8nuQdHVIMs/V8vNmUIPB1xFbLSkIdQRf1HgSIZH3aDu0n911TESKvkOJJ?= =?us-ascii?Q?HWEfq3IPP5K9iAhAKUA4Q2jta+IEM7eFTPWsRmkJUVbWBmuQWskFQwsmHWlS?= =?us-ascii?Q?yyerOUPulcL+YboYS70U2B8s37qiSbc6OMFzOpLRlPW7YJ5odv09NTVYTHM/?= =?us-ascii?Q?Wxh8jjzO6hoYrBXtFqKQihTl7TDgLsDk4CGcEY0Tr0fQQBsOOwIj8YwkabT3?= =?us-ascii?Q?MVBQIO33qB0k+tt+TlVEQkB2E3YwXhYiHxLAKN5jn5GS4r6K1TPHQ0vzhWzd?= =?us-ascii?Q?YPVYpIF6mjKasLpTtXTrXMZd9KgDOBuvhZCR3qZob1Gjw3TDbnfuqQmdq5he?= =?us-ascii?Q?wsSMb6RuSA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6312ced1-ba1e-4872-61a3-08da4331779d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2022 18:14:56.5451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XPACIsLgQumFUuTM3yhvR5i4bZJzzGjRinwTLeQHL3G089/Rr7N4ujquuRyi6+R/gkX4Z8KZRPu7lx1rS+AkoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2635 X-Proofpoint-GUID: qLxifUINnerwhEamNEb7xdNMrTLg_pkd X-Proofpoint-ORIG-GUID: qLxifUINnerwhEamNEb7xdNMrTLg_pkd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-05-31_07,2022-05-30_03,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > You should also set a default value of this flag. > > > > Default functionality is disable SDAP. Application is defining the cper= f options > > with all values 0s in its main(): "struct cperf_options opts =3D {0};".= Is n't it > > sufficient? > It would be good to initialize that with other options. It will help in d= ebugging > and > Improve code readability. > Please add it in cperf_options_default() as it is done for other PDCP opt= ions. >=20 Please send v4 of this patch as standalone patch. The rest of the patches h= ave been Applied to dpdk-next-crypto Thanks.