From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C05EDA0C51; Fri, 16 Jul 2021 21:05:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BA574067B; Fri, 16 Jul 2021 21:05:20 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 3078040151 for ; Fri, 16 Jul 2021 21:05:19 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16GIus3t024790; Fri, 16 Jul 2021 12:05:18 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2044.outbound.protection.outlook.com [104.47.74.44]) by mx0b-0016f401.pphosted.com with ESMTP id 39udxggeg8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jul 2021 12:05:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VXsECQLMjjbCTmWxC9zaSBf1GTp+50KrzGreD64sT/Vbs6oYM5lUpocKD9hqGr46dkgrtoifWX+Q5qKYvlm07qpCXmoMoBPMiWVKnObA61gPMaWqgoospc7whzKVLzpKd8gHeBU1qleh8DLX6r+qglpwET8Eh4oGIUASI6y13B30M0p4wRq5nCjkf3NR5Iu8qup0TSO7rkrlNoeHNAzRlvxyK86xooFpJlvS4FJTXDJLIajGab12xxRZM7JAouYE971P9rLFyfH3PGbBc5Nj2AomG3QZ19tFn6jBVhN8OaYk7zskBQbfNAkB0aZCpEyHK4RopDMTeJyvaQkPdb9rBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Y7Zt3thS5EckwKy5NjgmPlHTMPPt0NCGHWJGPI4NlY=; b=DrlmICPKUwzlrBoa0OxtkapBZSW2NyRo3/A7Tfddab+EmmXu11GQ3r2j2Aax/qrsLEGxWgl8YbjsW+7R5MFxcyI+MimD7PWLDL3Gcg4l0JB72uIE2Q+DaUBUSmj33eSGCgMTUSEtu0ZkjCq10dGD6OwEiXpqg6zRVy+hgLTMrmp1TwxLeGxW6dDnlN7dE1nX5C2lJHfwvEQm5JR7Uzk3AJYukULUT009yqzkq70dMdWAJU22XoIGF9YRf//KHODkazh00Nd9DvQTNgVNNuPCyTys84HloU5WBP/VGQdljv+NbG90QcYdrqNRLHaVvM4qhJudYkZMKfF8dIe2hnIeVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Y7Zt3thS5EckwKy5NjgmPlHTMPPt0NCGHWJGPI4NlY=; b=tqee2fbw6hfcA3mQJ13iDy6krckB2VUtnQCyw/ClLgxtXAQEYW01xirTYTYm/z/NDeIuJ3Hh3szoJfYBu+YGOGj9/5lxTECOuQLzRk59DUmZjo1TFC5BWXLd1Bx2X7yESEDEb1C9bEAjQ+74E7mOv0WgsyMIppdI+KjArHRhQpw= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO1PR18MB4731.namprd18.prod.outlook.com (2603:10b6:303:ea::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Fri, 16 Jul 2021 19:05:15 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::1455:9a67:a6e7:e557%6]) with mapi id 15.20.4331.028; Fri, 16 Jul 2021 19:05:14 +0000 From: Akhil Goyal To: Shiri Kuzin , "dev@dpdk.org" , Thomas Monjalon CC: "matan@nvidia.com" , "suanmingm@nvidia.com" , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD Thread-Index: AQHXeZhYb+JPlPFgXkOhdteyWr6XLKtF9gLA Date: Fri, 16 Jul 2021 19:05:14 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> In-Reply-To: <20210715164126.54073-1-shirik@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b18c8631-6a4d-4ce5-ff73-08d9488ca4f5 x-ms-traffictypediagnostic: CO1PR18MB4731: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jdtMJa6c4ubw7bfajEH8KjRzFkB85/vjJudGk71Sa04f1AqTCglhbJLixRtOtMh07jQo8mXVI73N6nGmu6YbRTenC1amuOnYl5qIA7t9jAjwXwy+UU/tFqIhqZ5lsjR9l1xQwxD8jFk4WLNVwq3kWry67HdR7b87xW0Bb60WHMSF9GwzNyF6nrcyNNudnEhcJprIjAeQ9CxaSjYRnrGHiIqK849UiBweg75nkciIiYaOAK5590kpHR8tJgDxBDNHQX2CNwxn8tLTBq1I41GakbHc8BJAok1X9x5mVJejQDczTtDRoP4AR4/DPl7f20yYvXBBrADWRyBW+YI3SJMwJgHGcFEWvSWTS5u4iGULW9GEzD1VdbX8YxgUzMSAx4x6VYB3DyeWFWRdUOrFGkQT/fqLRfhB7I46smhPPNy6pYA8RN3gB1qb1VP4XZ8TteKz/B63HAR8C+qzl4rc/fGa86FHOewDCjRfYLqKC1yLNafFD52GTTDOYk20G/6ThhE26jLxW6LOS822TsLkxT03/1y3WwK3apQIFEi42RDKr81vrhoC0t51v3bHaKeY1GZ86LMiO/vBiv/NzkJqZm2SKqB7e5mBWpywsTf4iGk4omd0fAY/92Hp17W71WwFvpp8+hK1zIuR7QwdBAGtVHrM8whtBIJIcxbpIKnJVVB8LzEgk3B95VzA+9J72fRZ5GsbNt3YWvJeZqdjERHD+Fb8gg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(376002)(396003)(346002)(38100700002)(122000001)(8676002)(52536014)(9686003)(478600001)(316002)(5660300002)(110136005)(66556008)(71200400001)(2906002)(86362001)(186003)(66446008)(66476007)(66946007)(55016002)(7696005)(26005)(54906003)(83380400001)(76116006)(33656002)(64756008)(8936002)(4326008)(6506007)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NQWHofy9prLYfl2PQct8kLe94reLar8yddAzanU75CRCDL5Uhv+a2jr9O3od?= =?us-ascii?Q?Z/CliebyHesUy3JsJgHC0dktCEuoplg04R2BVA6nWIQkec/XhSRC9Dh5Atp4?= =?us-ascii?Q?qXiwVYQk+4DRlwMVABHT62DbBeLvtu6FP9N42YNnWSCg9NnO8jRPUEgbFQeu?= =?us-ascii?Q?nSRyTDmkZ5XPMFBnW9PohFBvEkiVhbeeMJ+fjLkGyHXlneApakAR4TS9U08j?= =?us-ascii?Q?3OYfzmVrORClp5f/vTX+HuYRPtFKvJGxMurSkSxdx2khXxFcxlPE9BKkpqFe?= =?us-ascii?Q?M260GwzSZEA9jiIOeLt3m5AwU5Vp8AX97tgwofHWaY3cMJFGpx3klE6m//lQ?= =?us-ascii?Q?5ciawmtnoXw1LjOzIxRefuEYefcnVNf9uV6BcDnYuNVsWWzC1bgLOzqeilMC?= =?us-ascii?Q?N76ptsoR7HuIokf+eC7DAlpsdMOvf3bPhAjClZXyqEGyLCZXqYYwXnVHZLif?= =?us-ascii?Q?4m5CpMzbPbgZzwEn8CoXAjTpQDbhYzZaSk/JowmpVAENYaUyvMCLp+vqmy1e?= =?us-ascii?Q?Mm6v/F+gYSdd/YEImOJXVT0bk7rrBReDnS0xHgU7Cr6Si27OW33Sl6BvvAPa?= =?us-ascii?Q?UAvpSAE3fxfb5o0cghAQ0LG50sObbWOtYiNycy5W7Autj+dASZ8wY6u3BlmS?= =?us-ascii?Q?PAfDMzxsFVZO7x7MN+SADE0zk5098qlc9mmuHeQ3ngTNraFFSymz2fOvifG6?= =?us-ascii?Q?85CLR35jfx7EgOns2sjawUJtijO7MycPRYX/FrneauYZ9ZGr5vncU7GmHx85?= =?us-ascii?Q?LuD2dD0+PcxNNoCGZRRCS66BW+QBFtr4MyJgFj1sederPVluwyF+OQgdeyA2?= =?us-ascii?Q?Trc1+48cXERaX7kfI4tvvFGj0cEcmq+hH6NPvT96NxrekJJu3M85McUkgJef?= =?us-ascii?Q?r1vXYaj79nawOEK+OfzKWtGzkC2Gn1qdzh9YuSrCDP1qcWb0FBTLw2ZQUpzQ?= =?us-ascii?Q?GusAF187bcYCGANVIbPHyG/vsJzN7A8NeDPJ/+pcijdzZWGE0Bmqp9MMSMFx?= =?us-ascii?Q?3yxeLsMAAEXRot+tlaR3rtI0LplpKS6dJCDks3OrMksfbyNItal+JYGVHOIE?= =?us-ascii?Q?Gh4hj2m0zCzwSSOiKp3FKK5ZpyGrzuF1HTpRnN2YIi5GVYKI6E/DASqqD+4V?= =?us-ascii?Q?jjGJwa+vmGdtR3H/GbZ7D4OpE3KjFCnLzTEJxmHMl3qKyQn//fOCc+82GMF2?= =?us-ascii?Q?R2QZY22U+AP2nwFnqAZ5IpQYZu75EiqM9CxSqO8L6arI3BJTGBn8wD3VDt5a?= =?us-ascii?Q?du3ArahpNqSu3XzZrUfZN+bhuLEfrFKENox0NMRtTN3HzbpA0KcvipujgxxK?= =?us-ascii?Q?CuA=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b18c8631-6a4d-4ce5-ff73-08d9488ca4f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2021 19:05:14.8976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GOeqSO+uel2WyofoL+qvDC4oyZMeiqZYHlV8HZwoghMc4ipuW30ZyEM8D4Z+zUr1UjVU+9eizPfKEO3kOhNhUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4731 X-Proofpoint-ORIG-GUID: l8yFc78KVuwFGo7ctDZDHLkohmjGfGni X-Proofpoint-GUID: l8yFc78KVuwFGo7ctDZDHLkohmjGfGni X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-16_09:2021-07-16, 2021-07-16 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > v2: > - Add data-path part. >=20 > v3: > - Rebase. >=20 > v4: > - Rebase + Address the following Akhil comments: > - Set HW feature flag in the capability patch. > - Fix mp object release in session clear. > - Some spelling and word missing in doc. > - Squash data-unit adjustment to the session operations commit. > - Wording: device argument -> devarg. >=20 > v5: > - Add mlx5 crypto tests into test library. > - Update documentation according to Akhil comments. > - Fix memory region management. > - Fix multi segment case in data-path code. > - Split documentation to the correct commits according to Akhil comments. > - Rebase to new version. > - Change license to Nvidia license. >=20 > v6: > - Rebase to new version. > - Address David's comment and update log accordingly. > - Update testing app commits as suggested by Akhil. >=20 > v7: > - Rebase to new version. > - Add scatter gather and OOP test cases. >=20 > v8: > - Add a test case that was removed by error. >=20 >=20 >=20 > Shiri Kuzin (11): > drivers: introduce mlx5 crypto PMD > crypto/mlx5: add DEK object management This is really bad, I was planning to apply this series today, It had small issues, so was planning to fix them while applying. But when I applied the 2/16, it does not compile. Please fix this, we are into v8 and compilation is broken. I am adding few more comments, please fix them too in your next version As soon as possible. I was planning to close RC2 during weekend, but it loo= ks It will fall over next week. 147 | mlx5_crypto_dek_match_cb, | ^~~~~~~~~~~~~~~~~~~~~~~~ | | | int (*)(void *, struct mlx5_list_entry *, void *) In file included from ../drivers/crypto/mlx5/mlx5_crypto.h:13, from ../drivers/crypto/mlx5/mlx5_crypto_dek.c:14: ../drivers/common/mlx5/mlx5_common_utils.h:138:20: note: expected 'mlx5_hli= st_remove_cb' {aka 'void (*)(struct mlx5_hlist *, struct mlx5_hlist_entry *= )'} but argument is of type 'int (*)(void *, struct mlx5_list_entry *, void= *)' 138 | struct mlx5_hlist *mlx5_hlist_create(const char *name, uint32_t siz= e, | ^~~~~~~~~~~~~~~~~ ../drivers/crypto/mlx5/mlx5_crypto_dek.c:144:20: error: too many arguments = to function 'mlx5_hlist_create' 144 | priv->dek_hlist =3D mlx5_hlist_create("dek_hlist", | ^~~~~~~~~~~~~~~~~ In file included from ../drivers/crypto/mlx5/mlx5_crypto.h:13, from ../drivers/crypto/mlx5/mlx5_crypto_dek.c:14: ../drivers/common/mlx5/mlx5_common_utils.h:138:20: note: declared here 138 | struct mlx5_hlist *mlx5_hlist_create(const char *name, uint32_t siz= e, | ^~~~~~~~~~~~~~~~~ ../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_dest= roy': ../drivers/crypto/mlx5/mlx5_crypto_dek.c:26:1: error: control reaches end o= f non-void function [-Werror=3Dreturn-type] 26 | } | ^ ../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_prep= are': ../drivers/crypto/mlx5/mlx5_crypto_dek.c:45:1: error: control reaches end o= f non-void function [-Werror=3Dreturn-type] 45 | } | ^ ../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_crea= te_cb': ../drivers/crypto/mlx5/mlx5_crypto_dek.c:127:1: error: control reaches end = of non-void function [-Werror=3Dreturn-type] 127 | } | ^ cc1: all warnings being treated as errors