* [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path
@ 2022-01-21 10:38 Kai Ji
2022-01-21 10:40 ` Zhang, Roy Fan
0 siblings, 1 reply; 3+ messages in thread
From: Kai Ji @ 2022-01-21 10:38 UTC (permalink / raw)
To: dev; +Cc: stable, Kai Ji, roy.fan.zhang
This patch fix the cipher params configuration in AEAD job if
QAT GEN4 unified cipher slice(UCS) enabled.
Fixes: 328d690d2f60 ("crypto/qat: update raw data path")
Cc: roy.fan.zhang@intel.com
Signed-off-by: Kai Ji <kai.ji@intel.com>
---
drivers/crypto/qat/qat_sym_hw_dp.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/qat/qat_sym_hw_dp.c b/drivers/crypto/qat/qat_sym_hw_dp.c
index 12825e448b..792ad2b213 100644
--- a/drivers/crypto/qat/qat_sym_hw_dp.c
+++ b/drivers/crypto/qat/qat_sym_hw_dp.c
@@ -533,8 +533,20 @@ enqueue_one_aead_job(struct qat_sym_session *ctx,
/* CPM 1.7 uses single pass to treat AEAD as cipher operation */
if (ctx->is_single_pass) {
enqueue_one_cipher_job(ctx, req, iv, ofs, data_len);
- cipher_param->spc_aad_addr = aad->iova;
- cipher_param->spc_auth_res_addr = digest->iova;
+
+ if (ctx->is_ucs) {
+ /* QAT GEN4 uses single pass to treat AEAD as cipher
+ * operation
+ */
+ struct icp_qat_fw_la_cipher_20_req_params *cipher_param_20 =
+ (void *)&req->serv_specif_rqpars;
+ cipher_param_20->spc_aad_addr = aad->iova;
+ cipher_param_20->spc_auth_res_addr = digest->iova;
+ } else {
+ cipher_param->spc_aad_addr = aad->iova;
+ cipher_param->spc_auth_res_addr = digest->iova;
+ }
+
return;
}
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path
2022-01-21 10:38 [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path Kai Ji
@ 2022-01-21 10:40 ` Zhang, Roy Fan
2022-02-08 21:30 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Roy Fan @ 2022-01-21 10:40 UTC (permalink / raw)
To: Ji, Kai, dev; +Cc: stable
> -----Original Message-----
> From: Ji, Kai <kai.ji@intel.com>
> Sent: Friday, January 21, 2022 10:39 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Ji, Kai <kai.ji@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Subject: [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path
>
> This patch fix the cipher params configuration in AEAD job if
> QAT GEN4 unified cipher slice(UCS) enabled.
>
> Fixes: 328d690d2f60 ("crypto/qat: update raw data path")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
Nice catch, thanks!
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path
2022-01-21 10:40 ` Zhang, Roy Fan
@ 2022-02-08 21:30 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-02-08 21:30 UTC (permalink / raw)
To: Zhang, Roy Fan, Ji, Kai, dev; +Cc: stable
> > This patch fix the cipher params configuration in AEAD job if
> > QAT GEN4 unified cipher slice(UCS) enabled.
> >
> > Fixes: 328d690d2f60 ("crypto/qat: update raw data path")
> > Cc: roy.fan.zhang@intel.com
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > ---
> Nice catch, thanks!
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-08 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-21 10:38 [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path Kai Ji
2022-01-21 10:40 ` Zhang, Roy Fan
2022-02-08 21:30 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).