From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D6F3A054D; Thu, 26 May 2022 13:04:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5202840151; Thu, 26 May 2022 13:04:37 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 61ACA40150 for ; Thu, 26 May 2022 13:04:35 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24Q2AffO003176; Thu, 26 May 2022 04:04:34 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g9jap5aq5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 04:04:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3Eyskvfz2YL846pWtvdYFikDThn0m9XUuJc5ffFXILWS74c0MK+mNYwyWtFCnbkKKL6VBwEm8tOX7bFMyC2pC/6kqrZRWB7u7EXDAu+3JHYu8k4D41NiTgowpSjUj3+Z0XfDM6gFaaWDKIHGjhf5TfCjsENFkYpA1qvYxVogiR/PA0H8XsHlOcz4IRcHjlAeZhMk9LpqNofR7llVGSK0uFJl4bKtQh59EcEHo9fY3KWpKlsHV9uszs2UeOrbp0PBHEhDx0cEtDIrh+LcjRL6SCRbp2zjkwsbdEA9OI4+DClSOjfYNxgONMlPAh3B/tPnt7+a9kTJoqD9G29C2y30Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dCVCvre7mjuYdM4piIYjNif7lQn1whJ+klpihi0lbbc=; b=AGqrbEBXgr3Vn0MVjPTxT9YFNFkL6jZFXaprbpwqQ+vK4D2E9VRjQHOQSG0bPO7PWeKEniFEXsrTKzvHOd8YgqXQ1cdF5levxnJuLUWZLaBw32aqWKOQl3WOj1MWZl2NuoDuPrfue1BIaA5r1pUpDc5eC+r3mF5oCGKvsneT6iqtIp7i89NlTBLI73kxtgN1dsMTrNv0XTxM0Tm9nIV3UJAVjoLQ5MLFDq2FyoLkdxEo6goBN/HPsqZFipgymUu6pUka/Yq0Pk/jaZY0qIu/r9B1EfL/nO1t84sheZGjqaCEVv70omBpNUs9vo23Ihlwmi92bgdzxBF2wiu8WzbW5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dCVCvre7mjuYdM4piIYjNif7lQn1whJ+klpihi0lbbc=; b=nl8Uq71wFl2lao8/42ZzQKvpHjwosut2lRZ5Its7mx/KlYwK3wPw2qcplpqj/CNi4ntlMFTiToIfimiBAsJoWKVlmk8pr+UGYxnDD5pEixULe1F3dIAD1yEm2FFv3BOoW5lMY6zQYaBsx7WFWQJ2NdFLujOn4U2NGeeySdf/SWg= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SJ0PR18MB3993.namprd18.prod.outlook.com (2603:10b6:a03:2e5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 11:04:29 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::f154:453d:893:f6ce%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 11:04:29 +0000 From: Akhil Goyal To: Arek Kusztal , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" Subject: RE: [EXT] [PATCH v2 05/14] cryptodev: clarify usage of private key in dh Thread-Topic: [EXT] [PATCH v2 05/14] cryptodev: clarify usage of private key in dh Thread-Index: AQHYcFmDGADWt5nc1Euuxjl4LhyCfa0w/70w Date: Thu, 26 May 2022 11:04:29 +0000 Message-ID: References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> <20220525155324.9288-6-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-6-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 65d80577-12fa-496f-4801-08da3f07819f x-ms-traffictypediagnostic: SJ0PR18MB3993:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IIZ8KJvu5ADNnjQXfQ2zrXC1pQh//6q+EuQBwcoyBxZJpExwO/dUnllezOsmIeq2KFWO687ca4Na052kI88Y3iRckIbZByovqKltMbOmwXHVGwxRKP94sQYfLQ3Or5K7QytJXm9u/9abecLSjfEujilzTfFT625JWapzj5ITuAXKdYqkkKE5X6fqOg7TY7WWwtaoSKbBjOiQYiDiqQnVMeY3utIRgTMrVQIaJ7DAgaN0NXqt6afnhdUhsRF7ztCH5YzVNB9ResiWOdIgEhl6vCNpEaHcgmmqwxs8Md+RIyGOTM2iTzAXlx1CR1TO7pUOkfSOv9+597P0+Xu7Ur7qeXzTtMf8kEIZgwtIZQEiY1CYE0ilpjJ4cm5cik7ynTSyEX9F2+/QSal0Mk2RYhWJFYLMLnbCDo20JK7Tflzzw6FjWwqU7jqIeMejfD/ACRNrE1tAwUxPSW2+lxOuJHoMB5KD5nNo5QoCSy26fWi9tcLmz5z5hGB8qx9askgtUJA6/9gFJjUpBfOG/goZJFA+N7sxXBSizGxjWddsDMwrum/C3irK+qX1D1Q2uTxP87IZ05x7kfkE8fTOXe6imTr0UEXH/DNpN6iH5og4PmZEY4sVCnetIjKm8r468/DEB5JI3RYWYY2+41a2pP0LoW0k9V0Ib5sNON3gwkHbA9mhHZSgaCDXGLP/bg751uv9xKRiKUfiAUzzngOgID3QKfD+RA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(64756008)(66476007)(8676002)(66446008)(76116006)(55016003)(4326008)(5660300002)(8936002)(66946007)(66556008)(52536014)(122000001)(508600001)(33656002)(6506007)(71200400001)(316002)(7696005)(55236004)(38100700002)(186003)(110136005)(86362001)(2906002)(4744005)(26005)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rydtNpFcu/2Y3H+z1YjsiKaocRt8Wq/1eRpjDNN7PkVSSR1tsCYQPRaiJhjO?= =?us-ascii?Q?GKJkLzyFvPPxVZ0zuHsC4dMJP4HVXfLF7k/UMPO5cMsHEaD0a+auhLuQvLhL?= =?us-ascii?Q?LP+8Tz8Xn7NsA7zOAm0LzgRmh9IVV4i4vBk+02J8dT3Kib0kfqwNEzMoiZZk?= =?us-ascii?Q?KKhUIGOTfUUJCcDrK3wRbAD9eZcnbEVsUdvHmU3i85nXyqRlltHDU4qulQcy?= =?us-ascii?Q?yA/151CoIrOPXrqkwYNAM77bPWNgomYaJqBiyI33kh2mUosf0Y83TBczg947?= =?us-ascii?Q?7mySoeUOiMPSGqcQXUDoK9YgQzlYoMpTznJj7Te8+y0/6+4/+jwE1eB65XSj?= =?us-ascii?Q?HjvGI44UZD3a3MLVE0Uni0yNfabVx84arw+nTM7KwpbywfsZxLXkdt+IceW+?= =?us-ascii?Q?TDaMcAqQMc9GcyvngzYr1YRlaSlTh+yDBWaCQz2F7AP0BfuqMw6u0kxUbvn3?= =?us-ascii?Q?kMQmz4rnwTx0BhWrc3bemZwC45Pj0hFQ4KoT94QjQ+XlQkGIg2BHYOJoAS4I?= =?us-ascii?Q?+GphExMXVkhlrBIalHojX36AyLHKyxn7wWDhQ5xtdyDZpN4ZVtP3rWkqf+GZ?= =?us-ascii?Q?zlha92P1SH874OJks4c9+uTqY26TAPv2jJMrOjFf8K1oYA+w2S1dcIPxl9qC?= =?us-ascii?Q?ee7AlOpSp1IsHVrGLtA11LePKaRACv7efFpsHRQGlEMtpK2v0awx4A/CVZUt?= =?us-ascii?Q?8B3qh78YU+MH9aelDlGHJDZ5QfINoMNtrOBELJNvKgl9KSxqYwttvH7j30Aj?= =?us-ascii?Q?dmi4csUz6emYDzAjQ+3Qvf2S2OLXgOPIZxrJkwbHC1wR0ZneVAnMfoJ3+HAJ?= =?us-ascii?Q?sNZTrRHKGa0FRV/jUsvhyJlRnBBqfUdWJFBqE9F1pgfv9FDSSLgP48sEBgKJ?= =?us-ascii?Q?G7vnhaekF0SKZuFZWD21yruzzH4U9fAn+/XSUIVMgTjE7f85lkArqK0pSUBC?= =?us-ascii?Q?Omu97aZp27FCoIlegp7XaT1XrbtE4cVSG0c53hHGf/T8qkTMEXfR0jgQbwZK?= =?us-ascii?Q?oGJDmY8Fsp8rmF+Sqyt+9F70k6PEHhZXv7QM52NEQEzV7c0e5yARwcqvj63t?= =?us-ascii?Q?zQbEwYWyLMPYHQDZf0aFlWySHrilVwbBIXmY+jeHRYqCcMLsigBR1B3htTvC?= =?us-ascii?Q?oWwMAXB7Bh22Pw14sEZ/EDl3Pw19H9fylQ1OFfEAlFKXEM16TT5VDfrcWLh+?= =?us-ascii?Q?ijm3f71ZRBBYFJErOKKTlXQ7nudo6tAAd8Dn9mo6+cFmgB6pXFjOYvjTpU8f?= =?us-ascii?Q?obv9NxWTEYdpUFSEVZ/SlMBATIB3Id6JLlAxtN9R4Xafd1Bybzj+96gt7GDB?= =?us-ascii?Q?LgYGiDMdJk24SoxeNV37Rs+TAai6wJJ24mf6UYj0UN5VPrRO5uLV0afUeRIH?= =?us-ascii?Q?xU9xd9a5QXyILPaOL0DI7saqxfcMTH+jGeNdbDWY+XI1PWczdhkRU7DVvTkC?= =?us-ascii?Q?S8trsQjTV99vMmyEOF0xt6QNc8VZTcTgITaTeHqGM6ZELnDILwGvH0WcCf3H?= =?us-ascii?Q?PSV8tSj47N6NZMuj1idjO/aj8B6waV9wK5V6JM6+idAIBMlm3X8S8rSrj9SA?= =?us-ascii?Q?wBTgj1ZDVtt/1FypRkqD9xLKtF1YCvkqHVKiw9aoD4b/0cnYaXzMGHgijEE0?= =?us-ascii?Q?N9zu+mCy/BGGpQFSXHZ1IN19L0U9GDGD4/DS8lcYxUPXj2J0dVNooiznuh/P?= =?us-ascii?Q?pAUPHpVccsHlCbkWwn8A5WXBMRwQNQH9ETUo4x1coJWNn1Ba6rvSmO+wTDRa?= =?us-ascii?Q?DY3WPBlZiw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65d80577-12fa-496f-4801-08da3f07819f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 11:04:29.7742 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XZQfNnjZIskg+942lEFu/4naM13lQxQRnQIKBgeotJygtdOD3la/m2rf80GPt0PMaJl7Y10mhxYPUUd5FIQ8kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3993 X-Proofpoint-GUID: Rg-d8nN_zv_b22q6PlG0g9mljStOAIcd X-Proofpoint-ORIG-GUID: Rg-d8nN_zv_b22q6PlG0g9mljStOAIcd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_03,2022-05-25_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > - Clarified usage of private key in Diffie-Hellman. > CSRNG capable device should generate private key and then > use it for public key generation. >=20 > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_a= sym.h > index ef8686fda8..1a77a74478 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -394,6 +394,11 @@ struct rte_crypto_dh_op_param { > * Input - private key, when xform type is one of: > * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, > * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE. > + * > + * In case priv_key.length is 0 and xform type is set with > + * RTE_CRYPTO_ASYM_KE_PUBLIC_KEY_GENERATE, CSRNG capable > + * device will generate private key and use it for public > + * key generation. > */ Capability for CSRNG? Acked-by: Akhil Goyal