From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC793A00C4; Wed, 28 Sep 2022 14:56:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 588904113D; Wed, 28 Sep 2022 14:56:30 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id DFF714113C for ; Wed, 28 Sep 2022 14:56:28 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28SA4cr0003068; Wed, 28 Sep 2022 05:56:23 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jvjkk8tqu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Sep 2022 05:56:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JFWPOBjRtgLqN9LY82lmRUJ9aP1oFhm7pZi57ILozHw0sXUyjJ1rUctrAUZCxIWVbgJmhUpjAekYhlsznwL0En5JaMqqesJORCAUuQCy5eKRHcp5mMhH3OPcgoNHXdzq2xx+dy62fpGaEn8srul0oohnLRcvyAa3eXN5jPyzVatvTXjIc3lGwJcgE/Thk0llBkRdUZmZLNYxTFMm4ami9aGiJWm4vPwMtJchpLYhwOW+oFNQu9hgRTuDn+6+5CRXnEgI2eha/6C4Me4zGd9bYZfmj7OApF6bZOcPsbuxo2b5Q5bI9wyjvnJFuvLxPfQv0PpBVNafmsJ2NzBnMRqUdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tY72AE/RPSpX02AzjzH8AVNZ8/ZXfLvcmQkSG5f+zmU=; b=EbPtuxzIWSkcrqXDB9pEHmrs7I+hwYb/O3gI/Hyc8OgBzlf758W44H09yWWbdK3ZzS0QqlTHrKLV0eyhy22v8d65FfCvxcEcUUVac+jxCUcXkdvnzwUffirbozMuYjGycrCGgS+73OAI+6w/e60pAnJ4Fhby5Glit1jGVAc8wzKtIgSHedN0QVGPkwdfPWaI4wzlSD77JwwhqC63yL5z6cGv2JJvKONX6BPJgRj+UkLmQ7zLRI+6d4Mc9iqoS7O7W8cKnYrX32istpNSiC7HfJU57crotpjRCdQ6tCb0B7AUkbqrsD8EwraI1BfnKkO2KboHKZGNfxpvsi3PKIW1hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tY72AE/RPSpX02AzjzH8AVNZ8/ZXfLvcmQkSG5f+zmU=; b=ZMEOUclZabvj7yHPCGp5L9evnFKVsa/61lRCNscRZ4HUUQKblMdMIkZJ6BXvkLex9b3Pc8CjEm+SeR9XGm6yHgNOCXYmNIwvledx9j+Vl6xXBmk7ZvAoQiaQqOugjvIJhhZbhcN1UH1YWQnfuSzYd2DoZqrSRjlsUP0pf+mn17o= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by CO6PR18MB4516.namprd18.prod.outlook.com (2603:10b6:303:138::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Wed, 28 Sep 2022 12:56:18 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::ee27:3b96:a580:ba9e%9]) with mapi id 15.20.5676.015; Wed, 28 Sep 2022 12:56:18 +0000 From: Akhil Goyal To: "Ji, Kai" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Vamsi Krishna Attunuru , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" , "konstantin.v.ananyev@yandex.ru" , "jiawenwu@trustnetic.com" , "yisen.zhuang@huawei.com" , Igor Russkikh , Jerin Jacob Kollanukkaran , Ankur Dwivedi , "maxime.coquelin@redhat.com" , "chandu@amd.com" , "ruifeng.wang@arm.com" , "ajit.khaparde@broadcom.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "matan@nvidia.com" , "g.singh@nxp.com" , "Yang, Qiming" , "Wu, Wenjun1" , "jianwang@trustnetic.com" , "Wu, Jingjing" , "Xing, Beilei" , Nithin Kumar Dabilpuram , "Zhang, Roy Fan" , "Coyle, David" , "O'Sullivan, Kevin" Subject: RE: [PATCH v4 2/6] crypto/scheduler: use unified session Thread-Topic: [PATCH v4 2/6] crypto/scheduler: use unified session Thread-Index: AQHY0dxFgvo0mbmg50aOqXbcnjAU6q3zHdiAgACLqrCAASV+QA== Date: Wed, 28 Sep 2022 12:56:17 +0000 Message-ID: References: <20220924163542.4159562-1-gakhil@marvell.com> <20220926191424.1069668-1-gakhil@marvell.com> <20220926191424.1069668-3-gakhil@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|CO6PR18MB4516:EE_ x-ms-office365-filtering-correlation-id: e4ea2023-bd85-4b1b-f462-08daa150d583 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X90fPlTDsdgZbZbUhFO3dLiqSUEZ8mNi6rmJWzBJJFG5JAgRU0/8y/bFQn81fB1BfaYmXor/qS9Qh+LT6uV66p05kce/f5746Ouggo3rkJUfMSLuYvpCsG9J85eXMOY8I89lJubyFA49zCRYPt8ejKAbHANK4dObkJASmzFx5hbSI5GHGy4f+IkQeL1czpIyN2AOsFfeUcblFYuoDYwmuvhxKH1dZIWagDQAAyZuloTGBfzuv9VQfhT8EdOJ03pu6T9m1UT6uoI4CGa2PtEUDwflklCrdH8tPqa1AQa1uNm0PR92tomQ6+huYqOTvQSyuNzEc4Koap4PISrEe8BR12Aoecz2KZTb+UJi1bcjagCYC7SxAKmsXKD+vXOmX3kNjgBCMTHCOV6pXfj6c1fo2LrJ/bEcIZSVoUnmRKAKemg45/WDAQDSr6fUm5rTaM+HW8ejdzyOplm2tRy1H6RzbdTTf2RKL2Cr0ScskZ9pjR61aFy6mZqpEh3e3eJzXGDFDoN8R2eIWJGqn17nNjoxjni/5UjMigF14m0D+EBaiK/8SzbqqdzR2M9/NKVcFTaK2geHejnQxALV1m2N17VA0/jG4HSyAm3pWP+2wy8rA3+QHhQxu9INEXoKBwf5pG2Qr0U6XEZuPCXDQoCBKWjwu+87UNPxGjVuYvQhi9sEeYrBcfD4pQMKQSx26p/sE/qZLtw5ZJbPTaPSMpb/WHg83kaXBQvF+S8+9chjKDxaIjRXGrc7pb1b+QUcqn/VXe6j0dNitHk5OO0IelpFmVfvNIyIH/O1LZVhMwKXO7HReV0qDKRSxDnR/tF0CzzdrJWrKBq55Cfet8TioC/14iw3cwQgw4utJkNKZjP7IcnF0B0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(451199015)(83380400001)(186003)(38100700002)(122000001)(38070700005)(9686003)(7416002)(5660300002)(2906002)(41300700001)(8936002)(52536014)(478600001)(71200400001)(53546011)(55236004)(26005)(7696005)(6506007)(55016003)(66556008)(66476007)(66446008)(4326008)(8676002)(64756008)(76116006)(316002)(66946007)(110136005)(40140700001)(54906003)(33656002)(86362001)(23180200003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+J3XHpX1NYXt6wwRULhT5tgW+UnwdYSpDD45v7BOJ8G2Eb0Er8pJz4YitPs+?= =?us-ascii?Q?eDh+0JIfKivO8ix6kU77ODol3GKFavkMwohSIgmSGgqUQn7Zj5MLJFrdD58L?= =?us-ascii?Q?SJ6/Jh9UAGLdov0BkztVNr7hrhR2fahjbyVxLZ9WZcuYMsI05CdA8HFKVYtZ?= =?us-ascii?Q?oPLixI2IiRYiDr59emBurwPWZDNf4emTJ3Fh0wY//1SZW2KLCOIoGrTaZl6D?= =?us-ascii?Q?ph1NTNvjIA7G/Sg+5nKZvP4PTt+YndPN1MRZOO1JVpYkQ0PxHnpfcvluirXq?= =?us-ascii?Q?wAaK7uGWijRZCv2UeCMrxIp2roQkAAJU7grUFuXRSnf2j9YVnthqWhK6zZde?= =?us-ascii?Q?mDExTIHY45niiptoXYuyADxp6yGLbrPYg4WoRkskJ7/o3lJZPmCtT2TTc4Xk?= =?us-ascii?Q?dTg3HUtazviKPRc3jGFdSjffGknK8sFnOEzhGbpBPGFhTfM3KEkBEXYfHavc?= =?us-ascii?Q?spG6DpluJP+OECb3I/2Vz29irdxzMrMzblQsriuI4iu4UhyK15oX71UPH7Lv?= =?us-ascii?Q?OHJgndpz9W1ICpmR10e7uNrgoYzcOakFsN/rPyI3F/+NqG5DLVDajSEMvV3+?= =?us-ascii?Q?21P07T9Hxz1UfX3UKO9oamFdmr4ZkAzXbMcJ2bI98vTvvb2dnhHjy2lN4Vzx?= =?us-ascii?Q?UEP+y+AjXyzlVbIsa/JnwFhb646IOElGAdx4tOV9SCBejXlG0lWNFGJc2oXg?= =?us-ascii?Q?AlgUjCectu8d1SXuRhnL2MfuBzlESISQscZIStnZVXf+K51PaILI9vCh3sg5?= =?us-ascii?Q?FszSm0sbkGkVzzQiCT9kZBffUC/M5u+jNufvz7ZFY0UVYioa3KaOK9qdKPzh?= =?us-ascii?Q?PZ5wozmf85GIQU8H8WdBggj6eGFrwWPIEE23bdS1iCYHvTPDD0EW3yMxEagh?= =?us-ascii?Q?P8zv5TU/CQ6ScfYBMrDozyQfdRen+0A4a8uPrOILA5NQU2fu9JT6af/8x7fh?= =?us-ascii?Q?CS/BMQWiRavj8+Dy+tlnGE0UBpIz9rhcvz8Eqtz/rmdx5nrDJV2mVsuswnF6?= =?us-ascii?Q?aER8u9rtzJNwLwCxNhCk4Sy+W4BCgJ6hq5qePbiR720/f2Khr4Rnq7SN2xSw?= =?us-ascii?Q?TGfVdIkLRbmye+oGUZqGXR7yoYLSbEF29jWx+H6aydnYp573h65KYrxEnaf7?= =?us-ascii?Q?EavVdbcwv3vJeo8QnxYSOSdtPUlhImrtY+w4wBMXzgUoxptiPb5OAhp41OlF?= =?us-ascii?Q?ErRCT39bRyMp55hE44j2xJ8h31KaEpSKwo4XRbz3w3TleF4Nri+fAAF2zZrA?= =?us-ascii?Q?RrnKvGg7duL8ss+bX7cyghRiv7xJoRZXc+VzvIuZRS/JSJaR7cg68q4gzF/9?= =?us-ascii?Q?9jPFn+ko2jalT0mNqFU5JkSCaUCwYZ2TSBnHV9P6GrpDeoMSaRyizKmncF4t?= =?us-ascii?Q?aSHr3fZVauQ24LyWUNt4eC2R+kJyhQNKfh1QtJ/iHLo91+sQTHR9MJ+7jjvW?= =?us-ascii?Q?kEmQKl4k7HHSDMOMHCOPICJzLmtH3nKoUBRC5Xb+Q63bmke+9WTZll9nNOdC?= =?us-ascii?Q?28WieDt2WAkWDjOFaDhYpRyQq0szcIvB2KbxNcN3uBVtgKx+hyDjV9mKBPNx?= =?us-ascii?Q?9ukDcQBRLTSYrUG9nWc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4ea2023-bd85-4b1b-f462-08daa150d583 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 12:56:17.7840 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bXnR+A0DZMIt7QE2ZtrAN1rzojr8XubHNgBb3VlQoZaUtHBb6ENc8yMlKX/cy1wyxQTcc0RDOTf0sgW2B4g9xA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4516 X-Proofpoint-GUID: -i3f3UuIPrDIFZzqLzGB07I4L8EAF9RB X-Proofpoint-ORIG-GUID: -i3f3UuIPrDIFZzqLzGB07I4L8EAF9RB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-28_06,2022-09-28_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: RE: [PATCH v4 2/6] crypto/scheduler: use unified session >=20 > > Have the sym sessions changes been tested with the dpdk-test-crypto-per= f > tool ? >=20 > I have not tested for scheduler pmd. Can you root cause the issue and sen= d a > fix? > Fan may have tested it. Can this fix be taken up as a follow up patch (if not ready) and we merge t= his series in RC1, As it is a big change and we cannot delay it beyond RC1. >=20 > > > > root@silpixa00401033:build# ./app/dpdk-test-crypto-perf -l 3,4 --socket= -mem > > 4096,0 -a 0000:33:01.0,qat_sym_cipher_crc_enable=3D1 --vdev > crypto_aesni_mb1 > > --vdev > > > "crypto_scheduler,worker=3Dcrypto_aesni_mb1,worker=3D0000:33:01.0_qat_sym= ,m > > ode=3Dpacket-size-distr,ordering=3Ddisable,mode_param=3Dthreshold:64" -= n 6 -- > force- > > max-simd-bitwidth=3D512 -- --ptest throughput --silent --total-ops 3000= 000 -- > > burst-sz 32 --buffer-sz 105,277,1301 --imix 15,10,75 --devtype > crypto_scheduler > > --optype cipher-only --cipher-algo aes-docsisbpi --cipher-iv-sz 16 --ci= pher-op > > encrypt --cipher-key-sz 16 --docsis-hdr-sz 17 > > EAL: Detected CPU lcores: 128 > > EAL: Detected NUMA nodes: 2 > > EAL: Detected static linkage of DPDK > > EAL: Multi-process socket /var/run/dpdk/rte/mp_socket > > EAL: Selected IOVA mode 'PA' > > EAL: VFIO support initialized > > EAL: Using IOMMU type 1 (Type 1) > > EAL: Probe PCI driver: qat (8086:37c9) device: 0000:33:01.0 (socket 0) > > CRYPTODEV: Creating cryptodev 0000:33:01.0_qat_sym > > > > CRYPTODEV: Initialisation parameters - name: 0000:33:01.0_qat_sym,socke= t > id: > > 0, max queue pairs: 0 > > CRYPTODEV: Creating cryptodev 0000:33:01.0_qat_asym > > > > CRYPTODEV: Initialisation parameters - name: 0000:33:01.0_qat_asym,sock= et > > id: 0, max queue pairs: 0 > > CRYPTODEV: Creating cryptodev crypto_aesni_mb1 > > > > CRYPTODEV: Initialisation parameters - name: crypto_aesni_mb1,socket id= : 0, > > max queue pairs: 8 > > ipsec_mb_create() line 152: IPSec Multi-buffer library version used: 1.= 2.0 > > > > CRYPTODEV: Creating cryptodev crypto_scheduler > > > > CRYPTODEV: Initialisation parameters - name: crypto_scheduler,socket id= : 0, > > max queue pairs: 8 > > cryptodev_scheduler_create() line 138: Scheduling mode =3D packet-siz= e-distr > > PMD: Sched mode param (threshold =3D 64) > > cryptodev_scheduler_create() line 193: Packet ordering =3D disable > > scheduler_attach_init_worker() line 45: Scheduler crypto_scheduler atta= ched > > worker 0000:33:01.0_qat_sym > > scheduler_attach_init_worker() line 45: Scheduler crypto_scheduler atta= ched > > worker crypto_aesni_mb1 > > Allocated pool "sess_mp_0" on socket 0 > > USER1: Test run constructor failed > > > > > -----Original Message----- > > > From: Akhil Goyal > > > Sent: Monday, September 26, 2022 8:14 PM > > > To: dev@dpdk.org > > > Cc: thomas@monjalon.net; david.marchand@redhat.com; > > > hemant.agrawal@nxp.com; vattunuru@marvell.com; > > > ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru; > > > konstantin.v.ananyev@yandex.ru; jiawenwu@trustnetic.com; > > > yisen.zhuang@huawei.com; irusskikh@marvell.com; jerinj@marvell.com; > > > adwivedi@marvell.com; maxime.coquelin@redhat.com; chandu@amd.com; > > > ruifeng.wang@arm.com; ajit.khaparde@broadcom.com; > > > anoobj@marvell.com; De Lara Guarch, Pablo > > > ; matan@nvidia.com; g.singh@nxp.com; > > > Yang, Qiming ; Wu, Wenjun1 > > > ; jianwang@trustnetic.com; Wu, Jingjing > > > ; Xing, Beilei ; > > > ndabilpuram@marvell.com; Zhang, Roy Fan ; > > > Akhil Goyal ; Ji, Kai ; Coyle, = David > > > ; O'Sullivan, Kevin > > > Subject: [PATCH v4 2/6] crypto/scheduler: use unified session > > > > > > From: Fan Zhang > > > > > > This patch updates the scheduler PMD to use unified session data stru= cture. > > > Previously thanks to the private session array in cryptodev sym sessi= on there > > > are no necessary change needed for scheduler PMD other than the way o= ps > > > are enqueued/dequeued. The patch inherits the same design in the orig= inal > > > session data structure to the scheduler PMD so the cryptodev sym sess= ion > > > can be as a linear buffer for both session header and driver private = data. > > > > > > With the change there are inevitable extra cost on both memory > > > (64 bytes per session per driver type) and cycle count (set the corre= ct session > > > for each cop based on the worker before enqueue, and retrieve the ori= ginal > > > session after dequeue). > > > > > > Signed-off-by: Fan Zhang > > > Signed-off-by: Akhil Goyal > > > Acked-by: Kai Ji > > > Tested-by: Gagandeep Singh > > > Tested-by: David Coyle > > > Tested-by: Kevin O'Sullivan > > > ---