From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B9935A0C54;
Sun, 5 Sep 2021 16:19:33 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 37FD340042;
Sun, 5 Sep 2021 16:19:33 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173])
by mails.dpdk.org (Postfix) with ESMTP id 1BD214003D
for <dev@dpdk.org>; Sun, 5 Sep 2021 16:19:30 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 185CPPYc000844;
Sun, 5 Sep 2021 07:19:28 -0700
Received: from nam10-bn7-obe.outbound.protection.outlook.com
(mail-bn7nam10lp2108.outbound.protection.outlook.com [104.47.70.108])
by mx0b-0016f401.pphosted.com with ESMTP id 3av8amu73g-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Sun, 05 Sep 2021 07:19:28 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=hFJfEFFRGUjB4DcjZ5XpmLlOqfSxAWPkj/oLKwZbJ4R6euDBCSrdGIi++cp+4mkq03GpVJuKlm7bJgVrWBmbwmIyna5DgY8ZkpMOK3WPYyb0ZILds3MlpCG2UNPzV3RduHo9dF3E36k2cYisaKfuT2mnmqerxQywG6UI+MvlMl3O0wHxovTWEOLeRGYNc+Cyr+N2QKOflIqX1+Jnh1hYc7RvROy27DrHNDNf1njULWJyFbw+jMa5J9fUi1V2E/70GHH+dlHyWarnv2mbixJ4q/g/kTUqMSrw0pia3784nF3/p9xNBrQHb5XL/yqwT3jaHaxC2mWaXa59d4+h2b+Lgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=FMiHSzGN4vSBc8dCPC1y+LpNWPvA3tOGa3xBh6XCF5Y=;
b=C2Y/rSU2WGOp4axruMrfCdQAlfQxq2WFsn73BgKGhWOGgUdIfTCe3i1lcxJmxL+QhQjvVU/f0GcMkSXZMNshuo2moUU4BfbbHVmnUeqeR/P09DAkmPn+qhMIE3MjSfB4UI6JwS6QmwryOqcahtbgH85usTIotBt2Bt4YJ9dnXPIgNegvyymEMaQJeJRRpkKRv0pqm2D/zMZo7AyzDKHMvL6CShleP5okoA5XSMEyGkL4iRLsR3k14K7x8+B9IgpwrcBjwLXOVYePEsdbZpITNexWGRTq0cKpyKrFLigP1RfZPnKyPytd5VQfa+NfItmP1+pexwYuQM52BXd92LgH5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=FMiHSzGN4vSBc8dCPC1y+LpNWPvA3tOGa3xBh6XCF5Y=;
b=uVT5gxMmNzFujeftZhTeJf1Tk9E8jAYvbuiV/kJ7bp1zss/2tw2PcrOCTpYsc3/BFnej4Y1YGs4ZoI93Dz021pDSn+9F+dsbc0MEKnCMT+FUs65y9oPpcxohOUodLyLOTIVzNXP1CbTvveDcfrlVoxx3dBzQ3YagoM57ATldTXI=
Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by
CO1PR18MB4602.namprd18.prod.outlook.com (2603:10b6:303:e1::22) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4478.20; Sun, 5 Sep 2021 14:19:24 +0000
Received: from CO6PR18MB4484.namprd18.prod.outlook.com
([fe80::411f:5b87:321e:de29]) by CO6PR18MB4484.namprd18.prod.outlook.com
([fe80::411f:5b87:321e:de29%3]) with mapi id 15.20.4478.025; Sun, 5 Sep 2021
14:19:23 +0000
From: Akhil Goyal <gakhil@marvell.com>
To: Radu Nicolau <radu.nicolau@intel.com>, Declan Doherty
<declan.doherty@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "mdr@ashroe.eu" <mdr@ashroe.eu>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"vladimir.medvedkin@intel.com" <vladimir.medvedkin@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Anoob Joseph <anoobj@marvell.com>,
"abhijit.sinha@intel.com" <abhijit.sinha@intel.com>,
"daniel.m.buckley@intel.com" <daniel.m.buckley@intel.com>,
Archana Muniganti <marchana@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
"matan@nvidia.com" <matan@nvidia.com>
Thread-Topic: [EXT] [PATCH v4 02/10] security: add UDP params for IPsec NAT-T
Thread-Index: AQHXoLdmjSCkhnPH5Eem3chlJjwnzquVftng
Date: Sun, 5 Sep 2021 14:19:23 +0000
Message-ID: <CO6PR18MB448480A373ECBBD1EF20E8E9D8D19@CO6PR18MB4484.namprd18.prod.outlook.com>
References: <20210713133542.3550525-1-radu.nicolau@intel.com>
<20210903112626.304692-1-radu.nicolau@intel.com>
<20210903112626.304692-3-radu.nicolau@intel.com>
In-Reply-To: <20210903112626.304692-3-radu.nicolau@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=marvell.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f84ac564-960b-42d5-1194-08d97078292e
x-ms-traffictypediagnostic: CO1PR18MB4602:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <CO1PR18MB4602A648E71E62D1A95F2596D8D19@CO1PR18MB4602.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: h+aCYmhj39kBRJLhqYSGSiQrHb6vElkQpW9BFUGR0MluN9kplu+PIjb6/klM28ICnnN0wLLoDHIUHp8zXKceLFxOY0itRL7UGvNM9NiSyQsW+NpnQEIzp9EKGvKQ9rLYLjWQXtWAGVPRMNkCpK5YRGP8HPrdrEku5u9uiJXzy/MhTmd8cmF37pMiE2a96R5ODzD8tigZYLA6CUl1aRl9vX588Z1ASSMLLsEBU7CmoRfkms+FMUHZwsWhYxsYC+vVx4e1pHixLNv/fAo13SijSPMvJ2TkTPNKIhl9w6lrJjUW1vBnYqdxOA8aVLZiW79wvwGsQ8Zmb2r5FoaV8oFqwH07hP3/5k5qbCVtfSK5bdG3o/uMjybXdRTjXdyIGunZzu6IP2KsYPSiLgDNyiTbpTXNfyofTf+UkPjPiFyEgF9ck77WS8vCQBSNMKNMM1kgF19Cuhj41HtOc0rKnI44m/1/xu1TNq5mNIr4vHJz0gBwYKGXVIm5ceaQhWmyEZPzlYld+wyTBvVxPRJGEXPBcqPqrqtGtlGwUsSDdPZGQbMEnr3kCQz4wRDxgjSH2To8iTWwDMRB/6lhzQddvUIM/Z8l81h0k9WvhzR76f7hHz9hdG3+EW2QbmjB9faob6f+L0CCcFtTfD3NKSp84cjBEo3jPcK8xiwRnIX4SAx1SfKHuTwfy+j9wF5lITKsF0ZsW+bsi87pJZUJGMaEhV3mrQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(346002)(376002)(396003)(366004)(39850400004)(136003)(15650500001)(8676002)(2906002)(83380400001)(66556008)(122000001)(64756008)(8936002)(5660300002)(71200400001)(316002)(55016002)(52536014)(54906003)(7696005)(110136005)(66476007)(66946007)(4326008)(478600001)(6506007)(26005)(38070700005)(76116006)(186003)(86362001)(55236004)(7416002)(9686003)(38100700002)(66446008)(33656002);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LOWokbr/jxfRkHYX9m3FNQRM0ju+82E844o2WMfjxIy9uES6Is5HwnU2B4bP?=
=?us-ascii?Q?niwQgD/lBFEYjhVXbERKcf805fjxfIxiEp6y3pw/y9sYF5mz7vKYsBc+kCve?=
=?us-ascii?Q?tNQMdZc/+z0tS7MIb5pcSz6XfEf3oGF3+Q4QVSStDkTMob0Rtge+iWy8MIEp?=
=?us-ascii?Q?HRziPKl7MGdWEVHWeh0yVzIihG+c3ETMUearx5rubBv5s30fEhmidI3Hbk+J?=
=?us-ascii?Q?lUHlbNb9iPj7h/s2IBb0koXiquZ6ch3KC7j0Def1Ffd2OdE8MqFdTPa0O7FT?=
=?us-ascii?Q?0CnVE+dg1FCEH91rlYZ/LtiDx+TkrYtO2VEi67hd0H8X4GXPfmOPdrBKTWru?=
=?us-ascii?Q?yeP/ESXGV3CENjsNCui4MBmODWALY1WRuQOwXsE4u1KI3RwarcQWfxlvlpU+?=
=?us-ascii?Q?Y5jUdRTH3BWSDrVKb5+ZJDwgncuPffxeOTGC5J4UCSTSz3LwxJ/x4noGTjlC?=
=?us-ascii?Q?XY1hYA6WpyPsww5hK6FrFFfvqnfyC0E69YhN47GTnQTw0wAG3kB1/lC3Q+7B?=
=?us-ascii?Q?hVPIh4DuCnRKEQm+jszuIFLQsHr/FQGKVUwqiOuhRaAAHMjsDc6H2tXwR0Hh?=
=?us-ascii?Q?nuxSio5dkhWbq187ZdwuZnU8j1q9TqTlOYfE/mscQb8eu3hiLry6IH2wmmSs?=
=?us-ascii?Q?wto23HkUXltJcu0c9XirevP5G4nw+LlHpf8y7XvQClHfbO2+AV7ymxlhOCtN?=
=?us-ascii?Q?Gq5jAUsBNLw92rwnx+tXdlcOhyb7cL7I4ZYI3KpuHfewF8CItoTb+V58Zq89?=
=?us-ascii?Q?0CQssGtHN7Pxsc/o8H0tuixMe/V5XlZGklVeA5ckV2EHDWm2kLRP8VN/hzAB?=
=?us-ascii?Q?RfnZEr2FYtJnLo6SUd3uS0AP3AdVTEjQ6ty5DRnMmSsDrfPjfTjZosZY0y9c?=
=?us-ascii?Q?sd2128uYnw2xILDAG1KTXpG8BrzBqDlJT8cCPwoHhqqszO1nfR/6XOanot95?=
=?us-ascii?Q?4fQnYZcTMK+3EGvaZnYNCUKV5A7CaE66c5BOpcjNCJbjEV7J6x1wucCgYUaO?=
=?us-ascii?Q?t7vHO6Fel7euiYSjahmTx4v+uk6KLGmzclf6bXkj3UsuDvxb7AiYcqyNPjWd?=
=?us-ascii?Q?sn2PA9pdLSpXvKiZqYDK7976byhb5KFpZMxKl29kmvClM/Fg01Dq+OXhPu8J?=
=?us-ascii?Q?KcUB++/3JXjBxlUe1aorZFxOjyUkZGu/sGdIVdQPEhUWZi1Zh8PZD6cJVTKS?=
=?us-ascii?Q?NzdQSlq8khiciy48V0Rk2VYya4oGQeb403AC++GmkC+qFBFmbEvrJ4pbPubm?=
=?us-ascii?Q?NXwLpIdhHdLcKS1tZWI8+HstFQd2mTcbC6M5oac+ypfcIHCR6j7Z+Ljzax6T?=
=?us-ascii?Q?X9lTNEVb92a/t/TfBYOAZ4oh?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f84ac564-960b-42d5-1194-08d97078292e
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2021 14:19:23.7015 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PGDLr4pxx2D0wmnsFFBz8F1StKghuVxNUPp4Di/EcwRmzHwW4ogZtbZLj/dp+N52KZqeIfnrxkteEfDSxwwuaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4602
X-Proofpoint-GUID: I7kUD6i_FU03gBDikp2TmpTx_91QVWWh
X-Proofpoint-ORIG-GUID: I7kUD6i_FU03gBDikp2TmpTx_91QVWWh
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
definitions=2021-09-04_09,2021-09-03_01,2020-04-07_01
Subject: Re: [dpdk-dev] [EXT] [PATCH v4 02/10] security: add UDP params for
IPsec NAT-T
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi Radu,
> Add support for specifying UDP port params for UDP encapsulation option.
>=20
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> Signed-off-by: Abhijit Sinha <abhijit.sinha@intel.com>
> Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
Do we really need to specify the port numbers for NAT-T?
I suppose they are fixed as 4500.
Could you please specify what the user need to set here for session
creation?
> ---
> lib/security/rte_security.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>=20
> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h
> index 45896a77d0..03572b10ab 100644
> --- a/lib/security/rte_security.h
> +++ b/lib/security/rte_security.h
> @@ -112,6 +112,12 @@ struct rte_security_ipsec_tunnel_param {
> };
> };
>=20
> +struct rte_security_ipsec_udp_param {
> +
> + uint16_t sport;
> + uint16_t dport;
> +};
> +
> /**
> * IPsec Security Association option flags
> */
> @@ -224,6 +230,8 @@ struct rte_security_ipsec_xform {
> /**< IPsec SA Mode - transport/tunnel */
> struct rte_security_ipsec_tunnel_param tunnel;
> /**< Tunnel parameters, NULL for transport mode */
> + struct rte_security_ipsec_udp_param udp;
> + /**< UDP parameters, ignored when udp_encap option not specified
> */
> uint64_t esn_soft_limit;
> /**< ESN for which the overflow event need to be raised */
> uint32_t replay_win_sz;
> --
> 2.25.1