Re: [dpdk-dev] [EXT] [PATCH v6 1/7] examples/ipsec-secgw: add stats interval argument

[Akhil Goyal <gakhil@marvell.com>]

> On 11/3/2021 9:23 AM, Akhil Goyal wrote:
> >> -#if (STATS_INTERVAL > 0)
> >>   struct ipsec_core_statistics {
> >>   	uint64_t tx;
> >>   	uint64_t rx;
> >> @@ -94,7 +90,6 @@ struct ipsec_core_statistics {
> >>   } __rte_cache_aligned;
> >>
> >>   struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE];
> >> -#endif /* STATS_INTERVAL */
> > Did you check compilation with this patchset? Even CI is reporting
> compilation issues.
> > core_statistics need to be declared in .c file.
> 
> Hi Akhil, I did check on my local dev system and it passed, but I can
> see the problem.
> 
> But the issue was not introduced by this patchset, it was only made
> apparent by removing the #ifdef. It was introduced by this patch:
> 
Yes the issue was not visible as it was compiled off, but since your patch
Removed ifdefs, the compilation will be broken. Not sure how it passed your
Dev environment.


> commit 1329602b6c8f20949ebaefb7aa55f7dca6d1b4f4
> Author: Anoob Joseph <anoobj@marvell.com>
> Date:   Wed May 13 23:15:19 2020 +0530
> 
>      examples/ipsec-secgw: add per-core packet statistics
> 
> I will send a fix shortly.