From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 662CD4410E; Thu, 30 May 2024 13:01:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDE8140685; Thu, 30 May 2024 13:01:52 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 2D3C040608 for ; Thu, 30 May 2024 13:01:51 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44UAQ4xk022230; Thu, 30 May 2024 04:01:49 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3yeqpx04gp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 May 2024 04:01:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PoDp8qH7vt/YNya69amcLVA/SVfKKj/eFHG4bF8p5yqkLWaaXStLqBWhyw8Ci5PHfEL/zX1bfr6eVtGcIkBhTL2a6/eh+sFfJumjUJdzuTkA0FRAVxG9EjLmSzxTuJAuyIj+rNXOTyyM47q50NYVVE35hXtR4F9wx602qnYAjXjtAlS0TdigHdMClkeBWHE48CfLLY5bcmiZNUQBaP8jL68L8u1PJD9MrELZZdHV9nOqhSD+KCcBOsjAGU1onGObgaymXDIsLryRUE6CNacwf09AgZwbp5JzRyjBkWOq/sa31mkbuHyQlO9OplNVnbKFnGK2DP2EkZg8qIqeUYPHPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TeS1miiF0s8jFgqpS5B9BaWJLU0hi2VLXUg9H7X48ck=; b=WEldvaIn8oPptFQSfMfHluQ6Fhf5QzE5si69t4ar8qiAp3BG8KRa9qnlTn3srya+MAPF0C+zKgfKsifUS7ZVbXEAhNxCSQuOVkHUzDZu3hIBkrM7r1tqOVq2MloT+W8CL64bBS50HZjok1SAG20iEZNXANFDvfQS8RmA8D8+8J8AJK+k7qiD1qAzlF+xSHH/+hjkWWh9XuUFbvN+R+BjJRRljaK1nZgB4nsjscVq9jgBG6shD3Oc0VhmqptD7Pyh5DMw92zQTmlbq65DtMyunH3CSR8h3kAlzpf8DeKoabA0DbFbNWHRQ81sK39MhHK4L5TjiVTmpF93gycQ2POotg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TeS1miiF0s8jFgqpS5B9BaWJLU0hi2VLXUg9H7X48ck=; b=MmHMPy/6NX2mRbB5PtIaYOSD88tRNkcomJ6LW6n7C0GeNmTx+wInDZsaK5ZknPd+H6tzVcJcLz6ZItDXTAV729eTU3AoKcfKZA4yjpmqQlU04IVRyJUDgUAYL8r80qMyHtUEK/qRMSeQawZHl6dUEjdHDhE/TD6xYr1zx4938wI= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by MW4PR18MB5061.namprd18.prod.outlook.com (2603:10b6:303:1bd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.30; Thu, 30 May 2024 11:01:45 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d%4]) with mapi id 15.20.7633.018; Thu, 30 May 2024 11:01:45 +0000 From: Akhil Goyal To: Ganapati Kundapura , "dev@dpdk.org" , "abhinandan.gujjar@intel.com" , "ferruh.yigit@amd.com" , "thomas@monjalon.net" , "bruce.richardson@intel.com" , "fanzhang.oss@gmail.com" , "ciara.power@intel.com" , =?iso-8859-1?Q?Morten_Br=F8rup?= Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Topic: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro Thread-Index: AQHasdYqBA7BiFARTUmhLk6iVntHPbGvZbfQgAA31SA= Date: Thu, 30 May 2024 11:01:45 +0000 Message-ID: References: <20240416081222.3002268-1-ganapati.kundapura@intel.com> <20240529144025.4089318-1-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|MW4PR18MB5061:EE_ x-ms-office365-filtering-correlation-id: 43172d40-fd67-4073-0516-08dc8097e50c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?iso-8859-1?Q?T9TxpDpZRDMRn44RjDiqzwXmKgnXH5NMTbso+Gz8t76xgUgcYqd2BKTvTh?= =?iso-8859-1?Q?lw1bGSZR4gbAYEOcAfGTZ84p2Tl2aytUDmNCG90LDPaY55iZ2Gy6AK+msO?= =?iso-8859-1?Q?0i5yHGiqodKlqGjzw+SF9Ynz85wLVkD16pqiopkSNjv1waU2pZI5uTcKCs?= =?iso-8859-1?Q?MFgAC7GByzKAMetfGlOvm3aTDguEYbWAhHjk7w4NV+NKvh3bC8B0DHJ3Hg?= =?iso-8859-1?Q?NB7iLi9A8MDmVnMCrHVJ08WUk8xVnT0X/3fdpn7Az0PpXMZ6HWLmp+Qdxv?= =?iso-8859-1?Q?nL9Y5FeGDFPtr7TrKzNlc6S3I6mZ8gVPGFODwDxsiFQLIQPl6wzVp+x31y?= =?iso-8859-1?Q?olaEXIcuR8VWhcsugqMp+lwXUPnuziLUSvoo6A2mwOc91XG+cIJiPwNUuH?= =?iso-8859-1?Q?CQ9OUWsx6+O/d/nTWUQopjolr5WH+4asQrlV797N8M0nLk2MzeqzmmsVbU?= =?iso-8859-1?Q?zS4NK6CaZkgz859uTjlKedsvrm2hos59klH6NBe3vk17gmfMnPFO7yaqTY?= =?iso-8859-1?Q?08+DXofX8WM7oHjoRgSRq4XflNNx10j9+e0lgCrmTVmKla7XVsO53bPEEI?= =?iso-8859-1?Q?g5REgsH3sE8UrkgcG++KxBaofHX56KbwGX6g1/HxZqUi9kYknxCeX5+oqx?= =?iso-8859-1?Q?EJax4qxGIYIXK0jSYnjKxG5tS+6fv3ILHMaQSQ3ZSqJgr9ORZfBRFoyJ2P?= =?iso-8859-1?Q?5pEyQ4+pkWRuqxjySfIJ08urF/KnWYFV28lj6v+Uim1ylxOmCciFhuvcF+?= =?iso-8859-1?Q?01Y7GVKNjayTLW+pLbM5uv3Xgjoq4KRV3MwSgq1em+xQheTTzDcTmaRWDG?= =?iso-8859-1?Q?baLQaoKF7H/ca93jwI3J/eE3SCAtmwdZOhFxFmLelStu/1YVUcLLHbzIaz?= =?iso-8859-1?Q?FuXcUim2+yrDSYvWj6kYr9iZHlG1SDpdaVWuGSWkrcOb9/fmqYjgKmclll?= =?iso-8859-1?Q?/PbqybV8Jb7A3qgSH9cJPXIY2yypsNngVadGKX6AHQWh2vS1h2aXwM0by3?= =?iso-8859-1?Q?in/AhGOX5j9e4KZCjHN84hgXLwlvpq+oo2Wj+d5J1M3OZpjYKLJ7XunRJj?= =?iso-8859-1?Q?yKYe8IEthNR30o7WvvLpW/3xAGHb8poIAgyJUYzFd2J0UY7cOJ6CDaj79T?= =?iso-8859-1?Q?Vog22fWsGOoA8s0oIgxkDmAEuSdr+Uuur7jO++90mlNdKMHQ7KQmgxOPDF?= =?iso-8859-1?Q?zIPTnWdTK1HNCEMwon1N/71GDiH4+4oAg99FG3s0MYAl7VthmCO+T62syQ?= =?iso-8859-1?Q?UkG/A62IM0nkBQMnReVyUI6ZFetN7Oum9+fT0xNi90bCWjOvNNBLKm9uye?= =?iso-8859-1?Q?shOydqunDVyAzXVvP6ornId1pNzHb9a5eVsUqTzbFxYeVhXXk6IldACfP4?= =?iso-8859-1?Q?1ZimXJPeznxjBJQlu4XeiUCEW+A6B9cQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?b1E8Gk8bW03MN0DjRistHoRp6g/rIW8E1pMAjjTr3n5vPun4dThqybCklL?= =?iso-8859-1?Q?n3A/5dV0fcPWVXjPbDR0N5Cmaod+kAIwAwnU8fjZOk2Mb42NtB1Q5iNd49?= =?iso-8859-1?Q?SilUrPFn3dYTEn7OSh0AUxi+bSxFiqAzB5/H6FpbGTKedgiiHeJx5w8N09?= =?iso-8859-1?Q?dYVc4aGS9uHAzElGLBwKy/9GjhRAjYCAMHeu0FLL/WHkmqsdUynAtin9D4?= =?iso-8859-1?Q?gCh4cNnrhe8wyDK80efY4BDB4vTJEGu1kbooFuhal0WYJScAUPYjOtok71?= =?iso-8859-1?Q?EJWOOoomZOSHwwyMULl9KVVL4aiC0QG2Ax2JNZ6okF0/1G6N+FVPQryMHZ?= =?iso-8859-1?Q?MpI9sMzQpyViYFtTwH5Obhbdz2ASoOf4KX6aTimzBsIMbVjF1LxhNZWJOT?= =?iso-8859-1?Q?bghnVF5iBN12wPo1oyDr7hUltTV+XTEg9+afaf5O5moBpyhYTRhBniA5CK?= =?iso-8859-1?Q?UcwDCOt9sc/Z9zd6zpBHK6IgQK2jbvFvrgrA0Mj48echLnPNuNQFUa9JZD?= =?iso-8859-1?Q?RiSCxQxguFeVOfRZn7xoZt4MuZ+xwsX4tWhDQzRmVzPrlADXGIxZ1VoEuT?= =?iso-8859-1?Q?3Wc5RL6p7JpzftoKqCZhUqq86oT/Yei44U4d7zdRT5pALiBK+PcwKFp+OQ?= =?iso-8859-1?Q?vc/4zcTEaFtpKcIahZpvTd6QSE8QVceH2EUi/TsEa/z6DuPTEOXcboXE5i?= =?iso-8859-1?Q?7URKZKMkrIgpCjEFPAIkHBkT7mPjAjSZRNkrzSIPd3EMzJBZYTt2GqNYvk?= =?iso-8859-1?Q?D8k1XhWiVbKP4yw5r9qaLr4ygR9UwQe4s3+a2t4005QrJce3sksHy1AP87?= =?iso-8859-1?Q?ExBGibfJvQbsyDZUgTKY8WEaz45EqIkqkRUgZTJiEpU7VEKklNOdAzLC8O?= =?iso-8859-1?Q?PDMw6vO9Be4/+rb8X83Gz4xox0S4ictKNsWkuA1OVAEQKjG2BDNfW9Y1yF?= =?iso-8859-1?Q?AW5znqRS2QTm0J0Q1Mm2QQTZKie/LN2xLyhy8kLtHvtetCUlJQBEGKfr7z?= =?iso-8859-1?Q?f+izAaRopkuuYNIvzuk7qAgH9SyH0Pr0tp5Mbi9dJWs//SErYWLEET9Tgc?= =?iso-8859-1?Q?I+vflpNuXaza/4Obpc65WiB2RkdJoHuQdcOaQO3SHKzU3ba6KYHwTcoqKl?= =?iso-8859-1?Q?sz20GcJaIr+DFCAeDoI6HYzVi5yxJmqNUtCY3kM7HPuAWVw2oaVmfEl4Jx?= =?iso-8859-1?Q?LfnD5kGN/SOB81+C/whI02vv6097DsLHRIu2Pr2+Zzzbfijkcq/8ZgFpey?= =?iso-8859-1?Q?rZuHiGsvPqI6ZZpIgvauQBNJzvyDgn/zgMwwaZC3a4cmXN1dUSbPkLfv8e?= =?iso-8859-1?Q?D11Fc/SkLFBj5GqrN3JuXQpXz8zcRTDZGiM0CzAoPanm8IHpz9sHmr0nT2?= =?iso-8859-1?Q?pKHvqUQ9fSq683y9Uej9FV0EXZ4XQcWz6eb9Ql8FYNfCk0g+bykd04mib4?= =?iso-8859-1?Q?YUc6/KaKDJBz7dd+0Z2uMBINWCAG9e6nBSyhjMLrF+GUyGRtoIqDctof8A?= =?iso-8859-1?Q?PPrlHLZC4N9NFeZEtLgEBIU7RY+7YD2AmlSOGwPq78Hgk1pCdd3YDVOO96?= =?iso-8859-1?Q?BkAfBRSPNm35vK/vCPjH8L01Mlflechu3sGR8YtZObTuf6M4mcxCIunhv+?= =?iso-8859-1?Q?aXJM08O6uw8+FpdqG9DoRs6LEr1ls/gfhJ?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43172d40-fd67-4073-0516-08dc8097e50c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 11:01:45.0362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dfOSoKU8esrwtd0Mh60a6yYjPyQgFnZ2N0EWRz4Yk0D2S7yraXaGu64xCUNjZLEEKB4gpLXxTsgqocccgb9Inw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR18MB5061 X-Proofpoint-GUID: X4Btr0EKZqUtWl0QoxAlpDXiIEMBlXrf X-Proofpoint-ORIG-GUID: X4Btr0EKZqUtWl0QoxAlpDXiIEMBlXrf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-30_07,2024-05-28_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ++ Morten for comment on #if vs #ifdef > > Subject: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsettin= g crypto > > callbacks macro > > > > Crypto callbacks macro is defined with value 1 and being used with ifde= f, > > on config value is changed to 0 to disable, crypto callback changes > > still being compiled. > > > > Used #if instead of #ifdef and also wrapped crypto callback changes > > under RTE_CRYPTO_CALLBACKS macro to fix build issues when macro is > > unset. > > > > Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks") > > Fixes: 5523a75af539 ("test/crypto: add case for enqueue/dequeue callbac= ks") > > > > Signed-off-by: Ganapati Kundapura > > --- > > v2: > > * Used #if instead of #ifdef and restored macro definition in config > > * Split callback registration check in a seperate patch > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index 1703ebc..72cf77f 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -14547,6 +14547,7 @@ test_null_burst_operation(void) > > return TEST_SUCCESS; > > } > > > > +#if RTE_CRYPTO_CALLBACKS > > static uint16_t > > test_enq_callback(uint16_t dev_id, uint16_t qp_id, struct rte_crypto_o= p **ops, > > uint16_t nb_ops, void *user_param) > > @@ -14784,6 +14785,7 @@ test_deq_callback_setup(void) > > > > return TEST_SUCCESS; > > } > > +#endif /* RTE_CRYPTO_CALLBACKS */ > > > > static void > > generate_gmac_large_plaintext(uint8_t *data) > > @@ -18069,8 +18071,10 @@ static struct unit_test_suite > > cryptodev_gen_testsuite =3D { > > TEST_CASE_ST(ut_setup, ut_teardown, > > test_device_configure_invalid_queue_pair_ids), > > TEST_CASE_ST(ut_setup, ut_teardown, test_stats), > > +#if RTE_CRYPTO_CALLBACKS > > TEST_CASE_ST(ut_setup, ut_teardown, > > test_enq_callback_setup), > > TEST_CASE_ST(ut_setup, ut_teardown, > > test_deq_callback_setup), > > +#endif > > TEST_CASES_END() /**< NULL terminate unit test array */ > > } > > }; >=20 > #if may not be needed in application. > Test should be skipped if API is not available/supported. >=20 > > diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptode= v.c > > index 886eb7a..2e0890f 100644 > > --- a/lib/cryptodev/rte_cryptodev.c > > +++ b/lib/cryptodev/rte_cryptodev.c > > @@ -628,6 +628,7 @@ rte_cryptodev_asym_xform_capability_check_hash( > > return ret; > > } > > > > +#if RTE_CRYPTO_CALLBACKS > > /* spinlock for crypto device enq callbacks */ > > static rte_spinlock_t rte_cryptodev_callback_lock =3D > RTE_SPINLOCK_INITIALIZER; > > > > @@ -744,6 +745,7 @@ cryptodev_cb_init(struct rte_cryptodev *dev) > > cryptodev_cb_cleanup(dev); > > return -ENOMEM; > > } > > +#endif /* RTE_CRYPTO_CALLBACKS */ >=20 >=20 > > @@ -1485,6 +1491,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, > > uint16_t queue_pair_id, > > socket_id); > > } > > > > +#if RTE_CRYPTO_CALLBACKS > > struct rte_cryptodev_cb * > > rte_cryptodev_add_enq_callback(uint8_t dev_id, > > uint16_t qp_id, > > @@ -1763,6 +1770,7 @@ rte_cryptodev_remove_deq_callback(uint8_t dev_id, > > rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > return ret; > > } > > +#endif /* RTE_CRYPTO_CALLBACKS */ >=20 > There is an issue here. > The APIs are visible in .h file and are available for application to use. > But the API implementation is compiled out. > Rather, you should add a return ENOTSUP from the beginning of the APIs > if RTE_CRYPTO_CALLBACKS is enabled. > With this approach application will not need to put #if in its code.