RE: [EXTERNAL] [PATCH] app/test: refactor cryptodev test cases

[Akhil Goyal <gakhil@marvell.com>]

> This commit introduces several changes to the cryptodev
> test cases that should make it easier to maintain.
> 
> Changes included in this patch:
> - If not needed by the specific test case, the device should be
> started/stopped in the particular testsuite setup/teardown
> function.
> - Most of the remaining test vectors were moved from test.c file
> to the specific header vector files.
> - Part of GCM redundant functions were replaced by named test cases.
> - Unit tests do not need to check for the symmetric cryptography feature,
> if this feature were not present, the test should not even reach this stage.
> 
> Signed-off-by: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> Please note that this is work in progress, what is left to be done:
> - Rework security test cases, these will fail with current setup.
> - Fix OOP issue. OOP tests do not check for the prepended data in the OOP buffer.
> - Remove remaining test vectors from the .c file.
> - Remove redundant test functions that call common function, replace with
> named test cases.
> - Refactor block cipher functions, there are only three block cipher algorithms in
> the cryptodev.
> 
Nice work.

Please split the patch into smaller compiled patches.
It will be difficult to review such major changes in a single patch.