From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2B9B45A78; Tue, 1 Oct 2024 10:03:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DD554027A; Tue, 1 Oct 2024 10:03:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C616A4026C for ; Tue, 1 Oct 2024 10:03:25 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49108Q4C023408; Tue, 1 Oct 2024 01:03:25 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2048.outbound.protection.outlook.com [104.47.55.48]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 41yt6gcfca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Oct 2024 01:03:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ExHlj98Fks4D02qu0RF+dR47utwqIY0mHi+XEmTzzGxoF9O6aBmVjLd5ODzm0OPEw6wmk1TMWvc8MrMCSZL64I/zoQTlYWeSPioSughiShuSaTVi56H0PdAkaQDU2P5n1MTNtWIAVFxp+YeqHiedMFwz0PlDydRbfut4SspG+HbDRGa2HsLD/FT5JcfltxwLeDl+tU/uhyNPiUrXPdyXxouRkksO0VEIdYNZOqxf4M0PozaqX1HEqjVWH4oeiWn1thFd06DTp8Ucec7yTASueaHmLGOLgH3FZ2qgrgtGGdOfS3IvCVc9AHRvtSBtBsRaUcqGCpytu7+24myG3R/Ctg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/1h6HQnJJIt+VagsGViHDqgGcVrphrhbuZ0M4nwjgfI=; b=eVWX3+0CM+0z3/Tpxjmc4pvsB7LcLdCROSb92HEDTh6xXQbloaBElfaFVWJA8NrD6eYjXAsPL8DhiYGyIoPIv/FRSeFGdSO8ZgmFjSOG+7pLpoM+nbFVE6iMi2H3U1PPEo0iHQ1ZPheDSdl00qbGXeji+qAht2IkFovV3bklJIlRnZqlbHK4g1VvviTAyshptljOSAkdUxc0qyeRU09duVxM9hkWM4QWabfPy8WBi5InMBU1JnL5JIBYKI5zkI2jRhwnlbyEE4DxYIuz909/9PX3iIsvyHd/IMwSzVGgQXvrRAlizQu9l6ZTcH0t01kPQtXqMx4nPz9vQdKU9UfZDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1h6HQnJJIt+VagsGViHDqgGcVrphrhbuZ0M4nwjgfI=; b=A4cryEXyX1ePeI3w4BhcCn13WnjbkIkOBPohbFKbWCfAva4cVD1FfkGG8B9cHo6r1JyuOnbhO82jqwjO6b4PtVR1csKM/m8xzTrj7qGKHh8rolVVjrd7+QaQiAzKAjjvWjwhiqxjwnog1LmQh97t0gNvMiKa4Cw/xoJ2cgRYzYY= Received: from CO6PR18MB4484.namprd18.prod.outlook.com (2603:10b6:5:359::9) by SA3PR18MB5275.namprd18.prod.outlook.com (2603:10b6:806:2fb::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct 2024 08:03:22 +0000 Received: from CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d]) by CO6PR18MB4484.namprd18.prod.outlook.com ([fe80::3c98:dd36:4897:a51d%5]) with mapi id 15.20.8005.026; Tue, 1 Oct 2024 08:03:21 +0000 From: Akhil Goyal To: Arkadiusz Kusztal , "dev@dpdk.org" CC: "brian.dooley@intel.com" Subject: RE: [EXTERNAL] [PATCH] app/test: refactor cryptodev test cases Thread-Topic: [EXTERNAL] [PATCH] app/test: refactor cryptodev test cases Thread-Index: AQHbD4FmeI+7NpxQn0KA1qNe0q7srbJxkVuA Date: Tue, 1 Oct 2024 08:03:21 +0000 Message-ID: References: <20240925181525.66119-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20240925181525.66119-1-arkadiuszx.kusztal@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB4484:EE_|SA3PR18MB5275:EE_ x-ms-office365-filtering-correlation-id: de5efc35-36e7-42bd-98be-08dce1ef8486 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?gJMzc2ol+3vZEpyr7DpApvGmP2G1uwc4C+9HGE7QxVZSFA7PyPxs0imX0MP9?= =?us-ascii?Q?t22nYkgG4evA2yYEUjColig6epsRaGPUXbT+pSnmSpULLgYvlpTAmgt+3VyN?= =?us-ascii?Q?eL/TLJ05z1SumFMCnSekIufn2JJvf+vAQ59C1Lska8QVnzFsCXIePk1OqtSg?= =?us-ascii?Q?X30kAqbZF11iTbgJBZLxZD6YvleOMd5PcgeUxGkWKRrCcVJjZQzoy4EkWz98?= =?us-ascii?Q?txKb5KVPcKwqkzVlZ34yUxe9jYGlVJsyK6YuDbdsTwgf7V784gyFx7i77m/C?= =?us-ascii?Q?YvD8qwh7zXIzALwi0EOfKPgW6t9hXlzPRj6ciYnytQEtecFV29EOfC3Zii7z?= =?us-ascii?Q?InTgcGi6HYO4hWvj/rLSIAQUxKIHPGw1c+emsIbffc3NgiPFTYl+bQXaq5kE?= =?us-ascii?Q?N1NqDEL0HELDU5fY9kOh9mln2eH4yhc3WaSA4Md84t9TKM0bN5wEvnDXayKW?= =?us-ascii?Q?lFa4+9rQlFaXjz09+1+Q0M/ufl5mciMEMdUwwXkcdACOSsTd9H86JsDQJeB2?= =?us-ascii?Q?Y0An1IZc378hjEkEfXCxeUfiNUvAIDxkGczRY8rvhJJlvYrrkx4+eMb0X6vC?= =?us-ascii?Q?bigcGrWqbXKURvqGvC1QGomsy1XNb5xR03yYV9QjnXo6whGRsV25VF9Uk0Dd?= =?us-ascii?Q?ZRAodEG8p8iAcElIo7Bybii9ctPxdrr+NsNsorgQ4za4U2/9r7DkJJFDY8pl?= =?us-ascii?Q?uIdtriVCBDSAW4CiyWw2z7gupfHv9aqkge6XpMl7zVXRg5et0Ci0Xjv8tM1U?= =?us-ascii?Q?/M2E7Z/z0Aa2Do7YTL1uq9FpPXn4Tb5gFyWCG55PjC8n2CzA8KoyZTKM/uti?= =?us-ascii?Q?vWQovmfZjHARCvcaj14rpMkuzoAqKg9GqmDa6KEFIlTTmxCIVX5uiEQEaUPY?= =?us-ascii?Q?mYDumjMrzg47+K74XeoJxPzrVoWEguNIa/UPsKhPyf1wWjAEAHArfp7xPHsh?= =?us-ascii?Q?2L7jbfUcrDEXWWjMm220uByGsLlKEfoyT0YsxFfty84RawbG9oq7jpXJZwPI?= =?us-ascii?Q?c6KsR2C7NLbPQX5ysGH9Fw9O+lFT46DDifTz8ZAuMqoFaBfpXrW/2wGjaYY/?= =?us-ascii?Q?V3Ix3sNRJAV0Zzrh4aFl0VS998lRjU27Z8q2UEaz7nZU+jlfmXHa6DT8c4SM?= =?us-ascii?Q?68tB5GxqNqIQIqVRnyXYJBMCPVF93i0P10F+yYRr0vnv7wNMDmfGQHsPgCs5?= =?us-ascii?Q?WhaG/YK6COZQ8SSR+hFrDuKCx3hVUqeQRp1pdvkJlnkmsDqmAIoJM+wsBedV?= =?us-ascii?Q?aYbU67AgL1iJ+TPqOzP9LbhOhuSNer0JBaE+KfIYgkcNJwJUd2StxdUhE62P?= =?us-ascii?Q?3bUIqqy6mu8cKTwBASMnsnAlx49jJKbjeFmZXmrFQSMLWQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB4484.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2AbkBLIIkBf3OJZNd3EaOlPe8BTpUf/+CBzirMy/kDMAH7zHKKwp4lsgn15b?= =?us-ascii?Q?ZzNUDdbmfpq9etvWNn0Yue5s0k7hZ3raqLGAYiU+sBENXf5bibRlvz7vllU5?= =?us-ascii?Q?IfY0GXXZ8Krf08xS0Q91i4jTC3rm4ZSyoOorJTTuIG0RYr63Bdi3G7cMrQ28?= =?us-ascii?Q?m6t8skwttynX819MVXHf3UExBmAJNJ/1QIRTKSQ+JD6yzKyaX/85vOQEMOpr?= =?us-ascii?Q?GlBHiKoIUtOtpZm69DXUtqczzNx4fDtld/AXxmCzIbQ3Cq4wWOVBYVaZtZQZ?= =?us-ascii?Q?YcAQddaCWUWpGUa1v/cawZnBuDgGrwCyxI8+s9w63UTM4hIT0mvgBNhMkB7n?= =?us-ascii?Q?gtG5qc0Tu3JTKTmpVq6e8azLNHESPWkK4Fmav+yDuJh9M+qtSfIoK9efn7sn?= =?us-ascii?Q?Rt4mh1ioL56lPrOETWJsEM6jl5ngCMGaI0tNx2z/7JuW2RgE4QROhrAtiTdR?= =?us-ascii?Q?c7369Dc60xHqPnhghmLshggdzJQk3U+XtEmfw+zOWKCVVy9gThiiZUxwER9D?= =?us-ascii?Q?2udZrs5i6ZwEM9VSR59LlFjV62MKphvzymmIzxyiEIfJQzROloxQhXSUbR55?= =?us-ascii?Q?0kj/Azx7BDhJkdNNmRMAMvRpGlKPbY7+6Hq00d5huHSPZN9pj8MT1HjqHBWI?= =?us-ascii?Q?w+X9oJoKQAOdkAXjrJ1siCv9J7FrQ06ot847pmuvsddYe+HCqU8EyQ/3ZNWi?= =?us-ascii?Q?YzJHoWm0sQDmOUkheHAAHvvcv0LxxwZGDj6a6xFe9lwQ5YcSnFw9RTtyT65G?= =?us-ascii?Q?rZqjWm/zvCO63KPR5QPOhp22mBL1WrDaSwwN7cJRJYAlo8hC78ViLk2zi3e4?= =?us-ascii?Q?9fRa48+qYQncxhfDnKEXOMbIzhhFo3ZQ6Wcch0mRozPu72WeM6bTsQawJV5Y?= =?us-ascii?Q?xZesB/bD12KNy4FaUl9VhFv6vVkjm/ezZLAHuCnPtIZJkBefTaBtuyhrYpu0?= =?us-ascii?Q?QnEVjlsv4Vnt/+q/4iys5KExB211xXwskNmFrpGkTRp98xO0WGsZOn7Bd/lA?= =?us-ascii?Q?hOCcMaRGVChp9D5Hbxkb3l3ZD7CcocDkCAiBZ+3Wmi45vxB1RCASZ9bAQbI5?= =?us-ascii?Q?LKFqESHSMG7O6RfcoBmON5Gtd8kvHShqB6eI5Dn+quOPIUsg+x6iBfCOxGss?= =?us-ascii?Q?aOoXTCHmGSRvEW5P19F1ECHaAHg11xXI8B7H9e4rTfNga9agE1h/LblwBsns?= =?us-ascii?Q?Iv5L/fO5ZtUO4WPDm0fON01SVZ5/tDJMnNcsp+nvtfIFTnovAumQ6hYLoNFI?= =?us-ascii?Q?31BWXO0sw8nfI4AGeY8XepMEt3g4XArtejRGFCEZcM3JPji14Cm0pWKqXWbs?= =?us-ascii?Q?Rnz1UfNI/wZVAnPfMR+HLb0LlUlqF9SDKnTdfaGd7n5eC+4qqajEYPr+cz8S?= =?us-ascii?Q?42q3ZQD29hWgxGTbiUpM2Y+yMjcXAn8fS9g+Emyo0w23RGDRC6Q3oo+CSfic?= =?us-ascii?Q?GS4S5/WPIyKuNjc5rwaWEoWNro+YWIY99EpFU5wfYUL4WuIP001bwS7nvUVH?= =?us-ascii?Q?5dljHQ48DNKXXDOAltunoMR/rdgMvGeq8di8MEvNVqaqQeIjHMepOSFku0rR?= =?us-ascii?Q?j8XeNJhAPXvI0nZAuE4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4484.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de5efc35-36e7-42bd-98be-08dce1ef8486 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2024 08:03:21.6487 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ys/fh+zsLr6UcwGz4tflYKl0sX1pw6TvUbl+dcxQnFxlshPdqAjzq1bxP9rkjdgBJ3xBRW2e+osGENf1Tn3Spw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR18MB5275 X-Proofpoint-GUID: CneRGfgEei0oibXGsnzC69PA3_VmlnbH X-Proofpoint-ORIG-GUID: CneRGfgEei0oibXGsnzC69PA3_VmlnbH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > This commit introduces several changes to the cryptodev > test cases that should make it easier to maintain. >=20 > Changes included in this patch: > - If not needed by the specific test case, the device should be > started/stopped in the particular testsuite setup/teardown > function. > - Most of the remaining test vectors were moved from test.c file > to the specific header vector files. > - Part of GCM redundant functions were replaced by named test cases. > - Unit tests do not need to check for the symmetric cryptography feature, > if this feature were not present, the test should not even reach this sta= ge. >=20 > Signed-off-by: Arkadiusz Kusztal > --- > Please note that this is work in progress, what is left to be done: > - Rework security test cases, these will fail with current setup. > - Fix OOP issue. OOP tests do not check for the prepended data in the OOP= buffer. > - Remove remaining test vectors from the .c file. > - Remove redundant test functions that call common function, replace with > named test cases. > - Refactor block cipher functions, there are only three block cipher algo= rithms in > the cryptodev. >=20 Nice work. Please split the patch into smaller compiled patches. It will be difficult to review such major changes in a single patch.