From: Akhil Goyal <gakhil@marvell.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Declan Doherty <declan.doherty@intel.com>,
Fan Zhang <royzhang1980@gmail.com>,
Ashish Gupta <ashishg@marvell.com>, Ray Kinsella <mdr@ashroe.eu>,
"dev@dpdk.org" <dev@dpdk.org>,
"acc@openeuler.org" <acc@openeuler.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: RE: [EXT] [PATCH v4 0/6] crypto/uadk: introduce uadk crypto driver
Date: Thu, 20 Oct 2022 17:09:58 +0000 [thread overview]
Message-ID: <CO6PR18MB44849371A1F3EFB213425D4BD82A9@CO6PR18MB4484.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CABQgh9Foi3jgQjsriOca26fV4edP-7yExfgZ1VWC0iwAhqSbjA@mail.gmail.com>
> On Thu, 20 Oct 2022 at 22:46, Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > > Introduce a new crypto PMD for hardware accelerators based on UADK [1].
> > >
> > > UADK is a framework for user applications to access hardware accelerators.
> > > UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share
> > > the same page table between IOMMU and MMU.
> > > Thereby user application can directly use virtual address for device dma,
> > > which enhances the performance as well as easy usability.
> > >
> > > [1] https://urldefense.proofpoint.com/v2/url?u=https-
> > >
> 3A__github.com_Linaro_uadk&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=Dn
> > > L7Si2wl_PRwpZ9TWey3eu68gBzn7DkPwuqhd6WNyo&m=AkCizMeraG64B9u-
> > > h4gp5S2CYP3SiD5dpvFqvj2WHC4Cfuw6TbzZSeCk1Ryz-qLo&s=Tm7UGDJ-
> > > 3QUjCzOkIRUG_tjJA3ckOdK6kSOxuk7V5PQ&e=
> > >
> > > Test:
> > > sudo dpdk-test --vdev=crypto_uadk (--log-level=6)
> > > RTE>>cryptodev_uadk_autotest
> > > RTE>>quit
> > >
> > > Update in v4:
> > > Akril suggest dpdk use pkg-config, So
> > > Enable uadk support x86 local build, and support pkg-config.
> > > Use pkg-config feature for the uadk crypto pmd.
> > > Add build uadk library steps in doc
> > > Test on both x86 and arm.
> > > x86 can build and install, but can not test since no device.
> > >
> > I tried with the latest TOT of UADK. This resolved the openssl issue.
> > But it does not allow me to install UADK into a specific directory.
>
> What's the error?
>
> I am sorry, I will check this tomorrow.
>
> > It installs /usr/local/lib only.
> > And what is the use of pkg-config if I cannot use a specific directory
> > To install the libs and headers.
>
> Test with --prefix
>
> cd uadk
> mkdir build
> ./autogen.sh
> ./configure --prefix=$PWD/build
> make; make install
>
> $ ls build
> bin include lib
>
> $ ls build/lib/pkgconfig/
> libwd_comp.pc libwd_crypto.pc libwd.pc
>
> export PKG_CONFIG_PATH=$PWD/build/lib/pkgconfig
>
Above sequence worked. I would suggest to write this clearly in uadk.rst.
Also I made a few below changes to make compilation work.
Here, I see that you are creating a dependency on compressdev to compile a crypto
Driver.
Do you really need that?
I believe you should segregate the compressdev related stuff in compress PMD.
--------------------------------------------------------------------------------------------------------
diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst
index 8f09e4390e..e00398414d 100644
--- a/doc/guides/cryptodevs/uadk.rst
+++ b/doc/guides/cryptodevs/uadk.rst
@@ -3,7 +3,7 @@
Copyright 2022-2023 Linaro ltd.
UADK Crypto Poll Mode Driver
-=======================================================
+============================
UADK crypto PMD provides poll mode driver
All cryptographic operations are using UADK crypto API.
@@ -38,7 +38,7 @@ Hash algorithms:
* ``RTE_CRYPTO_AUTH_SHA512_HMAC``
Test steps
------------
+----------
.. code-block:: console
@@ -61,7 +61,7 @@ Test steps
3. Run test app
Dependency
-------------
+----------
UADK crypto PMD relies on UADK library [1]
@@ -72,7 +72,7 @@ As a result, user application can directly use virtual address for device dma,
which enhances the performance as well as easy usability.
Build & Install UADK
------------
+--------------------
.. code-block:: console
diff --git a/drivers/crypto/uadk/meson.build b/drivers/crypto/uadk/meson.build
index f6fae0a239..66418f1878 100644
--- a/drivers/crypto/uadk/meson.build
+++ b/drivers/crypto/uadk/meson.build
@@ -12,7 +12,7 @@ sources = files(
'uadk_crypto_pmd.c',
)
-deps += 'bus_vdev'
+deps += ['bus_vdev', 'compressdev']
dep = dependency('libwd_crypto', required: false, method: 'pkg-config')
if not dep.found()
build = false
diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c
index a166efa36c..2f8ef3562d 100644
--- a/drivers/crypto/uadk/uadk_crypto_pmd.c
+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c
@@ -8,9 +8,9 @@
#include <rte_bus_vdev.h>
#include <rte_comp.h>
#include <stdlib.h>
-#include <uadk/wd_cipher.h>
-#include <uadk/wd_digest.h>
-#include <uadk/wd_sched.h>
+#include <wd_cipher.h>
+#include <wd_digest.h>
+#include <wd_sched.h>
/* Maximum length for digest (SHA-512 needs 64 bytes) */
#define DIGEST_LENGTH_MAX 64
> dpdk$ ninja -C build
> ../drivers/crypto/uadk/uadk_crypto_pmd.c:11:28: fatal error:
> uadk/wd_cipher.h: No such file or directory
> compilation terminated.
> [2403/3371] Compiling C object
> drivers/libtmp_rte_crypto_octeontx.a.p/crypto_octeontx_otx_cryptodev_ops.c.
> o
> ninja: build stopped: subcommand failed.
>
> Will check tomorrow, a bit late.
>
> Thanks
>
>
> >
> > And even if I install at default location, I am seeing below errors while
> compiling DPDK
> >
> > [2453/3738] Compiling C object
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o'.
> > FAILED:
> drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd
> .c.o
> > ccache cc -Idrivers/a715181@@tmp_rte_crypto_uadk@sta -Idrivers -
> I../drivers -Idrivers/crypto/uadk -I../drivers/crypto/uadk -Ilib/cryptodev -
> I../lib/cryptodev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -
> Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -
> I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal
> -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -
> Ilib/telemetry -I../lib/telemetry -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -
> I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/rcu -I../lib/rcu -Idrivers/bus/vdev -
> I../drivers/bus/vdev -I/usr/local/include -fdiagnostics-color=always -pipe -
> D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h
> -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -
> Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-
> definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -
> Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -
> Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -
> DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-
> truncation -DRTE_LOG_DEFAULT_LOGTYPE=pmd.crypto.uadk -MD -MQ
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o' -MF
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o.d' -o
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o' -c ../drivers/crypto/uadk/uadk_crypto_pmd.c
> > ../drivers/crypto/uadk/uadk_crypto_pmd.c:9:10: fatal error: rte_comp.h: No
> such file or directory
> > 9 | #include <rte_comp.h>
> > | ^~~~~~~~~~~~
> > compilation terminated.
> >
> > ninja: Entering directory `build'
> > [65/1253] Compiling C object
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o'.
> > FAILED:
> drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pmd
> .c.o
> > ccache cc -Idrivers/a715181@@tmp_rte_crypto_uadk@sta -Idrivers -
> I../drivers -Idrivers/crypto/uadk -I../drivers/crypto/uadk -Ilib/cryptodev -
> I../lib/cryptodev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -
> Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -
> I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal
> -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -
> Ilib/telemetry -I../lib/telemetry -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -
> I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/rcu -I../lib/rcu -Idrivers/bus/vdev -
> I../drivers/bus/vdev -I/usr/local/include -fdiagnostics-color=always -pipe -
> D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h
> -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -
> Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-
> definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -
> Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -
> Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -
> DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-
> truncation -DRTE_LOG_DEFAULT_LOGTYPE=pmd.crypto.uadk -MD -MQ
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o' -MF
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o.d' -o
> 'drivers/a715181@@tmp_rte_crypto_uadk@sta/crypto_uadk_uadk_crypto_pm
> d.c.o' -c ../drivers/crypto/uadk/uadk_crypto_pmd.c
> > ../drivers/crypto/uadk/uadk_crypto_pmd.c:11:10: fatal error:
> uadk/wd_cipher.h: No such file or directory
> > 11 | #include <uadk/wd_cipher.h>
>
>
> >
> >
> > > Resend v3:
> > > Rebase on next/for-main, which just merged the series
> > > "cryptodev: rework session framework".
> > >
> > > Update in v3:
> > > Split patches according to Akhil's suggestions
> > > Please split the patches as below.
> > > 1. introduce driver - create files with meson.build and with probe/remove
> > > and device ops defined but not implemented.
> > > You do not need to write empty functions.
> > > Add basic documentation also which defines what the driver is.
> > > You can explain the build dependency here.
> > > 2. define queue structs and setup/remove APIs
> > > 3. Add data path
> > > 4. implement cipher op. Add capabilities and documentation of what is
> > > supported in each of the patches. Add feature flags etc.
> > > 5. implement auth, add capabilities and documentation
> > > 6. test app changes.
> > >
> > > Update in v2:
> > > Change uadk_supported_platform to uadk_crypto_version, which matches
> > > better
> > > than platform.
> > > enum uadk_crypto_version {
> > > UADK_CRYPTO_V2,
> > > UADK_CRYPTO_V3,
> > > };
> > >
> > > Update in v1, compared with rfc
> > >
> > > Suggested from Akhil Goyal <gakhil@marvell.com>
> > > Only consider crypto PMD first
> > > Split patch into small (individually compiled) patches.
> > > Update MAINTAINERS and doc/guides/cryptodevs/features/uadk.ini
> > >
> > > Zhangfei Gao (6):
> > > crypto/uadk: introduce uadk crypto driver
> > > crypto/uadk: support basic operations
> > > crypto/uadk: support enqueue/dequeue operations
> > > crypto/uadk: support cipher algorithms
> > > crypto/uadk: support auth algorithms
> > > test/crypto: add cryptodev_uadk_autotest
> > >
> > > MAINTAINERS | 6 +
> > > app/test/test_cryptodev.c | 7 +
> > > app/test/test_cryptodev.h | 1 +
> > > doc/guides/cryptodevs/features/uadk.ini | 55 ++
> > > doc/guides/cryptodevs/index.rst | 1 +
> > > doc/guides/cryptodevs/uadk.rst | 88 ++
> > > drivers/crypto/meson.build | 1 +
> > > drivers/crypto/uadk/meson.build | 30 +
> > > drivers/crypto/uadk/uadk_crypto_pmd.c | 1145
> +++++++++++++++++++++++
> > > drivers/crypto/uadk/version.map | 3 +
> > > 10 files changed, 1337 insertions(+)
> > > create mode 100644 doc/guides/cryptodevs/features/uadk.ini
> > > create mode 100644 doc/guides/cryptodevs/uadk.rst
> > > create mode 100644 drivers/crypto/uadk/meson.build
> > > create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c
> > > create mode 100644 drivers/crypto/uadk/version.map
> > >
> > > --
> > > 2.36.1
> >
next prev parent reply other threads:[~2022-10-20 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 12:57 Zhangfei Gao
2022-10-19 12:57 ` [PATCH v4 1/6] " Zhangfei Gao
2022-10-19 12:57 ` [PATCH v4 2/6] crypto/uadk: support basic operations Zhangfei Gao
2022-10-19 12:57 ` [PATCH v4 3/6] crypto/uadk: support enqueue/dequeue operations Zhangfei Gao
2022-10-19 12:57 ` [PATCH v4 4/6] crypto/uadk: support cipher algorithms Zhangfei Gao
2022-10-19 12:57 ` [PATCH v4 5/6] crypto/uadk: support auth algorithms Zhangfei Gao
2022-10-19 12:57 ` [PATCH v4 6/6] test/crypto: add cryptodev_uadk_autotest Zhangfei Gao
2022-10-20 14:44 ` [EXT] [PATCH v4 0/6] crypto/uadk: introduce uadk crypto driver Akhil Goyal
2022-10-20 15:56 ` Zhangfei Gao
2022-10-20 17:09 ` Akhil Goyal [this message]
2022-10-21 7:47 ` Zhangfei Gao
2022-10-24 12:54 ` Zhangfei Gao
2022-10-20 14:51 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB44849371A1F3EFB213425D4BD82A9@CO6PR18MB4484.namprd18.prod.outlook.com \
--to=gakhil@marvell.com \
--cc=acc@openeuler.org \
--cc=ashishg@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=royzhang1980@gmail.com \
--cc=thomas@monjalon.net \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).